Re: [libvirt] [PATCH] Document STR(N)EQ_NULLABLE (was Re: [PATCH 2/2] xenParseXM: don't dereference NULL pointer when script is empty)
On Thu, Oct 06, 2011 at 08:54:22AM -0600, Eric Blake wrote: > On 10/06/2011 08:52 AM, Guido Günther wrote: > >>ACK. But be sure you also run 'make check', then squash in the > >>regeneration of HACKING prior to pushing your commit. > > > >I had to do a explicit "make HACKING" to get this regenerated. Pushed > >now - thanks. > > Ah, maybe it was only 'make syntax-check' that does the auto-regen. > At any rate, thank you for the patch. I checked and it's "make syntax-check". Thanks, -- Guido -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Document STR(N)EQ_NULLABLE (was Re: [PATCH 2/2] xenParseXM: don't dereference NULL pointer when script is empty)
On 10/06/2011 08:52 AM, Guido Günther wrote: ACK. But be sure you also run 'make check', then squash in the regeneration of HACKING prior to pushing your commit. I had to do a explicit "make HACKING" to get this regenerated. Pushed now - thanks. Ah, maybe it was only 'make syntax-check' that does the auto-regen. At any rate, thank you for the patch. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Document STR(N)EQ_NULLABLE (was Re: [PATCH 2/2] xenParseXM: don't dereference NULL pointer when script is empty)
On Thu, Oct 06, 2011 at 08:27:42AM -0600, Eric Blake wrote: > On 10/06/2011 05:38 AM, Guido Günther wrote: > >...and here's the doc update. > > -- Guido > > > > > >0001-Document-STREQ_NULLABLE-and-STRNEQ_NULLABLE.patch > > > > > >>From 07b8940e3bb64e2208b191d890e95f059a7ac7a9 Mon Sep 17 00:00:00 2001 > >From: =?UTF-8?q?Guido=20G=C3=BCnther?= > >Date: Thu, 6 Oct 2011 13:32:49 +0200 > >Subject: [PATCH] Document STREQ_NULLABLE and STRNEQ_NULLABLE > > > >--- > > docs/hacking.html.in |6 ++ > > 1 files changed, 6 insertions(+), 0 deletions(-) > > > >diff --git a/docs/hacking.html.in b/docs/hacking.html.in > >index 1a32d07..89f9980 100644 > >--- a/docs/hacking.html.in > >+++ b/docs/hacking.html.in > >@@ -587,6 +587,12 @@ > >STRPREFIX(a,b) > > > > > >+To avoid having to check if a or b are NULL: > >+ > >+ STREQ_NULLABLE(a, b) > >+ STRNEQ_NULLABLE(a, b) > >+ > >+ > > ACK. But be sure you also run 'make check', then squash in the > regeneration of HACKING prior to pushing your commit. I had to do a explicit "make HACKING" to get this regenerated. Pushed now - thanks. Cheers, -- Guido > > -- > Eric Blake ebl...@redhat.com+1-801-349-2682 > Libvirt virtualization library http://libvirt.org > -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] Document STR(N)EQ_NULLABLE (was Re: [PATCH 2/2] xenParseXM: don't dereference NULL pointer when script is empty)
On 10/06/2011 05:38 AM, Guido Günther wrote: ...and here's the doc update. -- Guido 0001-Document-STREQ_NULLABLE-and-STRNEQ_NULLABLE.patch From 07b8940e3bb64e2208b191d890e95f059a7ac7a9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Guido=20G=C3=BCnther?= Date: Thu, 6 Oct 2011 13:32:49 +0200 Subject: [PATCH] Document STREQ_NULLABLE and STRNEQ_NULLABLE --- docs/hacking.html.in |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/docs/hacking.html.in b/docs/hacking.html.in index 1a32d07..89f9980 100644 --- a/docs/hacking.html.in +++ b/docs/hacking.html.in @@ -587,6 +587,12 @@ STRPREFIX(a,b) +To avoid having to check if a or b are NULL: + + STREQ_NULLABLE(a, b) + STRNEQ_NULLABLE(a, b) + + ACK. But be sure you also run 'make check', then squash in the regeneration of HACKING prior to pushing your commit. -- Eric Blake ebl...@redhat.com+1-801-349-2682 Libvirt virtualization library http://libvirt.org -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
