Re: [libvirt] [PATCH] conf: RNG: Always fill in default random source path for default backend
On 07/25/14 14:55, John Ferlan wrote: > On 07/25/2014 04:03 AM, Peter Krempa wrote: >> Libvirt documents that the default entropy source for the 'random' >> backend of a RNG device is /dev/random. Instead of storing and >> propagating NULL across our code and checking it in multiple places fill >> the default in the post parse callback and use that in the other places. >> --- >> Sending the fix as promised in the multiple-rng series. >> >> >> src/conf/domain_audit.c| 10 ++ >> src/conf/domain_conf.c | 14 >> +- >> src/qemu/qemu_cgroup.c | 12 >> src/qemu/qemu_command.c| 5 ++--- >> .../qemuxml2argvdata/qemuxml2argv-virtio-rng-default.args | 2 +- >> .../qemuxml2argvdata/qemuxml2argv-virtio-rng-multiple.args | 3 ++- >> 6 files changed, 20 insertions(+), 26 deletions(-) >> > > ACK > > John > Pushed; Thanks. Peter signature.asc Description: OpenPGP digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH] conf: RNG: Always fill in default random source path for default backend
On 07/25/2014 04:03 AM, Peter Krempa wrote: > Libvirt documents that the default entropy source for the 'random' > backend of a RNG device is /dev/random. Instead of storing and > propagating NULL across our code and checking it in multiple places fill > the default in the post parse callback and use that in the other places. > --- > Sending the fix as promised in the multiple-rng series. > > > src/conf/domain_audit.c| 10 ++ > src/conf/domain_conf.c | 14 > +- > src/qemu/qemu_cgroup.c | 12 > src/qemu/qemu_command.c| 5 ++--- > .../qemuxml2argvdata/qemuxml2argv-virtio-rng-default.args | 2 +- > .../qemuxml2argvdata/qemuxml2argv-virtio-rng-multiple.args | 3 ++- > 6 files changed, 20 insertions(+), 26 deletions(-) > ACK John -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
