Re: [libvirt] [PATCH] virsh: Add persistent history using libreadline

2010-01-06 Thread Daniel Veillard 
On Mon, Jan 04, 2010 at 12:06:29AM +0100, Matthias Bolte wrote:
 2010/1/3 Laine Stump la...@laine.org:
  On 01/03/2010 02:42 PM, Matthias Bolte wrote:
 
  +    if (virAsprintf(ctl-historyfile, %s/histroy, ctl-historydir)
   0) {
 
 
  A minor typo in the format string ;-)
 
 
 Fixed, thanks.

  ACK, if using libreadline GPL trojan horse as I have seen it called
recently :-) then we should use it to the full extend, and saving the
history really does help !

Daniel

-- 
Daniel Veillard  | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
dan...@veillard.com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/

--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] virsh: Add persistent history using libreadline

2010-01-03 Thread Laine Stump 

On 01/03/2010 02:42 PM, Matthias Bolte wrote:

+if (virAsprintf(ctl-historyfile, %s/histroy, ctl-historydir)  0) {
   


A minor typo in the format string ;-)

--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] virsh: Add persistent history using libreadline

2010-01-03 Thread Matthias Bolte 
2010/1/3 Laine Stump la...@laine.org:
 On 01/03/2010 02:42 PM, Matthias Bolte wrote:

 +    if (virAsprintf(ctl-historyfile, %s/histroy, ctl-historydir)
  0) {


 A minor typo in the format string ;-)


Fixed, thanks.

Matthias

--
Libvir-list mailing list
Libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list