Re: [libvirt] [PATCH] virsh: add missing help info of --source to domifaddr

[John Ferlan]

On 03/15/2018 10:03 PM, Chen Hanxiao wrote:
> From: Chen Hanxiao 
> 
> commit b4b5c82ce forgot to add this.
> 
> Signed-off-by: Chen Hanxiao 
> ---
>  tools/virsh-domain-monitor.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c
> index 68da11ed5..0f768d394 100644
> --- a/tools/virsh-domain-monitor.c
> +++ b/tools/virsh-domain-monitor.c
> @@ -2160,7 +2160,7 @@ static const vshCmdOptDef opts_domifaddr[] = {
>  {.name = "source",
>   .type = VSH_OT_STRING,
>   .flags = VSH_OFLAG_NONE,
> - .help = N_("address source: 'lease' or 'agent'")},
> + .help = N_("address source: 'lease', 'agent' or 'arp'")},

I added a comma after 'agent', e.g. 'lease', 'agent', or 'arp'

Reviewed-by: John Ferlan 

(safe for freeze and pushed)

John

>  {.name = NULL}
>  };
>  
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH] virsh: add missing help info of --source to domifaddr

[Chen Hanxiao]

At 2018-03-16 10:03:15, "Chen Hanxiao"  wrote:
>From: Chen Hanxiao 
>
>commit b4b5c82ce forgot to add this.
>
>Signed-off-by: Chen Hanxiao 
>---
> tools/virsh-domain-monitor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/tools/virsh-domain-monitor.c b/tools/virsh-domain-monitor.c
>index 68da11ed5..0f768d394 100644
>--- a/tools/virsh-domain-monitor.c
>+++ b/tools/virsh-domain-monitor.c
>@@ -2160,7 +2160,7 @@ static const vshCmdOptDef opts_domifaddr[] = {
> {.name = "source",
>  .type = VSH_OT_STRING,
>  .flags = VSH_OFLAG_NONE,
>- .help = N_("address source: 'lease' or 'agent'")},
>+ .help = N_("address source: 'lease', 'agent' or 'arp'")},
> {.name = NULL}
> };
> 

ping

Regards,
- Chen

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list