Re: [libvirt] [PATCH 0/3] bhyve: allow locking memory
On 14 May 2018, at 8:51, Roman Bogorodskiy wrote: > Peter Krempa wrote: > >> On Sun, May 13, 2018 at 14:01:25 +0400, Roman Bogorodskiy wrote: >>> Fabian Freyer wrote: >> >> [...] >> 13 files changed, 134 insertions(+) create mode 100644 tests/bhyveargv2xmldata/bhyveargv2xml-wired.args create mode 100644 tests/bhyveargv2xmldata/bhyveargv2xml-wired.xml create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-wired.args create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-wired.ldargs create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-wired.xml create mode 100644 tests/bhyvexml2xmloutdata/bhyvexml2xmlout-wired.xml >>> >>> Thanks for the patches, I've pushed the series with some syntax-check >>> fixes (trailing whitespaces, tabs instead of whitespaces) and added >>> 'Signed-off-by' line which is mandatory now. >> >> Note that 'Signed-off-by' should _NOT_ be added without explicit consent >> of the author of the patches. Otherwise it defeats the purpose of >> certification that the author agrees and complies with the Developer >> certificate of origin. Adding it without explicit consent makes the >> Signed-off-by line just a useless piece of jewelery added to appease the >> push hook. > > Oh, sorry about that. I assumed as Fabian is a long time contributor, > he's familiar with the general project policies. > > Fabian, do you have any issue with that? All good with me. In case you need it from me, for the whole series: Signed-off-by: Fabian Freyer signature.asc Description: OpenPGP digital signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/3] bhyve: allow locking memory
Peter Krempa wrote: > On Sun, May 13, 2018 at 14:01:25 +0400, Roman Bogorodskiy wrote: > > Fabian Freyer wrote: > > [...] > > > > 13 files changed, 134 insertions(+) > > > create mode 100644 tests/bhyveargv2xmldata/bhyveargv2xml-wired.args > > > create mode 100644 tests/bhyveargv2xmldata/bhyveargv2xml-wired.xml > > > create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-wired.args > > > create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-wired.ldargs > > > create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-wired.xml > > > create mode 100644 tests/bhyvexml2xmloutdata/bhyvexml2xmlout-wired.xml > > > > Thanks for the patches, I've pushed the series with some syntax-check > > fixes (trailing whitespaces, tabs instead of whitespaces) and added > > 'Signed-off-by' line which is mandatory now. > > Note that 'Signed-off-by' should _NOT_ be added without explicit consent > of the author of the patches. Otherwise it defeats the purpose of > certification that the author agrees and complies with the Developer > certificate of origin. Adding it without explicit consent makes the > Signed-off-by line just a useless piece of jewelery added to appease the > push hook. Oh, sorry about that. I assumed as Fabian is a long time contributor, he's familiar with the general project policies. Fabian, do you have any issue with that? > > > > Roman Bogorodskiy > > > > > -- > > libvir-list mailing list > > libvir-list@redhat.com > > https://www.redhat.com/mailman/listinfo/libvir-list > Roman Bogorodskiy signature.asc Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/3] bhyve: allow locking memory
On Sun, May 13, 2018 at 14:01:25 +0400, Roman Bogorodskiy wrote: > Fabian Freyer wrote: [...] > > 13 files changed, 134 insertions(+) > > create mode 100644 tests/bhyveargv2xmldata/bhyveargv2xml-wired.args > > create mode 100644 tests/bhyveargv2xmldata/bhyveargv2xml-wired.xml > > create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-wired.args > > create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-wired.ldargs > > create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-wired.xml > > create mode 100644 tests/bhyvexml2xmloutdata/bhyvexml2xmlout-wired.xml > > Thanks for the patches, I've pushed the series with some syntax-check > fixes (trailing whitespaces, tabs instead of whitespaces) and added > 'Signed-off-by' line which is mandatory now. Note that 'Signed-off-by' should _NOT_ be added without explicit consent of the author of the patches. Otherwise it defeats the purpose of certification that the author agrees and complies with the Developer certificate of origin. Adding it without explicit consent makes the Signed-off-by line just a useless piece of jewelery added to appease the push hook. > > Roman Bogorodskiy > -- > libvir-list mailing list > libvir-list@redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list signature.asc Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH 0/3] bhyve: allow locking memory
Fabian Freyer wrote: > This patch series adds support for locking guest memory to the bhyve > driver using the following elements > > > > > > When specified, the -S flag is passed to the bhyve binary. > > Fabian Freyer (3): > bhyve: add support for wiring memory > bhyve: add tests for wiring memory > bhyve: document support for wiring guest memory > > docs/drvbhyve.html.in | 14 + > docs/news.xml | 10 ++ > src/bhyve/bhyve_command.c | 3 ++ > src/bhyve/bhyve_parse_command.c| 3 ++ > tests/bhyveargv2xmldata/bhyveargv2xml-wired.args | 7 + > tests/bhyveargv2xmldata/bhyveargv2xml-wired.xml| 19 > tests/bhyveargv2xmltest.c | 1 + > tests/bhyvexml2argvdata/bhyvexml2argv-wired.args | 10 ++ > tests/bhyvexml2argvdata/bhyvexml2argv-wired.ldargs | 3 ++ > tests/bhyvexml2argvdata/bhyvexml2argv-wired.xml| 26 > tests/bhyvexml2argvtest.c | 1 + > .../bhyvexml2xmloutdata/bhyvexml2xmlout-wired.xml | 36 > ++ > tests/bhyvexml2xmltest.c | 1 + > 13 files changed, 134 insertions(+) > create mode 100644 tests/bhyveargv2xmldata/bhyveargv2xml-wired.args > create mode 100644 tests/bhyveargv2xmldata/bhyveargv2xml-wired.xml > create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-wired.args > create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-wired.ldargs > create mode 100644 tests/bhyvexml2argvdata/bhyvexml2argv-wired.xml > create mode 100644 tests/bhyvexml2xmloutdata/bhyvexml2xmlout-wired.xml Thanks for the patches, I've pushed the series with some syntax-check fixes (trailing whitespaces, tabs instead of whitespaces) and added 'Signed-off-by' line which is mandatory now. Roman Bogorodskiy signature.asc Description: PGP signature -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list