Re: [libvirt] [PATCH 00/16] Xen: remove xend config version

[Michal Privoznik]

On 15.12.2015 22:32, Jim Fehlig wrote:
> Hi All,
> 
> Ian Campbell recently attempted [1] to fix and issue around MAX_VIRT_VPUS
> on ARM that required adding a new XEND_CONFIG_VERSION. After some
> discussion [2] we decided to drop support for all of the old xend config
> versions and go with the version supported in Xen 4.0, since the xl syntax
> was originally based on (and intended to be compatible with) xm circa that
> point in time.
> 
> This series removes all traces of xend config version from the codebase,
> essentially removing support for Xen 3.x. Hopefully I succeeding in making
> the rather large series reviewable. The series is also available on the
> remove-xend-config-version branch of my libvirt github clone [2].
> 
> [1] https://www.redhat.com/archives/libvir-list/2015-November/msg01153.html
> [2] https://www.redhat.com/archives/libvir-list/2015-December/msg00148.html
> [3] https://github.com/jfehlig/libvirt/tree/remove-xend-config-version
> 
> Jim Fehlig (16):
>   Xen: tests: remove old xm config tests
>   Xen: tests: remove net-ioemu xm config test
>   Xen: tests: remove old sexpr2xml tests
>   Xen: tests: remove old xml2sexpr tests
>   Xen: tests: use latest XEND_CONFIG_VERSION in xm/xl tests
>   Xen: xenconfig: remove XEND_CONFIG_VERSION in common code
>   Xen: xenconfig: remove use of XEND_CONFIG_VERSION in xen_xm
>   Xen: xenconfig: remove xendConfigVersion from public functions
>   Xen: tests: use latest XEND_CONFIG_VERSION in sexpr2xml tests
>   Xen: xenconfig: remove disks from '(image)' sexpr
>   Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests
>   Xen: xenconfig: remove use of XEND_CONFIG_VERSION in xen_sxpr
>   Xen: xen_driver: remove use of XEND_CONFIG_VERSION
>   Xen: xend: remove use of XEND_CONFIG_VERSION
>   Xen: xenconfig: remove xendConfigVersion from public sexpr functions
>   Xen: remove xendConfigVersion from driver private struct
> 
>  src/libxl/libxl_driver.c   |   9 +-
>  src/xen/xen_driver.c   | 296 ---
>  src/xen/xen_driver.h   |   2 -
>  src/xen/xend_internal.c| 224 ++-
>  src/xen/xm_internal.c  |   9 +-
>  src/xenconfig/xen_common.c | 211 ---
>  src/xenconfig/xen_common.h |   7 +-
>  src/xenconfig/xen_sxpr.c   | 411 
> ++---
>  src/xenconfig/xen_sxpr.h   |  21 +-
>  src/xenconfig/xen_xl.c |   9 +-
>  src/xenconfig/xen_xl.h |   7 +-
>  src/xenconfig/xen_xm.c |  57 +--
>  src/xenconfig/xen_xm.h |   5 +-
>  src/xenconfig/xenxs_private.h  |   8 -
>  tests/sexpr2xmldata/sexpr2xml-fv-autoport.xml  |   2 +-
>  .../sexpr2xmldata/sexpr2xml-fv-empty-kernel.sexpr  |   4 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-empty-kernel.xml  |   4 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-force-hpet.sexpr  |   4 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-force-hpet.xml|   4 +-
>  .../sexpr2xmldata/sexpr2xml-fv-force-nohpet.sexpr  |   4 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-force-nohpet.xml  |   4 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-kernel.xml|   2 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-localtime.sexpr   |   3 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-localtime.xml |   4 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-net-ioemu.sexpr   |   9 -
>  tests/sexpr2xmldata/sexpr2xml-fv-net-ioemu.xml |  48 ---
>  .../sexpr2xmldata/sexpr2xml-fv-net-netfront.sexpr  |   4 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-net-netfront.xml  |   4 +-
>  .../sexpr2xmldata/sexpr2xml-fv-parallel-tcp.sexpr  |   3 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-parallel-tcp.xml  |   4 +-
>  .../sexpr2xml-fv-serial-dev-2-ports.sexpr  |   5 +-
>  .../sexpr2xml-fv-serial-dev-2-ports.xml|   4 +-
>  .../sexpr2xml-fv-serial-dev-2nd-port.sexpr |   4 +-
>  .../sexpr2xml-fv-serial-dev-2nd-port.xml   |   4 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-serial-file.sexpr |   7 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-serial-file.xml   |   4 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-serial-null.sexpr |   3 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-serial-null.xml   |   4 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-serial-pipe.sexpr |   7 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-serial-pipe.xml   |   4 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-serial-pty.sexpr  |   4 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-serial-pty.xml|   4 +-
>  .../sexpr2xmldata/sexpr2xml-fv-serial-stdio.sexpr  |   3 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-serial-stdio.xml  |   4 +-
>  .../sexpr2xml-fv-serial-tcp-telnet.sexpr   |   3 +-
>  .../sexpr2xml-fv-serial-tcp-telnet.xml |   4 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp.sexpr  |   3 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp.xml|   4 +-
>  

Re: [libvirt] [PATCH 00/16] Xen: remove xend config version

[Jim Fehlig]

On 12/17/2015 05:42 AM, Michal Privoznik wrote:
> On 15.12.2015 22:32, Jim Fehlig wrote:
>> Hi All,
>>
>> Ian Campbell recently attempted [1] to fix and issue around MAX_VIRT_VPUS
>> on ARM that required adding a new XEND_CONFIG_VERSION. After some
>> discussion [2] we decided to drop support for all of the old xend config
>> versions and go with the version supported in Xen 4.0, since the xl syntax
>> was originally based on (and intended to be compatible with) xm circa that
>> point in time.
>>
>> This series removes all traces of xend config version from the codebase,
>> essentially removing support for Xen 3.x. Hopefully I succeeding in making
>> the rather large series reviewable. The series is also available on the
>> remove-xend-config-version branch of my libvirt github clone [2].
>>
>> [1] https://www.redhat.com/archives/libvir-list/2015-November/msg01153.html
>> [2] https://www.redhat.com/archives/libvir-list/2015-December/msg00148.html
>> [3] https://github.com/jfehlig/libvirt/tree/remove-xend-config-version
>>
>> Jim Fehlig (16):
>>   Xen: tests: remove old xm config tests
>>   Xen: tests: remove net-ioemu xm config test
>>   Xen: tests: remove old sexpr2xml tests
>>   Xen: tests: remove old xml2sexpr tests
>>   Xen: tests: use latest XEND_CONFIG_VERSION in xm/xl tests
>>   Xen: xenconfig: remove XEND_CONFIG_VERSION in common code
>>   Xen: xenconfig: remove use of XEND_CONFIG_VERSION in xen_xm
>>   Xen: xenconfig: remove xendConfigVersion from public functions
>>   Xen: tests: use latest XEND_CONFIG_VERSION in sexpr2xml tests
>>   Xen: xenconfig: remove disks from '(image)' sexpr
>>   Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests
>>   Xen: xenconfig: remove use of XEND_CONFIG_VERSION in xen_sxpr
>>   Xen: xen_driver: remove use of XEND_CONFIG_VERSION
>>   Xen: xend: remove use of XEND_CONFIG_VERSION
>>   Xen: xenconfig: remove xendConfigVersion from public sexpr functions
>>   Xen: remove xendConfigVersion from driver private struct
>>
>>  src/libxl/libxl_driver.c   |   9 +-
>>  src/xen/xen_driver.c   | 296 ---
>>  src/xen/xen_driver.h   |   2 -
>>  src/xen/xend_internal.c| 224 ++-
>>  src/xen/xm_internal.c  |   9 +-
>>  src/xenconfig/xen_common.c | 211 ---
>>  src/xenconfig/xen_common.h |   7 +-
>>  src/xenconfig/xen_sxpr.c   | 411 
>> ++---
>>  src/xenconfig/xen_sxpr.h   |  21 +-
>>  src/xenconfig/xen_xl.c |   9 +-
>>  src/xenconfig/xen_xl.h |   7 +-
>>  src/xenconfig/xen_xm.c |  57 +--
>>  src/xenconfig/xen_xm.h |   5 +-
>>  src/xenconfig/xenxs_private.h  |   8 -
>>  tests/sexpr2xmldata/sexpr2xml-fv-autoport.xml  |   2 +-
>>  .../sexpr2xmldata/sexpr2xml-fv-empty-kernel.sexpr  |   4 +-
>>  tests/sexpr2xmldata/sexpr2xml-fv-empty-kernel.xml  |   4 +-
>>  tests/sexpr2xmldata/sexpr2xml-fv-force-hpet.sexpr  |   4 +-
>>  tests/sexpr2xmldata/sexpr2xml-fv-force-hpet.xml|   4 +-
>>  .../sexpr2xmldata/sexpr2xml-fv-force-nohpet.sexpr  |   4 +-
>>  tests/sexpr2xmldata/sexpr2xml-fv-force-nohpet.xml  |   4 +-
>>  tests/sexpr2xmldata/sexpr2xml-fv-kernel.xml|   2 +-
>>  tests/sexpr2xmldata/sexpr2xml-fv-localtime.sexpr   |   3 +-
>>  tests/sexpr2xmldata/sexpr2xml-fv-localtime.xml |   4 +-
>>  tests/sexpr2xmldata/sexpr2xml-fv-net-ioemu.sexpr   |   9 -
>>  tests/sexpr2xmldata/sexpr2xml-fv-net-ioemu.xml |  48 ---
>>  .../sexpr2xmldata/sexpr2xml-fv-net-netfront.sexpr  |   4 +-
>>  tests/sexpr2xmldata/sexpr2xml-fv-net-netfront.xml  |   4 +-
>>  .../sexpr2xmldata/sexpr2xml-fv-parallel-tcp.sexpr  |   3 +-
>>  tests/sexpr2xmldata/sexpr2xml-fv-parallel-tcp.xml  |   4 +-
>>  .../sexpr2xml-fv-serial-dev-2-ports.sexpr  |   5 +-
>>  .../sexpr2xml-fv-serial-dev-2-ports.xml|   4 +-
>>  .../sexpr2xml-fv-serial-dev-2nd-port.sexpr |   4 +-
>>  .../sexpr2xml-fv-serial-dev-2nd-port.xml   |   4 +-
>>  tests/sexpr2xmldata/sexpr2xml-fv-serial-file.sexpr |   7 +-
>>  tests/sexpr2xmldata/sexpr2xml-fv-serial-file.xml   |   4 +-
>>  tests/sexpr2xmldata/sexpr2xml-fv-serial-null.sexpr |   3 +-
>>  tests/sexpr2xmldata/sexpr2xml-fv-serial-null.xml   |   4 +-
>>  tests/sexpr2xmldata/sexpr2xml-fv-serial-pipe.sexpr |   7 +-
>>  tests/sexpr2xmldata/sexpr2xml-fv-serial-pipe.xml   |   4 +-
>>  tests/sexpr2xmldata/sexpr2xml-fv-serial-pty.sexpr  |   4 +-
>>  tests/sexpr2xmldata/sexpr2xml-fv-serial-pty.xml|   4 +-
>>  .../sexpr2xmldata/sexpr2xml-fv-serial-stdio.sexpr  |   3 +-
>>  tests/sexpr2xmldata/sexpr2xml-fv-serial-stdio.xml  |   4 +-
>>  .../sexpr2xml-fv-serial-tcp-telnet.sexpr   |   3 +-
>>  .../sexpr2xml-fv-serial-tcp-telnet.xml |   4 +-
>> 

Re: [libvirt] [PATCH 00/16] Xen: remove xend config version

[Jim Fehlig]

On 12/16/2015 03:11 AM, Ian Campbell wrote:
> On Wed, 2015-12-16 at 09:45 +, Ian Campbell wrote:
>> On Tue, 2015-12-15 at 14:32 -0700, Jim Fehlig wrote:
>>> Hi All,
>>>
>>> Ian Campbell recently attempted [1] to fix and issue around
>>> MAX_VIRT_VPUS
>>> on ARM that required adding a new XEND_CONFIG_VERSION. After some
>>> discussion [2] we decided to drop support for all of the old xend
>>> config
>>> versions and go with the version supported in Xen 4.0, since the xl
>>> syntax
>>> was originally based on (and intended to be compatible with) xm circa
>>> that
>>> point in time.
>>>
>>> This series removes all traces of xend config version from the
>>> codebase,
>>> essentially removing support for Xen 3.x. Hopefully I succeeding in
>>> making
>>> the rather large series reviewable. The series is also available on the
>>> remove-xend-config-version branch of my libvirt github clone [2].
>> Wow, thanks for offering to take this over, I had no idea it would end up
>> with so much yakk hair everywhere!
> I've looked through it and the transformations look good to me:
>
> Acked-by: Ian Campbell 

Thanks for taking the time to look at all of these changes!

>
> There were a couple of references to xendConfigVersion remaining in
> comments on src/xen/xen_driver.c.

I'll remove "with xendConfigVersion >= 3" from those sentences in 13/16.

> There was also po/* which I presume some sort of semiautomated update will
> strip eventually.

I think so. It is due to removal of translated error messages in
src/xen/xend_internal.c.

>
> I'm not sure what to make of the references under docs/api_extension/.

Those are old patches that serve as an example of implementing a new API in
libvirt. AFAIK, no one expects those to be kept in sync with current code.

> I tested this on ARM with "Xen: support maxvcpus in xm and xl config" on
> top and it worked.

Good to hear. Thanks for all the help!

Regards,
Jim

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 00/16] Xen: remove xend config version

[Ian Campbell]

On Tue, 2015-12-15 at 14:32 -0700, Jim Fehlig wrote:
> Hi All,
> 
> Ian Campbell recently attempted [1] to fix and issue around MAX_VIRT_VPUS
> on ARM that required adding a new XEND_CONFIG_VERSION. After some
> discussion [2] we decided to drop support for all of the old xend config
> versions and go with the version supported in Xen 4.0, since the xl syntax
> was originally based on (and intended to be compatible with) xm circa that
> point in time.
> 
> This series removes all traces of xend config version from the codebase,
> essentially removing support for Xen 3.x. Hopefully I succeeding in making
> the rather large series reviewable. The series is also available on the
> remove-xend-config-version branch of my libvirt github clone [2].

Wow, thanks for offering to take this over, I had no idea it would end up
with so much yakk hair everywhere!

Ian.

> 
> [1] https://www.redhat.com/archives/libvir-list/2015-November/msg01153.ht
> ml
> [2] https://www.redhat.com/archives/libvir-list/2015-December/msg00148.ht
> ml
> [3] https://github.com/jfehlig/libvirt/tree/remove-xend-config-version
> 
> Jim Fehlig (16):
>   Xen: tests: remove old xm config tests
>   Xen: tests: remove net-ioemu xm config test
>   Xen: tests: remove old sexpr2xml tests
>   Xen: tests: remove old xml2sexpr tests
>   Xen: tests: use latest XEND_CONFIG_VERSION in xm/xl tests
>   Xen: xenconfig: remove XEND_CONFIG_VERSION in common code
>   Xen: xenconfig: remove use of XEND_CONFIG_VERSION in xen_xm
>   Xen: xenconfig: remove xendConfigVersion from public functions
>   Xen: tests: use latest XEND_CONFIG_VERSION in sexpr2xml tests
>   Xen: xenconfig: remove disks from '(image)' sexpr
>   Xen: tests: use latest XEND_CONFIG_VERSION in xml2sexpr tests
>   Xen: xenconfig: remove use of XEND_CONFIG_VERSION in xen_sxpr
>   Xen: xen_driver: remove use of XEND_CONFIG_VERSION
>   Xen: xend: remove use of XEND_CONFIG_VERSION
>   Xen: xenconfig: remove xendConfigVersion from public sexpr functions
>   Xen: remove xendConfigVersion from driver private struct
> 
>  src/libxl/libxl_driver.c   |   9 +-
>  src/xen/xen_driver.c   | 296 ---
>  src/xen/xen_driver.h   |   2 -
>  src/xen/xend_internal.c| 224 ++-
>  src/xen/xm_internal.c  |   9 +-
>  src/xenconfig/xen_common.c | 211 ---
>  src/xenconfig/xen_common.h |   7 +-
>  src/xenconfig/xen_sxpr.c   | 411 ++-
> --
>  src/xenconfig/xen_sxpr.h   |  21 +-
>  src/xenconfig/xen_xl.c |   9 +-
>  src/xenconfig/xen_xl.h |   7 +-
>  src/xenconfig/xen_xm.c |  57 +--
>  src/xenconfig/xen_xm.h |   5 +-
>  src/xenconfig/xenxs_private.h  |   8 -
>  tests/sexpr2xmldata/sexpr2xml-fv-autoport.xml  |   2 +-
>  .../sexpr2xmldata/sexpr2xml-fv-empty-kernel.sexpr  |   4 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-empty-kernel.xml  |   4 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-force-hpet.sexpr  |   4 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-force-hpet.xml|   4 +-
>  .../sexpr2xmldata/sexpr2xml-fv-force-nohpet.sexpr  |   4 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-force-nohpet.xml  |   4 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-kernel.xml|   2 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-localtime.sexpr   |   3 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-localtime.xml |   4 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-net-ioemu.sexpr   |   9 -
>  tests/sexpr2xmldata/sexpr2xml-fv-net-ioemu.xml |  48 ---
>  .../sexpr2xmldata/sexpr2xml-fv-net-netfront.sexpr  |   4 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-net-netfront.xml  |   4 +-
>  .../sexpr2xmldata/sexpr2xml-fv-parallel-tcp.sexpr  |   3 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-parallel-tcp.xml  |   4 +-
>  .../sexpr2xml-fv-serial-dev-2-ports.sexpr  |   5 +-
>  .../sexpr2xml-fv-serial-dev-2-ports.xml|   4 +-
>  .../sexpr2xml-fv-serial-dev-2nd-port.sexpr |   4 +-
>  .../sexpr2xml-fv-serial-dev-2nd-port.xml   |   4 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-serial-file.sexpr |   7 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-serial-file.xml   |   4 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-serial-null.sexpr |   3 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-serial-null.xml   |   4 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-serial-pipe.sexpr |   7 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-serial-pipe.xml   |   4 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-serial-pty.sexpr  |   4 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-serial-pty.xml|   4 +-
>  .../sexpr2xmldata/sexpr2xml-fv-serial-stdio.sexpr  |   3 +-
>  tests/sexpr2xmldata/sexpr2xml-fv-serial-stdio.xml  |   4 +-
>  .../sexpr2xml-fv-serial-tcp-telnet.sexpr   |   3 +-
>  .../sexpr2xml-fv-serial-tcp-telnet.xml |  

Re: [libvirt] [PATCH 00/16] Xen: remove xend config version

[Ian Campbell]

On Wed, 2015-12-16 at 09:45 +, Ian Campbell wrote:
> On Tue, 2015-12-15 at 14:32 -0700, Jim Fehlig wrote:
> > Hi All,
> > 
> > Ian Campbell recently attempted [1] to fix and issue around
> > MAX_VIRT_VPUS
> > on ARM that required adding a new XEND_CONFIG_VERSION. After some
> > discussion [2] we decided to drop support for all of the old xend
> > config
> > versions and go with the version supported in Xen 4.0, since the xl
> > syntax
> > was originally based on (and intended to be compatible with) xm circa
> > that
> > point in time.
> > 
> > This series removes all traces of xend config version from the
> > codebase,
> > essentially removing support for Xen 3.x. Hopefully I succeeding in
> > making
> > the rather large series reviewable. The series is also available on the
> > remove-xend-config-version branch of my libvirt github clone [2].
> 
> Wow, thanks for offering to take this over, I had no idea it would end up
> with so much yakk hair everywhere!

I've looked through it and the transformations look good to me:

Acked-by: Ian Campbell 

There were a couple of references to xendConfigVersion remaining in
comments on src/xen/xen_driver.c.

There was also po/* which I presume some sort of semiautomated update will
strip eventually.

I'm not sure what to make of the references under docs/api_extension/.

I tested this on ARM with "Xen: support maxvcpus in xm and xl config" on
top and it worked.

Ian.

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list