Re: [libvirt] [PATCH 2/3] qemu: use g_autofree instead of VIR_FREE in qemuMonitorTextCreateSnapshot()

2019-12-18 Thread Pavel Mores 
On Tue, Dec 17, 2019 at 10:55:24AM -0500, Cole Robinson wrote:
> On 12/6/19 4:11 AM, Pavel Mores wrote:
> > While at bugfixing, convert the whole function to the new-style memory
> > allocation handling.
> > 
> > Signed-off-by: Pavel Mores 
> > ---
> >  src/qemu/qemu_monitor_text.c | 18 ++
> >  1 file changed, 6 insertions(+), 12 deletions(-)
> > 
> 
> Reviewed-by: Cole Robinson 
> 
> Looks like this patch was missed. Pushed now

Thanks!  I dropped this patch from v2 intentionally because it was just a
clean-up of a previous patch which was dropped (for duplicating a recent
commit) and without which this one felt out of place and context in v2.

But on its own, this patch is still relevant so it's good you pushed it.

Thanks,

pvl

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCH 2/3] qemu: use g_autofree instead of VIR_FREE in qemuMonitorTextCreateSnapshot()

2019-12-17 Thread Cole Robinson 
On 12/6/19 4:11 AM, Pavel Mores wrote:
> While at bugfixing, convert the whole function to the new-style memory
> allocation handling.
> 
> Signed-off-by: Pavel Mores 
> ---
>  src/qemu/qemu_monitor_text.c | 18 ++
>  1 file changed, 6 insertions(+), 12 deletions(-)
> 

Reviewed-by: Cole Robinson 

Looks like this patch was missed. Pushed now

- Cole

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list