Re: [libvirt] [PATCH v2 0/4] Expose link state speed
On 06/10/2014 08:19 PM, Michal Privoznik wrote: On 05.06.2014 17:39, Michal Privoznik wrote: While the 1/4 was ACKed, I'm sending int for completeness. And I've made a tiny change: the link speed is no longer unsigned long but unsigned int instead. That'll do too and it consumes less memory. Michal Privoznik (4): virInterface: Expose link state speed virnetdev: Introduce virNetDevGetLinkInfo interface_backend_udev: Implement link speed state node_device: Expose link state speed FYI, I'm now working on adding this to netcf. I'll Cc you when I post the patch. -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 0/4] Expose link state speed
On 11.06.2014 10:02, Laine Stump wrote: On 06/10/2014 08:19 PM, Michal Privoznik wrote: On 05.06.2014 17:39, Michal Privoznik wrote: While the 1/4 was ACKed, I'm sending int for completeness. And I've made a tiny change: the link speed is no longer unsigned long but unsigned int instead. That'll do too and it consumes less memory. Michal Privoznik (4): virInterface: Expose link state speed virnetdev: Introduce virNetDevGetLinkInfo interface_backend_udev: Implement link speed state node_device: Expose link state speed FYI, I'm now working on adding this to netcf. I'll Cc you when I post the patch. Awesome. Is the XML schema I'm proposing here okay with the netcf or do we need I need to change something? If so, it's still time to change it - up till the release. Michal -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 0/4] Expose link state speed
On 05.06.2014 17:39, Michal Privoznik wrote: While the 1/4 was ACKed, I'm sending int for completeness. And I've made a tiny change: the link speed is no longer unsigned long but unsigned int instead. That'll do too and it consumes less memory. Michal Privoznik (4): virInterface: Expose link state speed virnetdev: Introduce virNetDevGetLinkInfo interface_backend_udev: Implement link speed state node_device: Expose link state speed docs/formatnode.html.in | 6 ++ docs/schemas/basictypes.rng | 25 ++ docs/schemas/interface.rng | 1 + docs/schemas/nodedev.rng| 1 + src/Makefile.am | 4 +- src/conf/device_conf.c | 62 ++ src/conf/device_conf.h | 27 +- src/conf/interface_conf.c | 11 ++- src/conf/interface_conf.h | 2 + src/conf/node_device_conf.c | 7 +- src/conf/node_device_conf.h | 2 + src/interface/interface_backend_udev.c | 5 ++ src/libvirt_private.syms| 5 ++ src/node_device/node_device_driver.c| 11 ++- src/node_device/node_device_udev.c | 5 ++ src/util/virnetdev.c| 104 src/util/virnetdev.h| 6 ++ tests/interfaceschemadata/bridge-no-address.xml | 1 + tests/interfaceschemadata/bridge.xml| 1 + tests/interfaceschemadata/ethernet-dhcp.xml | 1 + 20 files changed, 280 insertions(+), 7 deletions(-) So I've fixed all the nits John found and pushed. Thanks! Michal -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 0/4] Expose link state speed
On 05.06.2014 17:39, Michal Privoznik wrote: While the 1/4 was ACKed, I'm sending int for completeness. And I've made a tiny change: the link speed is no longer unsigned long but unsigned int instead. That'll do too and it consumes less memory. Michal Privoznik (4): virInterface: Expose link state speed virnetdev: Introduce virNetDevGetLinkInfo interface_backend_udev: Implement link speed state node_device: Expose link state speed docs/formatnode.html.in | 6 ++ docs/schemas/basictypes.rng | 25 ++ docs/schemas/interface.rng | 1 + docs/schemas/nodedev.rng| 1 + src/Makefile.am | 4 +- src/conf/device_conf.c | 62 ++ src/conf/device_conf.h | 27 +- src/conf/interface_conf.c | 11 ++- src/conf/interface_conf.h | 2 + src/conf/node_device_conf.c | 7 +- src/conf/node_device_conf.h | 2 + src/interface/interface_backend_udev.c | 5 ++ src/libvirt_private.syms| 5 ++ src/node_device/node_device_driver.c| 11 ++- src/node_device/node_device_udev.c | 5 ++ src/util/virnetdev.c| 104 src/util/virnetdev.h| 6 ++ tests/interfaceschemadata/bridge-no-address.xml | 1 + tests/interfaceschemadata/bridge.xml| 1 + tests/interfaceschemadata/ethernet-dhcp.xml | 1 + 20 files changed, 280 insertions(+), 7 deletions(-) ping? -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
