Re: [libvirt] [PATCH v2 4/8] qemu: vfio-ccw device address generation
On 05/14/2018 06:30 PM, John Ferlan wrote: On 05/14/2018 03:43 AM, Boris Fiuczynski wrote: On 05/10/2018 10:52 PM, John Ferlan wrote: On 05/07/2018 10:41 AM, Boris Fiuczynski wrote: From: Shalini Chellathurai Saroja Introduces the vfio-ccw model for mediated devices and prime vfio-ccw devices such that CCW address will be generated. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski Reviewed-by: Marc Hartmayer Reviewed-by: Stefan Zimmermann --- docs/schemas/domaincommon.rng | 5 - src/qemu/qemu_domain_address.c | 20 src/util/virmdev.c | 3 ++- src/util/virmdev.h | 1 + 4 files changed, 27 insertions(+), 2 deletions(-) Looking at all places using VIR_MDEV_MODEL_TYPE_VFIO_PCI - should this patch make a change to virDomainHostdevDefPostParse to do something similar - that is: if (model == VIR_MDEV_MODEL_TYPE_VFIO_CCW && dev->info->type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW) { ... error message } ? Let me know... I think it should and can add it before pushing... You are correct. Good catch! How about fixing it like this? if ((model == VIR_MDEV_MODEL_TYPE_VFIO_PCI && dev->info->type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI) || (model == VIR_MDEV_MODEL_TYPE_VFIO_CCW && dev->info->type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW)) { virReportError(VIR_ERR_XML_ERROR, _("Unsupported address type '%s' with mediated " "device model '%s'"), virDomainDeviceAddressTypeToString(dev->info->type), virMediatedDeviceModelTypeToString(model)); return -1; } OK - added that... Besides that I just saw that the indention of the second parameter of method qemuDomainPrimeVfioDeviceAddresses is off by three blanks. ah true - adjusted that. I've merged with the latest top of tree and have pushed... So much flux in the capabilities lately... Thank you :-). John -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 4/8] qemu: vfio-ccw device address generation
On 05/14/2018 06:30 PM, John Ferlan wrote: On 05/14/2018 03:43 AM, Boris Fiuczynski wrote: On 05/10/2018 10:52 PM, John Ferlan wrote: On 05/07/2018 10:41 AM, Boris Fiuczynski wrote: From: Shalini Chellathurai Saroja Introduces the vfio-ccw model for mediated devices and prime vfio-ccw devices such that CCW address will be generated. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski Reviewed-by: Marc Hartmayer Reviewed-by: Stefan Zimmermann --- docs/schemas/domaincommon.rng | 5 - src/qemu/qemu_domain_address.c | 20 src/util/virmdev.c | 3 ++- src/util/virmdev.h | 1 + 4 files changed, 27 insertions(+), 2 deletions(-) Looking at all places using VIR_MDEV_MODEL_TYPE_VFIO_PCI - should this patch make a change to virDomainHostdevDefPostParse to do something similar - that is: if (model == VIR_MDEV_MODEL_TYPE_VFIO_CCW && dev->info->type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW) { ... error message } ? Let me know... I think it should and can add it before pushing... You are correct. Good catch! How about fixing it like this? if ((model == VIR_MDEV_MODEL_TYPE_VFIO_PCI && dev->info->type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI) || (model == VIR_MDEV_MODEL_TYPE_VFIO_CCW && dev->info->type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW)) { virReportError(VIR_ERR_XML_ERROR, _("Unsupported address type '%s' with mediated " "device model '%s'"), virDomainDeviceAddressTypeToString(dev->info->type), virMediatedDeviceModelTypeToString(model)); return -1; } OK - added that... Besides that I just saw that the indention of the second parameter of method qemuDomainPrimeVfioDeviceAddresses is off by three blanks. ah true - adjusted that. I've merged with the latest top of tree and have pushed... So much flux in the capabilities lately... John You are correct that lots of changes happened in the capabilities. Thanks for merging the changes and pushing the series! -- Mit freundlichen Grüßen/Kind regards Boris Fiuczynski IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 4/8] qemu: vfio-ccw device address generation
On 05/14/2018 03:43 AM, Boris Fiuczynski wrote: > On 05/10/2018 10:52 PM, John Ferlan wrote: >> >> >> On 05/07/2018 10:41 AM, Boris Fiuczynski wrote: >>> From: Shalini Chellathurai Saroja >>> >>> Introduces the vfio-ccw model for mediated devices and prime vfio-ccw >>> devices such that CCW address will be generated. >>> >>> Signed-off-by: Shalini Chellathurai Saroja >>> Reviewed-by: Bjoern Walk >>> Reviewed-by: Boris Fiuczynski >>> Reviewed-by: Marc Hartmayer >>> Reviewed-by: Stefan Zimmermann >>> --- >>> docs/schemas/domaincommon.rng | 5 - >>> src/qemu/qemu_domain_address.c | 20 >>> src/util/virmdev.c | 3 ++- >>> src/util/virmdev.h | 1 + >>> 4 files changed, 27 insertions(+), 2 deletions(-) >>> >> >> Looking at all places using VIR_MDEV_MODEL_TYPE_VFIO_PCI - should this >> patch make a change to virDomainHostdevDefPostParse to do something >> similar - that is: >> >> if (model == VIR_MDEV_MODEL_TYPE_VFIO_CCW && >> dev->info->type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW) { >> ... error message >> } >> >> ? >> >> Let me know... I think it should and can add it before pushing... > You are correct. Good catch! > How about fixing it like this? > if ((model == VIR_MDEV_MODEL_TYPE_VFIO_PCI && > dev->info->type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI) || > (model == VIR_MDEV_MODEL_TYPE_VFIO_CCW && > dev->info->type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW)) { > virReportError(VIR_ERR_XML_ERROR, > _("Unsupported address type '%s' with mediated " > "device model '%s'"), > > virDomainDeviceAddressTypeToString(dev->info->type), > virMediatedDeviceModelTypeToString(model)); > return -1; > } > OK - added that... > > > Besides that I just saw that the indention of the second parameter of > method qemuDomainPrimeVfioDeviceAddresses is off by three blanks. > ah true - adjusted that. I've merged with the latest top of tree and have pushed... So much flux in the capabilities lately... John -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 4/8] qemu: vfio-ccw device address generation
On 05/10/2018 10:52 PM, John Ferlan wrote: On 05/07/2018 10:41 AM, Boris Fiuczynski wrote: From: Shalini Chellathurai Saroja Introduces the vfio-ccw model for mediated devices and prime vfio-ccw devices such that CCW address will be generated. Signed-off-by: Shalini Chellathurai Saroja Reviewed-by: Bjoern Walk Reviewed-by: Boris Fiuczynski Reviewed-by: Marc Hartmayer Reviewed-by: Stefan Zimmermann --- docs/schemas/domaincommon.rng | 5 - src/qemu/qemu_domain_address.c | 20 src/util/virmdev.c | 3 ++- src/util/virmdev.h | 1 + 4 files changed, 27 insertions(+), 2 deletions(-) Looking at all places using VIR_MDEV_MODEL_TYPE_VFIO_PCI - should this patch make a change to virDomainHostdevDefPostParse to do something similar - that is: if (model == VIR_MDEV_MODEL_TYPE_VFIO_CCW && dev->info->type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW) { ... error message } ? Let me know... I think it should and can add it before pushing... You are correct. Good catch! How about fixing it like this? if ((model == VIR_MDEV_MODEL_TYPE_VFIO_PCI && dev->info->type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI) || (model == VIR_MDEV_MODEL_TYPE_VFIO_CCW && dev->info->type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW)) { virReportError(VIR_ERR_XML_ERROR, _("Unsupported address type '%s' with mediated " "device model '%s'"), virDomainDeviceAddressTypeToString(dev->info->type), virMediatedDeviceModelTypeToString(model)); return -1; } Besides that I just saw that the indention of the second parameter of method qemuDomainPrimeVfioDeviceAddresses is off by three blanks. Reviewed-by: John Ferlan John -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list -- Mit freundlichen Grüßen/Kind regards Boris Fiuczynski IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martina Köderitz Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294 -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Re: [libvirt] [PATCH v2 4/8] qemu: vfio-ccw device address generation
On 05/07/2018 10:41 AM, Boris Fiuczynski wrote: > From: Shalini Chellathurai Saroja > > Introduces the vfio-ccw model for mediated devices and prime vfio-ccw > devices such that CCW address will be generated. > > Signed-off-by: Shalini Chellathurai Saroja > Reviewed-by: Bjoern Walk > Reviewed-by: Boris Fiuczynski > Reviewed-by: Marc Hartmayer > Reviewed-by: Stefan Zimmermann > --- > docs/schemas/domaincommon.rng | 5 - > src/qemu/qemu_domain_address.c | 20 > src/util/virmdev.c | 3 ++- > src/util/virmdev.h | 1 + > 4 files changed, 27 insertions(+), 2 deletions(-) > Looking at all places using VIR_MDEV_MODEL_TYPE_VFIO_PCI - should this patch make a change to virDomainHostdevDefPostParse to do something similar - that is: if (model == VIR_MDEV_MODEL_TYPE_VFIO_CCW && dev->info->type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_CCW) { ... error message } ? Let me know... I think it should and can add it before pushing... Reviewed-by: John Ferlan John -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list