Re: [libvirt] [PATCH v2 8/8] news: Cold(un)plug and hot(un)plug support for usb hub device

2018-11-05 Thread John Ferlan



On 10/12/18 4:50 AM, Han Han wrote:
> Signed-off-by: Han Han 
> ---
>  docs/news.xml | 5 +
>  1 file changed, 5 insertions(+)
> 
> diff --git a/docs/news.xml b/docs/news.xml
> index dc08c96352..0efad21758 100644
> --- a/docs/news.xml
> +++ b/docs/news.xml
> @@ -35,6 +35,11 @@
>  
>
>  
> +  
> +
> +  qemu: Add support for cold(un)plugging and hot(un)plugging usb hub 
> device
> +
> +  

How about:


  Add active and inactive device add or remove for QEMU USB Hub devices


  Add the ability to attach or detach a USB Hub device either for
  active or inactive guests.


?

John

>  
>  
>  
> 

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


Re: [libvirt] [PATCH v2 8/8] news: Cold(un)plug and hot(un)plug support for usb hub device

2018-11-05 Thread Han Han
On Tue, Nov 6, 2018 at 6:52 AM John Ferlan  wrote:

>
>
> On 10/12/18 4:50 AM, Han Han wrote:
> > Signed-off-by: Han Han 
> > ---
> >  docs/news.xml | 5 +
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/docs/news.xml b/docs/news.xml
> > index dc08c96352..0efad21758 100644
> > --- a/docs/news.xml
> > +++ b/docs/news.xml
> > @@ -35,6 +35,11 @@
> >  
> >
> >  
> > +  
> > +
> > +  qemu: Add support for cold(un)plugging and hot(un)plugging
> usb hub device
> > +
> > +  
>
> How about:
>
> 
>   Add active and inactive device add or remove for QEMU USB Hub devices
> 
> 
>   Add the ability to attach or detach a USB Hub device either for
>   active or inactive guests.
> 
>
Well. Your advice is nice. 'active' or 'inactive' is to describe the guests
not the devices.

>
> ?
>
> John
>
> >  
> >  
> >  
> >
>


-- 
Best regards,
---
Han Han
Quality Engineer
Redhat.

Email: h...@redhat.com
Phone: +861065339333
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list