Re: [libvirt] [PATCH v3 0/5] Predictable file names for memory-backend-file

2017-11-08 Thread Michal Privoznik
On 11/07/2017 10:45 PM, John Ferlan wrote:
> 
> 
> On 11/07/2017 10:50 AM, Michal Privoznik wrote:
>> v3 of:
>>
>> https://www.redhat.com/archives/libvir-list/2017-October/msg01091.html
>>
>> diff to v2:
>> - Pushed 1/4 and 2/4 from the original series
>> - Split 3/4 into smaller patches
>>
>> Michal Privoznik (5):
>>   qemu: Set alias for memory cell in qemuBuildMemoryCellBackendStr
>>   qemu: Rename qemuProcessBuildDestroyHugepagesPath
>>   qemu: Destroy whole memory tree
>>   qemu: Use predictable file names for memory-backend-file
>>   news: Document predictable file names for memory-backend-file
>>
>>  docs/news.xml  |  11 ++
>>  src/qemu/qemu_command.c|   9 +-
>>  src/qemu/qemu_conf.c   |  55 -
>>  src/qemu/qemu_conf.h   |   9 +-
>>  src/qemu/qemu_driver.c |  17 +++
>>  src/qemu/qemu_hotplug.c|   2 +-
>>  src/qemu/qemu_process.c| 137 
>> +++--
>>  src/qemu/qemu_process.h|   8 +-
>>  .../qemuxml2argv-cpu-numa-memshared.args   |   6 +-
>>  .../qemuxml2argv-fd-memory-numa-topology.args  |   3 +-
>>  .../qemuxml2argv-fd-memory-numa-topology2.args |   6 +-
>>  .../qemuxml2argv-fd-memory-numa-topology3.args |   9 +-
>>  .../qemuxml2argv-hugepages-memaccess2.args |   9 +-
>>  13 files changed, 218 insertions(+), 63 deletions(-)
>>
> 
> There's a couple of things to clean up, but in general with those
> cleanups in place,
> 
> Reviewed-by: John Ferlan 

Thanks. Fixed all the raised points and pushed.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


Re: [libvirt] [PATCH v3 0/5] Predictable file names for memory-backend-file

2017-11-07 Thread John Ferlan


On 11/07/2017 10:50 AM, Michal Privoznik wrote:
> v3 of:
> 
> https://www.redhat.com/archives/libvir-list/2017-October/msg01091.html
> 
> diff to v2:
> - Pushed 1/4 and 2/4 from the original series
> - Split 3/4 into smaller patches
> 
> Michal Privoznik (5):
>   qemu: Set alias for memory cell in qemuBuildMemoryCellBackendStr
>   qemu: Rename qemuProcessBuildDestroyHugepagesPath
>   qemu: Destroy whole memory tree
>   qemu: Use predictable file names for memory-backend-file
>   news: Document predictable file names for memory-backend-file
> 
>  docs/news.xml  |  11 ++
>  src/qemu/qemu_command.c|   9 +-
>  src/qemu/qemu_conf.c   |  55 -
>  src/qemu/qemu_conf.h   |   9 +-
>  src/qemu/qemu_driver.c |  17 +++
>  src/qemu/qemu_hotplug.c|   2 +-
>  src/qemu/qemu_process.c| 137 
> +++--
>  src/qemu/qemu_process.h|   8 +-
>  .../qemuxml2argv-cpu-numa-memshared.args   |   6 +-
>  .../qemuxml2argv-fd-memory-numa-topology.args  |   3 +-
>  .../qemuxml2argv-fd-memory-numa-topology2.args |   6 +-
>  .../qemuxml2argv-fd-memory-numa-topology3.args |   9 +-
>  .../qemuxml2argv-hugepages-memaccess2.args |   9 +-
>  13 files changed, 218 insertions(+), 63 deletions(-)
> 

There's a couple of things to clean up, but in general with those
cleanups in place,

Reviewed-by: John Ferlan 

John

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list