Re: [libvirt] [PATCHv3] conf: don't modify cpu set string during parsing

2011-11-21 Thread Eric Blake 
On 11/18/2011 09:41 PM, Bharata B Rao wrote:
 On Fri, Nov 18, 2011 at 11:31:12AM -0700, Eric Blake wrote:
 None of the callers cared if str was updated to point to the next
 byte after the parsed cpuset; simplifying this results in quite
 a few code simplifications.  Additionally, virCPUDefParseXML was
 strdup()'ing a malloc()'d string; avoiding a memory copy resulted
 in less code.
 
 Changes to virCPUDefParseXML look good. numa ... /numa XML
 section is parsed correctly and qemu -numa options are generated
 correctly after this change.

Thanks for the review; I've pushed this patch now.

-- 
Eric Blake   ebl...@redhat.com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv3] conf: don't modify cpu set string during parsing

2011-11-18 Thread Bharata B Rao 
On Fri, Nov 18, 2011 at 11:31:12AM -0700, Eric Blake wrote:
 None of the callers cared if str was updated to point to the next
 byte after the parsed cpuset; simplifying this results in quite
 a few code simplifications.  Additionally, virCPUDefParseXML was
 strdup()'ing a malloc()'d string; avoiding a memory copy resulted
 in less code.

Changes to virCPUDefParseXML look good. numa ... /numa XML
section is parsed correctly and qemu -numa options are generated
correctly after this change.

Regards,
Bharata.

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list