Re: [libvirt] [PATCHv3 13/36] util: string: Return element count from virStringSplit

2014-06-03 Thread Peter Krempa
On 06/02/14 23:40, Eric Blake wrote:
 On 05/30/2014 02:37 AM, Peter Krempa wrote:
 To allow using the array manipulation macros on the arrays returned by
 virStringSplit we need to know the count of the elements in the array.
 Modify virStringSplit to return this value, rename it and add a helper
 with the old name so that we don't need to update all the code.
 ---

 Notes:
 Version 3:
 - added test coverage
 
 Thanks :)
 

  src/libvirt_private.syms |  1 +
  src/util/virstring.c | 24 
  src/util/virstring.h |  6 ++
  tests/virstringtest.c| 14 +-
  4 files changed, 40 insertions(+), 5 deletions(-)
 
 ACK.
 

Thanks; I've pushed patches 1 through 13.

Peter



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list

Re: [libvirt] [PATCHv3 13/36] util: string: Return element count from virStringSplit

2014-06-02 Thread Eric Blake
On 05/30/2014 02:37 AM, Peter Krempa wrote:
 To allow using the array manipulation macros on the arrays returned by
 virStringSplit we need to know the count of the elements in the array.
 Modify virStringSplit to return this value, rename it and add a helper
 with the old name so that we don't need to update all the code.
 ---
 
 Notes:
 Version 3:
 - added test coverage

Thanks :)

 
  src/libvirt_private.syms |  1 +
  src/util/virstring.c | 24 
  src/util/virstring.h |  6 ++
  tests/virstringtest.c| 14 +-
  4 files changed, 40 insertions(+), 5 deletions(-)

ACK.

-- 
Eric Blake   eblake redhat com+1-919-301-3266
Libvirt virtualization library http://libvirt.org



signature.asc
Description: OpenPGP digital signature
--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list