Re: [libvirt] [libvirt-php][PATCH 00/10] Couple of PHP fixes

2015-06-15 Thread Michal Privoznik
On 10.06.2015 11:29, Vasiliy Tolstov wrote:
 2015-06-10 12:23 GMT+03:00 Michal Privoznik mpriv...@redhat.com:
 Ping? No php knowledge is required to review these patches. They are
 merely Makefile and configure.ac cleanups.

 Michal
 
 
 Michal Novotny says that he busy now and you can accept/review my
 patches.. i think in this case - you can ACK ? =)
 

I went ahead and pushed this. Hopefully I did not break anything.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


Re: [libvirt] [libvirt-php][PATCH 00/10] Couple of PHP fixes

2015-06-10 Thread Vasiliy Tolstov
2015-06-10 12:23 GMT+03:00 Michal Privoznik mpriv...@redhat.com:
 Ping? No php knowledge is required to review these patches. They are
 merely Makefile and configure.ac cleanups.

 Michal


Michal Novotny says that he busy now and you can accept/review my
patches.. i think in this case - you can ACK ? =)

-- 
Vasiliy Tolstov,
e-mail: v.tols...@selfip.ru

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list


Re: [libvirt] [libvirt-php][PATCH 00/10] Couple of PHP fixes

2015-06-10 Thread Michal Privoznik
On 05.05.2015 11:59, Michal Privoznik wrote:
 Even though this project is not actively developed, it does not
 mean we can't make some things better in it. After this patchset,
 distcheck works, targets are not built everytime, only when
 necessary, and so on.
 
 Michal Privoznik (10):
   Update .gitignore
   Update autotools generated files
   get_next_free_numeric_value: Use correct format for sscanf()
   tools: Cleanup Makefile
   configure.ac: Check for libtool
   src: Clean up Makefile
   tests: Clean up Makefile.am
   tests: Update qemu path
   tests: run under distcheck
   Install libvirt-php.ini more wisely
 
  .gitignore   |  28 ++
  INSTALL  |   8 +-
  Makefile.am  |   4 +-
  configure.ac |   8 +-
  install-sh   |  14 +-
  missing  | 412 
 ++-
  src/Makefile.am  |  64 +++--
  src/libvirt-php.c|   2 +-
  tests/Makefile.am|  37 ++-
  tests/data/example-qcow2-disk.xml|   2 +-
  tests/{functions.phpt = functions.phpt.in}  |   4 +-
  tests/php.ini|   2 +-
  tests/runtests.sh|   4 +-
  tests/test-domain-create-and-coredump.phpt   |   3 +-
  tests/test-domain-create-and-get-xpath.phpt  |   3 +-
  tests/test-domain-create-get-metadata.phpt   |   3 +-
  tests/test-domain-create.phpt|   3 +-
  tests/test-domain-define-create-destroy.phpt |   3 +-
  tests/test-domain-define-undefine.phpt   |   3 +-
  tests/test-domain-snapshot.phpt  |   3 +-
  tools/Makefile.am|  29 +-
  21 files changed, 309 insertions(+), 330 deletions(-)
  rename tests/{functions.phpt = functions.phpt.in} (91%)
 

Ping? No php knowledge is required to review these patches. They are
merely Makefile and configure.ac cleanups.

Michal

--
libvir-list mailing list
libvir-list@redhat.com
https://www.redhat.com/mailman/listinfo/libvir-list