Re: [libvirt PATCH 3/3] ci: Start building RPMs
On Fri, 2020-10-09 at 07:11 -0400, Neal Gompa wrote: > On Fri, Oct 9, 2020 at 4:49 AM Andrea Bolognani wrote: > > On Thu, 2020-10-08 at 22:17 -0400, Neal Gompa wrote: > > > I've got a patch set locally that adds the few knobs needed to make > > > openSUSE build with the upstream spec file. If you want, I can clean > > > that up and submit it for upstream inclusion? > > > > Sure thing! > > I'll do it after your spec cleanup patch set lands, because otherwise > it's going to be a bit hellish to rebase. I agree, that's definitely the smart way to go about it :) -- Andrea Bolognani / Red Hat / Virtualization
Re: [libvirt PATCH 3/3] ci: Start building RPMs
On Fri, Oct 9, 2020 at 4:49 AM Andrea Bolognani wrote: > > On Thu, 2020-10-08 at 22:17 -0400, Neal Gompa wrote: > > On Thu, Oct 8, 2020 at 1:43 PM Andrea Bolognani wrote: > > > We lost this coverage during the move from CentOS CI to GitLab CI, > > > and it's high time we brought it back. > > > > > > Building RPMs is currently skipped for: > > > > > > * openSUSE, which is not supported by our spec file; > > > > I've got a patch set locally that adds the few knobs needed to make > > openSUSE build with the upstream spec file. If you want, I can clean > > that up and submit it for upstream inclusion? > > Sure thing! > I'll do it after your spec cleanup patch set lands, because otherwise it's going to be a bit hellish to rebase. -- 真実はいつも一つ！/ Always, there's only one truth!
Re: [libvirt PATCH 3/3] ci: Start building RPMs
On Thu, 2020-10-08 at 22:17 -0400, Neal Gompa wrote: > On Thu, Oct 8, 2020 at 1:43 PM Andrea Bolognani wrote: > > We lost this coverage during the move from CentOS CI to GitLab CI, > > and it's high time we brought it back. > > > > Building RPMs is currently skipped for: > > > > * openSUSE, which is not supported by our spec file; > > I've got a patch set locally that adds the few knobs needed to make > openSUSE build with the upstream spec file. If you want, I can clean > that up and submit it for upstream inclusion? Sure thing! -- Andrea Bolognani / Red Hat / Virtualization
Re: [libvirt PATCH 3/3] ci: Start building RPMs
On Thu, Oct 8, 2020 at 1:43 PM Andrea Bolognani wrote: > > We lost this coverage during the move from CentOS CI to GitLab CI, > and it's high time we brought it back. > > Building RPMs is currently skipped for: > > * openSUSE, which is not supported by our spec file; > I've got a patch set locally that adds the few knobs needed to make openSUSE build with the upstream spec file. If you want, I can clean that up and submit it for upstream inclusion? -- 真実はいつも一つ！/ Always, there's only one truth!
