Re: The exact meaning of DEVICE_REMOVED event

2021-10-26 Thread Peter Krempa
On Tue, Oct 26, 2021 at 15:13:22 +0800, Han Han wrote:
> Hi, developers
> I has a question about the event VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED. When
> will it occur? Detach device from an active VM? Or an inactive VM? Or both?
> I get a code comment from the callback of this event
> https://gitlab.com/libvirt/libvirt/-/blob/master/include/libvirt/libvirt-domain.h#L4151
> "This callback occurs when a device is removed from the domain"
> 
> But it is not clear the domain could be active or inactive or both.

The wording is indeed a bit confusing. At this point the callback is
emitted only when the VM is running and only when the guest OS
cooperates with the device removal.



The exact meaning of DEVICE_REMOVED event

2021-10-26 Thread Han Han
Hi, developers
I has a question about the event VIR_DOMAIN_EVENT_ID_DEVICE_REMOVED. When
will it occur? Detach device from an active VM? Or an inactive VM? Or both?
I get a code comment from the callback of this event
https://gitlab.com/libvirt/libvirt/-/blob/master/include/libvirt/libvirt-domain.h#L4151
"This callback occurs when a device is removed from the domain"

But it is not clear the domain could be active or inactive or both.