[Lift] Re: A round of thanks to Marius for better GC
Thank you Dave, I just noticed a little bug in case cookies are disabled. I just committed a fix for it. Br's, Marius On Feb 20, 4:29 am, David Pollak wrote: > Folks, > Marius made some patches to Lift's GC support today. He removed the lift:gc > tag so we don't trip over the Firefox namespace issue. > > I've done some initial testing (and made a few minor updates). > > Please do a mvn -U clean install and let us know how well the new code > works. > > Please also do tests like navigating to a page with form elements on it, > waiting 45 minutes and then making sure the form can be submitted. > > Thanks, > > David > > -- > Lift, the simply functional web frameworkhttp://liftweb.net > Beginning Scalahttp://www.apress.com/book/view/1430219890 > Follow me:http://twitter.com/dpp > Git some:http://github.com/dpp --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Lift" group. To post to this group, send email to liftweb@googlegroups.com To unsubscribe from this group, send email to liftweb+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/liftweb?hl=en -~--~~~~--~~--~--~---
[Lift] Re: A round of thanks to Marius for better GC
Has this fix been committed? Dunno for sure if it is really GC related But I did an mvn -U clean install and my app worked fine on my desktop But when I accessed it from my iPhone I got logged out in 10 or 15 seconds. I had cookies disabled in Safari on my iPhone. Enabling cookies fixed the problem. ---Paul O On Feb 19, 10:45 pm, "marius d." wrote: > Thank you Dave, > > I just noticed a little bug in case cookies are disabled. I just > committed a fix for it. > > Br's, > Marius > > On Feb 20, 4:29 am, David Pollak > wrote: > > > Folks, > > Marius made some patches to Lift's GC support today. He removed the lift:gc > > tag so we don't trip over the Firefox namespace issue. > > > I've done some initial testing (and made a few minor updates). > > > Please do a mvn -U clean install and let us know how well the new code > > works. > > > Please also do tests like navigating to a page with form elements on it, > > waiting 45 minutes and then making sure the form can be submitted. > > > Thanks, > > > David > > > -- > > Lift, the simply functional web frameworkhttp://liftweb.net > > Beginning Scalahttp://www.apress.com/book/view/1430219890 > > Follow me:http://twitter.com/dpp > > Git some:http://github.com/dpp --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Lift" group. To post to this group, send email to liftweb@googlegroups.com To unsubscribe from this group, send email to liftweb+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/liftweb?hl=en -~--~~~~--~~--~--~---
[Lift] Re: A round of thanks to Marius for better GC
Well I did some testing with cookies disabled and worked just fine. Can you pleas make a minimalist example that reproduces the problem? (I suspect you case should be reproducible on desktop browser as well if you turn of cookies from container) Br's, Marius On Feb 20, 11:40 am, "Paul O'Rorke" wrote: > Has this fix been committed? > Dunno for sure if it is really GC related > But I did an mvn -U clean install and my app worked fine on my desktop > But when I accessed it from my iPhone I got logged out in 10 or 15 > seconds. > I had cookies disabled in Safari on my iPhone. Enabling cookies fixed > the problem. > ---Paul O > > On Feb 19, 10:45 pm, "marius d." wrote: > > > Thank you Dave, > > > I just noticed a little bug in case cookies are disabled. I just > > committed a fix for it. > > > Br's, > > Marius > > > On Feb 20, 4:29 am, David Pollak > > wrote: > > > > Folks, > > > Marius made some patches to Lift's GC support today. He removed the > > > lift:gc > > > tag so we don't trip over the Firefox namespace issue. > > > > I've done some initial testing (and made a few minor updates). > > > > Please do a mvn -U clean install and let us know how well the new code > > > works. > > > > Please also do tests like navigating to a page with form elements on it, > > > waiting 45 minutes and then making sure the form can be submitted. > > > > Thanks, > > > > David > > > > -- > > > Lift, the simply functional web frameworkhttp://liftweb.net > > > Beginning Scalahttp://www.apress.com/book/view/1430219890 > > > Follow me:http://twitter.com/dpp > > > Git some:http://github.com/dpp --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Lift" group. To post to this group, send email to liftweb@googlegroups.com To unsubscribe from this group, send email to liftweb+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/liftweb?hl=en -~--~~~~--~~--~--~---
[Lift] Re: A round of thanks to Marius for better GC
Great work! I ran into the issue yesterday and today with an update it seems to be working fine. Derek On Thu, Feb 19, 2009 at 7:29 PM, David Pollak wrote: > Folks, > Marius made some patches to Lift's GC support today. He removed the > lift:gc tag so we don't trip over the Firefox namespace issue. > > I've done some initial testing (and made a few minor updates). > > Please do a mvn -U clean install and let us know how well the new code > works. > > Please also do tests like navigating to a page with form elements on it, > waiting 45 minutes and then making sure the form can be submitted. > > Thanks, > > David > > -- > Lift, the simply functional web framework http://liftweb.net > Beginning Scala http://www.apress.com/book/view/1430219890 > Follow me: http://twitter.com/dpp > Git some: http://github.com/dpp > > > > --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Lift" group. To post to this group, send email to liftweb@googlegroups.com To unsubscribe from this group, send email to liftweb+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/liftweb?hl=en -~--~~~~--~~--~--~---
[Lift] Re: A round of thanks to Marius for better GC
I unfortunately have been working alot lately and havent had a chance to check the new GC code out. Some kind soul who can explain the new solution? On Fri, Feb 20, 2009 at 4:18 PM, Derek Chen-Becker wrote: > Great work! I ran into the issue yesterday and today with an update it > seems to be working fine. > > Derek > > > On Thu, Feb 19, 2009 at 7:29 PM, David Pollak < > feeder.of.the.be...@gmail.com> wrote: > >> Folks, >> Marius made some patches to Lift's GC support today. He removed the >> lift:gc tag so we don't trip over the Firefox namespace issue. >> >> I've done some initial testing (and made a few minor updates). >> >> Please do a mvn -U clean install and let us know how well the new code >> works. >> >> Please also do tests like navigating to a page with form elements on it, >> waiting 45 minutes and then making sure the form can be submitted. >> >> Thanks, >> >> David >> >> -- >> Lift, the simply functional web framework http://liftweb.net >> Beginning Scala http://www.apress.com/book/view/1430219890 >> Follow me: http://twitter.com/dpp >> Git some: http://github.com/dpp >> >> >> > > > > -- Viktor Klang Senior Systems Analyst --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Lift" group. To post to this group, send email to liftweb@googlegroups.com To unsubscribe from this group, send email to liftweb+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/liftweb?hl=en -~--~~~~--~~--~--~---
[Lift] Re: A round of thanks to Marius for better GC
I still see some lift:when attributes in Lift output. Is this expected? (I seem to remember them being around long before the gc code went in.) --j On Thu, Feb 19, 2009 at 6:29 PM, David Pollak wrote: > Folks, > Marius made some patches to Lift's GC support today. He removed the > lift:gc tag so we don't trip over the Firefox namespace issue. > > I've done some initial testing (and made a few minor updates). > > Please do a mvn -U clean install and let us know how well the new code > works. > > Please also do tests like navigating to a page with form elements on it, > waiting 45 minutes and then making sure the form can be submitted. > > Thanks, > > David > > -- > Lift, the simply functional web framework http://liftweb.net > Beginning Scala http://www.apress.com/book/view/1430219890 > Follow me: http://twitter.com/dpp > Git some: http://github.com/dpp > > > > --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Lift" group. To post to this group, send email to liftweb@googlegroups.com To unsubscribe from this group, send email to liftweb+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/liftweb?hl=en -~--~~~~--~~--~--~---
[Lift] Re: A round of thanks to Marius for better GC
On Fri, Feb 20, 2009 at 9:49 AM, Jorge Ortiz wrote: > I still see some lift:when attributes in Lift output. Is this expected? (I > seem to remember them being around long before the gc code went in.) This is expected. It has not been the case that an ajax component inserts a comet component via jQuery, but this would trigger the problem. Given that this is a low-likelihood scenario and there is a work-around, I'm less concerned about it. > > > --j > > On Thu, Feb 19, 2009 at 6:29 PM, David Pollak < > feeder.of.the.be...@gmail.com> wrote: > >> Folks, >> Marius made some patches to Lift's GC support today. He removed the >> lift:gc tag so we don't trip over the Firefox namespace issue. >> >> I've done some initial testing (and made a few minor updates). >> >> Please do a mvn -U clean install and let us know how well the new code >> works. >> >> Please also do tests like navigating to a page with form elements on it, >> waiting 45 minutes and then making sure the form can be submitted. >> >> Thanks, >> >> David >> >> -- >> Lift, the simply functional web framework http://liftweb.net >> Beginning Scala http://www.apress.com/book/view/1430219890 >> Follow me: http://twitter.com/dpp >> Git some: http://github.com/dpp >> >> >> > > > > -- Lift, the simply functional web framework http://liftweb.net Beginning Scala http://www.apress.com/book/view/1430219890 Follow me: http://twitter.com/dpp Git some: http://github.com/dpp --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Lift" group. To post to this group, send email to liftweb@googlegroups.com To unsubscribe from this group, send email to liftweb+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/liftweb?hl=en -~--~~~~--~~--~--~---
[Lift] Re: A round of thanks to Marius for better GC
On Feb 20, 5:30 pm, Viktor Klang wrote: > I unfortunately have been working alot lately and havent had a chance to > check the new GC code out. > > Some kind soul who can explain the new solution? Well instead of using lift:gc all around the gc polling send up only the page ID. Functions on the session are no updating with the right owner in the rendering pipelline. Hence for a GC request we are updating the last-seen timestamp only for the functions pertaining to that specific page. Of course now if youare removing DOM nodes (or use SHtml) we don't really know what functions were tight to that node so those will still be kept around. I really don't think this is a biggie though. Even with old lift:gc approach there were some corner cases like one can clone a node, remove it, and later on add it back ... but in the mean time the function may have been gc-ed (could have happened extremely rare but it was still there). Another benefit now is that gc requests are more lightweight. ... and all thanks to Dave's nifty idea ! > > On Fri, Feb 20, 2009 at 4:18 PM, Derek Chen-Becker > wrote: > > > > > Great work! I ran into the issue yesterday and today with an update it > > seems to be working fine. > > > Derek > > > On Thu, Feb 19, 2009 at 7:29 PM, David Pollak < > > feeder.of.the.be...@gmail.com> wrote: > > >> Folks, > >> Marius made some patches to Lift's GC support today. He removed the > >> lift:gc tag so we don't trip over the Firefox namespace issue. > > >> I've done some initial testing (and made a few minor updates). > > >> Please do a mvn -U clean install and let us know how well the new code > >> works. > > >> Please also do tests like navigating to a page with form elements on it, > >> waiting 45 minutes and then making sure the form can be submitted. > > >> Thanks, > > >> David > > >> -- > >> Lift, the simply functional web frameworkhttp://liftweb.net > >> Beginning Scalahttp://www.apress.com/book/view/1430219890 > >> Follow me:http://twitter.com/dpp > >> Git some:http://github.com/dpp > > -- > Viktor Klang > Senior Systems Analyst --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Lift" group. To post to this group, send email to liftweb@googlegroups.com To unsubscribe from this group, send email to liftweb+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/liftweb?hl=en -~--~~~~--~~--~--~---
[Lift] Re: A round of thanks to Marius for better GC
On Fri, Feb 20, 2009 at 10:43 AM, marius d. wrote: > > > > On Feb 20, 5:30 pm, Viktor Klang wrote: > > I unfortunately have been working alot lately and havent had a chance to > > check the new GC code out. > > > > Some kind soul who can explain the new solution? > > Well instead of using lift:gc all around the gc polling send up only > the page ID. Functions on the session are no updating with the right > owner in the rendering pipelline. Hence for a GC request we are > updating the last-seen timestamp only for the functions pertaining to > that specific page. > > Of course now if youare removing DOM nodes (or use SHtml) we don't > really know what functions were tight to that node so those will still > be kept around. They will be kept around for the duration of the page display, not the duration of the session. For application-style stuff (e.g., GMail which is always on the same page), use the JSON handlers for communication between the page and the server. > I really don't think this is a biggie though. Even > with old lift:gc approach there were some corner cases like one can > clone a node, remove it, and later on add it back ... but in the mean > time the function may have been gc-ed (could have happened extremely > rare but it was still there). > > Another benefit now is that gc requests are more lightweight. > > ... and all thanks to Dave's nifty idea ! > > > > > On Fri, Feb 20, 2009 at 4:18 PM, Derek Chen-Becker < > dchenbec...@gmail.com>wrote: > > > > > > > > > Great work! I ran into the issue yesterday and today with an update it > > > seems to be working fine. > > > > > Derek > > > > > On Thu, Feb 19, 2009 at 7:29 PM, David Pollak < > > > feeder.of.the.be...@gmail.com> wrote: > > > > >> Folks, > > >> Marius made some patches to Lift's GC support today. He removed the > > >> lift:gc tag so we don't trip over the Firefox namespace issue. > > > > >> I've done some initial testing (and made a few minor updates). > > > > >> Please do a mvn -U clean install and let us know how well the new code > > >> works. > > > > >> Please also do tests like navigating to a page with form elements on > it, > > >> waiting 45 minutes and then making sure the form can be submitted. > > > > >> Thanks, > > > > >> David > > > > >> -- > > >> Lift, the simply functional web frameworkhttp://liftweb.net > > >> Beginning Scalahttp://www.apress.com/book/view/1430219890 > > >> Follow me:http://twitter.com/dpp > > >> Git some:http://github.com/dpp > > > > -- > > Viktor Klang > > Senior Systems Analyst > > > -- Lift, the simply functional web framework http://liftweb.net Beginning Scala http://www.apress.com/book/view/1430219890 Follow me: http://twitter.com/dpp Git some: http://github.com/dpp --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Lift" group. To post to this group, send email to liftweb@googlegroups.com To unsubscribe from this group, send email to liftweb+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/liftweb?hl=en -~--~~~~--~~--~--~---
[Lift] Re: A round of thanks to Marius for better GC
Smart solution :) Viktor, Rogue Software Architect 20 feb 2009 kl. 19.43 "marius d." skrev: > > > > On Feb 20, 5:30 pm, Viktor Klang wrote: >> I unfortunately have been working alot lately and havent had a >> chance to >> check the new GC code out. >> >> Some kind soul who can explain the new solution? > > Well instead of using lift:gc all around the gc polling send up only > the page ID. Functions on the session are no updating with the right > owner in the rendering pipelline. Hence for a GC request we are > updating the last-seen timestamp only for the functions pertaining to > that specific page. > > Of course now if youare removing DOM nodes (or use SHtml) we don't > really know what functions were tight to that node so those will still > be kept around. I really don't think this is a biggie though. Even > with old lift:gc approach there were some corner cases like one can > clone a node, remove it, and later on add it back ... but in the mean > time the function may have been gc-ed (could have happened extremely > rare but it was still there). > > Another benefit now is that gc requests are more lightweight. > > ... and all thanks to Dave's nifty idea ! > >> >> On Fri, Feb 20, 2009 at 4:18 PM, Derek Chen-Becker >> wrote: >> >> >> >>> Great work! I ran into the issue yesterday and today with an >>> update it >>> seems to be working fine. >> >>> Derek >> >>> On Thu, Feb 19, 2009 at 7:29 PM, David Pollak < >>> feeder.of.the.be...@gmail.com> wrote: >> Folks, Marius made some patches to Lift's GC support today. He removed the lift:gc tag so we don't trip over the Firefox namespace issue. >> I've done some initial testing (and made a few minor updates). >> Please do a mvn -U clean install and let us know how well the new code works. >> Please also do tests like navigating to a page with form elements on it, waiting 45 minutes and then making sure the form can be submitted. >> Thanks, >> David >> -- Lift, the simply functional web frameworkhttp://liftweb.net Beginning Scalahttp://www.apress.com/book/view/1430219890 Follow me:http://twitter.com/dpp Git some:http://github.com/dpp >> >> -- >> Viktor Klang >> Senior Systems Analyst > > --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Lift" group. To post to this group, send email to liftweb@googlegroups.com To unsubscribe from this group, send email to liftweb+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/liftweb?hl=en -~--~~~~--~~--~--~---
