[Lift] Re: Relax method scope

2009-08-19 Thread Timothy Perrett

Committed - I also added a dirty_? : Boolean method to Field.scala

Cheers, Tim

On Aug 18, 6:38 pm, David Pollak feeder.of.the.be...@gmail.com
wrote:
 It's okay to relax it... maybe even make it public.

 On Tue, Aug 18, 2009 at 8:57 AM, Timothy Perrett 
 timo...@getintheloop.euwrote:







  Guys,

  Is there a good reason that this method in MetaRecord is private
  [record]?

   private[record] def foreachCallback(inst: BaseRecord, f:
  LifecycleCallbacks = Any) {
     lifecycleCallbacks.foreach(m = f(m._2.invoke(inst).asInstanceOf
  [LifecycleCallbacks]))
   }

  Its a useful thing to want to implement in your custom record backends
  (DBRecord makes use of it for example) - can I relax it to:

   protected def foreachCallback(inst: BaseRecord, f:
  LifecycleCallbacks = Any) {
     lifecycleCallbacks.foreach(m = f(m._2.invoke(inst).asInstanceOf
  [LifecycleCallbacks]))
   }

  Cheers

  Tim

 --
 Lift, the simply functional web frameworkhttp://liftweb.net
 Beginning Scalahttp://www.apress.com/book/view/1430219890
 Follow me:http://twitter.com/dpp
 Git some:http://github.com/dpp
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
Lift group.
To post to this group, send email to liftweb@googlegroups.com
To unsubscribe from this group, send email to 
liftweb+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/liftweb?hl=en
-~--~~~~--~~--~--~---



[Lift] Re: Relax method scope

2009-08-18 Thread David Pollak
It's okay to relax it... maybe even make it public.

On Tue, Aug 18, 2009 at 8:57 AM, Timothy Perrett timo...@getintheloop.euwrote:


 Guys,

 Is there a good reason that this method in MetaRecord is private
 [record]?

  private[record] def foreachCallback(inst: BaseRecord, f:
 LifecycleCallbacks = Any) {
lifecycleCallbacks.foreach(m = f(m._2.invoke(inst).asInstanceOf
 [LifecycleCallbacks]))
  }

 Its a useful thing to want to implement in your custom record backends
 (DBRecord makes use of it for example) - can I relax it to:

  protected def foreachCallback(inst: BaseRecord, f:
 LifecycleCallbacks = Any) {
lifecycleCallbacks.foreach(m = f(m._2.invoke(inst).asInstanceOf
 [LifecycleCallbacks]))
  }

 Cheers

 Tim
 



-- 
Lift, the simply functional web framework http://liftweb.net
Beginning Scala http://www.apress.com/book/view/1430219890
Follow me: http://twitter.com/dpp
Git some: http://github.com/dpp

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
Lift group.
To post to this group, send email to liftweb@googlegroups.com
To unsubscribe from this group, send email to 
liftweb+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/liftweb?hl=en
-~--~~~~--~~--~--~---