[Lift] Re: form input tag name values changed when moving from M6 to M7
Hi, Bear in mind that I'm a newbie Lifter, so I won't have the knowledge of why certain choices were made or the knock on effects of changing how things work in Lift ... From my perspective (ie automatically testing a form on a page via Cucumber), I'm not sure the unique id (as in unique id across all forms in a webapp) is required. All I need is a unique id for a given form on a page. For my needs, the following line alone will provide that : val prefix: String = new DecimalFormat(0).format (bump + num) Is there a reason I'm not understanding for why a unique id provided by the stack trace is required ? Cheers, Ben --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Lift group. To post to this group, send email to liftweb@googlegroups.com To unsubscribe from this group, send email to liftweb+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/liftweb?hl=en -~--~~~~--~~--~--~---
[Lift] Re: form input tag name values changed when moving from M6 to M7
If Lift is running in test mode the element names should be static, right? Cheers, Tim On 10 Nov 2009, at 19:36, ben wrote: Hi, Bear in mind that I'm a newbie Lifter, so I won't have the knowledge of why certain choices were made or the knock on effects of changing how things work in Lift ... From my perspective (ie automatically testing a form on a page via Cucumber), I'm not sure the unique id (as in unique id across all forms in a webapp) is required. All I need is a unique id for a given form on a page. For my needs, the following line alone will provide that : val prefix: String = new DecimalFormat(0).format (bump + num) Is there a reason I'm not understanding for why a unique id provided by the stack trace is required ? Cheers, Ben --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Lift group. To post to this group, send email to liftweb@googlegroups.com To unsubscribe from this group, send email to liftweb+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/liftweb?hl=en -~--~~~~--~~--~--~---
[Lift] Re: form input tag name values changed when moving from M6 to M7
Timothy Perrett timo...@getintheloop.eu writes: If Lift is running in test mode the element names should be static, right? Only for the same version of Lift. As David wrote in a (this?) thread, when in test mode, the id is basically a hash of the stack trace. So when lift is updated, the ids (most likely) change and you'll have to update the test casesnot so nice :-) /Jeppe --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Lift group. To post to this group, send email to liftweb@googlegroups.com To unsubscribe from this group, send email to liftweb+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/liftweb?hl=en -~--~~~~--~~--~--~---
[Lift] Re: form input tag name values changed when moving from M6 to M7
Sorry I should have read the rest of the thread rather than replying via email - just trying to help but should have kept quiet! Cheers, Tim On Nov 10, 8:33 pm, Jeppe Nejsum Madsen je...@ingolfs.dk wrote: Timothy Perrett timo...@getintheloop.eu writes: If Lift is running in test mode the element names should be static, right? Only for the same version of Lift. As David wrote in a (this?) thread, when in test mode, the id is basically a hash of the stack trace. So when lift is updated, the ids (most likely) change and you'll have to update the test casesnot so nice :-) /Jeppe --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Lift group. To post to this group, send email to liftweb@googlegroups.com To unsubscribe from this group, send email to liftweb+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/liftweb?hl=en -~--~~~~--~~--~--~---
[Lift] Re: form input tag name values changed when moving from M6 to M7
Which brings us back to my original point ... how can we preserve acceptance tests ? Do we need to have a stack-trace hash on the form ids or can we have a non-unique-id-through-the-webapp but unique to the form in order to achieve this. My newbie knowledge of Lift suggests we can, but I don't have enough of a big picture view of Lift to give a conclusive answer ... --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups Lift group. To post to this group, send email to liftweb@googlegroups.com To unsubscribe from this group, send email to liftweb+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/liftweb?hl=en -~--~~~~--~~--~--~---
[Lift] Re: form input tag name values changed when moving from M6 to M7
On Thu, Nov 5, 2009 at 8:50 AM, ben b...@primrose.org.uk wrote:
Hi,
I was running 1.1-M6 with 2.7.6 with run.mode=test, and had written a
bunch of acceptance tests using Cucumber.
I just upgraded to 1.1-M7 with 2.7.7 and all the name values of form
input tags have changed, failing all my tests :(
D'oh.
Name value with 1.1-M6 + 2.7.6
f01001_77444531b59f74f18fbde8c81a40a22e862a00cb
Name value with 1.1-M7 + 2.7.7
f01001_1bceef1fd31e439accaa8462e3dfd1942e1a05ea
Can anyone shed any light on :
1) How are these ids generated
def formFuncName: String = if (Props.testMode) {
val bump: Long = ((_formGroup.is openOr 0) + 1000L) * 1L
val num: Int = formItemNumber.is
formItemNumber.set(num + 1)
import _root_.java.text._
val prefix: String = new DecimalFormat(0).format(bump
+ num)
f + prefix + _ + Helpers.hashHex((new
Exception).getStackTrace.toList.take(10).map(_.toString).mkString(,))
} else {
_formGroup.is match {
case Full(x) = Helpers.nextFuncName(x.toLong * 1L)
case _ = Helpers.nextFuncName
}
}
2) Will they always change when we upgrade liftweb/scala versions ?
It's based on the stack trace (10 frames), so I think so. I'm open to other
mechanisms of generating stable identifiers, so if you've got something that
will generate something stable and unique, changing things is cool with me.
Cheers,
Ben
--
Lift, the simply functional web framework http://liftweb.net
Beginning Scala http://www.apress.com/book/view/1430219890
Follow me: http://twitter.com/dpp
Surf the harmonics
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
Lift group.
To post to this group, send email to liftweb@googlegroups.com
To unsubscribe from this group, send email to
liftweb+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/liftweb?hl=en
-~--~~~~--~~--~--~---
