[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5152 Doc: CG: Add guideline for use of 'CSS' prefix in commit messages
- **Needs**: --> - **Patch**: new --> review - **Type**: --> Documentation - **Comment**: Passes make, make check and a full make doc. --- ** [issues:#5152] Doc: CG: Add guideline for use of 'CSS' prefix in commit messages** **Status:** Started **Created:** Tue Jul 04, 2017 07:22 PM UTC by Paul Morris **Last Updated:** Sat Jul 08, 2017 09:26 PM UTC **Owner:** Paul Morris Doc: CG: Add guideline for use of 'CSS' prefix in commit messages http://codereview.appspot.com/325970043 --- Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is subscribed to https://sourceforge.net/p/testlilyissues/issues/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Testlilyissues-auto mailing list testlilyissues-a...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4603 change all occurences of ‘partcombine’ to ‘partCombine’.
Ok, this is really really late but I've taken a look at the output of git grep '[pP]artCombine' in the current code base and changing those occurences to `partcombine` would be way less effort than the other way round: basically most of them are new. I might be predisposed by lots of exposure to previous code though. The oldest ones to be changed would be `partcombineListener` (output definitions are not capitalized?), `PartcombineMusic`, `PartcombinePartMusic`, `printPartcombineTexts`. I am slightly leaning to that change but it would also have to result in `Partcombine_engraver`, `Partcombine_iterator`, `Partcombine_part_iterator` to be consistent. Basically making partcombining one word (wouldn't separate words be rather "combine parts"? The correct spelling of partcombiner would likely be "the part-combiner". Huh). However that may be: having a large discrepancy without backward compatibility between 2.18 and 2.20 seems like a bad idea since LSR and online help will bomb a lot. We have seen this effect with various backward-compatible but compelling changes in the past: having this in a non-backward-compatible way seems like a bad idea that will cause a whole lot of medium-term pain for little long-term gain. So I think it would be reasonable to a) postpone any such changes to 2.21. Since we currently are at a good time to fork off the 2.20 release branch anyway, that does not need to imply a large delay. b) develop a mechanism for backward compatibility. Reasonably easy for commands, trickier for properties and engravers. Point b) should be tackled rather fast though, preferably within a reasonable time frame of a), perhaps even before if possible. Depends on how fast we can come up with ideas for making this work. --- ** [issues:#4603] change all occurences of ‘partcombine’ to ‘partCombine’.** **Status:** Started **Created:** Sun Sep 13, 2015 03:17 PM UTC by pkx166h **Last Updated:** Mon Jul 10, 2017 10:26 AM UTC **Owner:** Charles Winston On 13/08/15 21:42, Malte Meyn wrote: > Hi list, > > the case of the ‘c’ in partcombine is inconsistent, confusing me every > time I use \partcombine(Apart|Chords|…): > > \partcombine, \partcombineApart, … but > \partCombineTextsOnNote, \partCombineListener > > I would suggest to change all occurences of ‘partcombine’ to ‘partCombine’. > > Why not change ‘partCombine’ to ‘partcombine’? Because I looked at the > engravers which use the more ‘natural’ underscore instead of camelCase > for spaces. And in the same way as ‘Cue_clef_engraver’ suggests that > ‘cue clef’ are two words (resulting in ‘cueClefGlyph’, not > ‘cueclefGlyph’), ‘Part_combine_engraver’ does. > > I think that this would be rather easy to change. > > Cheers, > Malte Response to Issue #4603: Syntax change from all instances "partcombine" to "partCombine" and convert-ly rule added to go along with. http://codereview.appspot.com/323040043 - part 1 of 3 http://codereview.appspot.com/326870043 - part 2 of 3 http://codereview.appspot.com/327970043 - part 3 of 3 Note this will require both a convert.ly and a makelsr.py run to make sure that the patch passes all the tests. --- Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is subscribed to https://sourceforge.net/p/testlilyissues/issues/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Testlilyissues-auto mailing list testlilyissues-a...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4603 change all occurences of ‘partcombine’ to ‘partCombine’.
- Description has changed: Diff: --- old +++ new @@ -26,3 +26,7 @@ http://codereview.appspot.com/326870043 - part 2 of 3 +http://codereview.appspot.com/327970043 - part 3 of 3 + +Note this will require both a convert.ly and a makelsr.py run to make sure that the patch passes all the tests. + --- ** [issues:#4603] change all occurences of ‘partcombine’ to ‘partCombine’.** **Status:** Started **Created:** Sun Sep 13, 2015 03:17 PM UTC by pkx166h **Last Updated:** Mon Jul 10, 2017 10:25 AM UTC **Owner:** Charles Winston On 13/08/15 21:42, Malte Meyn wrote: > Hi list, > > the case of the ‘c’ in partcombine is inconsistent, confusing me every > time I use \partcombine(Apart|Chords|…): > > \partcombine, \partcombineApart, … but > \partCombineTextsOnNote, \partCombineListener > > I would suggest to change all occurences of ‘partcombine’ to ‘partCombine’. > > Why not change ‘partCombine’ to ‘partcombine’? Because I looked at the > engravers which use the more ‘natural’ underscore instead of camelCase > for spaces. And in the same way as ‘Cue_clef_engraver’ suggests that > ‘cue clef’ are two words (resulting in ‘cueClefGlyph’, not > ‘cueclefGlyph’), ‘Part_combine_engraver’ does. > > I think that this would be rather easy to change. > > Cheers, > Malte Response to Issue #4603: Syntax change from all instances "partcombine" to "partCombine" and convert-ly rule added to go along with. http://codereview.appspot.com/323040043 - part 1 of 3 http://codereview.appspot.com/326870043 - part 2 of 3 http://codereview.appspot.com/327970043 - part 3 of 3 Note this will require both a convert.ly and a makelsr.py run to make sure that the patch passes all the tests. --- Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is subscribed to https://sourceforge.net/p/testlilyissues/issues/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Testlilyissues-auto mailing list testlilyissues-a...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4603 change all occurences of ‘partcombine’ to ‘partCombine’.
- Description has changed: Diff: --- old +++ new @@ -23,3 +23,6 @@ Response to Issue #4603: Syntax change from all instances "partcombine" to "partCombine" and convert-ly rule added to go along with. http://codereview.appspot.com/323040043 - part 1 of 3 + +http://codereview.appspot.com/326870043 - part 2 of 3 + - **Needs**: --> - **Type**: --> --- ** [issues:#4603] change all occurences of ‘partcombine’ to ‘partCombine’.** **Status:** Started **Created:** Sun Sep 13, 2015 03:17 PM UTC by pkx166h **Last Updated:** Mon Jul 10, 2017 10:24 AM UTC **Owner:** Charles Winston On 13/08/15 21:42, Malte Meyn wrote: > Hi list, > > the case of the ‘c’ in partcombine is inconsistent, confusing me every > time I use \partcombine(Apart|Chords|…): > > \partcombine, \partcombineApart, … but > \partCombineTextsOnNote, \partCombineListener > > I would suggest to change all occurences of ‘partcombine’ to ‘partCombine’. > > Why not change ‘partCombine’ to ‘partcombine’? Because I looked at the > engravers which use the more ‘natural’ underscore instead of camelCase > for spaces. And in the same way as ‘Cue_clef_engraver’ suggests that > ‘cue clef’ are two words (resulting in ‘cueClefGlyph’, not > ‘cueclefGlyph’), ‘Part_combine_engraver’ does. > > I think that this would be rather easy to change. > > Cheers, > Malte Response to Issue #4603: Syntax change from all instances "partcombine" to "partCombine" and convert-ly rule added to go along with. http://codereview.appspot.com/323040043 - part 1 of 3 http://codereview.appspot.com/326870043 - part 2 of 3 --- Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is subscribed to https://sourceforge.net/p/testlilyissues/issues/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Testlilyissues-auto mailing list testlilyissues-a...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4603 change all occurences of ‘partcombine’ to ‘partCombine’.
Change all instances of \partcombine to \partCombine in the reg tests Issue 4603 (3 of 3) All instances of \partcombine in ../input/regression/ have been changed to \partCombine. http://codereview.appspot.com/327970043 --- ** [issues:#4603] change all occurences of ‘partcombine’ to ‘partCombine’.** **Status:** Started **Created:** Sun Sep 13, 2015 03:17 PM UTC by pkx166h **Last Updated:** Mon Jul 10, 2017 10:24 AM UTC **Owner:** Charles Winston On 13/08/15 21:42, Malte Meyn wrote: > Hi list, > > the case of the ‘c’ in partcombine is inconsistent, confusing me every > time I use \partcombine(Apart|Chords|…): > > \partcombine, \partcombineApart, … but > \partCombineTextsOnNote, \partCombineListener > > I would suggest to change all occurences of ‘partcombine’ to ‘partCombine’. > > Why not change ‘partCombine’ to ‘partcombine’? Because I looked at the > engravers which use the more ‘natural’ underscore instead of camelCase > for spaces. And in the same way as ‘Cue_clef_engraver’ suggests that > ‘cue clef’ are two words (resulting in ‘cueClefGlyph’, not > ‘cueclefGlyph’), ‘Part_combine_engraver’ does. > > I think that this would be rather easy to change. > > Cheers, > Malte Response to Issue #4603: Syntax change from all instances "partcombine" to "partCombine" and convert-ly rule added to go along with. http://codereview.appspot.com/323040043 - part 1 of 3 --- Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is subscribed to https://sourceforge.net/p/testlilyissues/issues/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Testlilyissues-auto mailing list testlilyissues-a...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4603 change all occurences of ‘partcombine’ to ‘partCombine’.
Change all instances of \partcombine to \partCombine in the documentation Issue 4603 (2 of 3) All instances of \partcombine in ../Documentation (including translated and snippets) have been changed to \partCombine. http://codereview.appspot.com/326870043 --- ** [issues:#4603] change all occurences of ‘partcombine’ to ‘partCombine’.** **Status:** Started **Created:** Sun Sep 13, 2015 03:17 PM UTC by pkx166h **Last Updated:** Mon Jul 10, 2017 10:19 AM UTC **Owner:** Charles Winston On 13/08/15 21:42, Malte Meyn wrote: > Hi list, > > the case of the ‘c’ in partcombine is inconsistent, confusing me every > time I use \partcombine(Apart|Chords|…): > > \partcombine, \partcombineApart, … but > \partCombineTextsOnNote, \partCombineListener > > I would suggest to change all occurences of ‘partcombine’ to ‘partCombine’. > > Why not change ‘partCombine’ to ‘partcombine’? Because I looked at the > engravers which use the more ‘natural’ underscore instead of camelCase > for spaces. And in the same way as ‘Cue_clef_engraver’ suggests that > ‘cue clef’ are two words (resulting in ‘cueClefGlyph’, not > ‘cueclefGlyph’), ‘Part_combine_engraver’ does. > > I think that this would be rather easy to change. > > Cheers, > Malte Response to Issue #4603: Syntax change from all instances "partcombine" to "partCombine" and convert-ly rule added to go along with. http://codereview.appspot.com/323040043 - part 1 of 3 --- Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is subscribed to https://sourceforge.net/p/testlilyissues/issues/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Testlilyissues-auto mailing list testlilyissues-a...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4603 change all occurences of ‘partcombine’ to ‘partCombine’.
- Description has changed: Diff: --- old +++ new @@ -19,3 +19,7 @@ > > Cheers, > Malte + +Response to Issue #4603: Syntax change from all instances "partcombine" to "partCombine" and convert-ly rule added to go along with. + +http://codereview.appspot.com/323040043 - part 1 of 3 - **Patch**: needs_work --> new - **Comment**: I have made the relevant Doc and Reg test edits to make this initial patch pass the tests. I'll upload the two other patches (split into a Doc & snippet patch and a Reg test patch) --- ** [issues:#4603] change all occurences of ‘partcombine’ to ‘partCombine’.** **Status:** Started **Created:** Sun Sep 13, 2015 03:17 PM UTC by pkx166h **Last Updated:** Fri Jun 02, 2017 06:47 AM UTC **Owner:** Charles Winston On 13/08/15 21:42, Malte Meyn wrote: > Hi list, > > the case of the ‘c’ in partcombine is inconsistent, confusing me every > time I use \partcombine(Apart|Chords|…): > > \partcombine, \partcombineApart, … but > \partCombineTextsOnNote, \partCombineListener > > I would suggest to change all occurences of ‘partcombine’ to ‘partCombine’. > > Why not change ‘partCombine’ to ‘partcombine’? Because I looked at the > engravers which use the more ‘natural’ underscore instead of camelCase > for spaces. And in the same way as ‘Cue_clef_engraver’ suggests that > ‘cue clef’ are two words (resulting in ‘cueClefGlyph’, not > ‘cueclefGlyph’), ‘Part_combine_engraver’ does. > > I think that this would be rather easy to change. > > Cheers, > Malte Response to Issue #4603: Syntax change from all instances "partcombine" to "partCombine" and convert-ly rule added to go along with. http://codereview.appspot.com/323040043 - part 1 of 3 --- Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is subscribed to https://sourceforge.net/p/testlilyissues/issues/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Testlilyissues-auto mailing list testlilyissues-a...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
