[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #4182 dynamics on skips confuse cross-staff stems

2020-05-11 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
In case you can read this, I still haven't figured out the right way to disable 
write access...


---

** [issues:#4182] dynamics on skips confuse cross-staff stems**

**Status:** Started
**Created:** Fri Oct 31, 2014 09:21 PM UTC by Anonymous
**Last Updated:** Mon May 11, 2020 09:06 AM UTC
**Owner:** Kevin Barry
**Attachments:**

- 
[stem.png](https://sourceforge.net/p/testlilyissues/issues/4182/attachment/stem.png)
 (6.0 kB; image/png)


https://codereview.appspot.com/554030043

*Originally created by:* *anonymous

*Originally created by:* 
[k-ohara5...@oco.net](http://code.google.com/u/110197288862747384800/)

Sometime since ver 2.18, dynamics on skips began to make cross-staff stems 
point the wrong way.   The ledger line seems to be necessary for the bug.

up = \change Staff = "up"
dn = \change Staff = "down"
\new PianoStaff \transpose c c' << \time 2/4
  \new Staff = "up"  
    s2
  \new Staff = "down" <<  
    \{s8\*3 s8\p  \} 
    \{ g8\[ \up e \dn g \up c\] \} >> >


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #4182 dynamics on skips confuse cross-staff stems

2020-05-11 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
Oh no, this should not have worked! Please use GitLab


---

** [issues:#4182] dynamics on skips confuse cross-staff stems**

**Status:** Started
**Created:** Fri Oct 31, 2014 09:21 PM UTC by Anonymous
**Last Updated:** Mon May 11, 2020 08:41 AM UTC
**Owner:** Kevin Barry
**Attachments:**

- 
[stem.png](https://sourceforge.net/p/testlilyissues/issues/4182/attachment/stem.png)
 (6.0 kB; image/png)


https://codereview.appspot.com/554030043

*Originally created by:* *anonymous

*Originally created by:* 
[k-ohara5...@oco.net](http://code.google.com/u/110197288862747384800/)

Sometime since ver 2.18, dynamics on skips began to make cross-staff stems 
point the wrong way.   The ledger line seems to be necessary for the bug.

up = \change Staff = "up"
dn = \change Staff = "down"
\new PianoStaff \transpose c c' << \time 2/4
  \new Staff = "up"  
    s2
  \new Staff = "down" <<  
    \{s8\*3 s8\p  \} 
    \{ g8\[ \up e \dn g \up c\] \} >> >


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5968 Prevent race condition in `-dfont-ps-resdir`

2020-05-11 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **Needs**:  -->  
- **Patch**: new --> review
- **Type**:  -->  
- **Comment**:

Passes make, make check and a full make doc.



---

** [issues:#5968] Prevent race condition in `-dfont-ps-resdir`**

**Status:** Started
**Created:** Sat May 09, 2020 10:26 AM UTC by Masamichi Hosoda
**Last Updated:** Sat May 09, 2020 02:22 PM UTC
**Owner:** Masamichi Hosoda


Prevent race condition in `-dfont-ps-resdir`

Issue 5968/4: Add Windows support for `-dfont-ps-resdir`

Windows environment could not use `-dfont-ps-resdir` option
because it used symlink.

This commit makes using file copying instead symlink when Windows.

Issue 5968/3: Prevent creating file race condition in `-dfont-ps-resdir`

For `-dfont-ps-resdir`,
we used creating file after checking the file existence.
However, when multiple lilypond processes were running,
as when using lilypond-book,
a race condition could cause creating file to fail.

This commit uses creating file method for `-dfont-export-dir`
that can prevent race condition.

Issue 5968/2: Prevent symlink race condition in `-dfont-ps-resdir`

For `-dfont-ps-resdir`,
we used symlink after checking the file existence.
However, when multiple lilypond processes were running,
as when using lilypond-book, a race condition could cause symlink to fail.

This commit makes preventing the race condition.

Issue 5968/1: Prevent mkdir race condition in `-dfont-ps-resdir`

For `-dfont-ps-resdir`,
we used mkdir after checking the directory existence.
However, when multiple lilypond processes were running,
as when using lilypond-book, a race condition could cause mkdir to fail.

This commit uses making directory method for `-dfont-export-dir`
that can prevent race condition.

http://codereview.appspot.com/561810045


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5940 Split glyph contours in up/down segments for skylines

2020-05-11 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **Needs**:  -->  
- **Patch**: new --> needs_work
- **Type**:  -->  
- **Comment**:

Patch does not apply to current master



---

** [issues:#5940] Split glyph contours in up/down segments for skylines**

**Status:** Started
**Created:** Sun Apr 26, 2020 07:43 AM UTC by Han-Wen Nienhuys
**Last Updated:** Sun May 10, 2020 09:08 AM UTC
**Owner:** Han-Wen Nienhuys


This reduces the amount of skyline input coming from glyph outlines by
2x.

benchmark for arguments: input/regression/mozart-hrn-3
raw data: {'ff2061b518': [2.72, 2.69, 2.71], 'e8212e15e2': [2.7, 2.68, 2.69]}

Version ff2061b518: Create skylines directly from glyph outlines.
e8212e15e2 - Split glyph contours in up/down segments for skylines
  med diff -0.02
  med diff -0.738007 % (e8212e15e2 is faster)


benchmark for arguments: -I carver MSDM
raw data: {'ff2061b518': [51.83, 51.99, 52.05], 'e8212e15e2': [51.27, 51.2, 
51.48]}

ff2061b518: Create skylines directly from glyph outlines.
e8212e15e2 - Split glyph contours in up/down segments for skylines
  med diff -0.72
  med diff -1.384882 % (e8212e15e2 is faster)

https://codereview.appspot.com/569700043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4182 dynamics on skips confuse cross-staff stems

2020-05-11 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **Needs**:  -->  
- **Patch**: new --> review
- **Type**:  -->  
- **Comment**:

Passes make, make check and a full make doc. (reg test diffs as commend above)



---

** [issues:#4182] dynamics on skips confuse cross-staff stems**

**Status:** Started
**Created:** Fri Oct 31, 2014 09:21 PM UTC by Anonymous
**Last Updated:** Sun May 10, 2020 08:08 AM UTC
**Owner:** Kevin Barry
**Attachments:**

- 
[stem.png](https://sourceforge.net/p/testlilyissues/issues/4182/attachment/stem.png)
 (6.0 kB; image/png)


https://codereview.appspot.com/554030043

*Originally created by:* *anonymous

*Originally created by:* 
[k-ohara5...@oco.net](http://code.google.com/u/110197288862747384800/)

Sometime since ver 2.18, dynamics on skips began to make cross-staff stems 
point the wrong way.   The ledger line seems to be necessary for the bug.

up = \change Staff = "up"
dn = \change Staff = "down"
\new PianoStaff \transpose c c' << \time 2/4
  \new Staff = "up"  
    s2
  \new Staff = "down" <<  
    \{s8\*3 s8\p  \} 
    \{ g8\[ \up e \dn g \up c\] \} >> >


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5949 Add option to use Ghostscript API instead of forking

2020-05-10 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **labels**:  --> Fixed_2_21_2
- **status**: Started --> Fixed
- **Patch**: push -->  
- **Comment**:

~~~
commit ddfd0b4fb548aa32bfd809014502de0666d514f3
Author: Jonas Hahnfeld 
AuthorDate: Mon Apr 27 20:54:43 2020 +0200
Commit: Jonas Hahnfeld 
CommitDate: Sat May 9 20:04:45 2020 +0200

Issue 5949: Add option to use Ghostscript API instead of forking

This is much more efficient than the current scheme when converting
many PostScript files, for example when building the documentation.
For the Notation Reference, lilypond-book now takes ~2m30s instead
of 5m to compile all snippets from the notation.tely file. Other
manuals benefit less, but still the time for 'make doc' on my system
improves by one third from around 33m to 22m.

An alternative would have been to always call gsapi_init_with_args
with the same arguments used until now. This indeed works and avoids
the overhead of forking, but the instance cannot be reused. Calling
gsapi_new_instance -> gsapi_init_with_args -> gsapi_delete_instance
for every conversion still means a lot of overhead and a prototype
suggested only a small gain compared to the previous solution.

This is not the default because recent versions of Ghostscript are
distributed under the AGPL and it's unclear what the implications of
linking to the library is. If built with support for the API, use
-dgs-api=#f to still fork the gs command.
~~~



---

** [issues:#5949] Add option to use Ghostscript API instead of forking**

**Status:** Fixed
**Labels:** Fixed_2_21_2 
**Created:** Thu Apr 30, 2020 07:12 PM UTC by Jonas Hahnfeld
**Last Updated:** Sat May 09, 2020 08:47 AM UTC
**Owner:** Jonas Hahnfeld


Add option to use Ghostscript API instead of forking

This is much more efficient than the current scheme when converting
many PostScript files, for example when building the documentation.
For the Notation Reference, lilypond-book now takes ~2m30s instead
of 5m to compile all snippets from the notation.tely file. Other
manuals benefit less, but still the time for 'make doc' on my system
improves by one third from around 33m to 22m.

An alternative would have been to always call gsapi_init_with_args
with the same arguments used until now. This indeed works and avoids
the overhead of forking, but the instance cannot be reused. Calling
gsapi_new_instance -> gsapi_init_with_args -> gsapi_delete_instance
for every conversion still means a lot of overhead and a prototype
suggested only a small gain compared to the previous solution.

This is not the default because recent versions of Ghostscript are
distributed under the AGPL and it's unclear what the implications of
linking to the library is. If built with support for the API, use
-dgs-api=#f to still fork the gs command.

http://codereview.appspot.com/548030043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5967 output-distance: set device properties in batch driver file

2020-05-10 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **labels**:  --> Fixed_2_21_2
- **status**: Started --> Fixed
- **Patch**: review -->  
- **Comment**:

~~~
commit d99780e93bfeafbcafce1c2653eac8e294057e84
Author: Han-Wen Nienhuys 
AuthorDate: Sat May 9 11:49:03 2020 +0200
Commit: Han-Wen Nienhuys 
CommitDate: Sun May 10 10:43:12 2020 +0200

output-distance: set device properties in batch driver file

This fixes the output quality of the regtest results.

Previously, the code sets a device by doing

 (png16m) finddevice

this put a default device on the stack, ignoring the command-line
arguments.  To fix this, specify these settings (HWResolution,
TextAlphaBits, GraphicsAlphaBits) as arguments to the putdeviceprops
call.
~~~



---

** [issues:#5967] output-distance: set device properties in batch driver file**

**Status:** Fixed
**Labels:** Fixed_2_21_2 
**Created:** Sat May 09, 2020 09:53 AM UTC by Han-Wen Nienhuys
**Last Updated:** Sat May 09, 2020 11:44 AM UTC
**Owner:** Han-Wen Nienhuys


This fixes the output quality of the regtest results.

Previously, the code sets a device by doing

 (png16m) finddevice

this put a default device on the stack, ignoring the command-line
arguments.  To fix this, specify these settings (HWResolution,
TextAlphaBits, GraphicsAlphaBits) as arguments to the putdeviceprops
call.

https://codereview.appspot.com/560020043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5963 Remove define causing a warning

2020-05-10 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **labels**:  --> Fixed_2_21_2
- **status**: Started --> Fixed
- **Patch**: push -->  
- **Comment**:

~~~
commit 3ba316af1f73395294df29ee34f3472df31b7e00
Author: Jonas Hahnfeld 
AuthorDate: Mon May 4 16:19:00 2020 +0200
Commit: Jonas Hahnfeld 
CommitDate: Sat May 9 20:04:45 2020 +0200

Issue 5963: Remove define causing a warning

These lines were added in commit 25beb8d01b in 2008 to provide
compatibility with GCC 3.4 which clearly does not support C++11.
(The warning is visible since commit b96b6334c0 which put system
headers last, so that the define is already provided transitvely.)
~~~



---

** [issues:#5963] Remove define causing a warning**

**Status:** Fixed
**Labels:** Fixed_2_21_2 
**Created:** Mon May 04, 2020 04:04 PM UTC by Jonas Hahnfeld
**Last Updated:** Sat May 09, 2020 08:46 AM UTC
**Owner:** Jonas Hahnfeld


Remove define causing a warning

These lines were added in commit 25beb8d01b in 2008 to provide
compatibility with GCC 3.4 which clearly does not support C++11.
(The warning is visible since commit b96b6334c0 which put system
headers last, so that the define is already provided transitvely.)

http://codereview.appspot.com/561790043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5969 Clean up and fix glyph contour generation nits.

2020-05-10 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
const&

https://codereview.appspot.com/566080043


---

** [issues:#5969] Clean up and fix glyph contour generation nits.**

**Status:** Started
**Created:** Sat May 09, 2020 10:31 AM UTC by Han-Wen Nienhuys
**Last Updated:** Sun May 10, 2020 10:08 AM UTC
**Owner:** Han-Wen Nienhuys


There are two bugs:

* Glyphs with multiple contours (e.g. "O" or "i") should compute the
  contours separately

* Contours can wraparound to the start. This leads to OOB reads and/or
  incorrect outlines in other circumstances.

https://codereview.appspot.com/566080043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5969 Clean up and fix glyph contour generation nits.

2020-05-10 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
jonas

https://codereview.appspot.com/566080043


---

** [issues:#5969] Clean up and fix glyph contour generation nits.**

**Status:** Started
**Created:** Sat May 09, 2020 10:31 AM UTC by Han-Wen Nienhuys
**Last Updated:** Sun May 10, 2020 09:30 AM UTC
**Owner:** Han-Wen Nienhuys


There are two bugs:

* Glyphs with multiple contours (e.g. "O" or "i") should compute the
  contours separately

* Contours can wraparound to the start. This leads to OOB reads and/or
  incorrect outlines in other circumstances.

https://codereview.appspot.com/566080043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5940 Split glyph contours in up/down segments for skylines

2020-05-10 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
rebase on bugfix change

https://codereview.appspot.com/569700043


---

** [issues:#5940] Split glyph contours in up/down segments for skylines**

**Status:** Started
**Created:** Sun Apr 26, 2020 07:43 AM UTC by Han-Wen Nienhuys
**Last Updated:** Sun May 10, 2020 09:08 AM UTC
**Owner:** Han-Wen Nienhuys


This reduces the amount of skyline input coming from glyph outlines by
2x.

benchmark for arguments: input/regression/mozart-hrn-3
raw data: {'ff2061b518': [2.72, 2.69, 2.71], 'e8212e15e2': [2.7, 2.68, 2.69]}

Version ff2061b518: Create skylines directly from glyph outlines.
e8212e15e2 - Split glyph contours in up/down segments for skylines
  med diff -0.02
  med diff -0.738007 % (e8212e15e2 is faster)


benchmark for arguments: -I carver MSDM
raw data: {'ff2061b518': [51.83, 51.99, 52.05], 'e8212e15e2': [51.27, 51.2, 
51.48]}

ff2061b518: Create skylines directly from glyph outlines.
e8212e15e2 - Split glyph contours in up/down segments for skylines
  med diff -0.72
  med diff -1.384882 % (e8212e15e2 is faster)

https://codereview.appspot.com/569700043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5969 Clean up and fix glyph contour generation nits.

2020-05-10 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
I don't think this is true. Reference?


---

** [issues:#5969] Clean up and fix glyph contour generation nits.**

**Status:** Started
**Created:** Sat May 09, 2020 10:31 AM UTC by Han-Wen Nienhuys
**Last Updated:** Sun May 10, 2020 08:25 AM UTC
**Owner:** Han-Wen Nienhuys


There are two bugs:

* Glyphs with multiple contours (e.g. "O" or "i") should compute the
  contours separately

* Contours can wraparound to the start. This leads to OOB reads and/or
  incorrect outlines in other circumstances.

https://codereview.appspot.com/566080043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5969 Clean up and fix glyph contour generation nits.

2020-05-10 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
Use FT_Outline_Decompose

https://codereview.appspot.com/566080043


---

** [issues:#5969] Clean up and fix glyph contour generation nits.**

**Status:** Started
**Created:** Sat May 09, 2020 10:31 AM UTC by Han-Wen Nienhuys
**Last Updated:** Sun May 10, 2020 08:25 AM UTC
**Owner:** Han-Wen Nienhuys


There are two bugs:

* Glyphs with multiple contours (e.g. "O" or "i") should compute the
  contours separately

* Contours can wraparound to the start. This leads to OOB reads and/or
  incorrect outlines in other circumstances.

https://codereview.appspot.com/566080043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4182 dynamics on skips confuse cross-staff stems

2020-05-10 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
Fix style issues

https://codereview.appspot.com/554030043


---

** [issues:#4182] dynamics on skips confuse cross-staff stems**

**Status:** Started
**Created:** Fri Oct 31, 2014 09:21 PM UTC by Anonymous
**Last Updated:** Sun May 10, 2020 08:08 AM UTC
**Owner:** Kevin Barry
**Attachments:**

- 
[stem.png](https://sourceforge.net/p/testlilyissues/issues/4182/attachment/stem.png)
 (6.0 kB; image/png)


https://codereview.appspot.com/554030043

*Originally created by:* *anonymous

*Originally created by:* 
[k-ohara5...@oco.net](http://code.google.com/u/110197288862747384800/)

Sometime since ver 2.18, dynamics on skips began to make cross-staff stems 
point the wrong way.   The ledger line seems to be necessary for the bug.

up = \change Staff = "up"
dn = \change Staff = "down"
\new PianoStaff \transpose c c' << \time 2/4
  \new Staff = "up"  
    s2
  \new Staff = "down" <<  
    \{s8\*3 s8\p  \} 
    \{ g8\[ \up e \dn g \up c\] \} >> >


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5973 Simplify and speed up break substitution

2020-05-09 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
reserve mem; clear mem; c++11 loops

https://codereview.appspot.com/569740046


---

** [issues:#5973] Simplify and speed up break substitution**

**Status:** Started
**Created:** Sat May 09, 2020 05:30 PM UTC by Han-Wen Nienhuys
**Last Updated:** Sat May 09, 2020 06:12 PM UTC
**Owner:** Han-Wen Nienhuys


When breaking a system into lines, the pointers between Grobs need to
be rearranged: for example, a single Slur grob that crosses a line break is
broken into two Slur grobs, and the first Slur will point to different
notes as the second slur.

This break substitution is centrally managed, and takes an appreciable
part of the runtime.

Before this change, complicated logic is executed during the break
substitution. For example, for an Item we would determine its System
by recursively following X-parent relationships. Since each item is a
pointed to from multiple other grobs, we have to repeat this expensive
step.

This change introduces a hash map in the root System grob, mapping
(original grob, system) => broken grob. This mapping is easily
populated before the substitution, and the break substitution itself
is reduced to hash lookups.

This yields a speedup of 3-4 %.

2ea63632de - drop islive conditional.
  baseline: 8343ec8810 PO: fetch Catalan from FTP
  args: -I carver/ MSDM
  memory: med diff 114296 (stddevs 257 240, n=3)
  memory: med diff 10.7 % (2ea63632de is fatter)
  time: med diff -1.39 (stddevs 0.06 0.10, n=3)
  time: med diff -2.9 % (2ea63632de is faster)

2ea63632de - drop islive conditional.
  baseline: 8343ec8810 PO: fetch Catalan from FTP
  args: input/regression/mozart-hrn-3.ly
  memory: med diff -103296 (stddevs 73 189, n=3)
  memory: med diff -23.0 % (2ea63632de is leaner)
  time: med diff -0.14 (stddevs 0.00 0.01, n=3)
  time: med diff -4.1 % (2ea63632de is faster)

https://codereview.appspot.com/569740046


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Ticket 3778 discussion

2020-05-09 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **labels**:  --> Fixed_2_21_2
- **status**: Started --> Fixed
- **Patch**: push -->  
- **Comment**:

~~~
commit 4860434b122611df632dfd9aaa21c430e4b67819
Author: Han-Wen Nienhuys 
AuthorDate: Sat May 2 11:46:02 2020 +0200
Commit: Han-Wen Nienhuys 
CommitDate: Sat May 9 11:28:51 2020 +0200

Compute SVG skyline based on original data

Since stencil data is used as input to formatting decisions, this
will make SVG output more similar to PS/PDF output.
~~~



---

** [issues:#3778] SVG backend: Use bounding box as skylines for markup / 
Compute SVG skyline based on original data**

**Status:** Fixed
**Labels:** Fixed_2_21_2 
**Created:** Sun Jan 05, 2014 05:39 AM UTC by Anonymous
**Last Updated:** Sat May 09, 2020 08:49 AM UTC
**Owner:** Han-Wen Nienhuys
**Attachments:**

- 
[document.svg](https://sourceforge.net/p/testlilyissues/issues/3778/attachment/document.svg)
 (4.4 kB; image/svg+xml)


https://codereview.appspot.com/545970043

(needs https://codereview.appspot.com/555760043/)

Compute SVG skyline based on original data

Since stencil data is used as input to formatting decisions, this
will make SVG output more similar to PS/PDF output.

 

Use bounding box as skylines for markup in svg backend

As there is no routine for determining skylines for utf-8-string
stencils, they normally fall back to the grob's bounding box, which is
fine. However, when there is a mixture of utf-8-string and other types
of stencil (which have associated skyline functions) in a single grob,
the entire grob gets a skyline determined only from the non-utf-8-string
stencils. This sometimes causes the text portion of such mixed grobs
(e.g. metronome marks) to collide with other grobs.

While looping over the stencils, check for utf-8-string and if found,
clear the skylines and break out of the loop. Empty skylines forces a
fallback to the grob's bounding box, which restores the behaviour from
before the patch to improve skyline approximations (issue 2148). This
does not fix the issue that there is no routine for determining skylines
for utf-8-strings when the backend is svg, but it does at least remove
the collisions without changing the behaviour in non-broken situations.

Add a suitable (svg backend) regression test.



***

Originally reported 
[here.](http://lists.gnu.org/archive/html/lilypond-user/2014-01/msg00213.html)

the tempo marking in the SVG output is both lower, so that it collides with the 
stem of the A, and also has insufficient space between the equals sign and the 
preceding quarter note:


:::TeX
\version "2.18.0"

\relative c'' {
  \tempo 4=76
  a4
}



---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5961 Cosmetic fixes to accidental.cc

2020-05-09 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **labels**:  --> Fixed_2_21_2
- **status**: Started --> Fixed
- **Patch**: push -->  
- **Comment**:

~~~
commit 4088a7813706aafd48dd551aa19d019970088412
Author: Han-Wen Nienhuys 
AuthorDate: Sun May 3 20:55:05 2020 +0200
Commit: Han-Wen Nienhuys 
CommitDate: Sat May 9 11:28:51 2020 +0200

Cosmetic fixes to accidental.cc
~~~



---

** [issues:#5961] Cosmetic fixes to accidental.cc**

**Status:** Fixed
**Labels:** Fixed_2_21_2 
**Created:** Sun May 03, 2020 06:55 PM UTC by Han-Wen Nienhuys
**Last Updated:** Sat May 09, 2020 08:46 AM UTC
**Owner:** Han-Wen Nienhuys


https://codereview.appspot.com/559950046


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5969 Clean up and fix glyph contour generation nits.

2020-05-09 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
https://sourceforge.net/p/testlilyissues/issues/5940/ never was "push", it's 
currently in "review".


---

** [issues:#5969] Clean up and fix glyph contour generation nits.**

**Status:** Started
**Created:** Sat May 09, 2020 10:31 AM UTC by Han-Wen Nienhuys
**Last Updated:** Sat May 09, 2020 01:57 PM UTC
**Owner:** Han-Wen Nienhuys


There are two bugs:

* Glyphs with multiple contours (e.g. "O" or "i") should compute the
  contours separately

* Contours can wraparound to the start. This leads to OOB reads and/or
  incorrect outlines in other circumstances.

https://codereview.appspot.com/566080043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5972 Break substitution cleanup

2020-05-09 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
rebase?

https://codereview.appspot.com/572130043


---

** [issues:#5972] Break substitution cleanup**

**Status:** Started
**Created:** Sat May 09, 2020 05:01 PM UTC by Han-Wen Nienhuys
**Last Updated:** Sat May 09, 2020 05:30 PM UTC
**Owner:** Han-Wen Nienhuys


* Remove global var from break substitution

  This assumes that we don't need to be that conservative of stack
  space. This is reasonable because mutable properties and objects live
  in different alists these days, limiting the amount of recursion.

* Remove some conditional checks that have no coverage in the regtest.

* Always call do_break_processing(), moving the is_live check into spanner.cc

https://codereview.appspot.com/572130043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5973 Simplify and speed up break substitution

2020-05-09 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development



---

** [issues:#5973] Simplify and speed up break substitution**

**Status:** Started
**Created:** Sat May 09, 2020 05:30 PM UTC by Han-Wen Nienhuys
**Last Updated:** Sat May 09, 2020 05:30 PM UTC
**Owner:** nobody


When breaking a system into lines, the pointers between Grobs need to
be rearranged: for example, a single Slur grob that crosses a line break is
broken into two Slur grobs, and the first Slur will point to different
notes as the second slur.

This break substitution is centrally managed, and takes an appreciable
part of the runtime.

Before this change, complicated logic is executed during the break
substitution. For example, for an Item we would determine its System
by recursively following X-parent relationships. Since each item is a
pointed to from multiple other grobs, we have to repeat this expensive
step.

This change introduces a hash map in the root System grob, mapping
(original grob, system) => broken grob. This mapping is easily
populated before the substitution, and the break substitution itself
is reduced to hash lookups.

This yields a speedup of 3-4 %.

2ea63632de - drop islive conditional.
  baseline: 8343ec8810 PO: fetch Catalan from FTP
  args: -I carver/ MSDM
  memory: med diff 114296 (stddevs 257 240, n=3)
  memory: med diff 10.7 % (2ea63632de is fatter)
  time: med diff -1.39 (stddevs 0.06 0.10, n=3)
  time: med diff -2.9 % (2ea63632de is faster)

2ea63632de - drop islive conditional.
  baseline: 8343ec8810 PO: fetch Catalan from FTP
  args: input/regression/mozart-hrn-3.ly
  memory: med diff -103296 (stddevs 73 189, n=3)
  memory: med diff -23.0 % (2ea63632de is leaner)
  time: med diff -0.14 (stddevs 0.00 0.01, n=3)
  time: med diff -4.1 % (2ea63632de is faster)

https://codereview.appspot.com/569740046


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5972 Break substitution cleanup

2020-05-09 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development



---

** [issues:#5972] Break substitution cleanup**

**Status:** Started
**Created:** Sat May 09, 2020 05:01 PM UTC by Han-Wen Nienhuys
**Last Updated:** Sat May 09, 2020 05:01 PM UTC
**Owner:** nobody


* Remove global var from break substitution

  This assumes that we don't need to be that conservative of stack
  space. This is reasonable because mutable properties and objects live
  in different alists these days, limiting the amount of recursion.

* Remove some conditional checks that have no coverage in the regtest.

* Always call do_break_processing(), moving the is_live check into spanner.cc

https://codereview.appspot.com/572130043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5971 Remove deprecated context properties

2020-05-09 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development



---

** [issues:#5971] Remove deprecated context properties**

**Status:** Started
**Created:** Sat May 09, 2020 04:21 PM UTC by Valentin Villenave
**Last Updated:** Sat May 09, 2020 04:21 PM UTC
**Owner:** Valentin Villenave


Skimming through define-context-properties.scm, I noticed a few deprecated 
props:

- `bassFigureFormatFunction` was dropped in 2.7.18 in favor of 
`figuredBassFormatter`.

- `alignBassFigureAccidentals` was deprecated even earlier, in 2.7.13.

- `chordNameExceptionsFull` and `chordNameExceptionsPartial` have been 
deprecated at least since I rewrote the chord naming functions in 2.21.0; the 
only trace left is in the chord-names-alternative snippet.
  
Here’s a patch to address that:
https://codereview.appspot.com/560030044/


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5968 Prevent race condition in `-dfont-ps-resdir`

2020-05-09 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
Patch Set 2 : Improve messages
https://codereview.appspot.com/561810045/


---

** [issues:#5968] Prevent race condition in `-dfont-ps-resdir`**

**Status:** Started
**Created:** Sat May 09, 2020 10:26 AM UTC by Masamichi Hosoda
**Last Updated:** Sat May 09, 2020 02:17 PM UTC
**Owner:** Masamichi Hosoda


Prevent race condition in `-dfont-ps-resdir`

Issue 5968/4: Add Windows support for `-dfont-ps-resdir`

Windows environment could not use `-dfont-ps-resdir` option
because it used symlink.

This commit makes using file copying instead symlink when Windows.

Issue 5968/3: Prevent creating file race condition in `-dfont-ps-resdir`

For `-dfont-ps-resdir`,
we used creating file after checking the file existence.
However, when multiple lilypond processes were running,
as when using lilypond-book,
a race condition could cause creating file to fail.

This commit uses creating file method for `-dfont-export-dir`
that can prevent race condition.

Issue 5968/2: Prevent symlink race condition in `-dfont-ps-resdir`

For `-dfont-ps-resdir`,
we used symlink after checking the file existence.
However, when multiple lilypond processes were running,
as when using lilypond-book, a race condition could cause symlink to fail.

This commit makes preventing the race condition.

Issue 5968/1: Prevent mkdir race condition in `-dfont-ps-resdir`

For `-dfont-ps-resdir`,
we used mkdir after checking the directory existence.
However, when multiple lilypond processes were running,
as when using lilypond-book, a race condition could cause mkdir to fail.

This commit uses making directory method for `-dfont-export-dir`
that can prevent race condition.

http://codereview.appspot.com/561810045


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5968 Prevent race condition in `-dfont-ps-resdir`

2020-05-09 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- Description has changed:

Diff:







- **Needs**:  -->  
- **Patch**: new --> review
- **Comment**:

Passes make, make check and a full make doc.



---

** [issues:#5968] Prevent race condition in `-dfont-ps-resdir`**

**Status:** Started
**Created:** Sat May 09, 2020 10:26 AM UTC by Masamichi Hosoda
**Last Updated:** Sat May 09, 2020 10:26 AM UTC
**Owner:** Masamichi Hosoda


Prevent race condition in `-dfont-ps-resdir`

Issue 5968/4: Add Windows support for `-dfont-ps-resdir`

Windows environment could not use `-dfont-ps-resdir` option
because it used symlink.

This commit makes using file copying instead symlink when Windows.

Issue 5968/3: Prevent creating file race condition in `-dfont-ps-resdir`

For `-dfont-ps-resdir`,
we used creating file after checking the file existence.
However, when multiple lilypond processes were running,
as when using lilypond-book,
a race condition could cause creating file to fail.

This commit uses creating file method for `-dfont-export-dir`
that can prevent race condition.

Issue 5968/2: Prevent symlink race condition in `-dfont-ps-resdir`

For `-dfont-ps-resdir`,
we used symlink after checking the file existence.
However, when multiple lilypond processes were running,
as when using lilypond-book, a race condition could cause symlink to fail.

This commit makes preventing the race condition.

Issue 5968/1: Prevent mkdir race condition in `-dfont-ps-resdir`

For `-dfont-ps-resdir`,
we used mkdir after checking the directory existence.
However, when multiple lilypond processes were running,
as when using lilypond-book, a race condition could cause mkdir to fail.

This commit uses making directory method for `-dfont-export-dir`
that can prevent race condition.

http://codereview.appspot.com/561810045


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5969 Clean up and fix glyph contour generation nits.

2020-05-09 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
Looks like what Han-wen did was push that patch anyway.


---

** [issues:#5969] Clean up and fix glyph contour generation nits.**

**Status:** Started
**Created:** Sat May 09, 2020 10:31 AM UTC by Han-Wen Nienhuys
**Last Updated:** Sat May 09, 2020 01:56 PM UTC
**Owner:** Han-Wen Nienhuys


There are two bugs:

* Glyphs with multiple contours (e.g. "O" or "i") should compute the
  contours separately

* Contours can wraparound to the start. This leads to OOB reads and/or
  incorrect outlines in other circumstances.

https://codereview.appspot.com/566080043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5969 Clean up and fix glyph contour generation nits.

2020-05-09 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
Passes make, make check and a full make doc.

Patch set 1 diffs (~6mb)

https://cloud-u8zj2dc4b.yourownnet.eu/s/AkGBgPZEpb5nrLH


---

** [issues:#5969] Clean up and fix glyph contour generation nits.**

**Status:** Started
**Created:** Sat May 09, 2020 10:31 AM UTC by Han-Wen Nienhuys
**Last Updated:** Sat May 09, 2020 01:51 PM UTC
**Owner:** Han-Wen Nienhuys


There are two bugs:

* Glyphs with multiple contours (e.g. "O" or "i") should compute the
  contours separately

* Contours can wraparound to the start. This leads to OOB reads and/or
  incorrect outlines in other circumstances.

https://codereview.appspot.com/566080043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5969 Clean up and fix glyph contour generation nits.

2020-05-09 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
I'd have to agree, else it may seem we're backdooring the process.


---

** [issues:#5969] Clean up and fix glyph contour generation nits.**

**Status:** Started
**Created:** Sat May 09, 2020 10:31 AM UTC by Han-Wen Nienhuys
**Last Updated:** Sat May 09, 2020 11:06 AM UTC
**Owner:** Han-Wen Nienhuys


There are two bugs:

* Glyphs with multiple contours (e.g. "O" or "i") should compute the
  contours separately

* Contours can wraparound to the start. This leads to OOB reads and/or
  incorrect outlines in other circumstances.

https://codereview.appspot.com/566080043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5964 Multi_measure_rest_engraver segfaults when its context doesn’t include Staff_symbol_engraver.

2020-05-09 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **Needs**:  -->  
- **Patch**: new --> review
- **Type**:  -->  



---

** [issues:#5964] Multi_measure_rest_engraver segfaults when its context 
doesn’t include Staff_symbol_engraver.**

**Status:** Started
**Created:** Wed May 06, 2020 10:47 PM UTC by Valentin Villenave
**Last Updated:** Sat May 09, 2020 12:09 PM UTC
**Owner:** Valentin Villenave


https://codereview.appspot.com/576090043

This used to work as recently as 2.20.0, and it no longer does:

\version 2.21.1
\layout {
  \context {
\type Engraver_group
\name GlobalRests
%\consists Staff_symbol_engraver
%\omit StaffSymbol
\consists Multi_measure_rest_engraver
  }
  \context {
\Score
\accepts GlobalRests
  }
}
\score {
\new GlobalRests { R1 }
}

Uncommenting the Staff_symbol_engraver prevents the segfault from happening.
Here’s what gdb has to say:
~~~
Program received signal SIGSEGV, Segmentation fault.
Grob::internal_get_property (this=this@entry=0x0, sym=0x7fffe98e1ea0) at 
grob-property.cc:162
162   SCM val = get_property_data (this, sym);
~~~
Reported by Trevor B: 
https://lists.gnu.org/archive/html/lilypond-user/2020-05/msg00077.html


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5964 Multi_measure_rest_engraver segfaults when its context doesn’t include Staff_symbol_engraver.

2020-05-09 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
Passes make, make check and a full make doc.

Reg test diff attached




Attachments:

- [Screenshot from 2020-05-09 
13-09-03.png](https://sourceforge.net/p/testlilyissues/issues/_discuss/thread/7942734bea/61d9/attachment/Screenshot%20from%202020-05-09%2013-09-03.png)
 (59.0 kB; image/png)


---

** [issues:#5964] Multi_measure_rest_engraver segfaults when its context 
doesn’t include Staff_symbol_engraver.**

**Status:** Started
**Created:** Wed May 06, 2020 10:47 PM UTC by Valentin Villenave
**Last Updated:** Sat May 09, 2020 10:39 AM UTC
**Owner:** Valentin Villenave


https://codereview.appspot.com/576090043

This used to work as recently as 2.20.0, and it no longer does:

\version 2.21.1
\layout {
  \context {
\type Engraver_group
\name GlobalRests
%\consists Staff_symbol_engraver
%\omit StaffSymbol
\consists Multi_measure_rest_engraver
  }
  \context {
\Score
\accepts GlobalRests
  }
}
\score {
\new GlobalRests { R1 }
}

Uncommenting the Staff_symbol_engraver prevents the segfault from happening.
Here’s what gdb has to say:
~~~
Program received signal SIGSEGV, Segmentation fault.
Grob::internal_get_property (this=this@entry=0x0, sym=0x7fffe98e1ea0) at 
grob-property.cc:162
162   SCM val = get_property_data (this, sym);
~~~
Reported by Trevor B: 
https://lists.gnu.org/archive/html/lilypond-user/2020-05/msg00077.html


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5967 output-distance: set device properties in batch driver file

2020-05-09 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- Description has changed:

Diff:







- **Needs**:  -->  
- **Patch**: new --> review
- **Comment**:

Passes make, make check and a full make doc.



---

** [issues:#5967] output-distance: set device properties in batch driver file**

**Status:** Started
**Created:** Sat May 09, 2020 09:53 AM UTC by Han-Wen Nienhuys
**Last Updated:** Sat May 09, 2020 09:53 AM UTC
**Owner:** Han-Wen Nienhuys


This fixes the output quality of the regtest results.

Previously, the code sets a device by doing

 (png16m) finddevice

this put a default device on the stack, ignoring the command-line
arguments.  To fix this, specify these settings (HWResolution,
TextAlphaBits, GraphicsAlphaBits) as arguments to the putdeviceprops
call.

https://codereview.appspot.com/560020043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5970 Remove do_break_substitution_and_fixup_refpoints() from System API

2020-05-09 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development



---

** [issues:#5970] Remove do_break_substitution_and_fixup_refpoints() from 
System API**

**Status:** Started
**Created:** Sat May 09, 2020 11:27 AM UTC by Han-Wen Nienhuys
**Last Updated:** Sat May 09, 2020 11:27 AM UTC
**Owner:** nobody


It always happens after break_into_pieces(), so call it there.

https://codereview.appspot.com/576110043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5966 Stop smobifying Transform

2020-05-09 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **Needs**:  -->  
- **Patch**: new --> review
- **Comment**:

Passes make, make check and a full make doc.



---

** [issues:#5966] Stop smobifying Transform**

**Status:** Started
**Created:** Sat May 09, 2020 09:34 AM UTC by Han-Wen Nienhuys
**Last Updated:** Sat May 09, 2020 09:35 AM UTC
**Owner:** Han-Wen Nienhuys


https://codereview.appspot.com/567580043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5969 Clean up and fix glyph contour generation nits.

2020-05-09 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
That sounds like it would be more sensible to remove that issue from "push" 
until the consequences have been figured out rather than to fasttrack 
everything.


---

** [issues:#5969] Clean up and fix glyph contour generation nits.**

**Status:** Started
**Created:** Sat May 09, 2020 10:31 AM UTC by Han-Wen Nienhuys
**Last Updated:** Sat May 09, 2020 10:33 AM UTC
**Owner:** Han-Wen Nienhuys


There are two bugs:

* Glyphs with multiple contours (e.g. "O" or "i") should compute the
  contours separately

* Contours can wraparound to the start. This leads to OOB reads and/or
  incorrect outlines in other circumstances.

https://codereview.appspot.com/566080043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5965 Make Scheme_hash_table just use the native hash table type. This

2020-05-09 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- Description has changed:

Diff:







- **Needs**:  -->  
- **Patch**: new --> review
- **Comment**:

Passes make, make check and a full make doc.



---

** [issues:#5965] Make Scheme_hash_table just use the native hash table type.  
This**

**Status:** Started
**Created:** Sat May 09, 2020 12:18 AM UTC by David Kastrup
**Last Updated:** Sat May 09, 2020 12:18 AM UTC
**Owner:** David Kastrup


Make Scheme_hash_table just use the native hash table type.  This
consists of two commits:



Implement Scheme_hash_table in terms of Smob0


Introduce Smob0 class without external storage



The Smob0 class is actually even more of a joke than the Smob1 class
already and makes do without introducing an actual Smob or its own
type.  It just allows a syntactic class wrapper around an actual
Scheme data structure to provide the normal Smob C++ programming
interface.  There might be a point in trying to make for a way of
working with Scheme traits that does not go through class pointers as
a prescribed interface in the first place.  In the current framework,
this may be the cheapest way to get rid of an additional class
indirection without losing the convenience of working with a fixed C++
type and associated member functions.

http://codereview.appspot.com/561810043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5964 Multi_measure_rest_engraver segfaults when its context doesn’t include Staff_symbol_engraver.

2020-05-09 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
[proposal] Make Staff_symbol::line_count public and use it when 
’s not needed

https://codereview.appspot.com/576090043


---

** [issues:#5964] Multi_measure_rest_engraver segfaults when its context 
doesn’t include Staff_symbol_engraver.**

**Status:** Started
**Created:** Wed May 06, 2020 10:47 PM UTC by Valentin Villenave
**Last Updated:** Sat May 09, 2020 10:39 AM UTC
**Owner:** Valentin Villenave


https://codereview.appspot.com/576090043

This used to work as recently as 2.20.0, and it no longer does:

\version 2.21.1
\layout {
  \context {
\type Engraver_group
\name GlobalRests
%\consists Staff_symbol_engraver
%\omit StaffSymbol
\consists Multi_measure_rest_engraver
  }
  \context {
\Score
\accepts GlobalRests
  }
}
\score {
\new GlobalRests { R1 }
}

Uncommenting the Staff_symbol_engraver prevents the segfault from happening.
Here’s what gdb has to say:
~~~
Program received signal SIGSEGV, Segmentation fault.
Grob::internal_get_property (this=this@entry=0x0, sym=0x7fffe98e1ea0) at 
grob-property.cc:162
162   SCM val = get_property_data (this, sym);
~~~
Reported by Trevor B: 
https://lists.gnu.org/archive/html/lilypond-user/2020-05/msg00077.html


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5969 Clean up and fix glyph contour generation nits.

2020-05-09 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
this is split off from  https://codereview.appspot.com/569700043/ . 

Since that one is in "push" status already, I suggest to fasttrack this, if 
Werner is agrees with this change.


---

** [issues:#5969] Clean up and fix glyph contour generation nits.**

**Status:** Started
**Created:** Sat May 09, 2020 10:31 AM UTC by Han-Wen Nienhuys
**Last Updated:** Sat May 09, 2020 10:31 AM UTC
**Owner:** Han-Wen Nienhuys


There are two bugs:

* Glyphs with multiple contours (e.g. "O" or "i") should compute the
  contours separately

* Contours can wraparound to the start. This leads to OOB reads and/or
  incorrect outlines in other circumstances.

https://codereview.appspot.com/566080043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5969 Clean up and fix glyph contour generation nits.

2020-05-09 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development



---

** [issues:#5969] Clean up and fix glyph contour generation nits.**

**Status:** Started
**Created:** Sat May 09, 2020 10:31 AM UTC by Han-Wen Nienhuys
**Last Updated:** Sat May 09, 2020 10:31 AM UTC
**Owner:** nobody


There are two bugs:

* Glyphs with multiple contours (e.g. "O" or "i") should compute the
  contours separately

* Contours can wraparound to the start. This leads to OOB reads and/or
  incorrect outlines in other circumstances.

https://codereview.appspot.com/566080043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5968 Prevent race condition in `-dfont-ps-resdir`

2020-05-09 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development



---

** [issues:#5968] Prevent race condition in `-dfont-ps-resdir`**

**Status:** Started
**Created:** Sat May 09, 2020 10:26 AM UTC by Masamichi Hosoda
**Last Updated:** Sat May 09, 2020 10:26 AM UTC
**Owner:** nobody


Prevent race condition in `-dfont-ps-resdir`

Issue 5968/4: Add Windows support for `-dfont-ps-resdir`

Windows environment could not use `-dfont-ps-resdir` option
because it used symlink.

This commit makes using file copying instead symlink when Windows.

Issue 5968/3: Prevent creating file race condition in `-dfont-ps-resdir`

For `-dfont-ps-resdir`,
we used creating file after checking the file existence.
However, when multiple lilypond processes were running,
as when using lilypond-book,
a race condition could cause creating file to fail.

This commit uses creating file method for `-dfont-export-dir`
that can prevent race condition.

Issue 5968/2: Prevent symlink race condition in `-dfont-ps-resdir`

For `-dfont-ps-resdir`,
we used symlink after checking the file existence.
However, when multiple lilypond processes were running,
as when using lilypond-book, a race condition could cause symlink to fail.

This commit makes preventing the race condition.

Issue 5968/1: Prevent mkdir race condition in `-dfont-ps-resdir`

For `-dfont-ps-resdir`,
we used mkdir after checking the directory existence.
However, when multiple lilypond processes were running,
as when using lilypond-book, a race condition could cause mkdir to fail.

This commit uses making directory method for `-dfont-export-dir`
that can prevent race condition.

http://codereview.appspot.com/561810045


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5967 output-distance: set device properties in batch driver file

2020-05-09 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development



---

** [issues:#5967] output-distance: set device properties in batch driver file**

**Status:** Started
**Created:** Sat May 09, 2020 09:53 AM UTC by Han-Wen Nienhuys
**Last Updated:** Sat May 09, 2020 09:53 AM UTC
**Owner:** nobody


This fixes the output quality of the regtest results.

Previously, the code sets a device by doing

 (png16m) finddevice

this put a default device on the stack, ignoring the command-line
arguments.  To fix this, specify these settings (HWResolution,
TextAlphaBits, GraphicsAlphaBits) as arguments to the putdeviceprops
call.

https://codereview.appspot.com/560020043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5966 Stop smobifying Transform

2020-05-09 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development



---

** [issues:#5966] Stop smobifying Transform**

**Status:** Started
**Created:** Sat May 09, 2020 09:34 AM UTC by Han-Wen Nienhuys
**Last Updated:** Sat May 09, 2020 09:34 AM UTC
**Owner:** nobody


https://codereview.appspot.com/567580043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5960 Add OTC font support for `-dfont-ps-resdir`

2020-05-09 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **labels**:  --> Fixed_2_21_2
- **status**: Started --> Fixed
- **Patch**: push -->  
- **Comment**:

I've pushed to staging.

commit 116b2765ea458daa4ab32a7ecaff79eb0ab5306f
Issue 5960/3: Doc: Remove unnecessary description about `-dfont-ps-resdir`

commit a2ff250f1fb4adb23c82000affe475ef34820cc6
Issue 5960/2: Add OTC font support for `-dfont-ps-resdir`

commit 92db18d3141484d3c46722f6ed911c253e06d0f4
Issue 5960/1: Add `ly:extract-subfont-from-collection`



---

** [issues:#5960] Add OTC font support for `-dfont-ps-resdir`**

**Status:** Fixed
**Labels:** Fixed_2_21_2 
**Created:** Sun May 03, 2020 02:17 PM UTC by Masamichi Hosoda
**Last Updated:** Sat May 09, 2020 08:46 AM UTC
**Owner:** Masamichi Hosoda


Add OTC font support for `-dfont-ps-resdir`

This commit adds support for OpenType/CFF collection (OTC) fonts
to the `-dfont-ps-resdir` option.

Add `ly:extract-subfont-from-collection`

Extract the subfont in TrueType collection (TTC)
or OpenType/CFF collection (OTC) file and write it to file.

http://codereview.appspot.com/548080043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5940 Split glyph contours in up/down segments for skylines

2020-05-09 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
looks like the bugfixes caused minor formatting diffs. I'll separate out the 
bugfixes so we can be sure.


---

** [issues:#5940] Split glyph contours in up/down segments for skylines**

**Status:** Started
**Created:** Sun Apr 26, 2020 07:43 AM UTC by Han-Wen Nienhuys
**Last Updated:** Fri May 08, 2020 06:32 PM UTC
**Owner:** Han-Wen Nienhuys


This reduces the amount of skyline input coming from glyph outlines by
2x.

benchmark for arguments: input/regression/mozart-hrn-3
raw data: {'ff2061b518': [2.72, 2.69, 2.71], 'e8212e15e2': [2.7, 2.68, 2.69]}

Version ff2061b518: Create skylines directly from glyph outlines.
e8212e15e2 - Split glyph contours in up/down segments for skylines
  med diff -0.02
  med diff -0.738007 % (e8212e15e2 is faster)


benchmark for arguments: -I carver MSDM
raw data: {'ff2061b518': [51.83, 51.99, 52.05], 'e8212e15e2': [51.27, 51.2, 
51.48]}

ff2061b518: Create skylines directly from glyph outlines.
e8212e15e2 - Split glyph contours in up/down segments for skylines
  med diff -0.72
  med diff -1.384882 % (e8212e15e2 is faster)

https://codereview.appspot.com/569700043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5476 programming error/segfault while omitting Fingering.stencil with fingeringOrientations set 'left

2020-05-09 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **Patch**: review --> countdown
- **Comment**:

Patch on countdown for May 11th



---

** [issues:#5476] programming error/segfault while omitting Fingering.stencil 
with fingeringOrientations set 'left**

**Status:** Started
**Created:** Fri Feb 08, 2019 12:30 PM UTC by Palmer Ralph
**Last Updated:** Fri May 08, 2020 10:47 AM UTC
**Owner:** Valentin Villenave


https://codereview.appspot.com/567560043

Thomas Morley wrote :

the following code is problematic


{
  \set fingeringOrientations = #'(left)
  \override Fingering #'stencil = ##f
%% chord needs two elements to trigger the bug
}


Versions 2.12.3 up to 2.16.2 print correctly, without error

Versions 2.18.2 up to 2.19.82 print correctly, but return:
programming error: Infinity or NaN encountered

Current master does:
Segmentation fault (core dumped)


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4182 dynamics on skips confuse cross-staff stems

2020-05-09 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **Patch**: review --> countdown
- **Comment**:

Patch on countdown for May 11th



---

** [issues:#4182] dynamics on skips confuse cross-staff stems**

**Status:** Started
**Created:** Fri Oct 31, 2014 09:21 PM UTC by Anonymous
**Last Updated:** Fri May 08, 2020 11:07 AM UTC
**Owner:** Kevin Barry
**Attachments:**

- 
[stem.png](https://sourceforge.net/p/testlilyissues/issues/4182/attachment/stem.png)
 (6.0 kB; image/png)


https://codereview.appspot.com/554030043

*Originally created by:* *anonymous

*Originally created by:* 
[k-ohara5...@oco.net](http://code.google.com/u/110197288862747384800/)

Sometime since ver 2.18, dynamics on skips began to make cross-staff stems 
point the wrong way.   The ledger line seems to be necessary for the bug.

up = \change Staff = "up"
dn = \change Staff = "down"
\new PianoStaff \transpose c c' << \time 2/4
  \new Staff = "up"  
    s2
  \new Staff = "down" <<  
    \{s8\*3 s8\p  \} 
    \{ g8\[ \up e \dn g \up c\] \} >> >


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5964 Multi_measure_rest_engraver segfaults when its context doesn’t include Staff_symbol_engraver.

2020-05-09 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **Patch**: review --> countdown
- **Comment**:

Patch on countdown for May 11th - although there are what look like relatively 
simple comments on Rietveld that need addressing



---

** [issues:#5964] Multi_measure_rest_engraver segfaults when its context 
doesn’t include Staff_symbol_engraver.**

**Status:** Started
**Created:** Wed May 06, 2020 10:47 PM UTC by Valentin Villenave
**Last Updated:** Thu May 07, 2020 10:06 AM UTC
**Owner:** Valentin Villenave


https://codereview.appspot.com/576090043

This used to work as recently as 2.20.0, and it no longer does:

\version 2.21.1
\layout {
  \context {
\type Engraver_group
\name GlobalRests
%\consists Staff_symbol_engraver
%\omit StaffSymbol
\consists Multi_measure_rest_engraver
  }
  \context {
\Score
\accepts GlobalRests
  }
}
\score {
\new GlobalRests { R1 }
}

Uncommenting the Staff_symbol_engraver prevents the segfault from happening.
Here’s what gdb has to say:
~~~
Program received signal SIGSEGV, Segmentation fault.
Grob::internal_get_property (this=this@entry=0x0, sym=0x7fffe98e1ea0) at 
grob-property.cc:162
162   SCM val = get_property_data (this, sym);
~~~
Reported by Trevor B: 
https://lists.gnu.org/archive/html/lilypond-user/2020-05/msg00077.html


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Ticket 3778 discussion

2020-05-09 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **Patch**: countdown --> push
- **Comment**:

Patch counted down please push - don't forget this goes on top of another patch.

(needs https://codereview.appspot.com/555760043/)



---

** [issues:#3778] SVG backend: Use bounding box as skylines for markup / 
Compute SVG skyline based on original data**

**Status:** Started
**Created:** Sun Jan 05, 2014 05:39 AM UTC by Anonymous
**Last Updated:** Thu May 07, 2020 08:54 AM UTC
**Owner:** Han-Wen Nienhuys
**Attachments:**

- 
[document.svg](https://sourceforge.net/p/testlilyissues/issues/3778/attachment/document.svg)
 (4.4 kB; image/svg+xml)


https://codereview.appspot.com/545970043

(needs https://codereview.appspot.com/555760043/)

Compute SVG skyline based on original data

Since stencil data is used as input to formatting decisions, this
will make SVG output more similar to PS/PDF output.

 

Use bounding box as skylines for markup in svg backend

As there is no routine for determining skylines for utf-8-string
stencils, they normally fall back to the grob's bounding box, which is
fine. However, when there is a mixture of utf-8-string and other types
of stencil (which have associated skyline functions) in a single grob,
the entire grob gets a skyline determined only from the non-utf-8-string
stencils. This sometimes causes the text portion of such mixed grobs
(e.g. metronome marks) to collide with other grobs.

While looping over the stencils, check for utf-8-string and if found,
clear the skylines and break out of the loop. Empty skylines forces a
fallback to the grob's bounding box, which restores the behaviour from
before the patch to improve skyline approximations (issue 2148). This
does not fix the issue that there is no routine for determining skylines
for utf-8-strings when the backend is svg, but it does at least remove
the collisions without changing the behaviour in non-broken situations.

Add a suitable (svg backend) regression test.



***

Originally reported 
[here.](http://lists.gnu.org/archive/html/lilypond-user/2014-01/msg00213.html)

the tempo marking in the SVG output is both lower, so that it collides with the 
stem of the A, and also has insufficient space between the equals sign and the 
preceding quarter note:


:::TeX
\version "2.18.0"

\relative c'' {
  \tempo 4=76
  a4
}



---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5949 Add option to use Ghostscript API instead of forking

2020-05-09 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **Patch**: countdown --> push
- **Comment**:

Patch counted down - please push



---

** [issues:#5949] Add option to use Ghostscript API instead of forking**

**Status:** Started
**Created:** Thu Apr 30, 2020 07:12 PM UTC by Jonas Hahnfeld
**Last Updated:** Thu May 07, 2020 08:54 AM UTC
**Owner:** Jonas Hahnfeld


Add option to use Ghostscript API instead of forking

This is much more efficient than the current scheme when converting
many PostScript files, for example when building the documentation.
For the Notation Reference, lilypond-book now takes ~2m30s instead
of 5m to compile all snippets from the notation.tely file. Other
manuals benefit less, but still the time for 'make doc' on my system
improves by one third from around 33m to 22m.

An alternative would have been to always call gsapi_init_with_args
with the same arguments used until now. This indeed works and avoids
the overhead of forking, but the instance cannot be reused. Calling
gsapi_new_instance -> gsapi_init_with_args -> gsapi_delete_instance
for every conversion still means a lot of overhead and a prototype
suggested only a small gain compared to the previous solution.

This is not the default because recent versions of Ghostscript are
distributed under the AGPL and it's unclear what the implications of
linking to the library is. If built with support for the API, use
-dgs-api=#f to still fork the gs command.

http://codereview.appspot.com/548030043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5961 Cosmetic fixes to accidental.cc

2020-05-09 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **Patch**: countdown --> push
- **Comment**:

Patch counted down - please push



---

** [issues:#5961] Cosmetic fixes to accidental.cc**

**Status:** Started
**Created:** Sun May 03, 2020 06:55 PM UTC by Han-Wen Nienhuys
**Last Updated:** Thu May 07, 2020 08:54 AM UTC
**Owner:** Han-Wen Nienhuys


https://codereview.appspot.com/559950046


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5963 Remove define causing a warning

2020-05-09 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **Patch**: countdown --> push
- **Comment**:

Patch counted down - please push



---

** [issues:#5963] Remove define causing a warning**

**Status:** Started
**Created:** Mon May 04, 2020 04:04 PM UTC by Jonas Hahnfeld
**Last Updated:** Thu May 07, 2020 08:54 AM UTC
**Owner:** Jonas Hahnfeld


Remove define causing a warning

These lines were added in commit 25beb8d01b in 2008 to provide
compatibility with GCC 3.4 which clearly does not support C++11.
(The warning is visible since commit b96b6334c0 which put system
headers last, so that the define is already provided transitvely.)

http://codereview.appspot.com/561790043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5960 Add OTC font support for `-dfont-ps-resdir`

2020-05-09 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **Patch**: countdown --> push
- **Comment**:

Patch counted down - please push



---

** [issues:#5960] Add OTC font support for `-dfont-ps-resdir`**

**Status:** Started
**Created:** Sun May 03, 2020 02:17 PM UTC by Masamichi Hosoda
**Last Updated:** Thu May 07, 2020 08:54 AM UTC
**Owner:** Masamichi Hosoda


Add OTC font support for `-dfont-ps-resdir`

This commit adds support for OpenType/CFF collection (OTC) fonts
to the `-dfont-ps-resdir` option.

Add `ly:extract-subfont-from-collection`

Extract the subfont in TrueType collection (TTC)
or OpenType/CFF collection (OTC) file and write it to file.

http://codereview.appspot.com/548080043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5965 Make Scheme_hash_table just use the native hash table type. This

2020-05-08 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development



---

** [issues:#5965] Make Scheme_hash_table just use the native hash table type.  
This**

**Status:** Started
**Created:** Sat May 09, 2020 12:18 AM UTC by David Kastrup
**Last Updated:** Sat May 09, 2020 12:18 AM UTC
**Owner:** nobody


Make Scheme_hash_table just use the native hash table type.  This
consists of two commits:



Implement Scheme_hash_table in terms of Smob0


Introduce Smob0 class without external storage



The Smob0 class is actually even more of a joke than the Smob1 class
already and makes do without introducing an actual Smob or its own
type.  It just allows a syntactic class wrapper around an actual
Scheme data structure to provide the normal Smob C++ programming
interface.  There might be a point in trying to make for a way of
working with Scheme traits that does not go through class pointers as
a prescribed interface in the first place.  In the current framework,
this may be the cheapest way to get rid of an additional class
indirection without losing the convenience of working with a fixed C++
type and associated member functions.

http://codereview.appspot.com/561810043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5940 Split glyph contours in up/down segments for skylines

2020-05-08 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **Needs**:  -->  
- **Patch**: new --> review
- **Type**:  -->  
- **Comment**:

Passes make, make check and a full make doc.

Reg test diffs here (patch 7) ~ 6MB!

https://cloud-u8zj2dc4b.yourownnet.eu/s/qJNCHJzFsmrRM3R



---

** [issues:#5940] Split glyph contours in up/down segments for skylines**

**Status:** Started
**Created:** Sun Apr 26, 2020 07:43 AM UTC by Han-Wen Nienhuys
**Last Updated:** Fri May 08, 2020 02:03 PM UTC
**Owner:** Han-Wen Nienhuys


This reduces the amount of skyline input coming from glyph outlines by
2x.

benchmark for arguments: input/regression/mozart-hrn-3
raw data: {'ff2061b518': [2.72, 2.69, 2.71], 'e8212e15e2': [2.7, 2.68, 2.69]}

Version ff2061b518: Create skylines directly from glyph outlines.
e8212e15e2 - Split glyph contours in up/down segments for skylines
  med diff -0.02
  med diff -0.738007 % (e8212e15e2 is faster)


benchmark for arguments: -I carver MSDM
raw data: {'ff2061b518': [51.83, 51.99, 52.05], 'e8212e15e2': [51.27, 51.2, 
51.48]}

ff2061b518: Create skylines directly from glyph outlines.
e8212e15e2 - Split glyph contours in up/down segments for skylines
  med diff -0.72
  med diff -1.384882 % (e8212e15e2 is faster)

https://codereview.appspot.com/569700043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5940 Split glyph contours in up/down segments for skylines

2020-05-08 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
jonas.

https://codereview.appspot.com/569700043


---

** [issues:#5940] Split glyph contours in up/down segments for skylines**

**Status:** Started
**Created:** Sun Apr 26, 2020 07:43 AM UTC by Han-Wen Nienhuys
**Last Updated:** Fri May 08, 2020 02:03 PM UTC
**Owner:** Han-Wen Nienhuys


This reduces the amount of skyline input coming from glyph outlines by
2x.

benchmark for arguments: input/regression/mozart-hrn-3
raw data: {'ff2061b518': [2.72, 2.69, 2.71], 'e8212e15e2': [2.7, 2.68, 2.69]}

Version ff2061b518: Create skylines directly from glyph outlines.
e8212e15e2 - Split glyph contours in up/down segments for skylines
  med diff -0.02
  med diff -0.738007 % (e8212e15e2 is faster)


benchmark for arguments: -I carver MSDM
raw data: {'ff2061b518': [51.83, 51.99, 52.05], 'e8212e15e2': [51.27, 51.2, 
51.48]}

ff2061b518: Create skylines directly from glyph outlines.
e8212e15e2 - Split glyph contours in up/down segments for skylines
  med diff -0.72
  med diff -1.384882 % (e8212e15e2 is faster)

https://codereview.appspot.com/569700043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5962 Avoid using Skyline_pair::insert.

2020-05-08 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **labels**:  --> Fixed_2_21_2
- **status**: Started --> Fixed
- **Patch**: push -->  
- **Comment**:

~~~
commit b872b327c471a9538d93fba21ff0385709aae2c2
Author: Han-Wen Nienhuys 
AuthorDate: Sun May 3 20:31:10 2020 +0200
Commit: Han-Wen Nienhuys 
CommitDate: Fri May 8 09:14:55 2020 +0200

Avoid using Skyline_pair::insert.

Skyline::insert(Box) creates a skyline and merges it. In this case,
the boxes are non-overlapping, so it is trivial to create a skyline
out of them.

Remove Skyline::insert(). Using it repeatedly leads to a quadratic
complexity, so it's best avoided.

Timing benchmarks are neutral
~~~



---

** [issues:#5962] Avoid using Skyline_pair::insert.**

**Status:** Fixed
**Labels:** Fixed_2_21_2 
**Created:** Sun May 03, 2020 06:55 PM UTC by Han-Wen Nienhuys
**Last Updated:** Thu May 07, 2020 08:49 AM UTC
**Owner:** Han-Wen Nienhuys


Skyline::insert(Box) creates a skyline and merges it. In this case,
the boxes are non-overlapping, so it is trivial to create a skyline
out of them.

Remove Skyline::insert(). Using it repeatedly leads to a quadratic
complexity, so it's best avoided.

Timing benchmarks are neutral

https://codereview.appspot.com/55443


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5958 output-distance: create PNG files in batch

2020-05-08 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **labels**:  --> Fixed_2_21_2
- **status**: Started --> Fixed
- **Patch**: push -->  
- **Comment**:

~~~
commit 1c1d51861861e11f7f6ffe664fb471bececc7baf
Author: Han-Wen Nienhuys 
AuthorDate: Sat May 2 14:25:13 2020 +0200
Commit: Han-Wen Nienhuys 
CommitDate: Fri May 8 09:13:27 2020 +0200

output-distance: create PNG files in batch
~~~



---

** [issues:#5958] output-distance: create PNG files in batch**

**Status:** Fixed
**Labels:** Fixed_2_21_2 
**Created:** Sat May 02, 2020 12:34 PM UTC by Han-Wen Nienhuys
**Last Updated:** Thu May 07, 2020 08:52 AM UTC
**Owner:** Han-Wen Nienhuys


https://codereview.appspot.com/567530052


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5952 Use axis indexing to clarify different behaviors for X/Y skylines

2020-05-08 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **status**: Started --> Fixed
- **Patch**: push -->  
- **Comment**:

~~~
commit 766070bdbcc1da6ac123f7003db5bf3ba073defd
Author: Han-Wen Nienhuys 
AuthorDate: Fri May 1 19:59:30 2020 +0200
Commit: Han-Wen Nienhuys 
CommitDate: Fri May 8 09:14:04 2020 +0200

Use axis indexing to clarify different behaviors for X/Y skylines
~~~



---

** [issues:#5952]  Use axis indexing to clarify different behaviors for X/Y 
skylines **

**Status:** Fixed
**Created:** Fri May 01, 2020 08:17 PM UTC by Han-Wen Nienhuys
**Last Updated:** Thu May 07, 2020 08:51 AM UTC
**Owner:** Han-Wen Nienhuys


Use axis indexing to clarify different behaviors for X/Y skylines

https://codereview.appspot.com/573770043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5943 Convert stencil to skyline directly

2020-05-08 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **labels**:  --> Fixed_2_21_2
- **status**: Started --> Fixed
- **Patch**: push -->  
- **Comment**:

~~~
commit 96b0e346adebe12ac742044c02cc8c2152e89977
Author: Han-Wen Nienhuys 
AuthorDate: Sat May 2 09:31:13 2020 +0200
Commit: Han-Wen Nienhuys 
CommitDate: Fri May 8 09:13:08 2020 +0200

Convert stencil to skyline directly

Gets rid of more intermediate storage.

eb3e0449f4 - Convert stencil to skyline directly
  baseline: 78d4ae8627 Thread skyline construction through stencil 
interpretation
  args: -I carver MSDM
  memory: med diff -1464 (stddevs 202 98, n=3)
  memory: med diff -0.1 % (eb3e0449f4 is leaner)
  time: med diff 0.10 (stddevs 0.09 0.06, n=3)
  time: med diff 0.2 % (eb3e0449f4 is neutral)
~~~

and

~~~
commit 9e69d5c5e19458bde7a413d7c3e4d3e0ec3060d4
Author: Han-Wen Nienhuys 
AuthorDate: Fri May 8 09:12:55 2020 +0200
Commit: Han-Wen Nienhuys 
CommitDate: Fri May 8 09:15:14 2020 +0200

Convert stencil to skyline directly

Gets rid of more intermediate storage.

f7d164b888 - Convert stencil to skyline directly
  baseline: 267e894e79 Thread skyline construction through stencil 
interpretation
  args: -I carver MSDM
  memory: med diff -1068 (stddevs 84 90, n=5)
  memory: med diff -0.1 % (f7d164b888 is leaner)
  time: med diff -0.18 (stddevs 0.15 0.05, n=5)
  time: med diff -0.4 % (f7d164b888 is neutral)
~~~
(the latter applying the changes I requested during review)



---

** [issues:#5943] Convert stencil to skyline directly**

**Status:** Fixed
**Labels:** Fixed_2_21_2 
**Created:** Sun Apr 26, 2020 12:13 PM UTC by Han-Wen Nienhuys
**Last Updated:** Thu May 07, 2020 08:50 AM UTC
**Owner:** Han-Wen Nienhuys


Gets rid of more intermediate storage.

Benchmarks show that this is performance neutral.

https://codereview.appspot.com/555760043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5952 Use axis indexing to clarify different behaviors for X/Y skylines

2020-05-08 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **labels**:  --> Fixed_2_21_2



---

** [issues:#5952]  Use axis indexing to clarify different behaviors for X/Y 
skylines **

**Status:** Fixed
**Labels:** Fixed_2_21_2 
**Created:** Fri May 01, 2020 08:17 PM UTC by Han-Wen Nienhuys
**Last Updated:** Fri May 08, 2020 01:07 PM UTC
**Owner:** Han-Wen Nienhuys


Use axis indexing to clarify different behaviors for X/Y skylines

https://codereview.appspot.com/573770043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5951 Calculate skylines only once.

2020-05-08 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **labels**:  --> Fixed_2_21_2
- **status**: Started --> Fixed
- **Patch**: push -->  
- **Comment**:

~~~
commit 750d6a547567409b6aa2d49bcb34912774aae4bc
Author: Han-Wen Nienhuys 
AuthorDate: Sun Apr 26 15:39:01 2020 +0200
Commit: Han-Wen Nienhuys 
CommitDate: Fri May 8 09:14:16 2020 +0200

Calculate skylines only once.

Before, Axis_group_interface::skyline_spacing() would call the
function add_interior_skylines(), which recursed into
VerticalAxisGroups.  This caused staff-skylines to be computed twice:
once as part of the Staff's VerticalAxisGroup, and once to compute
the skyline for System.

Instead, in Axis_group_interface::skyline_spacing(), compute the
vertical-skylines for all constituent elements.  Since the property is
subject to caching, the Staff skyline is only computed once.

To make this work

* Add flags to the NoteColumn using Axis_group_interface::add_element

* add vertical-skylines callbacks for NoteColumn and
  NoteCollision, which are also X,Y Axis groups.

* declare add-stem-support for bass figures (or the digits are meshed
  in with stems that stick out of the staff.)

* calculate a skyline for BassFigureAlignment, otherwise, the skyline
  is computed from the extent of the alignment, which is inaccurate if
  some bass figures have accidentals.

Formatting impact:

* ottava-edge.ly - the ottava bracket meshes better with the stem,
  leading to tighter spacing.

Timing impact

ac49229cdf - Calculate skylines only once.
  baseline: eaf40071f5 Use vectors rather than lists for skylines.
  args: -I carver MSDM
  memory: med diff 1916 (stddevs 103 135, n=5)
  memory: med diff 0.2 % (ac49229cdf is fatter)
  time: med diff -0.37 (stddevs 0.08 0.14, n=5)
  time: med diff -0.8 % (ac49229cdf is faster)
~~~



---

** [issues:#5951] Calculate skylines only once.**

**Status:** Fixed
**Labels:** Fixed_2_21_2 
**Created:** Fri May 01, 2020 05:52 PM UTC by Han-Wen Nienhuys
**Last Updated:** Thu May 07, 2020 08:51 AM UTC
**Owner:** Han-Wen Nienhuys


Before, Axis_group_interface::skyline_spacing() would call the
function add_interior_skylines(), which recursed into
VerticalAxisGroups.  This caused staff-skylines to be computed twice:
once as part of the Staff's VerticalAxisGroup, and once to compute
the skyline for System.

Instead, in Axis_group_interface::skyline_spacing(), compute the
vertical-skylines for all constituent elements.  Since the property is
subject to caching, the Staff skyline is only computed once.

To make this work

* Add flags to the NoteColumn using Axis_group_interface::add_element

* add vertical-skylines callbacks for NoteColumn and
  NoteCollision, which are also X,Y Axis groups.

* declare add-stem-support for bass figures (or the digits are meshed
  in with stems that stick out of the staff.)

* calculate a skyline for BassFigureAlignment, otherwise, the skyline
  is computed from the extent of the alignment, which is inaccurate if
  some bass figures have accidentals.

Formatting impact:

* ottava-edge.ly - the ottava bracket meshes better with the stem,
  leading to tighter spacing.

Timing impact

ac49229cdf - Calculate skylines only once.
  baseline: eaf40071f5 Use vectors rather than lists for skylines.
  args: -I carver MSDM
  memory: med diff 1916 (stddevs 103 135, n=5)
  memory: med diff 0.2 % (ac49229cdf is fatter)
  time: med diff -0.37 (stddevs 0.08 0.14, n=5)
  time: med diff -0.8 % (ac49229cdf is faster)

https://codereview.appspot.com/553980043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5941 Create skylines directly from glyph outlines.

2020-05-08 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **labels**:  --> Fixed_2_21_2
- **status**: Started --> Fixed
- **Patch**: push -->  
- **Comment**:

~~~
commit 79ec62e686a95bbb8bb8b61a3dcbd702de0abb91
Author: Han-Wen Nienhuys 
AuthorDate: Sat May 2 09:33:36 2020 +0200
Commit: Han-Wen Nienhuys 
CommitDate: Fri May 8 09:14:30 2020 +0200

Create skylines directly from glyph outlines.

This avoids creating garbage for the intermediate Scheme data to
transport the glyph outlines.

a20f8b786e - Create skylines directly from glyph outlines.
  baseline: 267e894e79 Thread skyline construction through stencil 
interpretation
  args: input/regression/mozart-hrn-3
  memory: med diff 76 (stddevs 77 85, n=3)
  memory: med diff 0.0 % (a20f8b786e is neutral)
  time: med diff 0.02 (stddevs 0.02 0.02, n=3)
  time: med diff 0.6 % (a20f8b786e is neutral)

a20f8b786e - Create skylines directly from glyph outlines.
  baseline: 267e894e79 Thread skyline construction through stencil 
interpretation
  args: -I carver MSDM
  memory: med diff -19408 (stddevs 134 228, n=5)
  memory: med diff -1.8 % (a20f8b786e is leaner)
  time: med diff -1.14 (stddevs 0.10 0.14, n=5)
  time: med diff -2.3 % (a20f8b786e is faster)
~~~



---

** [issues:#5941] Create skylines directly from glyph outlines.**

**Status:** Fixed
**Labels:** Fixed_2_21_2 
**Created:** Sun Apr 26, 2020 07:44 AM UTC by Han-Wen Nienhuys
**Last Updated:** Thu May 07, 2020 08:50 AM UTC
**Owner:** Han-Wen Nienhuys


This avoids creating garbage for the intermediate Scheme data to
transport the glyph outlines.

Benchmark:

benchmark for arguments: input/regression/mozart-hrn-3.ly
raw data: {'ac8eaa37ee': [2.73, 2.7, 2.73], '893552a691': [2.7, 2.71, 2.71]}
  med diff -0.732601 % (893552a691 is faster)

benchmark for arguments: -I carver MSDM
raw data: {'ac8eaa37ee': [52.43, 52.41, 52.17], '893552a691': [52.47, 52.33, 
52.18]}
893552a691 - Create skylines directly from glyph outlines.
  med diff -0.152643 % (893552a691 is faster)

(for Carver score, the difference is at noise)

https://codereview.appspot.com/561730043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5940 Split glyph contours in up/down segments for skylines

2020-05-08 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **Needs**:  -->  
- **Patch**: new --> needs_work
- **Type**:  -->  
- **Comment**:

Fails make check

~~~
...
Making Documentation/topdocs/out/AUTHORS.txt < texi
Making Documentation/topdocs/out/NEWS.txt < texi
[1]+  Donegitk  (wd: ~/lilypond-git)
(wd now: ~/lilypond-git/build)
.
--
Ran 1 test in 0.002s

OK
testing /home/james/lilypond-git/scripts/build/output-distance.py 

Please check the logfile

  /home/james/lilypond-git/build/scripts/build/./out/output-distance-test.log

for errors

last 20 lines:
GNU LilyPond 2.21.2
test results in  ./out/test-output-distance
Traceback (most recent call last):
  File "/home/james/lilypond-git/scripts/build/output-distance.py", line 1561, 
in 
main ()
  File "/home/james/lilypond-git/scripts/build/output-distance.py", line 1546, 
in main
run_tests ()
  File "/home/james/lilypond-git/scripts/build/output-distance.py", line 1494, 
in run_tests
test_basic_compare ()
  File "/home/james/lilypond-git/scripts/build/output-distance.py", line 1438, 
in test_basic_compare
test_compare_signatures (simple_names)
  File "/home/james/lilypond-git/scripts/build/output-distance.py", line 1481, 
in test_compare_signatures
assert combinations['20-19'][1] < 10.0
AssertionError
/home/james/lilypond-git/build/.././scripts/build/GNUmakefile:9: recipe for 
target 'local-test' failed
make[2]: *** [local-test] Error 1
/home/james/lilypond-git/build/../GNUmakefile.in:287: recipe for target 'test' 
failed
make[1]: *** [test] Error 2
/home/james/lilypond-git/build/../GNUmakefile.in:331: recipe for target 
'local-check-pre' failed
make: *** [local-check-pre] Error 2
~~~

The log file referenced just gives the same errors as the output above.



---

** [issues:#5940] Split glyph contours in up/down segments for skylines**

**Status:** Started
**Created:** Sun Apr 26, 2020 07:43 AM UTC by Han-Wen Nienhuys
**Last Updated:** Fri May 08, 2020 07:44 AM UTC
**Owner:** Han-Wen Nienhuys


This reduces the amount of skyline input coming from glyph outlines by
2x.

benchmark for arguments: input/regression/mozart-hrn-3
raw data: {'ff2061b518': [2.72, 2.69, 2.71], 'e8212e15e2': [2.7, 2.68, 2.69]}

Version ff2061b518: Create skylines directly from glyph outlines.
e8212e15e2 - Split glyph contours in up/down segments for skylines
  med diff -0.02
  med diff -0.738007 % (e8212e15e2 is faster)


benchmark for arguments: -I carver MSDM
raw data: {'ff2061b518': [51.83, 51.99, 52.05], 'e8212e15e2': [51.27, 51.2, 
51.48]}

ff2061b518: Create skylines directly from glyph outlines.
e8212e15e2 - Split glyph contours in up/down segments for skylines
  med diff -0.72
  med diff -1.384882 % (e8212e15e2 is faster)

https://codereview.appspot.com/569700043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4182 dynamics on skips confuse cross-staff stems

2020-05-08 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **Needs**:  -->  
- **Patch**: new --> review
- **Type**:  -->  
- **Comment**:

Passes make, make check and a full make doc. (reg test diffs as commend above)



---

** [issues:#4182] dynamics on skips confuse cross-staff stems**

**Status:** Started
**Created:** Fri Oct 31, 2014 09:21 PM UTC by Anonymous
**Last Updated:** Fri May 08, 2020 07:25 AM UTC
**Owner:** Kevin Barry
**Attachments:**

- 
[stem.png](https://sourceforge.net/p/testlilyissues/issues/4182/attachment/stem.png)
 (6.0 kB; image/png)


https://codereview.appspot.com/554030043

*Originally created by:* *anonymous

*Originally created by:* 
[k-ohara5...@oco.net](http://code.google.com/u/110197288862747384800/)

Sometime since ver 2.18, dynamics on skips began to make cross-staff stems 
point the wrong way.   The ledger line seems to be necessary for the bug.

up = \change Staff = "up"
dn = \change Staff = "down"
\new PianoStaff \transpose c c' << \time 2/4
  \new Staff = "up"  
    s2
  \new Staff = "down" <<  
    \{s8\*3 s8\p  \} 
    \{ g8\[ \up e \dn g \up c\] \} >> >


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5476 programming error/segfault while omitting Fingering.stencil with fingeringOrientations set 'left

2020-05-08 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
Passes make, make check and a full make doc.

Reg test diffs attached


Attachments:

- [Screenshot from 2020-05-08 
11-46-28.png](https://sourceforge.net/p/testlilyissues/issues/_discuss/thread/17e3afbeb8/1a31/attachment/Screenshot%20from%202020-05-08%2011-46-28.png)
 (49.1 kB; image/png)


---

** [issues:#5476] programming error/segfault while omitting Fingering.stencil 
with fingeringOrientations set 'left**

**Status:** Started
**Created:** Fri Feb 08, 2019 12:30 PM UTC by Palmer Ralph
**Last Updated:** Thu May 07, 2020 06:50 PM UTC
**Owner:** Valentin Villenave


https://codereview.appspot.com/567560043

Thomas Morley wrote :

the following code is problematic


{
  \set fingeringOrientations = #'(left)
  \override Fingering #'stencil = ##f
%% chord needs two elements to trigger the bug
}


Versions 2.12.3 up to 2.16.2 print correctly, without error

Versions 2.18.2 up to 2.19.82 print correctly, but return:
programming error: Infinity or NaN encountered

Current master does:
Segmentation fault (core dumped)


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5476 programming error/segfault while omitting Fingering.stencil with fingeringOrientations set 'left

2020-05-08 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **Needs**:  -->  
- **Patch**: new --> review
- **Type**:  -->  



---

** [issues:#5476] programming error/segfault while omitting Fingering.stencil 
with fingeringOrientations set 'left**

**Status:** Started
**Created:** Fri Feb 08, 2019 12:30 PM UTC by Palmer Ralph
**Last Updated:** Fri May 08, 2020 10:47 AM UTC
**Owner:** Valentin Villenave


https://codereview.appspot.com/567560043

Thomas Morley wrote :

the following code is problematic


{
  \set fingeringOrientations = #'(left)
  \override Fingering #'stencil = ##f
%% chord needs two elements to trigger the bug
}


Versions 2.12.3 up to 2.16.2 print correctly, without error

Versions 2.18.2 up to 2.19.82 print correctly, but return:
programming error: Infinity or NaN encountered

Current master does:
Segmentation fault (core dumped)


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5940 Split glyph contours in up/down segments for skylines

2020-05-08 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
rebase; drop experimental work

https://codereview.appspot.com/569700043


---

** [issues:#5940] Split glyph contours in up/down segments for skylines**

**Status:** Started
**Created:** Sun Apr 26, 2020 07:43 AM UTC by Han-Wen Nienhuys
**Last Updated:** Fri May 08, 2020 07:44 AM UTC
**Owner:** Han-Wen Nienhuys


This reduces the amount of skyline input coming from glyph outlines by
2x.

benchmark for arguments: input/regression/mozart-hrn-3
raw data: {'ff2061b518': [2.72, 2.69, 2.71], 'e8212e15e2': [2.7, 2.68, 2.69]}

Version ff2061b518: Create skylines directly from glyph outlines.
e8212e15e2 - Split glyph contours in up/down segments for skylines
  med diff -0.02
  med diff -0.738007 % (e8212e15e2 is faster)


benchmark for arguments: -I carver MSDM
raw data: {'ff2061b518': [51.83, 51.99, 52.05], 'e8212e15e2': [51.27, 51.2, 
51.48]}

ff2061b518: Create skylines directly from glyph outlines.
e8212e15e2 - Split glyph contours in up/down segments for skylines
  med diff -0.72
  med diff -1.384882 % (e8212e15e2 is faster)

https://codereview.appspot.com/569700043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5940 Split glyph contours in up/down segments for skylines

2020-05-08 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
rebase

https://codereview.appspot.com/569700043


---

** [issues:#5940] Split glyph contours in up/down segments for skylines**

**Status:** Started
**Created:** Sun Apr 26, 2020 07:43 AM UTC by Han-Wen Nienhuys
**Last Updated:** Fri May 08, 2020 07:42 AM UTC
**Owner:** Han-Wen Nienhuys


This reduces the amount of skyline input coming from glyph outlines by
2x.

benchmark for arguments: input/regression/mozart-hrn-3
raw data: {'ff2061b518': [2.72, 2.69, 2.71], 'e8212e15e2': [2.7, 2.68, 2.69]}

Version ff2061b518: Create skylines directly from glyph outlines.
e8212e15e2 - Split glyph contours in up/down segments for skylines
  med diff -0.02
  med diff -0.738007 % (e8212e15e2 is faster)


benchmark for arguments: -I carver MSDM
raw data: {'ff2061b518': [51.83, 51.99, 52.05], 'e8212e15e2': [51.27, 51.2, 
51.48]}

ff2061b518: Create skylines directly from glyph outlines.
e8212e15e2 - Split glyph contours in up/down segments for skylines
  med diff -0.72
  med diff -1.384882 % (e8212e15e2 is faster)

https://codereview.appspot.com/569700043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4182 dynamics on skips confuse cross-staff stems

2020-05-08 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
Fix texidoc style issues in cross-staff-stem-offset.ly

https://codereview.appspot.com/554030043


---

** [issues:#4182] dynamics on skips confuse cross-staff stems**

**Status:** Started
**Created:** Fri Oct 31, 2014 09:21 PM UTC by Anonymous
**Last Updated:** Fri May 08, 2020 07:25 AM UTC
**Owner:** Kevin Barry
**Attachments:**

- 
[stem.png](https://sourceforge.net/p/testlilyissues/issues/4182/attachment/stem.png)
 (6.0 kB; image/png)


https://codereview.appspot.com/554030043

*Originally created by:* *anonymous

*Originally created by:* 
[k-ohara5...@oco.net](http://code.google.com/u/110197288862747384800/)

Sometime since ver 2.18, dynamics on skips began to make cross-staff stems 
point the wrong way.   The ledger line seems to be necessary for the bug.

up = \change Staff = "up"
dn = \change Staff = "down"
\new PianoStaff \transpose c c' << \time 2/4
  \new Staff = "up"  
    s2
  \new Staff = "down" <<  
    \{s8\*3 s8\p  \} 
    \{ g8\[ \up e \dn g \up c\] \} >> >


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5476 programming error/segfault while omitting Fingering.stencil with fingeringOrientations set 'left

2020-05-07 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
Fix regtests (conditional should only apply to horizontal fingerings)

https://codereview.appspot.com/567560043


---

** [issues:#5476] programming error/segfault while omitting Fingering.stencil 
with fingeringOrientations set 'left**

**Status:** Started
**Created:** Fri Feb 08, 2019 12:30 PM UTC by Palmer Ralph
**Last Updated:** Thu May 07, 2020 06:50 PM UTC
**Owner:** Valentin Villenave


https://codereview.appspot.com/567560043

Thomas Morley wrote :

the following code is problematic


{
  \set fingeringOrientations = #'(left)
  \override Fingering #'stencil = ##f
%% chord needs two elements to trigger the bug
}


Versions 2.12.3 up to 2.16.2 print correctly, without error

Versions 2.18.2 up to 2.19.82 print correctly, but return:
programming error: Infinity or NaN encountered

Current master does:
Segmentation fault (core dumped)


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5476 programming error/segfault while omitting Fingering.stencil with fingeringOrientations set 'left

2020-05-07 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **Patch**: review --> needs_work
- **Comment**:

Yowza. Not good indeed. Thanks for catching this James, I should’ve paid more 
attention!



---

** [issues:#5476] programming error/segfault while omitting Fingering.stencil 
with fingeringOrientations set 'left**

**Status:** Started
**Created:** Fri Feb 08, 2019 12:30 PM UTC by Palmer Ralph
**Last Updated:** Thu May 07, 2020 05:41 PM UTC
**Owner:** Valentin Villenave


https://codereview.appspot.com/567560043

Thomas Morley wrote :

the following code is problematic


{
  \set fingeringOrientations = #'(left)
  \override Fingering #'stencil = ##f
%% chord needs two elements to trigger the bug
}


Versions 2.12.3 up to 2.16.2 print correctly, without error

Versions 2.18.2 up to 2.19.82 print correctly, but return:
programming error: Infinity or NaN encountered

Current master does:
Segmentation fault (core dumped)


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5957 Remove ly:lexer-keywords command

2020-05-07 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **labels**:  --> Fixed_2_21_2
- **status**: Started --> Fixed
- **Patch**: push -->  
- **Comment**:

~~~
Issue 5957: Remove ly:lexer-keywords command
author  David Kastrup 
Sat, 2 May 2020 10:43:55 +0100 (11:43 +0200)
committer   David Kastrup 
Thu, 7 May 2020 10:29:00 +0100 (11:29 +0200)
commit  53d3c069de1f3c20aa42179f347836a35ce46231
~~~



---

** [issues:#5957] Remove ly:lexer-keywords command**

**Status:** Fixed
**Labels:** Fixed_2_21_2 
**Created:** Sat May 02, 2020 10:19 AM UTC by David Kastrup
**Last Updated:** Thu May 07, 2020 08:52 AM UTC
**Owner:** David Kastrup


Remove ly:lexer-keywords command

It has been unused since its inception.  If it were to be retained, it
would make more sense to remove its (sole) argument since it was effectively
being ignored (other than that the presence of a Lexer guarantees that the
keyword table has been initialised).  Supporting member function
Lily_lexer::keyword_list is removed alongside.

http://codereview.appspot.com/559960060


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5954 Doc: Usage - update text about Open/LibreOffice

2020-05-07 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **labels**:  --> Fixed_2_21_2
- **status**: Started --> Fixed
- **Patch**: push -->  
- **Type**:   --> Documentation
- **Comment**:

~~~
Issue 5954: update OOoLilyPond info in usage manual staging
author  Kevin Barry  
Sat, 2 May 2020 10:17:30 +0100 (10:17 +0100)
committer   James Lowe  
Thu, 7 May 2020 18:43:19 +0100 (18:43 +0100)
commit  57617f931023d96645723d8139579e09948942f1
~~~

Thanks Kevin



---

** [issues:#5954] Doc: Usage - update text about Open/LibreOffice**

**Status:** Fixed
**Labels:** Fixed_2_21_2 
**Created:** Sat May 02, 2020 05:02 AM UTC by pkx166h
**Last Updated:** Thu May 07, 2020 01:13 PM UTC
**Owner:** Kevin Barry


On 01/05/2020 20:32, Ross Mohn wrote:
> LilyPond Usage Manual v2.20.0 Section 4.4.2 OpenOffice and LibreOffice 
> ,
>  please update the link when clicking on OOoLilyPond from the old 
> http://ooolilypond.sourceforge.net/ to the new 
> https://github.com/openlilylib/LO-ly. Also, replace this text:
>
> 
> Although this is no longer being developed, it appears to still work with 
> version 4.
> 
>
> with this:
>
> 
> OOoLilyPond (OLy) works with recent versions of LibreOffice and OpenOffice. 
> Older versions should work as well. It has even been tested with OpenOffice 
> 2.4 without issues.
> 
>
> Thanks! -Ross 


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5953 Further cleanup/regularisation of Callback_wrapper classes and trampolines

2020-05-07 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **labels**:  --> Fixed_2_21_2
- **status**: Started --> Fixed
- **Patch**: push -->  
- **Comment**:

~~~

Issue 5953/1: Make Callback_wrapper a class template
author  David Kastrup 
Wed, 29 Apr 2020 23:12:10 +0100 (00:12 +0200)
committer   David Kastrup 
Thu, 7 May 2020 10:28:49 +0100 (11:28 +0200)
commit  6a95c1d34f7cb7e4fb67d2279a917c9ef3cfdd6b
~~~

~~~
Issue 5953/2: Callback_wrapper:: move trampolines and make_smob to Callbacks 
class
author  David Kastrup 
Fri, 1 May 2020 20:12:10 +0100 (21:12 +0200)
committer   David Kastrup 
Thu, 7 May 2020 10:28:49 +0100 (11:28 +0200)
commit  3c13d9d745f9983deac6d217169764b527469d6b
~~~



---

** [issues:#5953] Further cleanup/regularisation of Callback_wrapper classes 
and trampolines**

**Status:** Fixed
**Labels:** Fixed_2_21_2 
**Created:** Fri May 01, 2020 08:51 PM UTC by David Kastrup
**Last Updated:** Thu May 07, 2020 08:51 AM UTC
**Owner:** David Kastrup


Further cleanup/regularisation of Callback_wrapper classes and trampolines

Contains two commits:

Callback_wrapper:: move trampolines and make_smob to Callbacks class



Make Callback_wrapper a class template

Templating Callback_wrapper on the wrapped argument list avoids a lot
of code repetition.

http://codereview.appspot.com/553980044


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5476 programming error/segfault while omitting Fingering.stencil with fingeringOrientations set 'left

2020-05-07 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **Patch**: new --> review



---

** [issues:#5476] programming error/segfault while omitting Fingering.stencil 
with fingeringOrientations set 'left**

**Status:** Started
**Created:** Fri Feb 08, 2019 12:30 PM UTC by Palmer Ralph
**Last Updated:** Thu May 07, 2020 05:41 PM UTC
**Owner:** Valentin Villenave


https://codereview.appspot.com/567560043

Thomas Morley wrote :

the following code is problematic


{
  \set fingeringOrientations = #'(left)
  \override Fingering #'stencil = ##f
%% chord needs two elements to trigger the bug
}


Versions 2.12.3 up to 2.16.2 print correctly, without error

Versions 2.18.2 up to 2.19.82 print correctly, but return:
programming error: Infinity or NaN encountered

Current master does:
Segmentation fault (core dumped)


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5476 programming error/segfault while omitting Fingering.stencil with fingeringOrientations set 'left

2020-05-07 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
Passes make, make check and a full make doc but the reg tests aren't good.

See:

https://cloud-u8zj2dc4b.yourownnet.eu/s/fD5Tjo2Frz3g9p5 (~1mb)


---

** [issues:#5476] programming error/segfault while omitting Fingering.stencil 
with fingeringOrientations set 'left**

**Status:** Started
**Created:** Fri Feb 08, 2019 12:30 PM UTC by Palmer Ralph
**Last Updated:** Thu May 07, 2020 01:29 PM UTC
**Owner:** Valentin Villenave


https://codereview.appspot.com/567560043

Thomas Morley wrote :

the following code is problematic


{
  \set fingeringOrientations = #'(left)
  \override Fingering #'stencil = ##f
%% chord needs two elements to trigger the bug
}


Versions 2.12.3 up to 2.16.2 print correctly, without error

Versions 2.18.2 up to 2.19.82 print correctly, but return:
programming error: Infinity or NaN encountered

Current master does:
Segmentation fault (core dumped)


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5954 Doc: Usage - update text about Open/LibreOffice

2020-05-07 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
Hi James,

A git formatted patch should be attached to this email.

Kevin
On Thu, May 07, 2020 at 01:13:29PM -, pkx166h wrote:
> No this is not automatic,
> 
> Can you attach git formatted patch based on current master and attach it 
> here, someone will push it for you.
> 
> or you can ask for commit access as per:
> 
> http://lilypond.org/doc/v2.19/Documentation/contributor-big-page#commit-access



---

** [issues:#5954] Doc: Usage - update text about Open/LibreOffice**

**Status:** Started
**Created:** Sat May 02, 2020 05:02 AM UTC by pkx166h
**Last Updated:** Thu May 07, 2020 01:13 PM UTC
**Owner:** Kevin Barry


On 01/05/2020 20:32, Ross Mohn wrote:
> LilyPond Usage Manual v2.20.0 Section 4.4.2 OpenOffice and LibreOffice 
> ,
>  please update the link when clicking on OOoLilyPond from the old 
> http://ooolilypond.sourceforge.net/ to the new 
> https://github.com/openlilylib/LO-ly. Also, replace this text:
>
> 
> Although this is no longer being developed, it appears to still work with 
> version 4.
> 
>
> with this:
>
> 
> OOoLilyPond (OLy) works with recent versions of LibreOffice and OpenOffice. 
> Older versions should work as well. It has even been tested with OpenOffice 
> 2.4 without issues.
> 
>
> Thanks! -Ross 


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5476 programming error/segfault while omitting Fingering.stencil with fingeringOrientations set 'left

2020-05-07 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- Description has changed:

Diff:



--- old
+++ new
@@ -1,3 +1,5 @@
+https://codereview.appspot.com/567560043
+
 Thomas Morley wrote :
 
 the following code is problematic



- **assigned_to**: Valentin Villenave
- **Needs**:  -->  
- **Type**:  -->  



---

** [issues:#5476] programming error/segfault while omitting Fingering.stencil 
with fingeringOrientations set 'left**

**Status:** Started
**Created:** Fri Feb 08, 2019 12:30 PM UTC by Palmer Ralph
**Last Updated:** Thu May 07, 2020 11:46 AM UTC
**Owner:** Valentin Villenave


https://codereview.appspot.com/567560043

Thomas Morley wrote :

the following code is problematic


{
  \set fingeringOrientations = #'(left)
  \override Fingering #'stencil = ##f
%% chord needs two elements to trigger the bug
}


Versions 2.12.3 up to 2.16.2 print correctly, without error

Versions 2.18.2 up to 2.19.82 print correctly, but return:
programming error: Infinity or NaN encountered

Current master does:
Segmentation fault (core dumped)


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4182 dynamics on skips confuse cross-staff stems

2020-05-07 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- Description has changed:

Diff:



--- old
+++ new
@@ -1,3 +1,5 @@
+https://codereview.appspot.com/554030043
+
 *Originally created by:* *anonymous
 
 *Originally created by:* 
[k-ohara5...@oco.net](http://code.google.com/u/110197288862747384800/)



- **assigned_to**: Kevin Barry
- **Needs**:  -->  
- **Patch**: new --> review
- **Type**:  -->  
- **Comment**:

Passes make, make check and a full make doc.



---

** [issues:#4182] dynamics on skips confuse cross-staff stems**

**Status:** Started
**Created:** Fri Oct 31, 2014 09:21 PM UTC by Anonymous
**Last Updated:** Thu May 07, 2020 10:28 AM UTC
**Owner:** Kevin Barry
**Attachments:**

- 
[stem.png](https://sourceforge.net/p/testlilyissues/issues/4182/attachment/stem.png)
 (6.0 kB; image/png)


https://codereview.appspot.com/554030043

*Originally created by:* *anonymous

*Originally created by:* 
[k-ohara5...@oco.net](http://code.google.com/u/110197288862747384800/)

Sometime since ver 2.18, dynamics on skips began to make cross-staff stems 
point the wrong way.   The ledger line seems to be necessary for the bug.

up = \change Staff = "up"
dn = \change Staff = "down"
\new PianoStaff \transpose c c' << \time 2/4
  \new Staff = "up"  
    s2
  \new Staff = "down" <<  
    \{s8\*3 s8\p  \} 
    \{ g8\[ \up e \dn g \up c\] \} >> >


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4182 dynamics on skips confuse cross-staff stems

2020-05-07 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
reg rest diffs attached


Attachments:

- [Screenshot from 2020-05-07 
14-19-10.png](https://sourceforge.net/p/testlilyissues/issues/_discuss/thread/4e2a5c719c/58bc/attachment/Screenshot%20from%202020-05-07%2014-19-10.png)
 (23.8 kB; image/png)
- [Screenshot from 2020-05-07 
14-19-35.png](https://sourceforge.net/p/testlilyissues/issues/_discuss/thread/4e2a5c719c/58bc/attachment/Screenshot%20from%202020-05-07%2014-19-35.png)
 (36.6 kB; image/png)


---

** [issues:#4182] dynamics on skips confuse cross-staff stems**

**Status:** Started
**Created:** Fri Oct 31, 2014 09:21 PM UTC by Anonymous
**Last Updated:** Thu May 07, 2020 01:28 PM UTC
**Owner:** Kevin Barry
**Attachments:**

- 
[stem.png](https://sourceforge.net/p/testlilyissues/issues/4182/attachment/stem.png)
 (6.0 kB; image/png)


https://codereview.appspot.com/554030043

*Originally created by:* *anonymous

*Originally created by:* 
[k-ohara5...@oco.net](http://code.google.com/u/110197288862747384800/)

Sometime since ver 2.18, dynamics on skips began to make cross-staff stems 
point the wrong way.   The ledger line seems to be necessary for the bug.

up = \change Staff = "up"
dn = \change Staff = "down"
\new PianoStaff \transpose c c' << \time 2/4
  \new Staff = "up"  
    s2
  \new Staff = "down" <<  
    \{s8\*3 s8\p  \} 
    \{ g8\[ \up e \dn g \up c\] \} >> >


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5954 Doc: Usage - update text about Open/LibreOffice

2020-05-07 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
No this is not automatic,

Can you attach git formatted patch based on current master and attach it here, 
someone will push it for you.

or you can ask for commit access as per:

http://lilypond.org/doc/v2.19/Documentation/contributor-big-page#commit-access




---

** [issues:#5954] Doc: Usage - update text about Open/LibreOffice**

**Status:** Started
**Created:** Sat May 02, 2020 05:02 AM UTC by pkx166h
**Last Updated:** Thu May 07, 2020 08:52 AM UTC
**Owner:** Kevin Barry


On 01/05/2020 20:32, Ross Mohn wrote:
> LilyPond Usage Manual v2.20.0 Section 4.4.2 OpenOffice and LibreOffice 
> ,
>  please update the link when clicking on OOoLilyPond from the old 
> http://ooolilypond.sourceforge.net/ to the new 
> https://github.com/openlilylib/LO-ly. Also, replace this text:
>
> 
> Although this is no longer being developed, it appears to still work with 
> version 4.
> 
>
> with this:
>
> 
> OOoLilyPond (OLy) works with recent versions of LibreOffice and OpenOffice. 
> Older versions should work as well. It has even been tested with OpenOffice 
> 2.4 without issues.
> 
>
> Thanks! -Ross 


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5950 Doc: mention tuplet-slur in Changes and in NR 1.2.1.2 "Tuplets"

2020-05-07 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **labels**:  --> Fixed_2_21_2
- **status**: Started --> Fixed
- **Comment**:

Pushed as 
https://git.savannah.gnu.org/cgit/lilypond.git/commit/?id=ee56da0f7a68cb6d6c5cd8531a566d81abdc5e59



---

** [issues:#5950] Doc: mention tuplet-slur in Changes and in NR 1.2.1.2 
"Tuplets"**

**Status:** Fixed
**Labels:** Fixed_2_21_2 
**Created:** Fri May 01, 2020 08:37 AM UTC by pkx166h
**Last Updated:** Thu May 07, 2020 08:51 AM UTC
**Owner:** Valentin Villenave


Doc: mention tuplet-slur in Changes and in NR 1.2.1.2 "Tuplets"

See issue #5567 for David Nalesnik’s original patch.
Documenting why the bracket-visibility default behavior
isn’t suited to tuplet-slurs allows me to explicitely
point towards the relevant snippet for more clarity,
and to add a couple of additional internal references.

https://codereview.appspot.com/559930043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5476 programming error/segfault while omitting Fingering.stencil with fingeringOrientations set 'left

2020-05-07 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
Fix #5476: segfault when Fingering stencil set to #f.

https://codereview.appspot.com/567560043


---

** [issues:#5476] programming error/segfault while omitting Fingering.stencil 
with fingeringOrientations set 'left**

**Status:** Started
**Created:** Fri Feb 08, 2019 12:30 PM UTC by Palmer Ralph
**Last Updated:** Thu May 07, 2020 11:46 AM UTC
**Owner:** nobody


Thomas Morley wrote :

the following code is problematic


{
  \set fingeringOrientations = #'(left)
  \override Fingering #'stencil = ##f
%% chord needs two elements to trigger the bug
}


Versions 2.12.3 up to 2.16.2 print correctly, without error

Versions 2.18.2 up to 2.19.82 print correctly, but return:
programming error: Infinity or NaN encountered

Current master does:
Segmentation fault (core dumped)


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5954 Doc: Usage - update text about Open/LibreOffice

2020-05-07 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
Does this get done automatically? (I don't have permissions to push).

On Thu, May 07, 2020 at 08:52:10AM -, pkx166h wrote:
> - **Patch**: countdown --> push
> - **Comment**:
> 
> Patch counted down - please push


---

** [issues:#5954] Doc: Usage - update text about Open/LibreOffice**

**Status:** Started
**Created:** Sat May 02, 2020 05:02 AM UTC by pkx166h
**Last Updated:** Thu May 07, 2020 08:52 AM UTC
**Owner:** Kevin Barry


On 01/05/2020 20:32, Ross Mohn wrote:
> LilyPond Usage Manual v2.20.0 Section 4.4.2 OpenOffice and LibreOffice 
> ,
>  please update the link when clicking on OOoLilyPond from the old 
> http://ooolilypond.sourceforge.net/ to the new 
> https://github.com/openlilylib/LO-ly. Also, replace this text:
>
> 
> Although this is no longer being developed, it appears to still work with 
> version 4.
> 
>
> with this:
>
> 
> OOoLilyPond (OLy) works with recent versions of LibreOffice and OpenOffice. 
> Older versions should work as well. It has even been tested with OpenOffice 
> 2.4 without issues.
> 
>
> Thanks! -Ross 


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4182 dynamics on skips confuse cross-staff stems

2020-05-07 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
Issue 4182: avoid checking the offset of cross-staff stems too early

Calculating the 'X-offset of a cross-staff Stem too early causes the
Stem's 'direction property to be accessed while it is still
"calculation-in-progress" - always returning "UP". This causes the
X-offset to be set incorrectly when the eventual stem direction will be
"DOWN".

This problem occurs in the scenario where the X-offset of a notehead is
calculated early, when NoteHead::stem_x_shift calls
Stem::calc_positioning_done (via get_property).

Update NoteHead::stem_x_shift to only check a stem's "positioning-done"
property if it is not cross-staff. This will prevent the above scenario
from triggering the problem. The Stem's offset will be calculated again
later anyway, and this does not change the return value of
NoteHead::stem_x_shift as it always returns 0.

Add a suitable regression test.

https://codereview.appspot.com/554030043


---

** [issues:#4182] dynamics on skips confuse cross-staff stems**

**Status:** Started
**Created:** Fri Oct 31, 2014 09:21 PM UTC by Anonymous
**Last Updated:** Thu May 07, 2020 10:28 AM UTC
**Owner:** nobody
**Attachments:**

- 
[stem.png](https://sourceforge.net/p/testlilyissues/issues/4182/attachment/stem.png)
 (6.0 kB; image/png)


*Originally created by:* *anonymous

*Originally created by:* 
[k-ohara5...@oco.net](http://code.google.com/u/110197288862747384800/)

Sometime since ver 2.18, dynamics on skips began to make cross-staff stems 
point the wrong way.   The ledger line seems to be necessary for the bug.

up = \change Staff = "up"
dn = \change Staff = "down"
\new PianoStaff \transpose c c' << \time 2/4
  \new Staff = "up"  
    s2
  \new Staff = "down" <<  
    \{s8\*3 s8\p  \} 
    \{ g8\[ \up e \dn g \up c\] \} >> >


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #4182 dynamics on skips confuse cross-staff stems

2020-05-07 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development



---

** [issues:#4182] dynamics on skips confuse cross-staff stems**

**Status:** Started
**Created:** Fri Oct 31, 2014 09:21 PM UTC by Anonymous
**Last Updated:** Mon Sep 14, 2015 12:57 PM UTC
**Owner:** nobody
**Attachments:**

- 
[stem.png](https://sourceforge.net/p/testlilyissues/issues/4182/attachment/stem.png)
 (6.0 kB; image/png)


*Originally created by:* *anonymous

*Originally created by:* 
[k-ohara5...@oco.net](http://code.google.com/u/110197288862747384800/)

Sometime since ver 2.18, dynamics on skips began to make cross-staff stems 
point the wrong way.   The ledger line seems to be necessary for the bug.

up = \change Staff = "up"
dn = \change Staff = "down"
\new PianoStaff \transpose c c' << \time 2/4
  \new Staff = "up"  
    s2
  \new Staff = "down" <<  
    \{s8\*3 s8\p  \} 
    \{ g8\[ \up e \dn g \up c\] \} >> >


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5964 Multi_measure_rest_engraver segfaults when its context doesn’t include Staff_symbol_engraver.

2020-05-07 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- Description has changed:

Diff:



--- old
+++ new
@@ -1,3 +1,5 @@
+https://codereview.appspot.com/576090043
+
 This used to work as recently as 2.20.0, and it no longer does:
 
 \version 2.21.1



- **assigned_to**: Valentin Villenave
- **Needs**:  -->  
- **Patch**: new --> review
- **Type**:  -->  



---

** [issues:#5964] Multi_measure_rest_engraver segfaults when its context 
doesn’t include Staff_symbol_engraver.**

**Status:** Started
**Created:** Wed May 06, 2020 10:47 PM UTC by Valentin Villenave
**Last Updated:** Thu May 07, 2020 10:05 AM UTC
**Owner:** Valentin Villenave


https://codereview.appspot.com/576090043

This used to work as recently as 2.20.0, and it no longer does:

\version 2.21.1
\layout {
  \context {
\type Engraver_group
\name GlobalRests
%\consists Staff_symbol_engraver
%\omit StaffSymbol
\consists Multi_measure_rest_engraver
  }
  \context {
\Score
\accepts GlobalRests
  }
}
\score {
\new GlobalRests { R1 }
}

Uncommenting the Staff_symbol_engraver prevents the segfault from happening.
Here’s what gdb has to say:
~~~
Program received signal SIGSEGV, Segmentation fault.
Grob::internal_get_property (this=this@entry=0x0, sym=0x7fffe98e1ea0) at 
grob-property.cc:162
162   SCM val = get_property_data (this, sym);
~~~
Reported by Trevor B: 
https://lists.gnu.org/archive/html/lilypond-user/2020-05/msg00077.html


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5964 Multi_measure_rest_engraver segfaults when its context doesn’t include Staff_symbol_engraver.

2020-05-07 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
Passes make, make check and a full make doc.

Reg test diff attached




Attachments:

- [Screenshot from 2020-05-07 
10-58-46.png](https://sourceforge.net/p/testlilyissues/issues/_discuss/thread/7942734bea/828b/attachment/Screenshot%20from%202020-05-07%2010-58-46.png)
 (59.8 kB; image/png)


---

** [issues:#5964] Multi_measure_rest_engraver segfaults when its context 
doesn’t include Staff_symbol_engraver.**

**Status:** Started
**Created:** Wed May 06, 2020 10:47 PM UTC by Valentin Villenave
**Last Updated:** Thu May 07, 2020 08:26 AM UTC
**Owner:** nobody


This used to work as recently as 2.20.0, and it no longer does:

\version 2.21.1
\layout {
  \context {
\type Engraver_group
\name GlobalRests
%\consists Staff_symbol_engraver
%\omit StaffSymbol
\consists Multi_measure_rest_engraver
  }
  \context {
\Score
\accepts GlobalRests
  }
}
\score {
\new GlobalRests { R1 }
}

Uncommenting the Staff_symbol_engraver prevents the segfault from happening.
Here’s what gdb has to say:
~~~
Program received signal SIGSEGV, Segmentation fault.
Grob::internal_get_property (this=this@entry=0x0, sym=0x7fffe98e1ea0) at 
grob-property.cc:162
162   SCM val = get_property_data (this, sym);
~~~
Reported by Trevor B: 
https://lists.gnu.org/archive/html/lilypond-user/2020-05/msg00077.html


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Re: #5964 Multi_measure_rest_engraver segfaults when its context doesn’t include Staff_symbol_engraver.

2020-05-07 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
Duh.
~~~
#0  Grob::internal_get_property(scm_unused_struct*) const (this=this@entry=0x0, 
sym=0x7fffe98e1ea0) at grob-property.cc:162
#1  0x00595190 in Staff_symbol::line_positions(Grob*) (me=0x0) at 
staff-symbol.cc:113
#2  0x005335d7 in Multi_measure_rest::church_rest(Grob*, Font_metric*, 
int, int, double) (me=me@entry=0xbaa270, musfont=musfont@entry=0xba0850, 
measure_count=measure_count@entry=1, mdl=, space=space@entry=0) 
at multi-measure-rest.cc:268
#3  0x00533f65 in Multi_measure_rest::symbol_stencil(Grob*, double) 
(me=me@entry=0xbaa270, space=space@entry=0) at multi-measure-rest.cc:216
#4  0x0053487a in 
Multi_measure_rest::set_spacing_rods(scm_unused_struct*) (smob=) 
at multi-measure-rest.cc:417
#5  0x77dc1044 in scm_dapply (proc=0x7fffea23aa30, arg1=0x7fffe64ca090, 
args=0x404) at eval.c:4895
#6  0x0065944c in Grob::try_callback_on_alist(scm_unused_struct**, 
scm_unused_struct*, scm_unused_struct*) (this=this@entry=0xbaa270, 
alist=alist@entry=0xbaa2f8, sym=0x7fffe98d1760, proc=0x7fffea23aa30) at 
/home/work/lilypond/lily/include/smobs.hh:318
#7  0x0065967c in Grob::internal_get_property(scm_unused_struct*) const 
(this=this@entry=0xbaa270, sym=) at grob-property.cc:184
#8  0x005f8b53 in System::pre_processing() (this=0xba05d0) at 
system.cc:552
#9  0x006b4bf0 in ly_format_output(scm_unused_struct*) 
(context=context@entry=0x7fffe6529860) at global-context-scheme.cc:45
#10 0x0045adc7 in Score::book_rendering(Output_def*, Output_def*) 
(this=this@entry=0xb76390, layoutbook=0xb76d70, 
default_def=default_def@entry=0xb75750) at score.cc:141
#11 0x006dbf38 in Book::process_score(scm_unused_struct*, Paper_book*, 
Output_def*) (this=this@entry=0xb76cf0, s=s@entry=0x7fffe6560b90, 
output_paper_book=output_paper_book@entry=0xb768f0, 
layout=layout@entry=0xb75750) at book.cc:222
#12 0x006dc7c8 in Book::process(Output_def*, Output_def*, Paper_book*) 
(this=this@entry=0xb76cf0, default_paper=, 
default_layout=0xb75750, parent_part=parent_part@entry=0x0) at book.cc:305
#13 0x006dc827 in Book::process(Output_def*, Output_def*) 
(this=this@entry=0xb76cf0, default_paper=, 
default_layout=) at book.cc:194
#14 0x005c9081 in ly_book_process(scm_unused_struct*, 
scm_unused_struct*, scm_unused_struct*, scm_unused_struct*) 
(book_smob=, default_paper=0x7fffe6882220, 
default_layout=0x7fffe66cba10, output=0x7fffe9556f00)
at /home/work/lilypond/lily/include/smobs.hh:179
#15 0x77dc11a0 in scm_dapply (proc=0x7fffe99104f0, arg1=0x7fffea2a8ae0, 
args=0x7fffe65a1f80, args@entry=0x404) at eval.c:4930
#16 0x77dc3d41 in deval (x=, env=) at 
eval.c:4378
#17 0x77dcbf38 in scm_c_with_fluid (fluid=0x7fffe98d0300, 
value=value@entry=0x7fffe65a4990, cproc=cproc@entry=0x44dc40 
, cdata=cdata@entry=0x7fffa4e0) at 
fluids.c:463
#18 0x0044e1e2 in evaluate_embedded_scheme(scm_unused_struct*, Input 
const&, bool, Lily_parser*) (form=0x7fffe65a5570, start=..., safe=, parser=) at 
/home/work/lilypond/lily/include/lily-modules.hh:65
#19 0x006f8806 in Lily_lexer::eval_scm(scm_unused_struct*, Input, char) 
(this=this@entry=0x81a410, readerdata=readerdata@entry=0x7fffe65a5570, 
location=..., extra_token=extra_token@entry=35 '#') at lexer.ll:1108
#20 0x0070561f in Lily_lexer::eval_scm_token(scm_unused_struct*, Input) 
(w=..., sval=0x7fffe65a5570, this=0x81a410) at 
/home/work/lilypond/lily/include/lily-lexer.hh:62
#21 yyparse(Lily_parser*, scm_unused_struct**) (parser=, 
retval=) at parser.yy:452
#22 0x00712857 in Lily_parser::do_yyparse_trampoline(void*) 
(parser=parser@entry=0xa6e6c0) at parser.yy:4246
#23 0x77dcbf38 in scm_c_with_fluid (fluid=0x7fffe98d0380, 
value=0x7fffe7460480, cproc=cproc@entry=0x712840 
, cdata=cdata@entry=0xa6e6c0) at 
fluids.c:463
#24 0x006fdeec in Lily_parser::do_yyparse() (this=this@entry=0xa6e6c0) 
at /home/work/lilypond/lily/include/lily-modules.hh:65
#25 0x006dcd28 in 
Lily_parser::parse_file(std::__cxx11::basic_string, std::allocator > const&, 
std::__cxx11::basic_string, std::allocator > 
const&, std::__cxx11::basic_string, 
std::allocator > const&) (this=this@entry=0xa6e6c0, init="init.ly", 
name="/tmp/document.ly", out_name="document") at lily-parser.cc:118
#26 0x004fa129 in ly_parse_file(scm_unused_struct*) (name=) at lily-parser-scheme.cc:124
#27 0x77dc3cf3 in deval (x=, x@entry=0x7fffe80b8630, 
env=, env@entry=0x7fffe7460510) at eval.c:4232
#28 0x77dc16a6 in scm_dapply (proc=0x7fffe7460620, arg1=, args=0x7fffe7460510) at ../libguile/inline.h:305
#29 0x77e1c971 in scm_c_catch
(tag=, body=body@entry=0x77e1c380 , 
body_data=body_data@entry=0x7fffcb50, handler=0x77e1c390 
, handler_data=handler_data@entry=0x7fffcb48, 
pre_unwind_handler=0x0, pre_unwind_handler_data=0x7fffcb40)
at throw.c:203
#30 0x77e1cba1 in scm_catch_with_pre_unwind_handler 

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5963 Remove define causing a warning

2020-05-07 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **Patch**: review --> countdown
- **Comment**:

Patch on countdown for May 9th



---

** [issues:#5963] Remove define causing a warning**

**Status:** Started
**Created:** Mon May 04, 2020 04:04 PM UTC by Jonas Hahnfeld
**Last Updated:** Tue May 05, 2020 07:51 AM UTC
**Owner:** Jonas Hahnfeld


Remove define causing a warning

These lines were added in commit 25beb8d01b in 2008 to provide
compatibility with GCC 3.4 which clearly does not support C++11.
(The warning is visible since commit b96b6334c0 which put system
headers last, so that the define is already provided transitvely.)

http://codereview.appspot.com/561790043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5961 Cosmetic fixes to accidental.cc

2020-05-07 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **Patch**: review --> countdown
- **Comment**:

Patch on countdown for May 9th



---

** [issues:#5961] Cosmetic fixes to accidental.cc**

**Status:** Started
**Created:** Sun May 03, 2020 06:55 PM UTC by Han-Wen Nienhuys
**Last Updated:** Mon May 04, 2020 10:51 AM UTC
**Owner:** Han-Wen Nienhuys


https://codereview.appspot.com/559950046


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5958 output-distance: create PNG files in batch

2020-05-07 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **Patch**: countdown --> push
- **Comment**:

Patch counted down - please push



---

** [issues:#5958] output-distance: create PNG files in batch**

**Status:** Started
**Created:** Sat May 02, 2020 12:34 PM UTC by Han-Wen Nienhuys
**Last Updated:** Mon May 04, 2020 12:16 PM UTC
**Owner:** Han-Wen Nienhuys


https://codereview.appspot.com/567530052


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5952 Use axis indexing to clarify different behaviors for X/Y skylines

2020-05-07 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **Patch**: countdown --> push
- **Comment**:

Patch counted down - please push



---

** [issues:#5952]  Use axis indexing to clarify different behaviors for X/Y 
skylines **

**Status:** Started
**Created:** Fri May 01, 2020 08:17 PM UTC by Han-Wen Nienhuys
**Last Updated:** Mon May 04, 2020 12:15 PM UTC
**Owner:** Han-Wen Nienhuys


Use axis indexing to clarify different behaviors for X/Y skylines

https://codereview.appspot.com/573770043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5950 Doc: mention tuplet-slur in Changes and in NR 1.2.1.2 "Tuplets"

2020-05-07 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
Patch counted down - please push - but see the nits on Rietveld Valentin.


---

** [issues:#5950] Doc: mention tuplet-slur in Changes and in NR 1.2.1.2 
"Tuplets"**

**Status:** Started
**Created:** Fri May 01, 2020 08:37 AM UTC by pkx166h
**Last Updated:** Mon May 04, 2020 12:14 PM UTC
**Owner:** Valentin Villenave


Doc: mention tuplet-slur in Changes and in NR 1.2.1.2 "Tuplets"

See issue #5567 for David Nalesnik’s original patch.
Documenting why the bracket-visibility default behavior
isn’t suited to tuplet-slurs allows me to explicitely
point towards the relevant snippet for more clarity,
and to add a couple of additional internal references.

https://codereview.appspot.com/559930043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5954 Doc: Usage - update text about Open/LibreOffice

2020-05-07 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **Patch**: countdown --> push
- **Comment**:

Patch counted down - please push



---

** [issues:#5954] Doc: Usage - update text about Open/LibreOffice**

**Status:** Started
**Created:** Sat May 02, 2020 05:02 AM UTC by pkx166h
**Last Updated:** Mon May 04, 2020 12:15 PM UTC
**Owner:** Kevin Barry


On 01/05/2020 20:32, Ross Mohn wrote:
> LilyPond Usage Manual v2.20.0 Section 4.4.2 OpenOffice and LibreOffice 
> ,
>  please update the link when clicking on OOoLilyPond from the old 
> http://ooolilypond.sourceforge.net/ to the new 
> https://github.com/openlilylib/LO-ly. Also, replace this text:
>
> 
> Although this is no longer being developed, it appears to still work with 
> version 4.
> 
>
> with this:
>
> 
> OOoLilyPond (OLy) works with recent versions of LibreOffice and OpenOffice. 
> Older versions should work as well. It has even been tested with OpenOffice 
> 2.4 without issues.
> 
>
> Thanks! -Ross 


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5949 Add option to use Ghostscript API instead of forking

2020-05-07 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **Patch**: review --> countdown
- **Comment**:

Patch on countdown for May 9th



---

** [issues:#5949] Add option to use Ghostscript API instead of forking**

**Status:** Started
**Created:** Thu Apr 30, 2020 07:12 PM UTC by Jonas Hahnfeld
**Last Updated:** Sun May 03, 2020 01:17 PM UTC
**Owner:** Jonas Hahnfeld


Add option to use Ghostscript API instead of forking

This is much more efficient than the current scheme when converting
many PostScript files, for example when building the documentation.
For the Notation Reference, lilypond-book now takes ~2m30s instead
of 5m to compile all snippets from the notation.tely file. Other
manuals benefit less, but still the time for 'make doc' on my system
improves by one third from around 33m to 22m.

An alternative would have been to always call gsapi_init_with_args
with the same arguments used until now. This indeed works and avoids
the overhead of forking, but the instance cannot be reused. Calling
gsapi_new_instance -> gsapi_init_with_args -> gsapi_delete_instance
for every conversion still means a lot of overhead and a prototype
suggested only a small gain compared to the previous solution.

This is not the default because recent versions of Ghostscript are
distributed under the AGPL and it's unclear what the implications of
linking to the library is. If built with support for the API, use
-dgs-api=#f to still fork the gs command.

http://codereview.appspot.com/548030043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5943 Convert stencil to skyline directly

2020-05-07 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **Patch**: countdown --> push
- **Comment**:

Patch counted down - please push



---

** [issues:#5943] Convert stencil to skyline directly**

**Status:** Started
**Created:** Sun Apr 26, 2020 12:13 PM UTC by Han-Wen Nienhuys
**Last Updated:** Mon May 04, 2020 12:13 PM UTC
**Owner:** Han-Wen Nienhuys


Gets rid of more intermediate storage.

Benchmarks show that this is performance neutral.

https://codereview.appspot.com/555760043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5941 Create skylines directly from glyph outlines.

2020-05-07 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **Patch**: countdown --> push
- **Comment**:

Patch counted down - please push



---

** [issues:#5941] Create skylines directly from glyph outlines.**

**Status:** Started
**Created:** Sun Apr 26, 2020 07:44 AM UTC by Han-Wen Nienhuys
**Last Updated:** Mon May 04, 2020 12:13 PM UTC
**Owner:** Han-Wen Nienhuys


This avoids creating garbage for the intermediate Scheme data to
transport the glyph outlines.

Benchmark:

benchmark for arguments: input/regression/mozart-hrn-3.ly
raw data: {'ac8eaa37ee': [2.73, 2.7, 2.73], '893552a691': [2.7, 2.71, 2.71]}
  med diff -0.732601 % (893552a691 is faster)

benchmark for arguments: -I carver MSDM
raw data: {'ac8eaa37ee': [52.43, 52.41, 52.17], '893552a691': [52.47, 52.33, 
52.18]}
893552a691 - Create skylines directly from glyph outlines.
  med diff -0.152643 % (893552a691 is faster)

(for Carver score, the difference is at noise)

https://codereview.appspot.com/561730043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5953 Further cleanup/regularisation of Callback_wrapper classes and trampolines

2020-05-07 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **Patch**: countdown --> push
- **Comment**:

Patch counted down - please push



---

** [issues:#5953] Further cleanup/regularisation of Callback_wrapper classes 
and trampolines**

**Status:** Started
**Created:** Fri May 01, 2020 08:51 PM UTC by David Kastrup
**Last Updated:** Mon May 04, 2020 12:15 PM UTC
**Owner:** David Kastrup


Further cleanup/regularisation of Callback_wrapper classes and trampolines

Contains two commits:

Callback_wrapper:: move trampolines and make_smob to Callbacks class



Make Callback_wrapper a class template

Templating Callback_wrapper on the wrapped argument list avoids a lot
of code repetition.

http://codereview.appspot.com/553980044


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5960 Add OTC font support for `-dfont-ps-resdir`

2020-05-07 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **Patch**: review --> countdown
- **Comment**:

Patch on countdown for May 9th



---

** [issues:#5960] Add OTC font support for `-dfont-ps-resdir`**

**Status:** Started
**Created:** Sun May 03, 2020 02:17 PM UTC by Masamichi Hosoda
**Last Updated:** Mon May 04, 2020 07:25 AM UTC
**Owner:** Masamichi Hosoda


Add OTC font support for `-dfont-ps-resdir`

This commit adds support for OpenType/CFF collection (OTC) fonts
to the `-dfont-ps-resdir` option.

Add `ly:extract-subfont-from-collection`

Extract the subfont in TrueType collection (TTC)
or OpenType/CFF collection (OTC) file and write it to file.

http://codereview.appspot.com/548080043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5951 Calculate skylines only once.

2020-05-07 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **Patch**: countdown --> push
- **Comment**:

Patch counted down - please push



---

** [issues:#5951] Calculate skylines only once.**

**Status:** Started
**Created:** Fri May 01, 2020 05:52 PM UTC by Han-Wen Nienhuys
**Last Updated:** Mon May 04, 2020 12:14 PM UTC
**Owner:** Han-Wen Nienhuys


Before, Axis_group_interface::skyline_spacing() would call the
function add_interior_skylines(), which recursed into
VerticalAxisGroups.  This caused staff-skylines to be computed twice:
once as part of the Staff's VerticalAxisGroup, and once to compute
the skyline for System.

Instead, in Axis_group_interface::skyline_spacing(), compute the
vertical-skylines for all constituent elements.  Since the property is
subject to caching, the Staff skyline is only computed once.

To make this work

* Add flags to the NoteColumn using Axis_group_interface::add_element

* add vertical-skylines callbacks for NoteColumn and
  NoteCollision, which are also X,Y Axis groups.

* declare add-stem-support for bass figures (or the digits are meshed
  in with stems that stick out of the staff.)

* calculate a skyline for BassFigureAlignment, otherwise, the skyline
  is computed from the extent of the alignment, which is inaccurate if
  some bass figures have accidentals.

Formatting impact:

* ottava-edge.ly - the ottava bracket meshes better with the stem,
  leading to tighter spacing.

Timing impact

ac49229cdf - Calculate skylines only once.
  baseline: eaf40071f5 Use vectors rather than lists for skylines.
  args: -I carver MSDM
  memory: med diff 1916 (stddevs 103 135, n=5)
  memory: med diff 0.2 % (ac49229cdf is fatter)
  time: med diff -0.37 (stddevs 0.08 0.14, n=5)
  time: med diff -0.8 % (ac49229cdf is faster)

https://codereview.appspot.com/553980043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] Ticket 3778 discussion

2020-05-07 Thread Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **Patch**: review --> countdown
- **Comment**:

Patch on countdown for May 9th



---

** [issues:#3778] SVG backend: Use bounding box as skylines for markup / 
Compute SVG skyline based on original data**

**Status:** Started
**Created:** Sun Jan 05, 2014 05:39 AM UTC by Anonymous
**Last Updated:** Tue May 05, 2020 08:40 AM UTC
**Owner:** Han-Wen Nienhuys
**Attachments:**

- 
[document.svg](https://sourceforge.net/p/testlilyissues/issues/3778/attachment/document.svg)
 (4.4 kB; image/svg+xml)


https://codereview.appspot.com/545970043

(needs https://codereview.appspot.com/555760043/)

Compute SVG skyline based on original data

Since stencil data is used as input to formatting decisions, this
will make SVG output more similar to PS/PDF output.

 

Use bounding box as skylines for markup in svg backend

As there is no routine for determining skylines for utf-8-string
stencils, they normally fall back to the grob's bounding box, which is
fine. However, when there is a mixture of utf-8-string and other types
of stencil (which have associated skyline functions) in a single grob,
the entire grob gets a skyline determined only from the non-utf-8-string
stencils. This sometimes causes the text portion of such mixed grobs
(e.g. metronome marks) to collide with other grobs.

While looping over the stencils, check for utf-8-string and if found,
clear the skylines and break out of the loop. Empty skylines forces a
fallback to the grob's bounding box, which restores the behaviour from
before the patch to improve skyline approximations (issue 2148). This
does not fix the issue that there is no routine for determining skylines
for utf-8-strings when the backend is svg, but it does at least remove
the collisions without changing the behaviour in non-broken situations.

Add a suitable (svg backend) regression test.



***

Originally reported 
[here.](http://lists.gnu.org/archive/html/lilypond-user/2014-01/msg00213.html)

the tempo marking in the SVG output is both lower, so that it collides with the 
stem of the A, and also has insufficient space between the equals sign and the 
preceding quarter note:


:::TeX
\version "2.18.0"

\relative c'' {
  \tempo 4=76
  a4
}



---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto


  1   2   3   4   5   6   7   8   9   10   >