[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5154 Centering bass figures on whole notes and longer

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

I now coded such a callback.
See attached. 
The file includes the relevant regtest.
Triggered by figured-bass-extenders-markup.ly a design-decision is be needed, 
how to deal with text-markups.
Needs design-decision as well: how to deal with suspended NoteHeads.


Attachments:

- 
[atest-63.ly](https://sourceforge.net/p/testlilyissues/issues/_discuss/thread/2e2f0279/ce35/attachment/atest-63.ly)
 (9.9 kB; text/x-lilypond)


---

** [issues:#5154] Centering bass figures on whole notes and longer**

**Status:** Started
**Created:** Fri Jul 14, 2017 03:41 PM UTC by pkx166h
**Last Updated:** Sat Jul 15, 2017 07:06 AM UTC
**Owner:** pkx166h


From:   Richard Shann
Subject:Patch to fix centering of some bass figures on whole notes and 
longer.
Date:   Sun, 09 Jul 2017 15:05:18 +0100

Simon Albrecht suggested I start a new thread for this (apologies for
any confusion)

Attached is a patch that fixes the centering of single bass figures over
notes of duration whole note and more. The duration is tested and a
translate applied horizontally if needed.

A test snippet is this:

8><8><8><8><8><8><8><8><8><8><8><8><8><8><8><8><
<<

{

\time 4/2 c''\breve c'' c''1 c''

c''4 c'' c'' c''


}

\new FiguredBass {

\figuremode {

<_+>\breve <_-> <3>1 <3+>

<_+>4 <_-> <3> <3+>

}

}

>>
8><8><8><8><8><8><8><8><8><8><8><8><8><8><8><8><

In version until now the single character figures are placed to the left
of the true center.


Centering bass figures on whole notes and longer

This is a patch that fixes
the centering of single bass
figures over notes of duration
whole note and more.

The duration is tested and a
translate applied horizontally
if needed.

http://codereview.appspot.com/325070043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5154 Centering bass figures on whole notes and longer

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

As David already pointed out this patch looks only at the duration of the 
BassFigure whether to apply some translation or not. This will only work, if 
the durations of BassFigure and related note match.

To illustrate:
~~~
<<
  \relative c' { c1 c'8 d e f g f e d }
  \figures { <6+>2 <6+>2 <6+>1 }
~~~
Only the third BassFigure is moved, but shouldn't!
See attached.

I'd rather go for a procedure looking at NoteColumn, applying it to 
BassFigure.X-offset or the like to get convincing aligning.


Attachments:

- 
[atest-63.png](https://sourceforge.net/p/testlilyissues/issues/_discuss/thread/2e2f0279/1933/attachment/atest-63.png)
 (4.9 kB; image/png)


---

** [issues:#5154] Centering bass figures on whole notes and longer**

**Status:** Started
**Created:** Fri Jul 14, 2017 03:41 PM UTC by pkx166h
**Last Updated:** Fri Jul 14, 2017 03:45 PM UTC
**Owner:** pkx166h


From:   Richard Shann
Subject:Patch to fix centering of some bass figures on whole notes and 
longer.
Date:   Sun, 09 Jul 2017 15:05:18 +0100

Simon Albrecht suggested I start a new thread for this (apologies for
any confusion)

Attached is a patch that fixes the centering of single bass figures over
notes of duration whole note and more. The duration is tested and a
translate applied horizontally if needed.

A test snippet is this:

8><8><8><8><8><8><8><8><8><8><8><8><8><8><8><8><
<<

{

\time 4/2 c''\breve c'' c''1 c''

c''4 c'' c'' c''


}

\new FiguredBass {

\figuremode {

<_+>\breve <_-> <3>1 <3+>

<_+>4 <_-> <3> <3+>

}

}

>>
8><8><8><8><8><8><8><8><8><8><8><8><8><8><8><8><

In version until now the single character figures are placed to the left
of the true center.


Centering bass figures on whole notes and longer

This is a patch that fixes
the centering of single bass
figures over notes of duration
whole note and more.

The duration is tested and a
translate applied horizontally
if needed.

http://codereview.appspot.com/325070043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5154 Centering bass figures on whole notes and longer

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- **Comment**:

Passes make, make check and a full make doc.



---

** [issues:#5154] Centering bass figures on whole notes and longer**

**Status:** Started
**Created:** Fri Jul 14, 2017 03:41 PM UTC by pkx166h
**Last Updated:** Fri Jul 14, 2017 03:43 PM UTC
**Owner:** pkx166h


From:   Richard Shann
Subject:Patch to fix centering of some bass figures on whole notes and 
longer.
Date:   Sun, 09 Jul 2017 15:05:18 +0100

Simon Albrecht suggested I start a new thread for this (apologies for
any confusion)

Attached is a patch that fixes the centering of single bass figures over
notes of duration whole note and more. The duration is tested and a
translate applied horizontally if needed.

A test snippet is this:

8><8><8><8><8><8><8><8><8><8><8><8><8><8><8><8><
<<

{

\time 4/2 c''\breve c'' c''1 c''

c''4 c'' c'' c''


}

\new FiguredBass {

\figuremode {

<_+>\breve <_-> <3>1 <3+>

<_+>4 <_-> <3> <3+>

}

}

>>
8><8><8><8><8><8><8><8><8><8><8><8><8><8><8><8><

In version until now the single character figures are placed to the left
of the true center.


Centering bass figures on whole notes and longer

This is a patch that fixes
the centering of single bass
figures over notes of duration
whole note and more.

The duration is tested and a
translate applied horizontally
if needed.

http://codereview.appspot.com/325070043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5154 Centering bass figures on whole notes and longer

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

From:   David Kastrup
Subject:Re: Patch to fix centering of some bass figures on whole notes 
and longer.
Date:   Sun, 09 Jul 2017 18:46:25 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)

Richard Shann  writes:

> Simon Albrecht suggested I start a new thread for this (apologies for
> any confusion)
>
> Attached is a patch that fixes the centering of single bass figures over
> notes of duration whole note and more. The duration is tested and a
> translate applied horizontally if needed.

Except that the "centering" or not decision then rests on the duration
of the bass figure rather than any properties of the note column in
question.

I think it isn't uncommon to have bass lines where there isn't one
figure per bass note but there are also intermediate notes without
figure.

-- 
David Kastrup



---

** [issues:#5154] Centering bass figures on whole notes and longer**

**Status:** Started
**Created:** Fri Jul 14, 2017 03:41 PM UTC by pkx166h
**Last Updated:** Fri Jul 14, 2017 03:43 PM UTC
**Owner:** pkx166h


From:   Richard Shann
Subject:Patch to fix centering of some bass figures on whole notes and 
longer.
Date:   Sun, 09 Jul 2017 15:05:18 +0100

Simon Albrecht suggested I start a new thread for this (apologies for
any confusion)

Attached is a patch that fixes the centering of single bass figures over
notes of duration whole note and more. The duration is tested and a
translate applied horizontally if needed.

A test snippet is this:

8><8><8><8><8><8><8><8><8><8><8><8><8><8><8><8><
<<

{

\time 4/2 c''\breve c'' c''1 c''

c''4 c'' c'' c''


}

\new FiguredBass {

\figuremode {

<_+>\breve <_-> <3>1 <3+>

<_+>4 <_-> <3> <3+>

}

}

>>
8><8><8><8><8><8><8><8><8><8><8><8><8><8><8><8><

In version until now the single character figures are placed to the left
of the true center.


Centering bass figures on whole notes and longer

This is a patch that fixes
the centering of single bass
figures over notes of duration
whole note and more.

The duration is tested and a
translate applied horizontally
if needed.

http://codereview.appspot.com/325070043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5154 Centering bass figures on whole notes and longer

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

- Description has changed:

Diff:



--- old
+++ new
@@ -1,3 +1,47 @@
+From:  Richard Shann
+Subject:   Patch to fix centering of some bass figures on whole notes and 
longer.
+Date:  Sun, 09 Jul 2017 15:05:18 +0100
+
+Simon Albrecht suggested I start a new thread for this (apologies for
+any confusion)
+
+Attached is a patch that fixes the centering of single bass figures over
+notes of duration whole note and more. The duration is tested and a
+translate applied horizontally if needed.
+
+A test snippet is this:
+
+8><8><8><8><8><8><8><8><8><8><8><8><8><8><8><8><
+<<
+
+{
+
+\time 4/2 c''\breve c'' c''1 c''
+
+c''4 c'' c'' c''
+
+
+}
+
+\new FiguredBass {
+
+\figuremode {
+
+<_+>\breve <_-> <3>1 <3+>
+
+<_+>4 <_-> <3> <3+>
+
+}
+
+}
+
+>>
+8><8><8><8><8><8><8><8><8><8><8><8><8><8><8><8><
+
+In version until now the single character figures are placed to the left
+of the true center.
+
+
 Centering bass figures on whole notes and longer
 
 This is a patch that fixes



- **Needs**:  -->  
- **Patch**: new --> review



---

** [issues:#5154] Centering bass figures on whole notes and longer**

**Status:** Started
**Created:** Fri Jul 14, 2017 03:41 PM UTC by pkx166h
**Last Updated:** Fri Jul 14, 2017 03:41 PM UTC
**Owner:** pkx166h


From:   Richard Shann
Subject:Patch to fix centering of some bass figures on whole notes and 
longer.
Date:   Sun, 09 Jul 2017 15:05:18 +0100

Simon Albrecht suggested I start a new thread for this (apologies for
any confusion)

Attached is a patch that fixes the centering of single bass figures over
notes of duration whole note and more. The duration is tested and a
translate applied horizontally if needed.

A test snippet is this:

8><8><8><8><8><8><8><8><8><8><8><8><8><8><8><8><
<<

{

\time 4/2 c''\breve c'' c''1 c''

c''4 c'' c'' c''


}

\new FiguredBass {

\figuremode {

<_+>\breve <_-> <3>1 <3+>

<_+>4 <_-> <3> <3+>

}

}

>>
8><8><8><8><8><8><8><8><8><8><8><8><8><8><8><8><

In version until now the single character figures are placed to the left
of the true center.


Centering bass figures on whole notes and longer

This is a patch that fixes
the centering of single bass
figures over notes of duration
whole note and more.

The duration is tested and a
translate applied horizontally
if needed.

http://codereview.appspot.com/325070043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto

[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5154 Centering bass figures on whole notes and longer

[Auto mailings of changes to Lily Issues via Testlilyissues-auto]

---

** [issues:#5154] Centering bass figures on whole notes and longer**

**Status:** Started
**Created:** Fri Jul 14, 2017 03:41 PM UTC by pkx166h
**Last Updated:** Fri Jul 14, 2017 03:41 PM UTC
**Owner:** nobody


Centering bass figures on whole notes and longer

This is a patch that fixes
the centering of single bass
figures over notes of duration
whole note and more.

The duration is tested and a
translate applied horizontally
if needed.

http://codereview.appspot.com/325070043


---

Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is 
subscribed to https://sourceforge.net/p/testlilyissues/issues/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/testlilyissues/admin/issues/options.  Or, if this is 
a mailing list, you can unsubscribe from the mailing list.--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Testlilyissues-auto mailing list
testlilyissues-a...@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto