[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5167 Allow defining markup commands in LilyPond syntax
2020-02-17
Thread
Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **labels**: --> Fixed_2_19_80 - Description has changed: Diff: --- old +++ new @@ -5,8 +5,8 @@ \markup with-red = \markup \with-color #red \etc or similar. The resulting definition (in addition to being available -as \with-red command inside of markups) can be used with the `markup' -macro and also gets a `make-with-red-markup' convenience function. +as `\with-red` command inside of markups) can be used with the `markup` +macro and also gets a `make-with-red-markup` convenience function. Also contains commits: @@ -19,7 +19,7 @@ -Parser: let `assignment_id' return a symbol +Parser: let `assignment_id` return a symbol That's actually what's needed rather than a string. - **status**: Started --> Verified - **Patch**: needs_work --> - **Type**: --> Enhancement --- ** [issues:#5167] Allow defining markup commands in LilyPond syntax** **Status:** Verified **Labels:** Fixed_2_19_80 **Created:** Fri Jul 28, 2017 06:55 PM UTC by David Kastrup **Last Updated:** Mon Feb 17, 2020 10:22 AM UTC **Owner:** David Kastrup Allow defining markup commands in LilyPond syntax This works with assignments of the form \markup with-red = \markup \with-color #red \etc or similar. The resulting definition (in addition to being available as `\with-red` command inside of markups) can be used with the `markup` macro and also gets a `make-with-red-markup` convenience function. Also contains commits: markup-partial regtest: use \markup function assignment Changes: show \markup xxx = ... \etc assignments Parser: let `assignment_id` return a symbol That's actually what's needed rather than a string. Split off `markup-lambda' from `define-markup-command' Also markup-list-lambda from define-markup-list-command. Let `make-markup' fetch the signature itself Also don't export it from markup-macros.scm: it is an internal function. Reorganize markup commands to use object properties This loosens the ties between the actual markup function and its calling methods. http://codereview.appspot.com/324140043 --- Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is subscribed to https://sourceforge.net/p/testlilyissues/issues/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Testlilyissues-auto mailing list testlilyissues-a...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5167 Allow defining markup commands in LilyPond syntax
2020-02-17
Thread
Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
Patch doesn't apply - probably needs a rebase? --- ** [issues:#5167] Allow defining markup commands in LilyPond syntax** **Status:** Started **Created:** Fri Jul 28, 2017 06:55 PM UTC by David Kastrup **Last Updated:** Sun Feb 16, 2020 08:35 PM UTC **Owner:** David Kastrup Allow defining markup commands in LilyPond syntax This works with assignments of the form \markup with-red = \markup \with-color #red \etc or similar. The resulting definition (in addition to being available as \with-red command inside of markups) can be used with the `markup' macro and also gets a `make-with-red-markup' convenience function. Also contains commits: markup-partial regtest: use \markup function assignment Changes: show \markup xxx = ... \etc assignments Parser: let `assignment_id' return a symbol That's actually what's needed rather than a string. Split off `markup-lambda' from `define-markup-command' Also markup-list-lambda from define-markup-list-command. Let `make-markup' fetch the signature itself Also don't export it from markup-macros.scm: it is an internal function. Reorganize markup commands to use object properties This loosens the ties between the actual markup function and its calling methods. http://codereview.appspot.com/324140043 --- Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is subscribed to https://sourceforge.net/p/testlilyissues/issues/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Testlilyissues-auto mailing list testlilyissues-a...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5167 Allow defining markup commands in LilyPond syntax
2020-02-17
Thread
Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
- **Needs**: --> - **Patch**: new --> needs_work - **Type**: --> --- ** [issues:#5167] Allow defining markup commands in LilyPond syntax** **Status:** Started **Created:** Fri Jul 28, 2017 06:55 PM UTC by David Kastrup **Last Updated:** Mon Feb 17, 2020 09:47 AM UTC **Owner:** David Kastrup Allow defining markup commands in LilyPond syntax This works with assignments of the form \markup with-red = \markup \with-color #red \etc or similar. The resulting definition (in addition to being available as \with-red command inside of markups) can be used with the `markup' macro and also gets a `make-with-red-markup' convenience function. Also contains commits: markup-partial regtest: use \markup function assignment Changes: show \markup xxx = ... \etc assignments Parser: let `assignment_id' return a symbol That's actually what's needed rather than a string. Split off `markup-lambda' from `define-markup-command' Also markup-list-lambda from define-markup-list-command. Let `make-markup' fetch the signature itself Also don't export it from markup-macros.scm: it is an internal function. Reorganize markup commands to use object properties This loosens the ties between the actual markup function and its calling methods. http://codereview.appspot.com/324140043 --- Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is subscribed to https://sourceforge.net/p/testlilyissues/issues/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Testlilyissues-auto mailing list testlilyissues-a...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5167 Allow defining markup commands in LilyPond syntax
2020-02-16
Thread
Auto mailings of changes to Lily Issues via Testlilyissues-auto via Automated messages for lilypond development
Simplify define-markup-[list-]command-internal, This reverts additions made in commit d2199b0163c33bcb7504c87e57eefbea93e08c88 "Issue 5167/3: Split off `markup-lambda' from `define-markup-command'" In this commit, extra support for the case where command-and-args is empty was added, ie. - (let* ((command (car command-and-args)) - (args (cdr command-and-args)) + (let* ((command (if (pair? command-and-args) + (car command-and-args) + command-and-args)) + (args (and (pair? command-and-args) (cdr command-and-args))) However, markup commands are functions that are always called with arguments 'layout' and 'props', so there can never be a case that 'args' would be empty. https://codereview.appspot.com/545590045 --- ** [issues:#5167] Allow defining markup commands in LilyPond syntax** **Status:** Started **Created:** Fri Jul 28, 2017 06:55 PM UTC by David Kastrup **Last Updated:** Sun Feb 16, 2020 08:35 PM UTC **Owner:** David Kastrup Allow defining markup commands in LilyPond syntax This works with assignments of the form \markup with-red = \markup \with-color #red \etc or similar. The resulting definition (in addition to being available as \with-red command inside of markups) can be used with the `markup' macro and also gets a `make-with-red-markup' convenience function. Also contains commits: markup-partial regtest: use \markup function assignment Changes: show \markup xxx = ... \etc assignments Parser: let `assignment_id' return a symbol That's actually what's needed rather than a string. Split off `markup-lambda' from `define-markup-command' Also markup-list-lambda from define-markup-list-command. Let `make-markup' fetch the signature itself Also don't export it from markup-macros.scm: it is an internal function. Reorganize markup commands to use object properties This loosens the ties between the actual markup function and its calling methods. http://codereview.appspot.com/324140043 --- Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is subscribed to https://sourceforge.net/p/testlilyissues/issues/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.___ Testlilyissues-auto mailing list testlilyissues-a...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5167 Allow defining markup commands in LilyPond syntax
- **labels**: Fixed_2_19_66 --> Fixed_2_19_80 - **status**: Fixed --> Verified --- ** [issues:#5167] Allow defining markup commands in LilyPond syntax** **Status:** Verified **Labels:** Fixed_2_19_80 **Created:** Fri Jul 28, 2017 06:55 PM UTC by David Kastrup **Last Updated:** Tue Aug 08, 2017 07:10 AM UTC **Owner:** David Kastrup Allow defining markup commands in LilyPond syntax This works with assignments of the form \markup with-red = \markup \with-color #red \etc or similar. The resulting definition (in addition to being available as \with-red command inside of markups) can be used with the `markup' macro and also gets a `make-with-red-markup' convenience function. Also contains commits: markup-partial regtest: use \markup function assignment Changes: show \markup xxx = ... \etc assignments Parser: let `assignment_id' return a symbol That's actually what's needed rather than a string. Split off `markup-lambda' from `define-markup-command' Also markup-list-lambda from define-markup-list-command. Let `make-markup' fetch the signature itself Also don't export it from markup-macros.scm: it is an internal function. Reorganize markup commands to use object properties This loosens the ties between the actual markup function and its calling methods. http://codereview.appspot.com/324140043 --- Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is subscribed to https://sourceforge.net/p/testlilyissues/issues/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Testlilyissues-auto mailing list testlilyissues-a...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5167 Allow defining markup commands in LilyPond syntax
- **Patch**: review --> countdown - **Comment**: Patch on countdown for August 4th --- ** [issues:#5167] Allow defining markup commands in LilyPond syntax** **Status:** Started **Created:** Fri Jul 28, 2017 06:55 PM UTC by David Kastrup **Last Updated:** Sat Jul 29, 2017 12:34 PM UTC **Owner:** David Kastrup Allow defining markup commands in LilyPond syntax This works with assignments of the form \markup with-red = \markup \with-color #red \etc or similar. The resulting definition (in addition to being available as \with-red command inside of markups) can be used with the `markup' macro and also gets a `make-with-red-markup' convenience function. Also contains commits: markup-partial regtest: use \markup function assignment Changes: show \markup xxx = ... \etc assignments Parser: let `assignment_id' return a symbol That's actually what's needed rather than a string. Split off `markup-lambda' from `define-markup-command' Also markup-list-lambda from define-markup-list-command. Let `make-markup' fetch the signature itself Also don't export it from markup-macros.scm: it is an internal function. Reorganize markup commands to use object properties This loosens the ties between the actual markup function and its calling methods. http://codereview.appspot.com/324140043 --- Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is subscribed to https://sourceforge.net/p/testlilyissues/issues/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Testlilyissues-auto mailing list testlilyissues-a...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5167 Allow defining markup commands in LilyPond syntax
- Description has changed: Diff: - **Needs**: --> - **Patch**: new --> review - **Comment**: Passes make, make check and a full make doc. --- ** [issues:#5167] Allow defining markup commands in LilyPond syntax** **Status:** Started **Created:** Fri Jul 28, 2017 06:55 PM UTC by David Kastrup **Last Updated:** Fri Jul 28, 2017 06:55 PM UTC **Owner:** David Kastrup Allow defining markup commands in LilyPond syntax This works with assignments of the form \markup with-red = \markup \with-color #red \etc or similar. The resulting definition (in addition to being available as \with-red command inside of markups) can be used with the `markup' macro and also gets a `make-with-red-markup' convenience function. Also contains commits: markup-partial regtest: use \markup function assignment Changes: show \markup xxx = ... \etc assignments Parser: let `assignment_id' return a symbol That's actually what's needed rather than a string. Split off `markup-lambda' from `define-markup-command' Also markup-list-lambda from define-markup-list-command. Let `make-markup' fetch the signature itself Also don't export it from markup-macros.scm: it is an internal function. Reorganize markup commands to use object properties This loosens the ties between the actual markup function and its calling methods. http://codereview.appspot.com/324140043 --- Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is subscribed to https://sourceforge.net/p/testlilyissues/issues/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Testlilyissues-auto mailing list testlilyissues-a...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto
[Lilypond-auto] [LilyIssues-auto] [testlilyissues:issues] #5167 Allow defining markup commands in LilyPond syntax
--- ** [issues:#5167] Allow defining markup commands in LilyPond syntax** **Status:** Started **Created:** Fri Jul 28, 2017 06:55 PM UTC by David Kastrup **Last Updated:** Fri Jul 28, 2017 06:55 PM UTC **Owner:** nobody Allow defining markup commands in LilyPond syntax This works with assignments of the form \markup with-red = \markup \with-color #red \etc or similar. The resulting definition (in addition to being available as \with-red command inside of markups) can be used with the `markup' macro and also gets a `make-with-red-markup' convenience function. Also contains commits: markup-partial regtest: use \markup function assignment Changes: show \markup xxx = ... \etc assignments Parser: let `assignment_id' return a symbol That's actually what's needed rather than a string. Split off `markup-lambda' from `define-markup-command' Also markup-list-lambda from define-markup-list-command. Let `make-markup' fetch the signature itself Also don't export it from markup-macros.scm: it is an internal function. Reorganize markup commands to use object properties This loosens the ties between the actual markup function and its calling methods. http://codereview.appspot.com/324140043 --- Sent from sourceforge.net because testlilyissues-a...@lists.sourceforge.net is subscribed to https://sourceforge.net/p/testlilyissues/issues/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/testlilyissues/admin/issues/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.-- Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot___ Testlilyissues-auto mailing list testlilyissues-a...@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/testlilyissues-auto