Re: [PATCH] Docs: Update default stylesheets
LGTM Trevor - Original Message - From: Patrick McCarty [EMAIL PROTECTED] To: Reinhold Kainhofer [EMAIL PROTECTED] Cc: lilypond-devel@gnu.org; Trevor Daniels [EMAIL PROTECTED]; till Rettig [EMAIL PROTECTED] Sent: Thursday, November 20, 2008 8:57 PM Subject: Re: [PATCH] Docs: Update default stylesheets On Thu, Nov 20, 2008 at 3:19 AM, Reinhold Kainhofer [EMAIL PROTECTED] wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am Donnerstag, 20. November 2008 schrieb Trevor Daniels: till Rettig wrote Thursday, November 20, 2008 7:25 AM Hi, nice work! I like the new green navigation bar! But again, I prefer ther warmer beige of the old contents box. :-) I agree with both these comments, but I prefer the tighter spacing of the contents list in the new one. Me too. My feeling with the new style is that now the page looks green all over, while the old style (the one in git and thus currently on kainhofer.com/~lilypond) was basically a plain style with some green elements, indicating importance. Thanks for your feedback! I have been so focused on making the design accessible, that I have not been paying as much attention to the colors most people like or don't like. Since I have decided to use almost-black colors for the links in the navigation bars and table of contents, there isn't a need to worry about the background colors being too dark. The only background colors that need to be lighter are the footer, language selection, and warning box, since they use blue links. See what you think of this design (compared to the current one): http://www.uoregon.edu/~pmccarty/texi2html/lilypond-index.html http://kainhofer.com/~lilypond/Documentation/user/lilypond/index.html I won't post another patch until we reach more of a consensus (or compromise). Thanks, Patrick ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
[PATCH] Fix for broken examples in section about explicit vertical positioning
Hi,
in the Documentation section about explicit vertical positioning, the
four examples have too many measures per line. This makes the lines
break in a funny way and garbles the examples quite a lot (see
http://tinyurl.com/expl-vert-spacing). Although I thought I knew a bit
about vertical spacing, it took me quite a while to connect the
pictures to the text while reading this section (actually, I had to
look at the code before it made sense). I suggest reducing the number
of measures from 6 to 5 per line so that there are no unintended line
breaks. Corresponding patches against master are attached (for the
English and Spanish version separately, in case the latter is somehow
automatically generated from the former).
Cheers,
Max
From 9cc0cbef69c4227127371f6d8e65946ed6a8889f Mon Sep 17 00:00:00 2001
From: Maximilian Albert [EMAIL PROTECTED]
Date: Fri, 21 Nov 2008 10:43:05 +0100
Subject: [PATCH] Examples for vertical spacing: Reduce number of measures per line so that they don't break due to the short line length
---
Documentation/user/spacing.itely | 42 +++---
1 files changed, 21 insertions(+), 21 deletions(-)
diff --git a/Documentation/user/spacing.itely b/Documentation/user/spacing.itely
index baabf80..349eabd 100644
--- a/Documentation/user/spacing.itely
+++ b/Documentation/user/spacing.itely
@@ -1507,14 +1507,14 @@ by looking at an example that includes no overrides at all.
\new Score
\new Staff
\new Voice {
- s1 * 6 \break
- s1 * 6 \break
- s1 * 6 \break
+ s1 * 5 \break
+ s1 * 5 \break
+ s1 * 5 \break
}
-\new Voice { \repeat unfold 18 { c'4 c'4 c'4 c'4 } }
+\new Voice { \repeat unfold 15 { c'4 c'4 c'4 c'4 } }
\new Staff {
-\repeat unfold 18 { d'4 d'4 d'4 d'4 }
+\repeat unfold 15 { d'4 d'4 d'4 d'4 }
}
@end lilypond
@@ -1536,18 +1536,18 @@ attribute of the @code{NonMusicalPaperColumn} grob:
\new Voice {
\overrideProperty #Score.NonMusicalPaperColumn
#'line-break-system-details #'((Y-offset . 0))
- s1 * 6 \break
+ s1 * 5 \break
\overrideProperty #Score.NonMusicalPaperColumn
#'line-break-system-details #'((Y-offset . 40))
- s1 * 6 \break
+ s1 * 5 \break
\overrideProperty #Score.NonMusicalPaperColumn
#'line-break-system-details #'((Y-offset . 80))
- s1 * 6 \break
+ s1 * 5 \break
}
-\new Voice { \repeat unfold 18 { c'4 c'4 c'4 c'4 } }
+\new Voice { \repeat unfold 15 { c'4 c'4 c'4 c'4 } }
\new Staff {
-\repeat unfold 18 { d'4 d'4 d'4 d'4 }
+\repeat unfold 15 { d'4 d'4 d'4 d'4 }
}
@end lilypond
@@ -1569,20 +1569,20 @@ subproperty of @code{line-break-system-details}.
\overrideProperty #Score.NonMusicalPaperColumn
#'line-break-system-details #'((Y-offset . 20)
(alignment-offsets . (0 -15)))
- s1 * 6 \break
+ s1 * 5 \break
\overrideProperty #Score.NonMusicalPaperColumn
#'line-break-system-details #'((Y-offset . 60)
(alignment-offsets . (0 -15)))
- s1 * 6 \break
+ s1 * 5 \break
\overrideProperty #Score.NonMusicalPaperColumn
#'line-break-system-details #'((Y-offset . 100)
(alignment-offsets . (0 -15)))
- s1 * 6 \break
+ s1 * 5 \break
}
-\new Voice { \repeat unfold 18 { c'4 c'4 c'4 c'4 } }
+\new Voice { \repeat unfold 15 { c'4 c'4 c'4 c'4 } }
\new Staff {
-\repeat unfold 18 { d'4 d'4 d'4 d'4 }
+\repeat unfold 15 { d'4 d'4 d'4 d'4 }
}
@end lilypond
@@ -1604,24 +1604,24 @@ specifies the vertical positioning of staves but not of staff groups.
\overrideProperty #Score.NonMusicalPaperColumn
#'line-break-system-details #'((Y-offset . 0)
(alignment-offsets . (0 -30 -40)))
- s1 * 6 \break
+ s1 * 5 \break
\overrideProperty #Score.NonMusicalPaperColumn
#'line-break-system-details #'((Y-offset . 60)
(alignment-offsets . (0 -10 -20)))
- s1 * 6 \break
+ s1 * 5 \break
\overrideProperty #Score.NonMusicalPaperColumn
#'line-break-system-details #'((Y-offset . 100)
(alignment-offsets . (0 -10, -40)))
- s1 * 6 \break
+ s1 * 5 \break
}
-\new Voice { \repeat unfold 18 { c'4 c'4 c'4 c'4 } }
+\new Voice { \repeat unfold 15 { c'4 c'4 c'4 c'4 } }
\new StaffGroup
\new Staff {
- \repeat unfold 18 { d'4 d'4 d'4 d'4 }
+ \repeat unfold 15 { d'4 d'4 d'4 d'4 }
}
\new Staff {
- \repeat unfold 18 { e'4 e'4 e'4 e'4 }
+ \repeat unfold 15 { e'4 e'4 e'4 e'4 }
}
--
1.5.4.3
From e4cc73ed87b31b0039540e1887acb41fe3bb353b Mon Sep 17 00:00:00 2001
From: Maximilian Albert [EMAIL PROTECTED]
Date: Fri, 21 Nov 2008 10:49:47 +0100
Subject: [PATCH] Also reduce number of measures in spacing examples in Spanish version
---
Documentation/es/user/spacing.itely | 42 +-
1 files changed, 21
gregorian notation
Hi, I like lilypond very much and use it for writing scores for my choir. I would love to use it for gregorian (square) notation also, but for this lilypond output is simply not satisfiable. It is obvious from examle given in current documentation: http://lilypond.org/doc/v2.11/Documentation/user/lilypond-big-page#Ancient-notation. Comparing with Ideas of lilypond essay http://lilypond.org/web/about/automated-engraving/ there is a big contradiction. There are many issues, as discussed already few times, for example here: http://lists.gnu.org/archive/html/lilypond-devel/2006-03/msg00224.html The main issue IMO is spacing. As Juergen Reuter 32 months ago writes: Right, horizontal spacing is a known issue in Gregorian chant notation in Lily. It has been discussed in the past more than once, though without finding a good and easy-to-implement solution. I can believe, it is not easy at all, but I would like to find a way how to change/improve it. I could offer my time (some little part of it), some amount of money, my knowledge in this area (gregorian chant)... Maybe I could do some coding also, but I don't know python yet and because of complexity of the problem it would definitely require some leading. Where to begin? Marek Klein http://gregoriana.sk ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
[Scheme] Few basics...
Scheme hackers, following simple code extract: (define testlist (list 0 1 2 3 4 5 6 7)) (define (addlist i nr) (cons (list-ref testlist i) (if (= (+ i 1) nr) '() (addlist (+ i 1) nr))) ) (display (addlist 0 3)) The procedure addlist returns all list elements up to the element before that whose index is given through the second argument. I. The source list is now defined globally. How can I pass it to the procedure addlist without carrying it along through all instances of the recursion? II. I assume also the index number (nr) doesn't has to be passed to addlist every recursion stage. How to achieve this? I'd be happy about any advice! Cheers, Michael ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
correct usage of @funindex and friends
Folks, in the manual I often see both [EMAIL PROTECTED] foo' and [EMAIL PROTECTED] \foo'. IMHO, one of those forms is redundant. Which one? I'll walk over all such index entries and fix it accordingly, but I ask you to decide which form is the right one. Werner ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: correct usage of @funindex and friends
Hi Werner, On Fri, Nov 21, 2008 at 2:07 AM, Werner LEMBERG [EMAIL PROTECTED] wrote: in the manual I often see both [EMAIL PROTECTED] foo' and [EMAIL PROTECTED] \foo'. IMHO, one of those forms is redundant. Which one? I'll walk over all such index entries and fix it accordingly, but I ask you to decide which form is the right one. I think the [EMAIL PROTECTED] foo' form is redundant, since the actual function/command names always begin with a backslash. However, I think it would be acceptable to use [EMAIL PROTECTED] foo' as well as the [EMAIL PROTECTED] \foo'. -Patrick ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: [PATCH] Fix for broken examples in section about explicit vertical positioning
Hi Max,
2008/11/21 Maximilian Albert [EMAIL PROTECTED]:
Hi,
in the Documentation section about explicit vertical positioning, the
four examples have too many measures per line. This makes the lines
break in a funny way and garbles the examples quite a lot (see
http://tinyurl.com/expl-vert-spacing). Although I thought I knew a bit
about vertical spacing, it took me quite a while to connect the
pictures to the text while reading this section (actually, I had to
look at the code before it made sense). I suggest reducing the number
of measures from 6 to 5 per line so that there are no unintended line
breaks. Corresponding patches against master are attached (for the
English and Spanish version separately, in case the latter is somehow
automatically generated from the former).
Thanks for the patch; it's a definite improvement. :)
Unfortunately, that's just the start of what's wrong with these
examples; they're designed to show explicit spacing in a page, but
you've probably noticed that they show almost identical spacing
between systems. The only way around this is to enclose each example
in \book { }. Therefore, I've applied your patch together with the
following changes:
1. use \book { } to maintain the correct spacing in each example;
2. remove ragged-right from fragment options;
3. remove tagline: this tidies up the empty space below the last
system when using \book (though not in the pdf, regrettably);
4. change left-margin to zero so that the examples don't appear too
far to the right in pdf.
Attached is the third snippet using the new settings, demonstrating
the correct spacing.
Cheers,
Neil
attachment: lily-5e516a13.png___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: correct usage of @funindex and friends
On Fri, Nov 21, 2008 at 11:07:29AM +0100, Werner LEMBERG wrote: in the manual I often see both [EMAIL PROTECTED] foo' and [EMAIL PROTECTED] \foo'. IMHO, one of those forms is redundant. Which one? I'll walk over all such index entries and fix it accordingly, but I ask you to decide which form is the right one. See discussion here: http://lists.gnu.org/archive/html/lilypond-user/2008-08/msg00063.html The answer appears to be both. I don't think that's optimal, but people didn't seem to like the \command style only. :( Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: [Scheme] Few basics...
Scheme hackers, [..] I am far from a Scheme hacker, and i cannot certify that is good programmation, but the following seems to work. ; (define (addlist i nr) (let ((local-list (list 0 1 2 3 4 5 6 7))) (define (local-addlist i) (cons (list-ref local-list i) (if (= (+ i 1) nr) '() (local-addlist (+ i 1) (local-addlist i) )) (display (addlist 0 6)) ;;; Is it what you wanted ? Gilles ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: [Scheme] Few basics...
On Fri, Nov 21, 2008 at 4:46 PM, Michael Käppler [EMAIL PROTECTED] wrote:
Scheme hackers,
following simple code extract:
(define testlist (list 0 1 2 3 4 5 6 7))
(define (addlist i nr)
(cons (list-ref testlist i) (if (= (+ i 1) nr) '() (addlist (+ i 1) nr)))
)
(display (addlist 0 3))
The procedure addlist returns all list elements up to the element before
that whose index is given through the second argument.
I think you should look into the srfi-1 library. Also,
guile (help list-head)
`list-head' is a primitive procedure in the (guile) module.
c snarfed from list.c:491
@deffn {Scheme Procedure} list-head lst k
Copy the first @var{k} elements from @var{lst} into a new list, and
return it.
@end deffn
Iwould probably write something like
(define (take lst n)
(define (helper lst acc n)
(if (or (=? 0 n) (null? lst))
acc (helper (cdr lst) (cons lst acc) (1- n
(reverse (helper lst '() n)))
--
Han-Wen Nienhuys - [EMAIL PROTECTED] - http://www.xs4all.nl/~hanwen
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
[PATCH] Tweakable kerning for percent repeat glyphs
Hello, Please go here to review this: http://codereview.appspot.com/9457/show Also, here are two other patches which you might have missed: Nested properties in list form when using \override (http://codereview.appspot.com/7765/show) Fix DynamicTextSpanner alignment issues (http://codereview.appspot.com/7763/show) Cheers, Neil ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
More tweakable percent repeat glyphs.
Reviewers: Neil Puttock, Message: LGTM Description: More tweakable percent repeat glyphs. - use grob properties for dot_neg_kern and slash_neg_kern. Please review this at http://codereview.appspot.com/9457 Affected files: A input/regression/repeat-percent-kerning.ly M lily/include/percent-repeat-item.hh M lily/multi-measure-rest.cc M lily/percent-repeat-item.cc M scm/define-grob-interfaces.scm M scm/define-grob-properties.scm M scm/define-grobs.scm ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
* Allow for nested properties in list form when using \override.
Reviewers: Neil Puttock,
Message:
LGTM
Description:
* Allow for nested properties in list form when using \override.
This patch provides a convenient way of overriding nested properties,
matching the syntax available when using \revert, e.g.,
\override DynamicTextSpanner #'(bound-details left text) = #foo
Please review this at http://codereview.appspot.com/7765
Affected files:
A input/regression/property-nested-override.ly
M scm/ly-syntax-constructors.scm
Index: input/regression/property-nested-override.ly
diff --git a/input/regression/property-nested-override.ly
b/input/regression/property-nested-override.ly
new file mode 100644
index
..16028b7a17391b4747a5538be8548602929d7626
--- /dev/null
+++ b/input/regression/property-nested-override.ly
@@ -0,0 +1,20 @@
+\version 2.11.64
+\header {
+ texidoc = Nested properties may be overridden using Scheme list
+syntax. This test performs two property overrides: the first
+measure uses standard @code{\\override} syntax; the second uses a
+list.
+
+}
+
+\relative c' {
+ \once \override TextSpanner #'bound-details #'left #'text = #foo
+ c4\startTextSpan
+ \once \override Tie #'details #'note-head-gap = #1
+ c4 ~ c c\stopTextSpan
+
+ \once \override TextSpanner #'(bound-details left text) = #foo
+ c4\startTextSpan
+ \once \override Tie #'(details note-head-gap) = #1
+ c4 ~ c c\stopTextSpan
+}
Index: scm/ly-syntax-constructors.scm
diff --git a/scm/ly-syntax-constructors.scm b/scm/ly-syntax-constructors.scm
index
584dd6b3e17943623010c56e969c406ca94d3674..ee798233611a6a65361f1fae414962848a9f3cfa
100644
--- a/scm/ly-syntax-constructors.scm
+++ b/scm/ly-syntax-constructors.scm
@@ -143,7 +143,9 @@
((PropertySet) (list 'value (car args)))
((PropertyUnset) '())
((OverrideProperty) (list 'grob-value (car args)
- 'grob-property-path (cdr args)
+ 'grob-property-path (if (list?
(cadr args))
+ (cadr args)
+ (cdr args))
'pop-first #t))
((RevertProperty)
(if (list? (car args))
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: [PATCH] Tweakable kerning for percent repeat glyphs
Hi Neil, On Fri, Nov 21, 2008 at 5:27 PM, Neil Puttock [EMAIL PROTECTED] wrote: Please go here to review this: http://codereview.appspot.com/9457/show Also, here are two other patches which you might have missed: Nested properties in list form when using \override (http://codereview.appspot.com/7765/show) Fix DynamicTextSpanner alignment issues (http://codereview.appspot.com/7763/show) Have you been able to find a solution for the conversions in your first patch? http://codereview.appspot.com/5889/show I don't have any comments for you, but I still see the warnings whenever I compile LilyPond. Thanks, Patrick ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
