Re: Page turn breaking blank pages

[Nicolas Sceaux]

Le 14 déc. 08 à 21:12, Joe Neeman a écrit :


This gives good results, however,
the page-turn page breaking algorithm adds blank pages at some  
places,

for instance, just before the last page of a bookpart, which gives an
awkward result:
 _4_  _5__6_  _7__8_
|===||===|  |===||   |  |===|  (then the beginning of the next part  
on

|===||===|  |===||   |  |===|  the following odd page)
|===||===|  |===||   |  |===|
 ---  ------  ------


This is awkward not just because of bookparts, right? If these four
pages were the whole book, you would also want to avoid the blank  
page.
Can you check that the blank page is there if this is the whole book  
(it

should be, because the page breaker shouldn't see anything different)?


Indeed. Here is an example demonstrating this behavior:
  
  
Two consecutive odd pages are left blanck.


Do you really need both chunks? I would expect the second chunk to be
enough since it disables all inserting of blank pages.


[patch]


The two chunks were needed, with the second one only the algorithm
seemed to confuse odd and even pages, and sometimes would place nice
page turns between even and odd pages, and not so nice ones between
odd and even pages (unless I messed up my tests of course.) Anyway
the results seemed different.

Nicolas



___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

[PATCHES] Single thick barline; order of alterations in Staff.keySignature

[Reinhold Kainhofer]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Please review the following two patches:

1) About the single thick barlines and the current \bar "." style (which 
produces a single centered dot). Unless someone has a good reason, I propose 
to use \bar "." for a thick bar line instead and drop the single centered dot 
altogether (or shall we add a \bar "dot" style?). Patch is here:
http://codereview.appspot.com/11044


2) The Staff.keySignature alist contains the alterations of the current key 
signature in reversed order, so manually setting it of non-standard key 
signatures is a bit confusing (you have to give the reverse order). This patch 
makes Lilypond store the alterations in their real order:
http://codereview.appspot.com/8686
(See also the short thread on Nov 30, and Dec 9)

Cheers,
Reinhold
- -- 
- --
Reinhold Kainhofer, reinh...@kainhofer.com, http://reinhold.kainhofer.com/
 * Financial & Actuarial Math., Vienna Univ. of Technology, Austria
 * http://www.fam.tuwien.ac.at/, DVR: 0005886
 * LilyPond, Music typesetting, http://www.lilypond.org
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (GNU/Linux)

iD8DBQFJUNetTqjEwhXvPN0RAmXZAKCSigUU4D1YqA4gpktv//ekuZIU1QCgxnpb
GKUI8Nq8lAxMVlweR1D0hcw=
=sj8Y
-END PGP SIGNATURE-


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Patch for stylesheets

[Reinhold Kainhofer]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Am Dienstag, 23. Dezember 2008 05:01:39 schrieb Patrick McCarty:
> Is this better for you, Till?  Does anyone else have any more
> comments?

The only thing that is bothering me is the color of visited links in the TOC 
on the left. The different colors for visited and non-visited links visually 
clutter the TOC a lot, so I would prefer to use the same color for visited and 
non-visited links...

Cheers,
Reinhold
- -- 
- --
Reinhold Kainhofer, reinh...@kainhofer.com, http://reinhold.kainhofer.com/
 * Financial & Actuarial Math., Vienna Univ. of Technology, Austria
 * http://www.fam.tuwien.ac.at/, DVR: 0005886
 * LilyPond, Music typesetting, http://www.lilypond.org
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.9 (GNU/Linux)

iD8DBQFJUNj+TqjEwhXvPN0RApLKAJ9oQNpf4l66h+qR+S6l8/gcz+EB9gCghoV4
Hi156dNGACGgT+d7EEWTyuM=
=2v7h
-END PGP SIGNATURE-


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: [PATCHES] Single thick barline; order of alterations in Staff.keySignature

[Werner LEMBERG]

> Please review the following two patches:
> 
> 1) About the single thick barlines and the current \bar "." style
> (which produces a single centered dot). Unless someone has a good
> reason, I propose to use \bar "." for a thick bar line instead and
> drop the single centered dot altogether (or shall we add a \bar
> "dot" style?).  Patch is here:
>
> http://codereview.appspot.com/11044
> 
> 
> 2) The Staff.keySignature alist contains the alterations of the
> current key signature in reversed order, so manually setting it of
> non-standard key signatures is a bit confusing (you have to give the
> reverse order).  This patch makes Lilypond store the alterations in
> their real order:
>
> http://codereview.appspot.com/8686

I support both, and the code looks fine too (however, I'm no expert
here).


Werner


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

* use correct left to right ordering in keySignature list

[hanwenn]

Reviewers: Reinhold,

Message:
Shouldn't there be changes in other files to correspond? (do we have a
regtest?)

Description:
* use correct left to right ordering in keySignature list
The keySignature property list of the KeySignature so far was using
reversed order (e.g. the rightmost accidental came first). This was
quite confusing when manually setting non-standard key signatures like
  \set Staff.keySignature = #`(((0 . 3) . ,SHARP)
   ((0 . 5) . ,FLAT)
   ((0 . 6) . ,FLAT))
In this example, you'll get bes, as, fis in that reversed order rather
than
in the order in which you list the alterations.

Please review this at http://codereview.appspot.com/8686

Affected files:
  M lily/key-engraver.cc


Index: lily/key-engraver.cc
diff --git a/lily/key-engraver.cc b/lily/key-engraver.cc
index  
d3b7eb01ddada1c2d00b7888fef88ee16ed88eb7..3f9dc02c1c9d40de7732bc2c569b7e65ec7ab73a  
100644

--- a/lily/key-engraver.cc
+++ b/lily/key-engraver.cc
@@ -93,13 +93,13 @@ Key_engraver::create_key (bool is_default)
 key_event_
 ? key_event_->self_scm () : SCM_EOL);

- cancellation_->set_property ("alteration-alist", restore);
+	  cancellation_->set_property ("alteration-alist", scm_reverse  
(restore));

  cancellation_->set_property ("c0-position",
   get_property ("middleCPosition"));
}
}

-  item_->set_property ("alteration-alist", key);
+  item_->set_property ("alteration-alist", scm_reverse (key));
 }

   if (!is_default)
@@ -189,7 +189,7 @@ Key_engraver::read_event (Stream_event const *r)
r->origin ()->warning ("No ordering for key signature alterations");
 }

-  context ()->set_property ("keySignature", accs);
+  context ()->set_property ("keySignature", scm_reverse (accs));
   context ()->set_property ("tonic",
r->get_property ("tonic"));
 }




___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Implement thick bar lines (use \bar "." for this)

[hanwenn]

Reviewers: Reinhold,

Message:
LGTM

missing documentation, and regtest though

Description:
Implement thick bar lines (use \bar "." for this)
Until now, \bar"." produced a single dot instead of the bar line, which
was however not used anywhere and also not documented...
Using "." for the bar line style is consistent with other types like
".|" or "|.", where a | indicates a think line and . indicates a thick
line.

Please review this at http://codereview.appspot.com/11044

Affected files:
  M lily/bar-line.cc


Index: lily/bar-line.cc
diff --git a/lily/bar-line.cc b/lily/bar-line.cc
index  
df97638dba6b9faa9f43e95d1780454e35d0a5c7..0013b189615564142e768aeda0cc9127e72ae011  
100644

--- a/lily/bar-line.cc
+++ b/lily/bar-line.cc
@@ -116,6 +116,11 @@ Bar_line::compound_barline (Grob *me, string str, Real  
h,

   thin.translate_axis (center, Y_AXIS);
   return thin;
 }
+  else if (str == ".")
+{
+  thick.translate_axis (center, Y_AXIS);
+  return thick;
+}
   else if (str == "|." || (h == 0 && str == ":|"))
 {
   m.add_at_edge (X_AXIS, LEFT, thick, 0);
@@ -198,10 +203,6 @@ Bar_line::compound_barline (Grob *me, string str, Real  
h,

 {
   m = dashed_bar_line (me, h, hair);
 }
-  else if (str == ".")
-{
-  m = dot;
-}

   m.translate_axis (center, Y_AXIS);
   return m;




___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Patch for stylesheets

[Patrick McCarty]

On Tue, Dec 23, 2008 at 4:26 AM, Reinhold Kainhofer
 wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> Am Dienstag, 23. Dezember 2008 05:01:39 schrieb Patrick McCarty:
>> Is this better for you, Till?  Does anyone else have any more
>> comments?
>
> The only thing that is bothering me is the color of visited links in the TOC
> on the left. The different colors for visited and non-visited links visually
> clutter the TOC a lot, so I would prefer to use the same color for visited and
> non-visited links...

Oops...

Last night I accidentally copied the stylesheet from the master branch
instead of my own branch, and I forgot to double check.  :-)

You should see the correct style now.  *This* is the style implemented
by the patch.

http://kainhofer.com/~lilypond/Documentation/user/lilypond/index.html
http://uoregon.edu/~pmccarty/texi2html/lilypond-index.html

Thanks,
Patrick


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Lilypond fails to compile in GCC 4.4 - patch attached

[Daniel Johnson]

GCC 4.4 tends to be extra-picky about explicitly including header
files in C++.  Attached is a patch to resolve the issue.


0001-Add-header-includes-for-GCC-4.4.patch
Description: application/download
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Lilypond fails to compile in GCC 4.4 - patch attached

[Werner LEMBERG]

> GCC 4.4 tends to be extra-picky about explicitly including header
> files in C++.  Attached is a patch to resolve the issue.

Applied, thanks.


Werner


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

2.12 uploaded

[Han-Wen Nienhuys]

Hello,

I have just cut a 2.12.0 release, uploaded it to lilypond.org, and
switched over the redirects to v2.12.

I leave it to anyone interested to pose as the official representative
of the lilypond community and post a release announcement.

-- 
Han-Wen Nienhuys - han...@xs4all.nl - http://www.xs4all.nl/~hanwen


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: 2.12 uploaded

[Graham Percival]

On Wed, Dec 24, 2008 at 12:27:33AM -0200, Han-Wen Nienhuys wrote:
> I have just cut a 2.12.0 release, uploaded it to lilypond.org, and
> switched over the redirects to v2.12.

Yay!  Christmas present for everybody.

> I leave it to anyone interested to pose as the official representative
> of the lilypond community

:)

> and post a release announcement.

Ok, will do in a few hours.

Cheers,
- Graham


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

[patch] new convert-ly rule for 2.12

[Graham Percival]

Whoever is up-to-date on convert-ly (I'm not), please review and
apply.

Cheers,
- Graham
diff --git a/python/convertrules.py b/python/convertrules.py
index f86165c..d431bf6 100644
--- a/python/convertrules.py
+++ b/python/convertrules.py
@@ -2860,6 +2860,12 @@ chord-shape call.\n"))
 raise FatalConversionError ()
 return str
 
+...@rule ((2, 12, 0), "Bump verison for release")
+def conv(str)
+stderr_write ("\n")
+stderr_write (FROM_TO % ("bump version for release.\n"))
+return str
+
 # Guidelines to write rules (please keep this at the end of this file)
 #
 # - keep at most one rule per version; if several conversions should be done,
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: 2.12 uploaded

[Han-Wen Nienhuys]

Note that I also did not update the website accordingly, so you'll
need to update the download page too.

On Wed, Dec 24, 2008 at 1:10 AM, Graham Percival
 wrote:
> On Wed, Dec 24, 2008 at 12:27:33AM -0200, Han-Wen Nienhuys wrote:
>> I have just cut a 2.12.0 release, uploaded it to lilypond.org, and
>> switched over the redirects to v2.12.
>
> Yay!  Christmas present for everybody.
>
>> I leave it to anyone interested to pose as the official representative
>> of the lilypond community
>
> :)
>
>> and post a release announcement.
>
> Ok, will do in a few hours.
>
> Cheers,
> - Graham
>



-- 
Han-Wen Nienhuys - han...@xs4all.nl - http://www.xs4all.nl/~hanwen


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: 2.12 uploaded

[Jonathan Kulp]

Han-Wen Nienhuys wrote:

Hello,

I have just cut a 2.12.0 release, uploaded it to lilypond.org, and
switched over the redirects to v2.12.

I leave it to anyone interested to pose as the official representative
of the lilypond community and post a release announcement.

Congratulations!  I just downloaded and ran my first file with it. 
Thanks for all the work, guys.  It's awesome. :)  Happy holidays,


Jon
--
Jonathan Kulp
http://www.jonathankulp.com


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel