Re: Issue 881 Arpeggios may collide with laissezVibrer ties (was Re: Critical issues)
On 5/14/10 8:18 AM, "Karl Hammar" wrote: > Carl Sorensen: >> On 5/14/10 7:01 AM, "Karl Hammar" wrote: >>> Carl Sorensen: > ... >> You also need to redefine the 'stencil for laissez-vibrez tie in >> scm/define-grobs.scm. > ... > > I can help with doning the regression test. Second-guessing what > Niels patch was about was not included in that offer. > Thanks for your offer. I've posted a patch on Rietveld. Can you do the regression test? Thanks, Carl http://codereview.appspot.com/1195044 ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
lost bug reports (was: Text cresc *without dashed line* and Y-offset)
On Fri, May 14, 2010 at 6:06 PM, Reinhold Kainhofer wrote: > Welcome to the club... I ran into that problem two years ago, and I haven't > yet found a solution: > > http://lists.gnu.org/archive/html/lilypond-user/2008-03/msg00232.html re my last email about temporary bug squad members from 30 seconds ago... make that "I'm aware of 4 lost bug reports / feature requests", not "3". :) Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: temporary bug squad member needed
On Mon, May 10, 2010 at 11:07 AM, Valentin Villenave wrote: > On Mon, May 10, 2010 at 9:42 AM, Trevor Daniels wrote: >> I would have been willing to do this if no one else had >> stepped forward, but Patrick has - thanks Patrick. If you >> lose interest after a while let me know and I'll continue. > > Er, I believe we could use an extra pair of hands anyway. If Graham > doesn't object, I don't see anything wrong with you temporarily > joining the bug squad! Indeed. There's three major tasks: 1) Catch up on old (missing) bug reports. I've found three so far (in April; May looked ok, but I wouldn't swear on it). Do we have all the reports from March, Feb, and Jan? How much do we care if we lose a few bug reports? 2) Check+update Contributing 7 Issues. Does this chapter reflect our current practice? (I haven't checked it recently, so it might be perfect, or it might be completely bogus) Also, my latest thinking about GOP is to phase it in gradually -- first we'll hit up people to tackle "simple tasks" (as defined on the website "help us" page). If a helpful user reads Contributing 7, will they be able to do the job that we expect the Bug Squad to do? For that matter, do we know what we expect the Bug Squad to do? (see previous paragraph) 3) When GOP starts... which might be slightly before 2.14 if we do the "phase in" thing... it would be nice to have experienced bug squad members mentoring the new bug squad members. If this ends up being me, fine, but then I'll delay GOP until I have time to deal with them. If Patrick and/or Trevor was willing to mentor beginning Bug Squad people, that would lift a burden from me, and we could start GOP sooner. Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Issue 881 Arpeggios may collide with laissezVibrer ties (was Re: Critical issues)
Carl Sorensen: > On 5/14/10 7:01 AM, "Karl Hammar" wrote: > > Carl Sorensen: ... > You also need to redefine the 'stencil for laissez-vibrez tie in > scm/define-grobs.scm. ... I can help with doning the regression test. Second-guessing what Niels patch was about was not included in that offer. Regards, /Karl ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Critical issues
On 5/14/10 7:01 AM, "Karl Hammar" wrote: > Carl Sorensen: >> On 5/13/10 1:11 PM, "Karl Hammar" wrote: > ... >> make test-baseline > ... >> make check > ... > > Ok, done that. > > With the guidance from http://code.google.com/p/lilypond/issues/detail?id=881: > > I can't explain why, but making the print function pure by redefining > ly:tie::print > just for LaissezVibrerTie seems to fix this (I haven't done a regtest check, > so it > might end up breaking something else): > > (define-public (laissez-vibrer::print grob) > (ly:tie::print grob)) > > (then add laissez-vibrer::print to pure-print-callbacks) > > I tried this: > > diff --git a/scm/define-grobs.scm b/scm/define-grobs.scm > index 176debd..35186f8 100644 > --- a/scm/define-grobs.scm > +++ b/scm/define-grobs.scm > @@ -2345,8 +2345,12 @@ > (interval-union '(0 . 0) (cons smaller larger))) > '(0 . 0 > > +(define-public (laissez-vibrer::print grob) > + (ly:tie::print grob)) > + >(define pure-print-callbacks > (list > + laissez-vibrer::print > fret-board::calc-stencil > note-head::brew-ez-stencil > print-circled-text-callback > > $ make test-redo > >> out/test-results/index.html >> >> that shows the results of the regression tests. > ... > > I got (except the test-output-distance.ly) an distance of 0300030 and > "HEAD is: 22d889f4d27469864c31db81445e9de49774ae23" to the right and > left plus the git-diff to the rigth. > > So I assume it was the wrong patch try. Does anybody have Neil's > proposed fix available ? You also need to redefine the 'stencil for laissez-vibrez tie in scm/define-grobs.scm. HTH, Carl ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Critical issues
Carl Sorensen: > On 5/13/10 1:11 PM, "Karl Hammar" wrote: ... > make test-baseline ... > make check ... Ok, done that. With the guidance from http://code.google.com/p/lilypond/issues/detail?id=881: I can't explain why, but making the print function pure by redefining ly:tie::print just for LaissezVibrerTie seems to fix this (I haven't done a regtest check, so it might end up breaking something else): (define-public (laissez-vibrer::print grob) (ly:tie::print grob)) (then add laissez-vibrer::print to pure-print-callbacks) I tried this: diff --git a/scm/define-grobs.scm b/scm/define-grobs.scm index 176debd..35186f8 100644 --- a/scm/define-grobs.scm +++ b/scm/define-grobs.scm @@ -2345,8 +2345,12 @@ (interval-union '(0 . 0) (cons smaller larger))) '(0 . 0 +(define-public (laissez-vibrer::print grob) + (ly:tie::print grob)) + (define pure-print-callbacks (list + laissez-vibrer::print fret-board::calc-stencil note-head::brew-ez-stencil print-circled-text-callback $ make test-redo > out/test-results/index.html > > that shows the results of the regression tests. ... I got (except the test-output-distance.ly) an distance of 0300030 and "HEAD is: 22d889f4d27469864c31db81445e9de49774ae23" to the right and left plus the git-diff to the rigth. So I assume it was the wrong patch try. Does anybody have Neil's proposed fix available ? Regards, /Karl Hammar ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
