Re: Experimental support for woff fonts in svg. (issue1428042)

2010-06-07 Thread jan . nieuwenhuizen 

Move to font.scm or backend-library.scm?


Moved to backend-library.scm.  I mistook output-lib to be the
library for output-*.scm but it isn't, thanks.


http://codereview.appspot.com/1428042/show

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Experimental support for woff fonts in svg. (issue1428042)

2010-06-07 Thread jan . nieuwenhuizen 

On 2010/06/06 18:42:05, Patrick McCarty wrote:

http://codereview.appspot.com/1428042/diff/13002/17014
File configure.in (right):



http://codereview.appspot.com/1428042/diff/13002/17014#newcode140
configure.in:140: STEPMAKE_PATH_PROG(FONTFORGE, fontforge, REQUIRED,

20090923)

Is 20090923 actually required?



I didn't want to bump the required fontforge version unless we really

need to.

It had 20050624 and I could not imagine that to work as we have
used GIT versions in GUB for quite some time.
This 2009 version was just an educated guess of what is required,
I'll just revert to 2005 and let the build process barf if FF
is too old.

http://codereview.appspot.com/1428042/show

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Syntax Colourgin in BBEdit and TextWrangler

2010-06-07 Thread josé henrique padovani 

Em 06/06/10 23:41, Han-Wen Nienhuys escreveu:

[+lily-devel]

The list is probably a better place to ask around.

On Sun, Jun 6, 2010 at 3:53 PM, Frans van Dunné  wrote:
   

Dear Han Wen,

I made a preliminary syntax colouring xml available to use BBedit or
TextWrangler available
(http://fransvandunne.com/2010/06/bblily-lilypond-syntax-colouring-for-bbedit/).

It's not really time yet to disseminate amongst the Lilypond users, but I
will keep you posted. It has been my personal wish to have this since 2006
(go figure how long it takes to understand how syntax colouring works).

One special request: is there a list full list of Lilypond keywords and
functions available in XML or asci? Going through the manual and copy
pasting is too much for me.

Can you make the syntax keywords and functions avalaible to me as a list so
I can finish up the syntax colouring?


 
The emacs extension has a file "lilypond-words.el" which lists these 
words... maybe it is easier to copy them from there.


josé

--
http://zepadovani.info


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Documentation Change

2010-06-07 Thread Phillip Koebbe 
In section 2.2.5 TextMate of the Application Usage documentation,
the command for installing the TextMate bundle is given as:

svn co http://macromates.com/svn/Bundles/trunk/Bundles/Lilypond.tmbundle/

That is currently incorrect and will result in a redirection statement
which then results in an error that the bundle does not exist. The
bundle is now hosted on GitHub, and the proper command is:

git clone http://github.com/textmate/lilypond.tmbundle.git

Peace,
Phillip Koebbe
Illinois, USA


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Documentation Change

2010-06-07 Thread Graham Percival 
On Mon, Jun 7, 2010 at 2:49 PM, Phillip Koebbe  wrote:
> In section 2.2.5 TextMate of the Application Usage documentation,

Thanks for this report, but that section has been removed from the
2.13 docs; information about editors will be accessed through the
Easier Editing web page.

Cheers,
- Graham

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

typo in NR 4.4.2 Vertical spacing between systems

2010-06-07 Thread -Eluze 

in the enumeration  of paper block variables top-system-spacing is mentioned
twice.
-- 
View this message in context: 
http://old.nabble.com/typo-in-NR-4.4.2-Vertical-spacing-between-systems-tp28805958p28805958.html
Sent from the Gnu - Lilypond - Dev mailing list archive at Nabble.com.


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: typo in NR 4.4.2 Vertical spacing between systems

2010-06-07 Thread James Lowe 

Thanks, I'll check this and make a patch.

James

-Eluze wrote:

in the enumeration  of paper block variables top-system-spacing is mentioned
twice.


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: typo in NR 4.4.2 Vertical spacing between systems

2010-06-07 Thread James Lowe 

Patch has been applied.

Thanks Eluze.

James

James Lowe wrote:

Thanks, I'll check this and make a patch.

James

-Eluze wrote:
in the enumeration  of paper block variables top-system-spacing is 
mentioned

twice.


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel



___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Experimental support for woff fonts in svg. (issue1428042)

2010-06-07 Thread n . puttock 

Hi Jan,

I've just been testing this patch, and have stumbled upon a problem with
chords.  With this snippet,

\chords {
  c4
}

I get the following error message:

/home/neil/lilypond/out/share/lilypond/current/scm/backend-library.scm:270:23:
In procedure car in expression (car (ly:pango-font-physical-fonts
pango-font)):
/home/neil/lilypond/out/share/lilypond/current/scm/backend-library.scm:270:23:
Wrong type (expecting pair): ()

Cheers,
Neil

http://codereview.appspot.com/1428042/show

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Regression tests

2010-06-07 Thread Carl Sorensen 
On 6/6/10 8:01 AM, "Graham Percival"  wrote:

> 
> I'm seeing too much juggling.  Focus on the Regressions -- dump
> all other info into the CG (anywhere that makes remote sense,
> other than CG 1, 2, and 7).  Don't bother with a patch-review for
> that info-dump.  Then work carefully on Regressions, post a patch,
> etc.

Well, I forgot to split the dump from the rest of the work.  I dumped the
programmers test cycle in programming as a temporary place holder.

The patch is available for review on Rietveld.

http://codereview.appspot.com/1545043

Thanks,

Carl


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Align metronome mark at time signature or first musical element. Fixes #684. (issue1579041)

2010-06-07 Thread n . puttock 

Hi Jan,

Have you checked what happens with full-bar rests?

I haven't tested your patch, but it's similar to the one I posted, which
suffers from invisible tempo marks at full-bar rests.

Cheers,
Neil


http://codereview.appspot.com/1579041/diff/2001/3001
File lily/metronome-engraver.cc (right):

http://codereview.appspot.com/1579041/diff/2001/3001#newcode78
lily/metronome-engraver.cc:78: == text_->get_property_data
("break-align-symbol")))
should be break-align-symbols (which complicates it a bit)

http://codereview.appspot.com/1579041/show

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: fix ly:parser-parse-file in an ly file (issue1345041)

2010-06-07 Thread n . puttock 

On 2010/06/07 13:59:45, Reinhold wrote:


The only occurrence where it might make sense to have a separate

parser is in

scm/parser-ly-from-scheme.scm in the function read-lily-expression,

which calls

parse-string-result. However, I fail to see where this is actually

used...

It's called whenever Guile encounters the character sequence #{ for
parsing LilyPond expressions inside scheme (i.e., inside music
functions).

http://codereview.appspot.com/1345041/show

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

[PATCH] Refactoring lilypond-book into separate classes (for each output format)

2010-06-07 Thread Reinhold Kainhofer 
Here is a patch that refactors lilypond into several python classes:
http://codereview.appspot.com/1543042

There is one base class for the output format, handling the basic operations, 
while the format-specific operations (and regexps) are provided by derived 
classes. This makes it easier to add further formats (e.g. one wants to extend 
a format for a particular use, but not for lilypond-book in general) or to 
change things for just one format. It also makes it easier to understand 
lilypond-book.


The main reason I'm working on it is that for the MusicXML test suite I want 
to 

1) implement musicxml snippet support, too (basically, simply running the 
snippet through musicxml2ly as a filter and then treating it like any other ly 
snippet, except that the output will link to the xml) and

2) modify the output of the musicxml files so it better suits the musicxml 
test suite (will be done in a custom format living in 
input/regression/musicxml/book_musicxmltestsuit.py, not in stock lilypond-
book)


Cheers,
Reinhold
-- 
--
Reinhold Kainhofer, reinh...@kainhofer.com, http://reinhold.kainhofer.com/
 * Financial & Actuarial Math., Vienna Univ. of Technology, Austria
 * http://www.fam.tuwien.ac.at/, DVR: 0005886
 * LilyPond, Music typesetting, http://www.lilypond.org

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: fix ly:parser-parse-file in an ly file (issue1345041)

2010-06-07 Thread reinhold . kainhofer 

On 2010/06/07 19:17:27, Neil Puttock wrote:

On 2010/06/07 13:59:45, Reinhold wrote:
> However, I fail to see where this is actually used...



It's called whenever Guile encounters the character sequence #{ for

parsing

LilyPond expressions inside scheme (i.e., inside music functions).


Ah, thanks for enlightening me! In this case, I suppose we really want a
copy of the parser, since we make available the function's variables as
$varname...

http://codereview.appspot.com/1345041/show

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Lilypond-book: Factor out the formatting from lilypond-book into separate classes (issue1543042)

2010-06-07 Thread Carl . D . Sorensen 

Looks nicely done to me.  It was a big job!

Thanks,

Carl


http://codereview.appspot.com/1543042/show

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: completion disturbed by other staff (issue 1082)

2010-06-07 Thread Neil Puttock 
On 6 June 2010 09:51, Benkő Pál  wrote:
> attached the updated patch for 1082.

Thanks, applied.

Regards,
Neil

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Align metronome mark at time signature or first musical element. Fixes #684. (issue1579041)

2010-06-07 Thread Jan Nieuwenhuizen 
Op maandag 07-06-2010 om 16:59 uur [tijdzone +], schreef
n.putt...@gmail.com:

Hi Neil,

> Have you checked what happens with full-bar rests?

Uhuh, I have now ;-)

> I haven't tested your patch, but it's similar to the one I posted, which
> suffers from invisible tempo marks at full-bar rests.

Good catch, that should also be fixed now.  Thanks!

Greetings,
Jan.

> Cheers,
> Neil
> 
> 
> http://codereview.appspot.com/1579041/diff/2001/3001
> File lily/metronome-engraver.cc (right):
> 
> http://codereview.appspot.com/1579041/diff/2001/3001#newcode78
> lily/metronome-engraver.cc:78: == text_->get_property_data
> ("break-align-symbol")))
> should be break-align-symbols (which complicates it a bit)
> 
> http://codereview.appspot.com/1579041/show
> 
> ___
> lilypond-devel mailing list
> lilypond-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/lilypond-devel



___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel