Re: sustainable development in LilyPond

[Karl Hammar]

Graham:
...
> http://percival-music.ca/blog/2010-08-01-sustainable-development.html
...

Thank you for the slides, I liked them.

Regards,
/Karl Hammar

-
Aspö Data
Lilla Aspö 148
S-742 94 Östhammar
Sweden
+46 173 140 57



___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Adds scheme binding for Side_position_interface::set_axis (issue1880050)

[mtsolo]

Reviewers: Neil Puttock,

Message:
I created a binding for chain_callback in grob-scheme.cc.  Please see
http://codereview.appspot.com/1890044 .  I'm fine using this and then
maybe making a scheme version of set_axis (i.e.
side-position-interface::set-axis) in the appropriate .scm file.  First,
let me know if this is what you had in mind.

Cheers,
Mike

Description:
Adds scheme binding for Side_position_interface::set_axis



Provides scheme bindings for Side_position_interface::set_axis

Please review this at http://codereview.appspot.com/1880050/show

Affected files:
  A lily/side-position-interface-scheme.cc


Index: lily/side-position-interface-scheme.cc
diff --git a/lily/side-position-interface-scheme.cc  
b/lily/side-position-interface-scheme.cc

new file mode 100644
index  
..8ed43feade8b4edbb2ef2a62a4374b96059d503b

--- /dev/null
+++ b/lily/side-position-interface-scheme.cc
@@ -0,0 +1,35 @@
+/*
+  This file is part of LilyPond, the GNU music typesetter.
+
+  Copyright (C) 2010 Han-Wen Nienhuys 
+
+  LilyPond is free software: you can redistribute it and/or modify
+  it under the terms of the GNU General Public License as published by
+  the Free Software Foundation, either version 3 of the License, or
+  (at your option) any later version.
+
+  LilyPond is distributed in the hope that it will be useful,
+  but WITHOUT ANY WARRANTY; without even the implied warranty of
+  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+  GNU General Public License for more details.
+
+  You should have received a copy of the GNU General Public License
+  along with LilyPond.  If not, see .
+*/
+
+#include "side-position-interface.hh"
+#include "grob.hh"
+
+LY_DEFINE  
(ly_side_position_interface__set_axis, "ly:side-position-interface::set-axis!",

+  2, 0, 0, (SCM grob, SCM axis),
+  "Set @var{axis} as @var{grob}'s axis for offset callbacks.")
+{
+  LY_ASSERT_TYPE (unsmob_grob, grob, 1);
+  LY_ASSERT_TYPE (is_axis, axis, 2);
+
+  Side_position_interface::set_axis (unsmob_grob (grob),
+ Axis (scm_to_int (axis)));
+
+  return SCM_UNSPECIFIED;
+}
+



___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Adds announce-end-grob to engraver-scheme.cc (issue1914043)

[mtsolo]

http://codereview.appspot.com/1914043/diff/6001/7001
File lily/engraver-scheme.cc (right):

http://codereview.appspot.com/1914043/diff/6001/7001#newcode26
lily/engraver-scheme.cc:26: " with give @code{grob_name}, a symbol.
@code{cause}"
On 2010/08/02 22:56:25, Neil Puttock wrote:

with given @code{grob-name},


Done.

http://codereview.appspot.com/1914043/diff/6001/7001#newcode42
lily/engraver-scheme.cc:42: " Announces an end grob originating from
given engraver instance,"
On 2010/08/02 22:56:25, Neil Puttock wrote:

This could be a bit clearer (an `end grob' doesn't make much sense)


Done.

http://codereview.appspot.com/1914043/diff/6001/7001#newcode44
lily/engraver-scheme.cc:44: " be another grob or a music event.")
On 2010/08/02 22:56:25, Neil Puttock wrote:

indent


Done.

http://codereview.appspot.com/1914043/diff/6001/7001#newcode47
lily/engraver-scheme.cc:47: LY_ASSERT_TYPE (unsmob_grob, grob, 2);
On 2010/08/02 22:56:25, Neil Puttock wrote:

LY_ASSERT_SMOB (Grob, grob, 2);


Done.

http://codereview.appspot.com/1914043/show

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel