Re: doc-addition: the full lilypond command line with options+redirections
On Thu, Aug 12, 2010 at 03:05:38PM -0700, -Eluze wrote: The lilypond executable may be called as follows from the command line. lilypond [option]... file...[[1]file.log] [2file.txt] 1 and 2 (and, for the matter, ) have nothing to do with lilypond. I will reluctantly agree to adding something like this at the bottom of some section: - @subsubsection Standard shell commands If your shell (i.e. command window) supports normal redirects, then you might find it useful to use: lilypond file.ly 1stdout.log 2stderr.log all.log // check which does which 1 normal output 2 errors all output Consult documentation for your shell to see if it supports these options, or if the syntax is different. These commands have nothing to do with lilypond. - Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Extra check in define-event-class patch
On 8/12/10 7:20 PM, Trevor Daniels t.dani...@treda.co.uk wrote: Mike Solomon wrote Thursday, August 12, 2010 10:16 AM I added an extra symbol check to my event class patch: http://codereview.appspot.com/1867050 Also, I have a regression test that creates a spanner engraver from the scheme end using this function (said regtest could also be turned into a bit of documentation for the contributor's guide if people feel that'd be helpful - I think it would given a recent thread on frogs concerning engravers their complexity), but I don't know if I should submit it as part of this patch set or as a new issue on Reitveld. Lemme know :-) If the regression test tests the new function I'd make it part of the same Reitveld issue. If your patch makes it to the distribution we'd want to install both together. Trevor Done - thank you for the suggestion. Attached is the patch series, which can also be found on http://codereview.appspot.com/1867050 . Thank you! ~Mike 0003-Adds-a-regression-test-showing-ly-define-event-class.patch Description: Binary data 0002-Symbol-checking.patch Description: Binary data 0001-Create-ly-define-event-class.patch Description: Binary data ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: doc-addition: the full lilypond command line withoptions+redirections
Graham Percival wrote Friday, August 13, 2010 7:28 AM On Thu, Aug 12, 2010 at 03:05:38PM -0700, -Eluze wrote: The lilypond executable may be called as follows from the command line. lilypond [option]... file...[[1]file.log] [2file.txt] 1 and 2 (and, for the matter, ) have nothing to do with lilypond. I will reluctantly agree to adding something like this at the bottom of some section: Done Trevor ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Add \path markup command, and use it for \eyeglasses. (issue1730044)
LGTM. Carl http://codereview.appspot.com/1730044/show ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fix 1084. (issue1871058)
Looks ok here; I just did a build from scratch with it applied. The only potential issue is whether it works with the regtest comparison, but we can't test that until I make another release. Please push. :) http://codereview.appspot.com/1871058/show ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: NR 2.1 Vocal music
On Thu, Aug 12, 2010 at 11:13 PM, Trevor Daniels t.dani...@treda.co.uk wrote: Graham Percival wrote Thursday, August 12, 2010 7:38 PM I'd really rather that you helped out with programming (or at least testing+reviewing patches) and critical doc issues... I looked through the 12 remaining critical issues before making my suggestion to tackle NR 2.1. 8 are marked as started, of which 2 have patches being reworked by the authors. Of the 4 remaining, 2 are website stuff that only you can do, 1 Carl has promised to look at and the final one I think only Joe can tackle. First -- I'm happy with you working on NR 2.1, so don't take this email as discouraging you from doing that. I'm aiming these comments at the mailing list in general, and some Frogs (or even not yet frogs), not you. I think that 1084 was only waiting for somebody to test it with a doc build. I've done this now, but it's not something that's hard -- it just takes firing off a few commands and then going for dinner. (that said, it seems like this is a bad option for people working with a virtual machine... but any potential contributor on linux could certainly have done this) Second, the release can't happen immediately after the last Critical issue is solved. There's about 10-20 hours of work left to do after that. A lot of it is technical build stuff (which I wouldn't wish on my worst enemy), but there's still a chunk that's fairly easy to delegate. A quick glance at CG 10.3 should serve as sufficient evidence of our unready state. BTW, the first thing I'd delegate is making a list of places to announce the release. The current list is about 5 years old, and even *that* list has various notes like non-existant?. In short: there's plenty of work, for any ability level, that needs to be done before 2.14.0. I can always find work for minions. Cheers, - Graham PS that said, I'm not claiming that anybody *should* be focused on making a release. If somebody just wants to work on writing good code and doesn't care at all about official releases and the like, then of course just continue doing that! ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
release 2.14 timeline
We're down to 8 Critical issues. - 1 is a website issue that's basically finished. - 1 is a doc issue that might already be finished (after an issue split) That leaves 6 code issues. 3 of them have patches: - Issue 1116:Title not centered http://code.google.com/p/lilypond/issues/detail?id=1116 - Issue 1173:LilyPond crash when using showFirstLength/showLastLength with \compressFullBarRests http://code.google.com/p/lilypond/issues/detail?id=1173 - Issue 1198:Display method for \time broken http://code.google.com/p/lilypond/issues/detail?id=1198 1 has a new programmer actively working on it: - Issue 1096:ly:parser-parse-string segfaults when directly called at toplevel http://code.google.com/p/lilypond/issues/detail?id=1096 (don't steal this issue from him) 1 hasn't been touched since Feb: - Issue 818: Bus error when adding Instrument_name_engraver to StaffGroup and outputting MIDI. http://code.google.com/p/lilypond/issues/detail?id=818 1 might not be a regression at all, but we need a spacing-aware developer to look at it: - Issue 1208:minor regression: Some combination of 'staff-affinity for two Lyrics may cause unwanted vertical space http://code.google.com/p/lilypond/issues/detail?id=1208 Once we're down to 3 (or fewer) Critical code issues, I'll announce an alpha version of 2.14.0 and invite normal users to try it out. Note that reviewing and helping fix the existing patches would satisfy this condition. When that happens, I expect to see another 5-15 Critical issues from people trying it out. Maybe less because a lot of users are already using 2.13... but don't be surprised (or discouraged) to see a flood of bug reports once we officially invite people to try out 2.13. Once we're down to 0 Critical issues, we'll start having release candidates. Translators: at the moment, I'm cautiously predicting that 2.14.0 will be 4 to 8 weeks away. You will have at least 2 weeks (14 days) notice before 2.14.0 -- each release candidate is such a warning. Francisco, you're in charge of sending this to the translator list, and/or sending private emails to relevant people. Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fix 1198: Fix displayLilyMusic for \time and #(set-time-signature) (issue1986042)
Hi Carl, LGTM. Cheers, Neil http://codereview.appspot.com/1986042/diff/1/2 File scm/define-music-display-methods.scm (right): http://codereview.appspot.com/1986042/diff/1/2#newcode887 scm/define-music-display-methods.scm:887: (let* ((arguments (ly:music-property expr 'time-signature-arguments)) I'd prefer separate properties since it would make the output of \displayMusic less cryptic. There's already 'numerator and 'denominator (which are currently used for \times, even though their docstrings mention \time). http://codereview.appspot.com/1986042/diff/1/2#newcode897 scm/define-music-display-methods.scm:897: #(set-time-signature ~a ~a ~a)~a #(set-time-signature ~a ~a '~a)~a http://codereview.appspot.com/1986042/diff/1/4 File scm/define-music-types.scm (right): http://codereview.appspot.com/1986042/diff/1/4#newcode53 scm/define-music-types.scm:53: (define (make-time-signature-set music) We should probably think about moving these to a separate file now there's more than one callback. (naturally this can wait for another patch) http://codereview.appspot.com/1986042/diff/1/5 File scm/music-functions.scm (left): http://codereview.appspot.com/1986042/diff/1/5#oldcode507 scm/music-functions.scm:507: (define-public (make-beam-rule-time-signature-set num den rest) Do you want to keep this? http://codereview.appspot.com/1986042/show ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Add independent control of thickness and offset for underline markup (issue1347041)
On 2010/08/13 03:15:48, Carl wrote: Is the default OK now? Looks fine to me. Cheers, Neil http://codereview.appspot.com/1347041/show ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Add \path markup command, and use it for \eyeglasses. (issue1730044)
On 2010/08/13 11:04:00, Carl wrote: LGTM. Carl Thanks Carl. I'll push this patchset shortly (with regression tests). -Patrick http://codereview.appspot.com/1730044/show ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fix 1198: Fix displayLilyMusic for \time and #(set-time-signature) (issue1986042)
Let me know about the filename for the new callbacks, and I'll add that to this patch and push it. THanks, Carl http://codereview.appspot.com/1986042/diff/1/2 File scm/define-music-display-methods.scm (right): http://codereview.appspot.com/1986042/diff/1/2#newcode887 scm/define-music-display-methods.scm:887: (let* ((arguments (ly:music-property expr 'time-signature-arguments)) On 2010/08/13 21:25:13, Neil Puttock wrote: I'd prefer separate properties since it would make the output of \displayMusic less cryptic. There's already 'numerator and 'denominator (which are currently used for \times, even though their docstrings mention \time). Ah, got it. I hadn't thought of displayMusic. Done. http://codereview.appspot.com/1986042/diff/1/2#newcode897 scm/define-music-display-methods.scm:897: #(set-time-signature ~a ~a ~a)~a On 2010/08/13 21:25:13, Neil Puttock wrote: #(set-time-signature ~a ~a '~a)~a Of course! Thanks, Done. http://codereview.appspot.com/1986042/diff/1/4 File scm/define-music-types.scm (right): http://codereview.appspot.com/1986042/diff/1/4#newcode53 scm/define-music-types.scm:53: (define (make-time-signature-set music) On 2010/08/13 21:25:13, Neil Puttock wrote: We should probably think about moving these to a separate file now there's more than one callback. maybe something like scm/define-music-callbacks.scm ? (naturally this can wait for another patch) http://codereview.appspot.com/1986042/diff/1/5 File scm/music-functions.scm (left): http://codereview.appspot.com/1986042/diff/1/5#oldcode507 scm/music-functions.scm:507: (define-public (make-beam-rule-time-signature-set num den rest) On 2010/08/13 21:25:13, Neil Puttock wrote: Do you want to keep this? Of course not. Thanks for the catch. Done http://codereview.appspot.com/1986042/show ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Extra check in define-event-class patch
On 13 August 2010 09:12, Mike Solomon mike...@ufl.edu wrote: Done - thank you for the suggestion. Attached is the patch series, which can also be found on http://codereview.appspot.com/1867050 . Thank you! Looks good. I've added quite a few comments, but just got a sever error trying to publish them. :( I'll see if it works tomorrow, otherwise I'll copy them here. Cheers, Neil ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fix 1198: Fix displayLilyMusic for \time and #(set-time-signature) (issue1986042)
On 2010/08/13 22:25:43, Carl wrote: Let me know about the filename for the new callbacks, and I'll add that to this patch and push it. I'd be happy with scm/define-music-callbacks.scm. Cheers, Neil http://codereview.appspot.com/1986042/show ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: woodwind diagrams in lilypond (http://codereview.appspot.com/1385041)
Hey all, How's this as a simple example? I will likely be pressed for time over the next week as I start a new job (a teaching job in which one of the units will be on using Lilypond!). So, while I won't really be able to take the lead on this feature's documentation, I can certainly do guided and specific work that would contribute towards people's understand of these diagrams. Specifically, if there's one person who'd like to work on the dox for this, I can be in touch with him or her directly about how this feature works. ~Mike On 8/9/10 6:57 PM, Valentin Villenave valen...@villenave.net wrote: On Sun, May 30, 2010 at 10:52 PM, Neil Puttock n.putt...@gmail.com wrote: On 28 May 2010 07:45, Mike Solomon mike...@ufl.edu wrote: 2) Do the diagrams look nice? They're very impressive; well done! Greetings Mike, I have just closed the tracker page that had been opened to keep track of your woodwind-diagrams patches: http://code.google.com/p/lilypond/issues/detail?id=1117 It would be nice if your nice work could be made a bit more visible (and helpful) in the Documentation, specifically in http://lilypond.org/doc/v2.13//Documentation/notation/common-notation-for-wind -instruments (at the very least). I'm not sure exactly where it should go (fingerings?) nor how to introduce it (a nice, simple example would go a long way, btw). Could you have a look? Cheers, Valentin woodwind-diagrams-tutorial.ly Description: Binary data ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
