default-next-staff-spacing question
When would I ever need to set default-next-staff-spacing? I can't think of a case where this property (as described in the docs) is ever needed, since I can always just set next-staff-spacing. Can someone explain? Thanks. - Mark ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: default-next-staff-spacing question
Suppose you have an orchestral score with several staff groups and you set next-staff-spacing for the flute part. If there is a part where only the flute and strings play, then your next-staff-spacing will apply for the spacing between the flute part and the violin part. If you had set default-next-staff-spacing instead, then StaffGrouper 'after-last-staff-spacing would have applied instead (which is probably what you want). Cheers, Joe On Mon, Oct 11, 2010 at 12:02 AM, Mark Polesky markpole...@yahoo.comwrote: When would I ever need to set default-next-staff-spacing? I can't think of a case where this property (as described in the docs) is ever needed, since I can always just set next-staff-spacing. Can someone explain? Thanks. - Mark ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
macro missing for nl website
Could somebody fix this? make website: ... Initializing settings for web site: [nl] ** Unknown command with braces `...@contactusabout' (in out-website/others-did.itexi l. 31) ... AFAIK all you need to do is copy the macro from the English docs and put it in the relevant place in the nl docs. Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Rename vertical spacing dimensions. (issue2303044)
With regards to convert-ly, it would be nice to run it on the translations. But as long as the doc build still works, don't manually change anything in the translations. I'll be writing up policies for convert-ly later this evening or tomorrow. For the regtests, just go ahead and rename them. Any regressions in those files in 2.13.36 won't be picked up automatically, but I think we have enough eyes on the spacing stuff right now that this isn't a huge loss. If you want to be totally safe, then check those specific regtests manually in the official 2.13.36 release. http://codereview.appspot.com/2303044/diff/2001/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (right): http://codereview.appspot.com/2303044/diff/2001/Documentation/notation/spacing.itely#newcode11 Documentation/notation/spacing.itely:11: @c \version 2.12.0 I expected convert-ly to update this number. Did you deliberately suppress (or revert) that change, or is convert-ly broken? :( In either case, please update the version number here. http://codereview.appspot.com/2303044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: names of vertical spacing dimensions
On 10/10/10 12:56 PM, Mark Polesky markpole...@yahoo.com wrote: Here's an updated patch set for review: http://codereview.appspot.com/2303044/ It's organized into 5 commits on my local branch: 1) Rename vertical spacing dimensions. 2) Update convert-ly (vertical spacing). 3) Run convert-ly on affected regtests (vert. spacing). 4) Revise regtest texidoc headers (vert.spacing). 5) Update docs in English (vert. spacing). ...but Rietveld meshed them all into one. So, once approved, I'll push it as a set of patches, not just one. Why not push it as one patch? It seems like all of those pieces need to be accomplished in order to have a fully-buildable release (i.e. if the variable names in lilypond don't match the variable names in the docs, make doc will fail. I think it should all be pushed as one patch. 2 questions: 1) The filenames of some of the affected regtests are now incorrectly named. For example, page-spacing-top-title-spacing.ly should probably become page-spacing-top-markup-spacing.ly. What's the protocol for this type of situation? git mv input/regression/page-spacing-top-title-spacing.ly input/regression/page-spacing-top-markup-spacing.ly 2) Should I update the translated docs? If your convert-ly rule can make the changes, go ahead and run convert-ly on the foreign language docs. If your convert-ly rule can't make the changes, then you should modify *the snippets* in the foreign language docs, so they will continue to compile. Don't modify the text in the foreign language docs; the translators will do that. Thanks, Carl ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
convert: properly escape some single-backslashes. (issue2401042)
Reviewers: , Message: I noticed a few weird error messages while testing convert-ly on the docs. Description: convert: properly escape some single-backslashes. Please review this at http://codereview.appspot.com/2401042/ Affected files: M python/convertrules.py Index: python/convertrules.py diff --git a/python/convertrules.py b/python/convertrules.py index 992d371617863f5c1e5fde31ff1c66769e455318..d1bffcb37742e2b13e0f78235918b2d8411eb633 100644 --- a/python/convertrules.py +++ b/python/convertrules.py @@ -2989,7 +2989,7 @@ def conv(str): return re.sub(r'\bfeta(Number|Dynamic)', 'fetaText', str) @rule ((2, 13, 18), - _ (\RemoveEmpty*StaffContext - \*Staff \RemoveEmptyStaves)) + _ (\\RemoveEmpty*StaffContext - \*Staff \\RemoveEmptyStaves)) def conv(str): str = re.sub (r\\RemoveEmpty(|Drum|Rhythmic|Tab)StaffContext, r\\\1Staff \\RemoveEmptyStaves, @@ -3006,7 +3006,7 @@ def conv (str): return str @rule ((2, 13, 29), - _ (Eliminate beamSettings, beatLength, \setBeatGrouping, \overrideBeamSettings and \revertBeamSettings\n\ + _ (Eliminate beamSettings, beatLength, \\setBeatGrouping, \\overrideBeamSettings and \\revertBeamSettings\n\ \accordion.accEtcbase\ - \accordion.etcbass\)) def conv(str): def sub_acc (m): @@ -3024,11 +3024,11 @@ def conv(str): sub_acc, str) if re.search(r'overrideBeamSettings', str): stderr_write(\n) -stderr_write(NOT_SMART % _(\overrideBeamSettings. Use \set beamExceptions or \overrideTimeSignatureSettings.\n)) +stderr_write(NOT_SMART % _(\\overrideBeamSettings. Use \\set beamExceptions or \\overrideTimeSignatureSettings.\n)) stderr_write(UPDATE_MANUALLY) if re.search(r'revertBeamSettings', str): stderr_write(\n) -stderr_write(NOT_SMART % _(\revertBeamSettings. Use \set beamExceptions or \revertTimeSignatureSettings.\n)) +stderr_write(NOT_SMART % _(\\revertBeamSettings. Use \\set beamExceptions or \\revertTimeSignatureSettings.\n)) stderr_write(UPDATE_MANUALLY) if re.search(r'beamSettings', str): stderr_write(\n) ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: convert: properly escape some single-backslashes. (issue2401042)
http://codereview.appspot.com/2401042/diff/1/python/convertrules.py File python/convertrules.py (right): http://codereview.appspot.com/2401042/diff/1/python/convertrules.py#newcode2992 python/convertrules.py:2992: _ (\\RemoveEmpty*StaffContext - \*Staff \\RemoveEmptyStaves)) Any particular reason that \*Staff does not get the backslash doubled as well? http://codereview.appspot.com/2401042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: convert: properly escape some single-backslashes. (issue2401042)
http://codereview.appspot.com/2401042/diff/1/python/convertrules.py File python/convertrules.py (right): http://codereview.appspot.com/2401042/diff/1/python/convertrules.py#newcode2992 python/convertrules.py:2992: _ (\\RemoveEmpty*StaffContext - \*Staff \\RemoveEmptyStaves)) Any particular reason that \*Staff does not get the backslash doubled as well? http://codereview.appspot.com/2401042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: [Patch] Request for addition to the publications list
Le 10/10/2010 22:48, Valentin Villenave disait : On Sun, Oct 10, 2010 at 9:41 PM, Graham Percival wrote: Hmm. My first thought was that maybe it should go under Community-Publishing (since it was a developer who wrote it) Wow, look at that. And here I was, thinking I had written it myself. rather than Introduction-Reviews (especially since it's not actually review), but on second thought I think it's fine as it is. Go ahead and push. Thanks! Pushed. (Can't help but wonder, though, who that developer was, who sneaked into my flat at night and wrote this article on my laptop :-) Valentin, Je te laisse le soin de traduire, sur la branche traduction, le fichier en question (à partir de la ligne 630). @+ Jean-Charles ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: convert: properly escape some single-backslashes. (issue2401042)
On 2010/10/11 18:18:37, dak wrote: python/convertrules.py:2992: _ (\\RemoveEmpty*StaffContext - \*Staff \\RemoveEmptyStaves)) Any particular reason that \*Staff does not get the backslash doubled as well? The reason was that I didn't know what \* did -- I'm guessing it has a special meaning in regex -- so I thought I should leave it alone. Cheers, - Graham http://codereview.appspot.com/2401042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: [Patch] Request for addition to the publications list
On Mon, Oct 11, 2010 at 9:57 PM, Jean-Charles Malahieude lily...@orange.fr wrote: Je te laisse le soin de traduire, sur la branche traduction, le fichier en question (à partir de la ligne 630). Merci, c'est fait. Valentin ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: macro missing for nl website
2010/10/11 Graham Percival gra...@percival-music.ca: Could somebody fix this? make website: ... Initializing settings for web site: [nl] ** Unknown command with braces `...@contactusabout' (in out-website/others-did.itexi l. 31) ... AFAIK all you need to do is copy the macro from the English docs and put it in the relevant place in the nl docs. Done. -- Francisco Vila. Badajoz (Spain) www.paconet.org , www.csmbadajoz.com ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: names of vertical spacing dimensions
On Mon, Oct 11, 2010 at 6:29 PM, Carl Sorensen c_soren...@byu.edu wrote: On 10/10/10 12:56 PM, Mark Polesky markpole...@yahoo.com wrote: ...but Rietveld meshed them all into one. So, once approved, I'll push it as a set of patches, not just one. Why not push it as one patch? It seems like all of those pieces need to be accomplished in order to have a fully-buildable release (i.e. if the variable names in lilypond don't match the variable names in the docs, make doc will fail. If he has them as separate patches, that might help future debugging efforts if there's any problem with this. I don't think it matters much, but pushing them as separate patches gives us a bit more information in the history, and it certainly doesn't hurt anything. Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Compile failure with commit edd89894
Hi Graham,
With GCC 4.5.1, I'm seeing a compile failure with latest git.
Reverting your commit edd89894 fixes it. Here's the error:
context-def.cc: In static member function 'static scm_unused_struct*
Context_def::mark_smob(scm_unused_struct*)':
context-def.cc:118:1: error: expected 'while' before 'Context_def'
context-def.cc:118:1: error: expected '(' before 'Context_def'
context-def.cc:118:35: error: expected primary-expression before 'mod'
context-def.cc:119:1: error: expected ')' before '{' token
context-def.cc:119:1: error: expected ';' before '{' token
context-def.cc:120:22: error: 'mod' was not declared in this scope
./include/context-def.hh:44:7: error: invalid use of member
'Context_def::description_' in static member function
context-def.cc:123:7: error: from this location
context-def.cc:124:7: error: return-statement with no value, in function
returning 'scm_unused_struct*'
./include/context-def.hh:48:7: error: invalid use of member
'Context_def::default_child_' in static member function
context-def.cc:135:5: error: from this location
./include/context-def.hh:41:7: error: invalid use of member
'Context_def::translator_mods_' in static member function
context-def.cc:139:7: error: from this location
./include/context-def.hh:41:7: error: invalid use of member
'Context_def::translator_mods_' in static member function
context-def.cc:139:59: error: from this location
./include/context-def.hh:42:7: error: invalid use of member
'Context_def::accept_mods_' in static member function
context-def.cc:143:5: error: from this location
./include/context-def.hh:42:7: error: invalid use of member
'Context_def::accept_mods_' in static member function
context-def.cc:143:53: error: from this location
./include/context-def.hh:43:7: error: invalid use of member
'Context_def::property_ops_' in static member function
context-def.cc:148:5: error: from this location
./include/context-def.hh:43:7: error: invalid use of member
'Context_def::property_ops_' in static member function
context-def.cc:148:36: error: from this location
./include/context-def.hh:46:7: error: invalid use of member
'Context_def::context_aliases_' in static member function
context-def.cc:150:5: error: from this location
./include/context-def.hh:46:7: error: invalid use of member
'Context_def::context_aliases_' in static member function
context-def.cc:150:39: error: from this location
./include/context-def.hh:47:7: error: invalid use of member
'Context_def::translator_group_type_' in static member function
context-def.cc:152:5: error: from this location
./include/context-def.hh:45:7: error: invalid use of member
'Context_def::context_name_' in static member function
context-def.cc:154:5: error: from this location
context-def.cc:161:1: error: a function-definition is not allowed here before
'{' token
context-def.cc:349:1: error: expected '}' at end of input
make[1]: *** [out/context-def.o] Error 1
make[1]: Leaving directory `/home/pnorcks/git/lilypond/lily'
make: *** [all] Error 2
-Patrick
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Compile failure with commit edd89894
On Tue, Oct 12, 2010 at 2:30 AM, Patrick McCarty pnor...@gmail.com wrote:
With GCC 4.5.1, I'm seeing a compile failure with latest git.
Reverting your commit edd89894 fixes it. Here's the error:
context-def.cc: In static member function 'static scm_unused_struct*
Context_def::mark_smob(scm_unused_struct*)':
context-def.cc:118:1: error: expected 'while' before 'Context_def'
???
There's definitely a while in the macro defintion. Unless gcc 4.5
doesn't honour \ symbols in macro definitions?
Or might it be unhappy with the
do { }
part? (should it be do { ; } ?)
If nothing spots anything before tomorrow, I'll compile gcc 4.5 and
see what I can do.
Cheers,
- Graham
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Compile failure with commit edd89894
On Mon, Oct 11, 2010 at 6:54 PM, Graham Percival
gra...@percival-music.ca wrote:
On Tue, Oct 12, 2010 at 2:30 AM, Patrick McCarty pnor...@gmail.com wrote:
With GCC 4.5.1, I'm seeing a compile failure with latest git.
Reverting your commit edd89894 fixes it. Here's the error:
context-def.cc: In static member function 'static scm_unused_struct*
Context_def::mark_smob(scm_unused_struct*)':
context-def.cc:118:1: error: expected 'while' before 'Context_def'
???
There's definitely a while in the macro defintion. Unless gcc 4.5
doesn't honour \ symbols in macro definitions?
Or might it be unhappy with the
do { }
part? (should it be do { ; } ?)
If nothing spots anything before tomorrow, I'll compile gcc 4.5 and
see what I can do.
Sorry for the noise. I just figured it out and pushed a fix.
Thanks,
Patrick
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Compile failure with commit edd89894
On Mon, Oct 11, 2010 at 06:59:32PM -0700, Patrick McCarty wrote: On Mon, Oct 11, 2010 at 6:54 PM, Graham Percival gra...@percival-music.ca wrote: On Tue, Oct 12, 2010 at 2:30 AM, Patrick McCarty pnor...@gmail.com wrote: With GCC 4.5.1, I'm seeing a compile failure with latest git. Reverting your commit edd89894 fixes it. Here's the error: context-def.cc: In static member function 'static scm_unused_struct* Context_def::mark_smob(scm_unused_struct*)': context-def.cc:118:1: error: expected 'while' before 'Context_def' Sorry for the noise. Not at all -- I was the one who broke that file. Thanks for the fix! Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
