Re: remove bar-size and replace its usage by bar-extent (issue4025044)
new patch set up, thanks for reviewing. answers below. On 2011/01/21 13:50:22, Graham Percival wrote: The python bits looked fine. I tried a regtest comparison and didn't see any change at all other than test-output-distance, so maybe something went wrong. Should I see any difference in the graphical output? no; I added a new file to the test suite; perhaps it's too big. I think there's some debugging code in here that needs to be cleaned up. Indeed; sorry for having left those in. http://codereview.appspot.com/4025044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Example for melismaBusyProperties in NR extremely misleading
Reinhold Kainhofer wrote Thursday, January 20, 2011 7:31 PM
In NR 2.1.1 ("Multiple notes to a syllable") we have an example
for
melismaBusyProperties, which is extremely misleading, as it gives
the
expression that this property can be used to skip notes without
assigning a
lyrics syllable:
http://kainhofer.com/~lilypond/Documentation/notation/common-notation-for-
vocal-music.html#multiple-notes-to-one-syllable
Actually, I don't see the point for this snippet: If one wants to
assign one
syllable to multiple notes (i.e. a melisma), it is really
counter-productive
to disable melismata in the notes.
I agree; the example is bad. Its purpose is to explain
melismaBusyProperties and it fails to do this clearly.
If anything, melismas should be explained in the next section
"Skipping
notes",
?? But this whole subsection is about melismata.
Skipping notes has a different purpose, eg skipping
a note needed in one language but not in another.
Again, a better example could be devised.
and the example should be changed to show that it is possible to
really assign a syllable to the second note of a tie/slur or so.
I agree. I'll have a look at improving this section.
Trevor
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: global staff-staff spacing fails in 2.13.46
Trevor Daniels wrote Wednesday, January 19, 2011 12:43 PM Keith OHara wrote Wednesday, January 19, 2011 7:25 AM Follow-up patch attached. This looks fine to me. I'll push it in a day or two if there are no adverse comments. Pushed. Trevor ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: remove bar-size and replace its usage by bar-extent (issue4025044)
The python bits looked fine. I tried a regtest comparison and didn't
see any change at all other than test-output-distance, so maybe
something went wrong. Should I see any difference in the graphical
output?
I think there's some debugging code in here that needs to be cleaned up.
http://codereview.appspot.com/4025044/diff/1/lily/bar-line.cc
File lily/bar-line.cc (right):
http://codereview.appspot.com/4025044/diff/1/lily/bar-line.cc#newcode30
lily/bar-line.cc:30: #include
Why iostream? We have our own functions for printing, which (I think)
makes it easier to translate the text.
http://codereview.appspot.com/4025044/diff/1/lily/bar-line.cc#newcode342
lily/bar-line.cc:342: std::clog << __PRETTY_FUNCTION__ << ": (" <<
extent.at (DOWN) << " . "
I'm suspicious about printing text this way.
http://codereview.appspot.com/4025044/diff/1/lily/bar-line.cc#newcode367
lily/bar-line.cc:367:
Ditto.
http://codereview.appspot.com/4025044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fix 1120 in a way to avoid issues 1472, 1474 (issue4095041)
Regtest comparison shows nothing obviously wrong, and it compiles the docs from scratch. http://codereview.appspot.com/4095041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Keith's fix to 1472 (issue4056043)
This patch appears to be obsolete; according to http://code.google.com/p/lilypond/issues/detail?id=1472 , Keith has an updated patch. http://codereview.appspot.com/4056043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel
