Re: 13.52 regtests

2011-03-06 Thread Keith OHara
Phil Holmes  philholmes.net> writes:
> 
> lyrics-bar.png - the music now breaks over the line to accommodate the text 

> mensural-ligatures.ly - one of the staves now disappears over the edge of 
> the page.

These two tests suffered somewhat from making keep-inside-line = ##t, so I 
adjusted to compensate for this new default.

Expect to see these two regression tests changed in 2.13.54




___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Wrong loop boundaries when iterating over markup list (issue4236047)

2011-03-06 Thread k-ohara5a5a

Boris,
  This is the last remaining critical bug preventing version 2.14.
I applied the suggestions above to your patch, resulting in
http://codereview.appspot.com/4253061/

Would you either comment there, or adopt the revisions,
whichever is appropriate given the amount of time you can give to
LilyPond.

--Keith


http://codereview.appspot.com/4236047/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: DOC: NR 1.5.2 Multiple voices - part combining (issue4188056)

2011-03-06 Thread ColinPKCampbell

On 2011/03/06 12:13:15, Reinhold wrote:

http://codereview.appspot.com/4188056/diff/22001/Documentation/notation/simultaneous.itely

File Documentation/notation/simultaneous.itely (right):



http://codereview.appspot.com/4188056/diff/22001/Documentation/notation/simultaneous.itely#newcode871

Documentation/notation/simultaneous.itely:871: previous part combining
mechanism.
Actually, it never returns to the previous mechanism, but rather to

the default

built-in mechanism (just like \revert always resets a grob property to

the

default an not to the value before the previous \override).


Ah, I was thinking that \partcombineautomatic once would go automatic
for one note, then return to whatever was in force before it was called.
 If you would confirm that, I'll reword the explanation to suit.


http://codereview.appspot.com/4188056/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: shortened flags affair, part 4 - downstem 8th flag

2011-03-06 Thread Carl Sorensen
On 3/6/11 2:44 AM, "Janek Warchoł"  wrote:

> 2011/3/6 Carl Sorensen :
>> 


>>> bars 8,9,11: ugly slurs, bad placement in bar 8
>> 
>> I agree with 9 and 11 having ugly slurs -- too sharply peaked.
>> 
>> I've changed the slur scoring so that it doesn't try to move slurs away from
>> staff lines.  It cleans up the ugly slurs, at the expense of letting the
>> slurs touch the line.  I've attached a pdf with those changes.
> 
> Looks great!
> And in fact these slurs don't touch staff lines, there is a small
> clearance. I printed it and it looks ok (however, my printer prints
> *very* badly and shaky now, so it should be double-checked).

I've looked at very large magnifications; the slurs in measures 8, 9, 10,
and 11 all touch on one end.

> 
>> I don't think 8 is an ugly slur, or that the placement is bad.  Can you tell
>> me what is ugly about it, and why the placement is bad?
> 
> I'm not sure. Perhaps the left end is too high. I attach output from
> finale 2008 demo, i'd say that something between this and current Lily
> output would be optimal.
> 

Looking at this comparison reminds me of how much I prefer the rounded ends
of the LilyPond slurs to the pointed slurs of Finale.

Thanks,

Carl



___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Modifies the Staff_symbol::print function to address Issue 1506 (issue4253059)

2011-03-06 Thread Neil Puttock
On 7 March 2011 00:17, m...@apollinemike.com  wrote:
> Blech...

Couldn't have put it better myself. ;)

Try the attached patch.  I can't test it properly until tomorrow
evening, but it doesn't appear to break anything.

Cheers,
Neil
From 920eedbe36b465e8a17b30d6b41474a73197f217 Mon Sep 17 00:00:00 2001
From: Neil Puttock 
Date: Mon, 7 Mar 2011 00:28:27 +
Subject: [PATCH] Possible fix for #1506.

---
 lily/staff-symbol.cc |9 +
 1 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/lily/staff-symbol.cc b/lily/staff-symbol.cc
index d1629df..8cf7be4 100644
--- a/lily/staff-symbol.cc
+++ b/lily/staff-symbol.cc
@@ -22,6 +22,7 @@
 #include "lookup.hh"
 #include "dimensions.hh"
 #include "output-def.hh"
+#include "paper-column.hh"
 #include "warn.hh"
 #include "item.hh"
 #include "staff-symbol-referencer.hh"
@@ -66,12 +67,12 @@ Staff_symbol::print (SCM smob)
 	{
 	  Item *x = sp->get_bound (d);
 
-	  span_points[d] = x->relative_coordinate (common, X_AXIS);
-	  if (!x->break_status_dir ()
+	  span_points[d] =
+	((!x->break_status_dir ()
 	  && !x->extent (x, X_AXIS).is_empty ())
-	span_points[d] += x->extent (x, X_AXIS)[d];
+	 ? Paper_column::break_align_width (x, ly_symbol2scm ("break-alignment"))[d]
+	 : x->relative_coordinate (common, X_AXIS));
 	}
-
   span_points[d] -= d* t / 2;
 }
   while (flip (&d) != LEFT);
-- 
1.7.1

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Modifies the Staff_symbol::print function to address Issue 1506 (issue4253059)

2011-03-06 Thread m...@apollinemike.com
Blech...

http://codereview.appspot.com/4253059

But it works!

Cheers,
MS___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Fix to Issue 1506 (issue4243060)

2011-03-06 Thread m...@apollinemike.com
On Mar 6, 2011, at 19:04, Neil Puttock  wrote:

> On 6 March 2011 23:30, m...@apollinemike.com  wrote:
>> It's dirt simple, and perhaps breaks other things, but it works.
> 
> Judging by the original commit
> (http://repo.or.cz/w/lilypond/mirror.git/commit/2f47e632d869f7adfffa656b79a6f76cfa31a11e?f=lily/staff-symbol.cc),
> it will break this snippet:
> 
> http://lsr.dsi.unimi.it/LSR/Item?id=138
> 
> Edit: It does; the lower system's staff-symbol stops before the repeat.
> 
>> If someone could run the reg-tests, I'd be much obliged!
> 
> Attached.
> 

Thanks!
I was afraid of this sorta grob-dependent thing.

I have a much uglier and more involved version that I'll send out to the list 
in a second.

Sorry that I can't run regtests, but I'm trying to maximize the juice in my 
machine before my flight.

Cheers,
Mike

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Fix to Issue 1506 (issue4243060)

2011-03-06 Thread Neil Puttock
On 6 March 2011 23:30, m...@apollinemike.com  wrote:
> It's dirt simple, and perhaps breaks other things, but it works.

Judging by the original commit
(http://repo.or.cz/w/lilypond/mirror.git/commit/2f47e632d869f7adfffa656b79a6f76cfa31a11e?f=lily/staff-symbol.cc),
it will break this snippet:

http://lsr.dsi.unimi.it/LSR/Item?id=138

Edit: It does; the lower system's staff-symbol stops before the repeat.

> If someone could run the reg-tests, I'd be much obliged!

Attached.

Cheers,
Neil


test-results.tar.bz2
Description: BZip2 compressed data
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Implements the 2nd of 5 legs of getting footnotes up and running. (issue4254055)

2011-03-06 Thread mtsolo

Reviewers: Neil Puttock,

Message:
Thanks Neil!

New patch set uploaded.

Cheers,
Mike


http://codereview.appspot.com/4254055/diff/1/lily/balloon.cc
File lily/balloon.cc (right):

http://codereview.appspot.com/4254055/diff/1/lily/balloon.cc#newcode38
lily/balloon.cc:38: static SCM internal_balloon_print (Grob *me, Grob
*p, Offset &off);
On 2011/03/06 23:35:28, Neil Puttock wrote:

Offset *off (makes code fussy due to dereferencing)



or



Offset off (better: all existing code appears to pass Offset by value)


Done.

http://codereview.appspot.com/4254055/diff/1/lily/balloon.cc#newcode75
lily/balloon.cc:75: spanner_placement = 1.0;
On 2011/03/06 23:35:28, Neil Puttock wrote:

  Real spanner_placement =
min (1.0, max (robust_scm2double (me->get_property

("spanner-placement"),

-1.0), -1.0));


Done.

http://codereview.appspot.com/4254055/diff/1/lily/balloon.cc#newcode93
lily/balloon.cc:93: Drul_array bounds;
On 2011/03/06 23:35:28, Neil Puttock wrote:

remove


Done.

http://codereview.appspot.com/4254055/diff/1/scm/define-grob-properties.scm
File scm/define-grob-properties.scm (right):

http://codereview.appspot.com/4254055/diff/1/scm/define-grob-properties.scm#newcode51
scm/define-grob-properties.scm:51: (annotation-balloon ,boolean? "Print
the ballon around an annotation.")
On 2011/03/06 23:35:28, Neil Puttock wrote:

Print the balloon


Done.

http://codereview.appspot.com/4254055/diff/1/scm/define-grobs.scm
File scm/define-grobs.scm (left):

http://codereview.appspot.com/4254055/diff/1/scm/define-grobs.scm#oldcode872
scm/define-grobs.scm:872: (Y-extent . 0.0)
On 2011/03/06 23:35:28, Neil Puttock wrote:

Y-extent . #f


Done.

http://codereview.appspot.com/4254055/diff/1/scm/define-grobs.scm#oldcode887
scm/define-grobs.scm:887: (Y-extent . 0.0)
On 2011/03/06 23:35:28, Neil Puttock wrote:

Y-extent . #f


Done.

http://codereview.appspot.com/4254055/diff/1/scm/define-grobs.scm
File scm/define-grobs.scm (right):

http://codereview.appspot.com/4254055/diff/1/scm/define-grobs.scm#newcode180
scm/define-grobs.scm:180: (annotation-balloon . #f)
On 2011/03/06 23:37:55, Neil Puttock wrote:

On 2011/03/06 23:35:28, Neil Puttock wrote:
> remove



Oops, I mean change to #t (same for annotation-line)



Done.

Description:
Implements the 2nd of 5 legs of getting footnotes up and running.

Gets the annotations to print next to the footnoted grobs.

The 3rd leg will be merging Balloon and FootnoteItem into one grob
that is responsible for annotations.

The 4th will be implementing endnotes.

The 5th will be automatic numbering.

Please review this at http://codereview.appspot.com/4254055/

Affected files:
  M lily/balloon.cc
  M lily/system.cc
  M scm/define-grob-properties.scm
  M scm/define-grobs.scm


Index: lily/balloon.cc
diff --git a/lily/balloon.cc b/lily/balloon.cc
index  
f4efd4c4894a7b827e62b4a203a312daa8da0c28..793bcf13c3ed751e6bcc63be9dc5fde02790a201  
100644

--- a/lily/balloon.cc
+++ b/lily/balloon.cc
@@ -19,18 +19,23 @@

 #include "text-interface.hh"
 #include "grob.hh"
+#include "item.hh"
 #include "line-interface.hh"
 #include "lookup.hh"
 #include "font-interface.hh"
 #include "lily-guile.hh"
 #include "output-def.hh"
 #include "misc.hh"
+#include "spanner.hh"

 class Balloon_interface
 {
 public:
   DECLARE_SCHEME_CALLBACK (print, (SCM));
+  DECLARE_SCHEME_CALLBACK (print_spanner, (SCM));
   DECLARE_GROB_INTERFACE ();
+
+  static SCM internal_balloon_print (Grob *me, Grob *p, Offset off);
 };

 MAKE_SCHEME_CALLBACK (Balloon_interface, print, 1);
@@ -39,19 +44,67 @@ Balloon_interface::print (SCM smob)
 {
   Grob *me = unsmob_grob (smob);

+  if (Item *item = dynamic_cast(me))
+if (!Item::break_visible (item))
+  return SCM_EOL;
+
   Grob *p = me->get_parent (X_AXIS);
-
+
   Offset off (me->relative_coordinate (p, X_AXIS),
  me->relative_coordinate (p, Y_AXIS));

+  return internal_balloon_print (me, p, off);
+}
+
+// ugh...code dup...hopefully can be consolidated w/ above one day
+MAKE_SCHEME_CALLBACK (Balloon_interface, print_spanner, 1);
+SCM
+Balloon_interface::print_spanner (SCM smob)
+{
+  Spanner *me = unsmob_spanner (smob);
+  Grob *orig = me->original ();
+
+  if (orig)
+{
+  // TODO : consolidate code dup from  
System::get_footnote_grobs_in_range

+  int pos = orig->spanned_rank_interval ()[LEFT];
+  Real spanner_placement = min (1.0,
+max (robust_scm2double  
(me->get_property ("spanner-placement"), -1.0),

+ -1.0));
+
+  spanner_placement = (spanner_placement + 1.0) / 2.0;
+  int rpos = orig->spanned_rank_interval ()[RIGHT];
+  pos = (int)((rpos - pos) * spanner_placement + pos + 0.5);
+
+  if (pos < me->spanned_rank_interval () [LEFT])
+return SCM_EOL;
+  if (pos >= me->spanned_rank_interval () [RIGHT] &&  
(me->spanned_rank_interval () [RIGHT] != orig->spanned_rank_interval ()  
[RIGHT]))

+return SCM_EOL;
+}
+
+
+  Spanner *p =

Re: Implements the 2nd of 5 legs of getting footnotes up and running. (issue4254055)

2011-03-06 Thread n . puttock


http://codereview.appspot.com/4254055/diff/1/scm/define-grobs.scm
File scm/define-grobs.scm (right):

http://codereview.appspot.com/4254055/diff/1/scm/define-grobs.scm#newcode180
scm/define-grobs.scm:180: (annotation-balloon . #f)
On 2011/03/06 23:35:28, Neil Puttock wrote:

remove


Oops, I mean change to #t (same for annotation-line)

http://codereview.appspot.com/4254055/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Implements the 2nd of 5 legs of getting footnotes up and running. (issue4254055)

2011-03-06 Thread n . puttock

Hi Mike,

Just a few minor nitpicks for you.

Cheers,
Neil


http://codereview.appspot.com/4254055/diff/1/lily/balloon.cc
File lily/balloon.cc (right):

http://codereview.appspot.com/4254055/diff/1/lily/balloon.cc#newcode38
lily/balloon.cc:38: static SCM internal_balloon_print (Grob *me, Grob
*p, Offset &off);
Offset *off (makes code fussy due to dereferencing)

or

Offset off (better: all existing code appears to pass Offset by value)

http://codereview.appspot.com/4254055/diff/1/lily/balloon.cc#newcode75
lily/balloon.cc:75: spanner_placement = 1.0;
 Real spanner_placement =
   min (1.0, max (robust_scm2double (me->get_property
("spanner-placement"), -1.0), -1.0));

http://codereview.appspot.com/4254055/diff/1/lily/balloon.cc#newcode93
lily/balloon.cc:93: Drul_array bounds;
remove

http://codereview.appspot.com/4254055/diff/1/scm/define-grob-properties.scm
File scm/define-grob-properties.scm (right):

http://codereview.appspot.com/4254055/diff/1/scm/define-grob-properties.scm#newcode51
scm/define-grob-properties.scm:51: (annotation-balloon ,boolean? "Print
the ballon around an annotation.")
Print the balloon

http://codereview.appspot.com/4254055/diff/1/scm/define-grobs.scm
File scm/define-grobs.scm (left):

http://codereview.appspot.com/4254055/diff/1/scm/define-grobs.scm#oldcode872
scm/define-grobs.scm:872: (Y-extent . 0.0)
Y-extent . #f

http://codereview.appspot.com/4254055/diff/1/scm/define-grobs.scm#oldcode887
scm/define-grobs.scm:887: (Y-extent . 0.0)
Y-extent . #f

http://codereview.appspot.com/4254055/diff/1/scm/define-grobs.scm
File scm/define-grobs.scm (right):

http://codereview.appspot.com/4254055/diff/1/scm/define-grobs.scm#newcode180
scm/define-grobs.scm:180: (annotation-balloon . #f)
remove

http://codereview.appspot.com/4254055/diff/1/scm/define-grobs.scm#newcode181
scm/define-grobs.scm:181: (annotation-line . #f)
remove

http://codereview.appspot.com/4254055/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Fix to Issue 1506 (issue4243060)

2011-03-06 Thread m...@apollinemike.com
It's dirt simple, and perhaps breaks other things, but it works.
If someone could run the reg-tests, I'd be much obliged!

It's also possible to include the deleted code but gate it via some sorta 
boolean grob property set for the StaffSymbol, but I wouldn't know what to call 
this property.

http://codereview.appspot.com/4243060

Cheers,
MS
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


13.53 regtests

2011-03-06 Thread Phil Holmes
All looking pretty good.  A number have changed since it looks like lyrics 
are placed slightly further from the staff than before - this pushes lower 
staves down.  completion-heads-factor.ly has had some more notes added to 
the test.  page-spacing-staff-group-nested.ly now sets the nested staves in 
a different place from before, but it's not clear to me whether this is a 
problem, or just different.  The major change is lyrics-bar.ly, where the 
previous release had the text over the lines of the staff, which looked 
wrong to me and I was persuaded was not a bug, but now there's no collision. 
Looking good!


--
Phil Holmes
Bug Squad




___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


2nd stage of footnote patch (issue 4254055)

2011-03-06 Thread m...@apollinemike.com
http://codereview.appspot.com/4254055

This implements the annotation part.  No real new stuff, but smaller and easier 
to digest.

Let me know what you think!

Cheers,
MS
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Toolchain to get scores into video?

2011-03-06 Thread Neil Puttock
On 6 March 2011 17:33, David Kastrup  wrote:
> James Lowe  writes:
>
>> The google tracker issue does work in as much as the main point of this is
>> to split the Lilypond score into 'lines' and each line is exported to an
>> EPS file - this bit is done by Lilypond (IIR) you can then manually put
>> each line into a video using most standard video editing software, this
>> bit is done by the 'user'.
>
> That would be more like flashing line by line rather than a continuous
> horizontal scroll, right?

The method which issue 965 references from Silas Brown does a
continuous horizontal scroll.  I tried it out last year and it
produces OK results (following a few code fixes).  Like James says
though, you have to produce a timing file by pressing a key whenever a
new system appears; it then uses this info to create loads of shifted
images which it stitches together.

Cheers,
Neil

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Toolchain to get scores into video?

2011-03-06 Thread m...@apollinemike.com
On Mar 6, 2011, at 12:33, David Kastrup  wrote:

> James Lowe  writes:
> 
>> The google tracker issue does work in as much as the main point of this is
>> to split the Lilypond score into 'lines' and each line is exported to an
>> EPS file - this bit is done by Lilypond (IIR) you can then manually put
>> each line into a video using most standard video editing software, this
>> bit is done by the 'user'.
> 
> That would be more like flashing line by line rather than a continuous
> horizontal scroll, right?
> 
>> Then (again using the video software) you use the timing marks created
>> manual, the music itself (that can be generated separately as midi
>> from LilyPond or be a real recording) and the snippets of music to
>> create a 'video'. It works but it is very clunky, takea a fair bit of
>> work. If you are comfortable with your video editing software, and
>> have a good recording of you music then fine, but I am not sure it is
>> quite the same as a 'follow along' video.
> 
> I'd likely be able to write (in a nontrivial amount of time) the
> required code for matching Midi time to sound file time.  That's
> reasonably manageable signal processing.
> 
> Correlating grobs to miditime would be another task.  And then, of
> course, generating the equivalent of one long strip, and making that run
> through, likely in a nice smoothed motion with some cursor following the
> notes more accurately.
> 
> -- 
> David Kastrup
> 
> 

Just to avoid potential wheel reinventing, make sure to check out the 
conference proceedings of the 2010 Journées d'Informatique Musicale. I remember 
someone presenting a time-point based score follower there.

~Mike
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Toolchain to get scores into video?

2011-03-06 Thread David Kastrup
James Lowe  writes:

> The google tracker issue does work in as much as the main point of this is
> to split the Lilypond score into 'lines' and each line is exported to an
> EPS file - this bit is done by Lilypond (IIR) you can then manually put
> each line into a video using most standard video editing software, this
> bit is done by the 'user'.

That would be more like flashing line by line rather than a continuous
horizontal scroll, right?

> Then (again using the video software) you use the timing marks created
> manual, the music itself (that can be generated separately as midi
> from LilyPond or be a real recording) and the snippets of music to
> create a 'video'. It works but it is very clunky, takea a fair bit of
> work. If you are comfortable with your video editing software, and
> have a good recording of you music then fine, but I am not sure it is
> quite the same as a 'follow along' video.

I'd likely be able to write (in a nontrivial amount of time) the
required code for matching Midi time to sound file time.  That's
reasonably manageable signal processing.

Correlating grobs to miditime would be another task.  And then, of
course, generating the equivalent of one long strip, and making that run
through, likely in a nice smoothed motion with some cursor following the
notes more accurately.

-- 
David Kastrup

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Toolchain to get scores into video?

2011-03-06 Thread James Lowe
The google tracker issue does work in as much as the main point of this is
to split the Lilypond score into 'lines' and each line is exported to an
EPS file - this bit is done by Lilypond (IIR) you can then manually put
each line into a video using most standard video editing software, this
bit is done by the 'user'.

The trick though is that this doesn't really 'follow along' as much as
display a line of a system until the 'end' of that line, and then display
the next whole line. So it;s really just a series of 'screenshots', the
user also has to determine the change of each line by manually playing
along the music separately and then, using the software, pressing keys to
indicate the change of the next line.

Then (again using the video software) you use the timing marks created
manual, the music itself (that can be generated separately as midi from
LilyPond or be a real recording) and the snippets of music to create a
'video'. It works but it is very clunky, takea a fair bit of work. If you
are comfortable with your video editing software, and have a good
recording of you music then fine, but I am not sure it is quite the same
as a 'follow along' video.

Mike S was doing some interesting things with SVG output - yo may remember
a few months ago he had LilyPond output jiggling about in webpages. I
discussed the possibility of making this a 'movie' such that the score
would 'appear'a note at a time, Mike intimated this was possible but that
getting the timing just right would be non-trivial.

It just depends on how much 'manual' editing and tweaking one wants to do
and whether the amount of work required is worth it.

James

-Original Message-
From: Graham Percival 
Date: Sun, 6 Mar 2011 15:43:10 +
To: David Kastrup 
Cc: Lilypond Dev 
Subject: Re: Toolchain to get scores into video?

>On Sun, Mar 06, 2011 at 03:55:50PM +0100, David Kastrup wrote:
>> 
>> But the question is how to get this kind of thing out of Lilypond and
>> into a video stream.
>
>http://code.google.com/p/lilypond/issues/detail?id=965
>
>If you can make a dvd, then you can certainly make a plain old
>video.
>
>(I haven't looked at the instructions in question, nor do I know
>if they still work, but that's where I'd start)
>
>Cheers,
>- Graham
>
>___
>lilypond-devel mailing list
>lilypond-devel@gnu.org
>http://lists.gnu.org/mailman/listinfo/lilypond-devel


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Clarification for footnotes push commit message

2011-03-06 Thread m...@apollinemike.com
Hey all,
In the commit message about the footnote push, you'll see a line about TEST 
ONLY. What I mean here is that it is only 1/2 of the feature and thus should 
not yet be documented or considered complete (as discussed in previous emails). 
There is nothing test-ish about the implementation, however. It is the same one 
that's been going out to the list for a few days w all of the requested fixes.

Also, Graham has informed me that commit messages should start w a one-line 
description followed by something longer. I'll do this for future commits.

Cheers,
Mike



___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Implements footnotes in LilyPond (issue4245062)

2011-03-06 Thread Mike Solomon
On Mar 5, 2011, at 10:43 AM, Neil Puttock wrote:

> On 5 March 2011 14:38, Mike Solomon  wrote:
> 
>> Done - thanks for bearing with me as I learn about break-visibility.  It is 
>> a corner of the code that I never had to deal with directly, so I'm still 
>> getting my sea legs.
> 
> I suggest you remove the fallback value from
> inherit-x-parent-visibility (or if you prefer, add another callback
> for y-parent visibility without a default) otherwise grobs which don't
> care about break-visibility (such as noteheads) will lose their
> footnotes.
> 
>> If you feel this is too hackish, I could make this direction-only (LEFT, 
>> CENTER, RIGHT) with CENTER defaulting to LEFT and have the footnote only 
>> apply to the first and last spanner.  But, for long spanners, this seems 
>> less than ideal.  As always, your suggestions are welcome!
> 
> I'm afraid I'm at a loss to suggest anything better, so I'll have to
> put up with it (unless anybody else can think of a better way.

The first half has been pushed with everything changed save this one caveat 
that you bring up.  If after a week people have better suggestions after having 
played around with these footnotes, I'll incorporate that into push 2/2.

Cheers,
MS
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Potential fix for issue 1504 (issue4237057)

2011-03-06 Thread m...@apollinemike.com
Hey all,

A potential fix for issue 1504 is posted here:

http://codereview.appspot.com/4237057/

I haven't had time to run the regtests yet (traveling), but will in the next 
few days.  There is, however, an additional regtest (see patch) that shows this 
patch in action.

Lemme know what you think!

Cheers,
MS___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Toolchain to get scores into video?

2011-03-06 Thread Graham Percival
On Sun, Mar 06, 2011 at 03:55:50PM +0100, David Kastrup wrote:
> 
> But the question is how to get this kind of thing out of Lilypond and
> into a video stream.

http://code.google.com/p/lilypond/issues/detail?id=965

If you can make a dvd, then you can certainly make a plain old
video.

(I haven't looked at the instructions in question, nor do I know
if they still work, but that's where I'd start)

Cheers,
- Graham

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Toolchain to get scores into video?

2011-03-06 Thread David Kastrup

Here is an example of what I mean:

http://www.youtube.com/watch?v=gMBJowDdFq4>

This is organized as a vertically scrolling endless paper strip with a
running cursor.

It would also be conceivable to just have a horizontally scrolling
endless staffgroup.

But the question is how to get this kind of thing out of Lilypond and
into a video stream.

Ideas?

-- 
David Kastrup


___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


LilyPond speed. Idea for Schikkers list

2011-03-06 Thread Janek Warchoł
Hi,

how fast would be LilyPond if we turned off collision detecting,
optical spacing, line breaking, beam quanting and sloping, slur
shaping, etc etc etc - basically everything except placing symbols on
paper in one infinately long system?
I thought this can be checked by remowing all possible engravers, but
doing so would prevent any symbols from appearing on staff...
Can you give any estimate?

Janek

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: DOC: NR 1.5.2 Multiple voices - part combining (issue4188056)

2011-03-06 Thread reinhold . kainhofer


http://codereview.appspot.com/4188056/diff/22001/Documentation/notation/simultaneous.itely
File Documentation/notation/simultaneous.itely (right):

http://codereview.appspot.com/4188056/diff/22001/Documentation/notation/simultaneous.itely#newcode871
Documentation/notation/simultaneous.itely:871: previous part combining
mechanism.
Actually, it never returns to the previous mechanism, but rather to the
default built-in mechanism (just like \revert always resets a grob
property to the default an not to the value before the previous
\override).

http://codereview.appspot.com/4188056/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


PATCHES: 48-hour notice for feta flag code and key signatures

2011-03-06 Thread Graham Percival
Tues, 9am.

Cleaning Feta flags code
http://codereview.appspot.com/4236043/

One-line fix for key signatures should be inherited by all Voices
http://code.google.com/p/lilypond/issues/detail?id=897


Cheers,
- Graham

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: a list of manually fine-tuned beaming exceptions?

2011-03-06 Thread Trevor Daniels


 wrote Saturday, March 05, 2011 11:05 PM


On Mar 5, 2011, at 17:33, Janek Warchoł 
 wrote:



2011/3/5 Trevor Daniels :

When I suggested investigating the automatic beaming I didn't
mean messing with the code.  But there are a number of 
parameters
in the #'details property of beam which might be worth 
exploring.


Thanks for information! Yes, this should be investigated.
However, i'm afraid that when i change some well-established
parameters, it may cause unwanted side-effects in other beams. 
And the
worst part is that i have no means to check this: it would 
require a
gigantic proof-sheet consisting of thousands of different beams 
to

check that some parameter combination works optimal.
That's why i suggested a temporary solution. It could also serve 
as a

reference beaming database later.


Having recently OD'd on beam quanting, I am convinced that the 
right
cocktails of penalties and demerits can hit all of the targets 
that would
potentially be on this list. There's nothing wrong with keeping a 
list like
this in the form of a regtest with lots of beams (I think it's a 
great idea!),


Excellent idea!

but I think the goal should be to modify the quanting such that it 
attains
the result you want while not breaking other regtests. I know this 
is a tall
order and means more work, but it seems like a better use of 
contributor

time and a more sustainable solution.



~Mike

Trevor



___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: shortened flags affair, part 4 - downstem 8th flag

2011-03-06 Thread Trevor Daniels


Janek Warchoł wrote Sunday, March 06, 2011 1:54 AM



I was curious too, so i wrote it down.
Indeed it looks like he used non-default layout (by default Lily 
uses

3 systems), but i won't call it non-optimal. In my opinion fitting
this music in two systems is perfectly reasonable here (and maybe 
even

better than spreading over 3 systems), and Lily should be able to
execute this flawlessly.
Unfortunately, measure 6 still looks bad. It's not as spectacular 
as

in his pdf, but i won't said its acceptable at all. It's a shame
especially because this problem is something in which Finale 
(2008)

excels (see attachment).


Finale certainly excels at the problem; pity about its solution!
Nice to see some irony!

Still, even not counting this, he undoubtedly proved - with some 
very

simple music - that LilyPond 2.10.33 failed to produce acceptable
output :(


Yes, but Carl is on to it.

Optimising the slur shapes is a similar problem to optimising beam
positions.  Collecting currently poor examples in a reg test is a 
good

starting point for optimising both of these.


Janek

Trevor







___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel





___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: DOC: NR 1.5.2 Multiple voices - part combining (issue4188056)

2011-03-06 Thread tdanielsmusic

LGTM, apart from a minor nitpick in original text


http://codereview.appspot.com/4188056/diff/22001/Documentation/notation/simultaneous.itely
File Documentation/notation/simultaneous.itely (left):

http://codereview.appspot.com/4188056/diff/22001/Documentation/notation/simultaneous.itely#oldcode821
Documentation/notation/simultaneous.itely:821: @qq{a2}.
@q{a2} for consistency
or change the quotes above to @qq{}

http://codereview.appspot.com/4188056/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel