Re: Sketchy sketch for a modification to the typesetting backend. (issue4446060)
http://codereview.appspot.com/4446060/diff/3/lily/beam.cc
File lily/beam.cc (right):
http://codereview.appspot.com/4446060/diff/3/lily/beam.cc#newcode1208
lily/beam.cc:1208: if ((Beam::is_cross_staff (me)
On 2011/04/25 03:20:51, hanwenn wrote:
comment why we are doing this.
If we don't do this, this continues to be a problem:
\new Staff = up \relative c'' {
\time 2/4
\autoBeamOff
b8 b b b
}
\new Staff = down \relative c'' {
b b b b
\change Staff = up
}
as does this
\new Staff = up \relative c'' {
\time 2/4
\autoBeamOff
b8 b b b
}
\new Staff = down \relative c'' {
b b b b
\change Staff = up
}
as does this
\new Staff = up \relative c'' {
\time 2/4
b8 b b b
}
\new Staff = down \relative c'' {
b b b b
\change Staff = up
}
Granted, I could keep this in the engraver as it previously was, but I
was under the impression you wanted this logic in beam.cc.
http://codereview.appspot.com/4446060/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: [PATCH] find(1) needs a path before any expression.
On Sun, Apr 24, 2011 at 08:32:40PM +0200, Matthias Kilian wrote: This unbreaks the build in a separate directory on OpenBSD. thanks, pushed. Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Add predefined mandolin fretboards to lilypond. (issue4370054)
Marc: can you send me the patch so that I can push it? http://codereview.appspot.com/4370054/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Sketchy sketch for a modification to the typesetting backend. (issue4446060)
regtests look fine. http://codereview.appspot.com/4446060/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Articulate patch for barcheck warnings. (issue4435069)
Reviewers: , Message: Please review. Description: Articulate patch for barcheck warnings. Please review this at http://codereview.appspot.com/4435069/ Affected files: M ly/articulate.ly Index: ly/articulate.ly diff --git a/ly/articulate.ly b/ly/articulate.ly index 5afb4adfe7d132e71b35b4bced2c03244ab1b709..62c0abd4ea69e9f04aae9225b22b0519d37035b9 100644 --- a/ly/articulate.ly +++ b/ly/articulate.ly @@ -375,22 +375,8 @@ ((BeamEvent) ; throw away beam events, or they'll be duplicated by turn or trill (loop factor newelements tail actions)) - ((LineBreakEvent) ; pass through linebreak events. - (loop (cons 1 1) (cons e newelements) tail actions)) - ((FingeringEvent) ; and fingering events too. - (loop factor newelements tail actions)) - - ((BreathingEvent) ; throw away BreathingEvent --- - ; should really shorten previous note a little. - (loop (cons 1 1) (cons e newelements) tail actions)) - - ((TieEvent) - (loop (cons 1 1) (cons e newelements) tail actions)) - - ((SkipEvent) - (loop (cons 1 1) (cons e newelements) tail actions)) - ((RestEvent) + ((LineBreakEvent FingeringEvent MarkEvent BreathingEvent TieEvent SkipEvent RestEvent) ; pass through some events. (loop (cons 1 1) (cons e newelements) tail actions)) ((ArticulationEvent) ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Sketchy sketch for a modification to the typesetting backend. (issue4446060)
On Mon, Apr 25, 2011 at 6:56 AM, mts...@gmail.com wrote: http://codereview.appspot.com/4446060/diff/3/lily/beam.cc File lily/beam.cc (right): http://codereview.appspot.com/4446060/diff/3/lily/beam.cc#newcode1208 lily/beam.cc:1208: if ((Beam::is_cross_staff (me) On 2011/04/25 03:20:51, hanwenn wrote: comment why we are doing this. If we don't do this, this continues to be a problem: I mean: add a short comment to the code. -- Han-Wen Nienhuys - han...@xs4all.nl - http://www.xs4all.nl/~hanwen ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Sketchy sketch for a modification to the typesetting backend. (issue4446060)
I realized that it was way too restrictive to have cross-staff beams avoid stems and beams - Reinhold had sent out a Beethoven example a while back that would need cross staff beams to take other beams into consideration. The real problem is that certain cross staff beams are not in fact cross staff beams. This patch weeds them out of beam collision work via a new function Beam::is_fake_cross_staff. Ultimately, this sorta logic can disappear once the beam collision engraver moves up to the score level, which seems like something that'll cause several bugs in the unstable version (if history is any indication) and thus is something I'm holding off on until this current crop of bugs dies down. http://codereview.appspot.com/4446060/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Add predefined mandolin fretboards to lilypond. (issue4370054)
Am 25.04.2011 13:24, schrieb percival.music...@gmail.com:
Marc: can you send me the patch so that I can push it?
http://codereview.appspot.com/4370054/
Here it is.
Regards,
Marc
From 6933e27f08ac93330511946f3c69b887aeefc1a9 Mon Sep 17 00:00:00 2001
From: Marc Hohl m...@hohlart.de
Date: Thu, 7 Apr 2011 10:42:11 +0200
Subject: [PATCH] Add predefined mandolin fretboards to lilypond.
---
.../display-predefined-mandolin-fretboards.ly | 74 ++
Documentation/notation/fretted-strings.itely | 24 +-
Documentation/notation/notation-appendices.itely |4 +
ly/predefined-mandolin-fretboards.ly | 876
4 files changed, 976 insertions(+), 2 deletions(-)
create mode 100644
Documentation/included/display-predefined-mandolin-fretboards.ly
create mode 100644 ly/predefined-mandolin-fretboards.ly
diff --git a/Documentation/included/display-predefined-mandolin-fretboards.ly
b/Documentation/included/display-predefined-mandolin-fretboards.ly
new file mode 100644
index 000..0435a91
--- /dev/null
+++ b/Documentation/included/display-predefined-mandolin-fretboards.ly
@@ -0,0 +1,74 @@
+\version 2.13.61
+\include ./predefined-mandolin-fretboards.ly
+
+
+mychords = \chordmode {
+ c1 c:m c:aug c:dim7 c:7 c:maj7 c:m7 c:m7.5-
+ c:6 c:sus2 c:sus4 c:9
+ \break
+}
+
+chordsline = {
+ \mychords
+ \transpose c cis {
+\mychords
+ }
+ \transpose c des {
+\mychords
+ }
+ \transpose c d {
+\mychords
+ }
+ \transpose c dis {
+\mychords
+ }
+ \transpose c ees {
+\mychords
+ }
+ \transpose c e {
+\mychords
+ }
+ \transpose c f {
+\mychords
+ }
+ \transpose c fis {
+\mychords
+ }
+ \transpose c ges {
+\mychords
+ }
+ \transpose c g {
+\mychords
+ }
+ \transpose c gis {
+\mychords
+ }
+ \transpose c aes {
+\mychords
+ }
+ \transpose c a {
+\mychords
+ }
+ \transpose c ais {
+\mychords
+ }
+ \transpose c bes {
+\mychords
+ }
+ \transpose c b {
+\mychords
+ }
+}
+
+
+ \context ChordNames {
+\chordsline
+ }
+ \context FretBoards {
+\set stringTunings = #mandolin-tuning
+\chordsline
+ }
+ \context Staff {
+\chordsline
+ }
+
diff --git a/Documentation/notation/fretted-strings.itely
b/Documentation/notation/fretted-strings.itely
index c60ddd4..850557f 100644
--- a/Documentation/notation/fretted-strings.itely
+++ b/Documentation/notation/fretted-strings.itely
@@ -,6 +,7 @@ Internals Reference:
@cindex fret diagrams
@cindex fret diagrams, ukulele
+@cindex fret diagrams, mandolin
@cindex chord diagrams
@funindex FretBoards
@@ -1157,6 +1158,24 @@ myChords = \chordmode { a1 a:m a:aug }
}
@end lilypond
+Fret diagrams for the mandolin are contained in the file
+@file{predefined-mandolin-fretboards.ly}.
+
+@lilypond[verbatim, ragged-right, quote]
+\include predefined-mandolin-fretboards.ly
+
+myChords = \chordmode { c1 c:m7.5- c:aug }
+
+\new ChordNames {
+ \myChords
+}
+
+\new FretBoards {
+ \set stringTunings = #mandolin-tuning
+ \myChords
+}
+@end lilypond
+
Chord pitches can be entered
either as simultaneous music or using chord mode (see
@ref{Chord mode overview}).
@@ -1394,7 +1413,8 @@ Notation Reference:
Installed Files:
@file{ly/predefined-guitar-fretboards.ly},
@file{ly/predefined-guitar-ninth-fretboards.ly},
-@file{ly/predefined-ukulele-fretboards.ly}.
+@file{ly/predefined-ukulele-fretboards.ly},
+@file{ly/predefined-mandolin-fretboards.ly}.
Snippets:
@rlsr{Fretted strings}.
@@ -1882,4 +1902,4 @@ Snippets:
@rlsr{Fretted strings}.
Installed Files:
-@file{scm/output-lib.scm} contains predefined banjo tunings.
+@file{scm/string-tunings-init.scm} contains predefined banjo tunings.
diff --git a/Documentation/notation/notation-appendices.itely
b/Documentation/notation/notation-appendices.itely
index fb5cb99..f89e563 100644
--- a/Documentation/notation/notation-appendices.itely
+++ b/Documentation/notation/notation-appendices.itely
@@ -435,6 +435,10 @@ The chart below shows the predefined fretboard diagrams
for ukulele.
@lilypondfile{display-predefined-ukulele-fretboards.ly}
+The chart below shows the predefined fretboard diagrams for mandolin.
+
+@lilypondfile{display-predefined-mandolin-fretboards.ly}
+
@node MIDI instruments
@appendixsec MIDI instruments
diff --git a/ly/predefined-mandolin-fretboards.ly
b/ly/predefined-mandolin-fretboards.ly
new file mode 100644
index 000..a971234
--- /dev/null
+++ b/ly/predefined-mandolin-fretboards.ly
@@ -0,0 +1,876 @@
+ This file is part of LilyPond, the GNU music typesetter.
+
+ Copyright (C) 2011 Marc Hohl m...@hohlart.de
+
+ LilyPond is free software: you can redistribute it and/or modify
+ it under the terms of the GNU General Public License as published by
+ the Free Software Foundation, either version 3 of the License, or
+ (at your option) any later version.
+
+ LilyPond is distributed in the hope that it will be useful,
+ but
Re: Add predefined mandolin fretboards to lilypond. (issue4370054)
On Mon, Apr 25, 2011 at 04:43:45PM +0200, Marc Hohl wrote: Am 25.04.2011 13:24, schrieb percival.music...@gmail.com: Marc: can you send me the patch so that I can push it? http://codereview.appspot.com/4370054/ Here it is. thanks, pushed. Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Allows glissandi between chords (issue4442082)
Reviewers: , Message: It gets the job done on this tiny example. I'm guessing this breaks something somewhere (haven't run the regtests yet), but I figured I'd get it out there in case any of you have time to test it, run regtests, try to break it, make suggestions, etc.. Description: Allows glissandi between chords Please review this at http://codereview.appspot.com/4442082/ Affected files: M lily/glissando-engraver.cc M scm/define-context-properties.scm ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Allows glissandi between chords (issue4442082)
The test file I've been using is:
\relative c' {
c1 \glissando g'
c,1 \glissando s1 g'
c, e1 \glissando g' b
c, e1 \glissando s1 g' b
\set glissandoMap = #'((0 . 1) (1 . 0))
c, g'1 \glissando s1 d a'
\set glissandoMap = #'((0 . 0) (0 . 1) (0 . 2))
c1 \glissando s1 d f a
\set glissandoMap = #'((2 . 0) (1 . 0) (0 . 0))
d f a1 \glissando s1 c
}
http://codereview.appspot.com/4442082/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Sketchy sketch for a modification to the typesetting backend. (issue4446060)
On Mon, Apr 25, 2011 at 9:45 AM, mts...@gmail.com wrote: I realized that it was way too restrictive to have cross-staff beams avoid stems and beams - Reinhold had sent out a Beethoven example a while back that would need cross staff beams to take other beams into consideration. You're not really into the lilypond spirit of things yet. We don't strive to be perfect; the objective is just to be better than the last release. It's ok to not handle some cases if it's too hairy. -- Han-Wen Nienhuys - han...@xs4all.nl - http://www.xs4all.nl/~hanwen ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Sketchy sketch for a modification to the typesetting backend. (issue4446060)
On Apr 25, 2011, at 3:57 PM, Han-Wen Nienhuys wrote: On Mon, Apr 25, 2011 at 9:45 AM, mts...@gmail.com wrote: I realized that it was way too restrictive to have cross-staff beams avoid stems and beams - Reinhold had sent out a Beethoven example a while back that would need cross staff beams to take other beams into consideration. You're not really into the lilypond spirit of things yet. We don't strive to be perfect; the objective is just to be better than the last release. It's ok to not handle some cases if it's too hairy. Is that a LGTM in disguise? :) Cheers, MS ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Sketchy sketch for a modification to the typesetting backend. (issue4446060)
On Mon, Apr 25, 2011 at 9:45 AM, mts...@gmail.com wrote: I realized that it was way too restrictive to have cross-staff beams avoid stems and beams - Reinhold had sent out a Beethoven example a while back that would need cross staff beams to take other beams into consideration. The real problem is that certain cross staff beams are not in fact cross staff beams. This patch weeds them out of beam collision work via a new function Beam::is_fake_cross_staff. Ultimately, this sorta logic can disappear once the beam collision engraver moves up to the score level, which seems like something that'll cause several bugs in the unstable version (if history is any indication) and thus is something I'm holding off on until this current crop of bugs dies down. Can you try with looking for the common Y refpoint of stems and beam, and seeing if that is an Y-aligment instead? This code looks a bit kludgey. alternatively, put all staff_syms into a setGrob* and check if the length 1. -- Han-Wen Nienhuys - han...@xs4all.nl - http://www.xs4all.nl/~hanwen ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Sketchy sketch for a modification to the typesetting backend. (issue4446060)
On Apr 25, 2011, at 5:37 PM, Han-Wen Nienhuys wrote: On Mon, Apr 25, 2011 at 9:45 AM, mts...@gmail.com wrote: I realized that it was way too restrictive to have cross-staff beams avoid stems and beams - Reinhold had sent out a Beethoven example a while back that would need cross staff beams to take other beams into consideration. The real problem is that certain cross staff beams are not in fact cross staff beams. This patch weeds them out of beam collision work via a new function Beam::is_fake_cross_staff. Ultimately, this sorta logic can disappear once the beam collision engraver moves up to the score level, which seems like something that'll cause several bugs in the unstable version (if history is any indication) and thus is something I'm holding off on until this current crop of bugs dies down. Can you try with looking for the common Y refpoint of stems and beam, and seeing if that is an Y-aligment instead? This code looks a bit kludgey. What is a Y-alignment? I tried git grep y-alignment git grep Y-alignment git grep Yalignment git grep yalignment git grep y_alignment but got meager results. Cheers, MS alternatively, put all staff_syms into a setGrob* and check if the length 1. -- Han-Wen Nienhuys - han...@xs4all.nl - http://www.xs4all.nl/~hanwen ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Sketchy sketch for a modification to the typesetting backend. (issue4446060)
On Mon, Apr 25, 2011 at 6:43 PM, m...@apollinemike.com m...@apollinemike.com wrote: On Apr 25, 2011, at 5:37 PM, Han-Wen Nienhuys wrote: On Mon, Apr 25, 2011 at 9:45 AM, mts...@gmail.com wrote: I realized that it was way too restrictive to have cross-staff beams avoid stems and beams - Reinhold had sent out a Beethoven example a while back that would need cross staff beams to take other beams into consideration. The real problem is that certain cross staff beams are not in fact cross staff beams. This patch weeds them out of beam collision work via a new function Beam::is_fake_cross_staff. Ultimately, this sorta logic can disappear once the beam collision engraver moves up to the score level, which seems like something that'll cause several bugs in the unstable version (if history is any indication) and thus is something I'm holding off on until this current crop of bugs dies down. Can you try with looking for the common Y refpoint of stems and beam, and seeing if that is an Y-aligment instead? This code looks a bit kludgey. What is a Y-alignment? I tried git grep y-alignment git grep Y-alignment git grep Yalignment git grep yalignment git grep y_alignment but got meager results. Look for Align_interface. IIRC, the type has an get_axis() method (or similar). -- Han-Wen Nienhuys - han...@xs4all.nl - http://www.xs4all.nl/~hanwen ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
lily/rest-collision.cc: adjust all rests in column (issue4441066)
Reviewers: , Message: patch from Keith for magical rest collisions Description: lily/rest-collision.cc: adjust all rests in column Process all rests in a noteColumn, not just the first; fix issue 1618. Print warning only for rests that are moved but don't fit; fix issue 1547. Please review this at http://codereview.appspot.com/4441066/ Affected files: M lily/rest-collision.cc ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Sketchy sketch for a modification to the typesetting backend. (issue4446060)
On Apr 25, 2011, at 5:37 PM, Han-Wen Nienhuys wrote: On Mon, Apr 25, 2011 at 9:45 AM, mts...@gmail.com wrote: I realized that it was way too restrictive to have cross-staff beams avoid stems and beams - Reinhold had sent out a Beethoven example a while back that would need cross staff beams to take other beams into consideration. The real problem is that certain cross staff beams are not in fact cross staff beams. This patch weeds them out of beam collision work via a new function Beam::is_fake_cross_staff. Ultimately, this sorta logic can disappear once the beam collision engraver moves up to the score level, which seems like something that'll cause several bugs in the unstable version (if history is any indication) and thus is something I'm holding off on until this current crop of bugs dies down. Can you try with looking for the common Y refpoint of stems and beam, and seeing if that is an Y-aligment instead? This code looks a bit kludgey. alternatively, put all staff_syms into a setGrob* and check if the length 1. I did the former. New patch set up. Cheers, MS ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Sketchy sketch for a modification to the typesetting backend. (issue4446060)
LGTM http://codereview.appspot.com/4446060/diff/11001/lily/beam.cc File lily/beam.cc (right): http://codereview.appspot.com/4446060/diff/11001/lily/beam.cc#newcode1209 lily/beam.cc:1209: if (is_cross_staff (me) Align_interface::has_interface (common_refpoint_of_array (stems, me, Y_AXIS))) can you add a TODO here to use the Align trick for is_cross_staff ? http://codereview.appspot.com/4446060/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Allows glissandi between chords (issue4442082)
Regtest uploaded and glissando-index property added to allow for the tweaking of individual Glissando grobs. http://codereview.appspot.com/4442082/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: lily/rest-collision.cc: adjust all rests in column (issue4441066)
I resolved my internet problem and uploaded a version with regtest http://codereview.appspot.com/4442083/ Please direct your reviews there. http://codereview.appspot.com/4441066/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
