Re: Add ties from Completion_note_heads_engraver to a TieColumn. (issue4592060)

2011-06-18 Thread n . puttock

Pushed: 91ff7544dcefe4fc273559047c72991d207ab5ba

http://codereview.appspot.com/4592060/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Fix breathing sign Y-offset when using line-positions. (issue4620051)

2011-06-18 Thread n . puttock

Pushed: c1a48137f98086b46a91cf5b741c0b744409904b

http://codereview.appspot.com/4620051/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Property setting in lyrics: allow markup, not just bare strings (issue4571080)

2011-06-18 Thread Neil Puttock
On 16 June 2011 17:28,   wrote:

> I won't bother with an issue tracker item for this; I think it's
> simple+clear enough that it can be pushed without a full "patch
> countdown".

Thanks, pushed: eb307731804e61efcb62a13ebbf13da5bb050f3f

Cheers,
Neil

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: multi-measure-rest.cc breaks build with log2

2011-06-18 Thread Neil Puttock
On 18 June 2011 20:33, Graham Percival  wrote:

> Looks fine, please push.

Pushed: 295ad53e7b4e3e2b2a0a612f46b184f79c3cc7ce

Cheers,
Neil

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: multi-measure-rest.cc breaks build with log2

2011-06-18 Thread Graham Percival
On Sat, Jun 18, 2011 at 06:49:51PM +0100, Neil Puttock wrote:
> The attached patch works for me: passes regtest checks and produces
> both FreeBSD builds.

Looks fine, please push.

Cheers,
- Graham

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: multi-measure-rest.cc breaks build with log2

2011-06-18 Thread Neil Puttock
On 18 June 2011 14:42, Graham Percival  wrote:
> Either use a different function, or include the right header.
>
> /main/src/gub/target/freebsd-64/src/lilypond-git.sv.gnu.org--lilypond.git-release-unstable/lily/multi-measure-rest.cc:
> In function 'int measure_duration_log(Grob*)':
> /main/src/gub/target/freebsd-64/src/lilypond-git.sv.gnu.org--lilypond.git-release-unstable/lily/multi-measure-rest.cc:130:
> error: 'log2' was not declared in this scope

The attached patch works for me: passes regtest checks and produces
both FreeBSD builds.

OK to push?

Cheers,
Neil
From 6e4e3f1ae76c824e69596c18e34763dbd2f34dee Mon Sep 17 00:00:00 2001
From: Neil Puttock 
Date: Sat, 18 Jun 2011 18:47:03 +0100
Subject: [PATCH] Compile fix for FreeBSD builds.

* lily/multi-measure-rest.cc (measure_duration_log):

  log2(3) isn't supported in older FreeBSD versions, so use log_2 from
  lily/misc.cc instead
---
 lily/multi-measure-rest.cc |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lily/multi-measure-rest.cc b/lily/multi-measure-rest.cc
index 69b71c9..1a9f5e1 100644
--- a/lily/multi-measure-rest.cc
+++ b/lily/multi-measure-rest.cc
@@ -127,7 +127,7 @@ measure_duration_log (Grob *me)
   bool round = to_boolean (me->get_property ("round-to-longer-rest"));
   Rational ml = (unsmob_moment (sml)) ? unsmob_moment (sml)->main_part_ : Rational (1);
 
-  double duration_log = -log2 (ml.Rational::to_double ());
+  double duration_log = -log_2 (ml.Rational::to_double ());
   int measure_duration_log = int (ceil (duration_log));
   if (round && duration_log - measure_duration_log < 0)
 measure_duration_log--;
-- 
1.7.4.1

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Added missing semi-colon to fret .ly file (issue4632049)

2011-06-18 Thread Carl . D . Sorensen

LGTM.   Please push.

Carl


http://codereview.appspot.com/4632049/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Doc: Added \cueClef command (issue4601060)

2011-06-18 Thread pkx166h

On 2011/06/18 14:30:39, Graham Percival wrote:

LGTM, please push.



d25fbff2e29563ae3e2bd8f3a6d7269fd1164393

Closed issue and updated tracker issue.

http://codereview.appspot.com/4601060/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Doc: Added \cueClef command (issue4601060)

2011-06-18 Thread percival . music . ca

LGTM, please push.

http://codereview.appspot.com/4601060/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Current state of automatic footnotes. (issue4580041)

2011-06-18 Thread bordage . bertrand

Hi Mike!
There is a problem with your patch, I can not compile until the end,
even after "git clean -fxd." This crashes when building internals.texi
And there is still the same spacing issues with "number_raise" and notes
higher than 9...

Thanks,
Bertrand


http://codereview.appspot.com/4580041/diff/2001/lily/page-layout-problem.cc
File lily/page-layout-problem.cc (right):

http://codereview.appspot.com/4580041/diff/2001/lily/page-layout-problem.cc#newcode209
lily/page-layout-problem.cc:209: annotation->translate_axis
(footnote_stencil->extent (Y_AXIS)[UP] + number_raise -
annotation->extent(Y_AXIS)[UP], Y_AXIS);
Looks like the vertical spacing problem comes from here.
Why not just :
annotation->translate_axis (number_raise, Y_AXIS);
?
Or with a Scheme interface that allows users to chose between fixed and
variable height ?
Same comment for line 239.

http://codereview.appspot.com/4580041/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


multi-measure-rest.cc breaks build with log2

2011-06-18 Thread Graham Percival
Either use a different function, or include the right header.

/main/src/gub/target/freebsd-64/src/lilypond-git.sv.gnu.org--lilypond.git-release-unstable/lily/multi-measure-rest.cc:
In function 'int measure_duration_log(Grob*)':
/main/src/gub/target/freebsd-64/src/lilypond-git.sv.gnu.org--lilypond.git-release-unstable/lily/multi-measure-rest.cc:130:
error: 'log2' was not declared in this scope


Cheers,
- Graham

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


RE: GOP-PROP 2: mentors and Frogs

2011-06-18 Thread James Lowe
Hello,

From: lilypond-devel-bounces+james.lowe=datacore@gnu.org 
[lilypond-devel-bounces+james.lowe=datacore@gnu.org] on behalf of Graham 
Percival [gra...@percival-music.ca]
Sent: 18 June 2011 00:48
To: Carl Sorensen
Cc: lilypond-devel@gnu.org
Subject: Re: GOP-PROP 2: mentors and Frogs



> Maybe we'll just dump all newcomers on Janek?

+1

;)

(only kidding!)

> Let's look at specifics.  Of people who have git access, what (if
> anything) would make you consider being a mentor?  Not everybody
> is cut out to be a teacher; if you don't feel comfortable in that
> position, then it's best not to offer.

Well I'm happy to help and of course I can 'mentor' someone around editing doc 
and formatting and uploading patches, however I seem to be of the 'rare' breed 
here that while understanding 'coding' principles and terminology, has no 
ability to write code (I can just about follow a relatively simple .py script). 
But I use the 'easy' tools (lilygit.tcl) and very limited git-cl and git 
commands, and so am probably less than useful to most potential contributors 
who probably know how to push a patch, can 'git their heads' (or is it 'head 
their gits'?) on the cli in their sleep. I cannot translate any doc either and 
just about get around the build process - I can deal with the problems I face 
with it better than I used to but not with any real technical understanding (i 
just worksforme).

So I can comment on general patch formatting (at least as far as the CG goes - 
but again, I would be on shaky ground commenting on C++ code formatting as the 
recent threads have proved to me).

Of course if we get person(s) who are like me and want to help with doc I'm 
fine with that, but I'm not seeing it alas. I guess 'doc aint sexy' ;)

But, if anyone thinks I could help/assist in a slot that woudl allow someone to 
move 'sideways' and use their time better spent on things they are good at 
('admin' stuff for instance) I am happy to help there.

James



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


PATCH: one-character typo in predefined-guitar-fretboards.ly

2011-06-18 Thread James Lowe
http://codereview.appspot.com/4632049

This is for tracker http://code.google.com/p/lilypond/issues/detail?id=1665

I know I could push this, but as I don't really do fret stuff, I'd like someone 
else to check it :)

Thanks

James
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Doc: Added \cueClef command (issue4601060)

2011-06-18 Thread pkx166h

Reviewers: Graham Percival,

Message:
Draft 2.

Thanks

James


http://codereview.appspot.com/4601060/diff/1/Documentation/notation/staff.itely
File Documentation/notation/staff.itely (right):

http://codereview.appspot.com/4601060/diff/1/Documentation/notation/staff.itely#newcode1221
Documentation/notation/staff.itely:1221: \new CueVoice
On 2011/06/16 16:21:51, Graham Percival wrote:

could these be
   \new CueVoice {
 \stemUp d'8^"flute" c d e fis2
   }
or
   \new CueVoice { \stemUp d'8^"flute" c d e fis2 }
instead?  that's more in keeping with the doc .ly style elsewhere.



Yes, we'll have a GOP discussion about .ly formatting, but for now if

you do the

same stuff as the rest of the docs, there's no reason to hold up this

patch.

Done.

Description:
Doc: Added \cueClef command

Added usage of \cueClef and \cueClefUnset commands.

Added some @cindex and @funindex entries

Moved the small section for cueVoice to the top and updated
the first few examples to be more in keeping with the preceding
examples added for \quoteDuring and tried to keep similar examples
throughout to show how the different commands can be used.

Added new @lilyponds showing how to use \cueClef with CueVoice.

Please review this at http://codereview.appspot.com/4601060/

Affected files:
  M Documentation/notation/staff.itely



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel