Re: Rietveld workflow problems
Reinhold Kainhofer reinh...@kainhofer.com writes: Am Wednesday, 21. September 2011, 15:04:05 schrieb David Kastrup: Reinhold Kainhofer reinh...@kainhofer.com writes: Am Wednesday, 21. September 2011, 10:52:37 schrieb David Kastrup: Perhaps it would be nice if we found a way to play with Gerrit, supposedly a git-based system similar to Rietveld. I looked at gerrit a while ago. If you want to take a look at it: http://server.kainhofer.com:8088/ Here is a quick summary: -) Each review is basically one commit in a branch on the gerrit server. Well, that's pretty much what we already have. No. In gerrit you really need to clean up your patches before you submit them for review. I typically have lots of small commits in a branch when I upload a patch to rietveld. git-cl will simply take the diff to origin/master (i.e. all patches in the branch combined into one large patch) and show the combined diff. gerrit, on the other hand, will show each small patch as one review. So, I would have to clean up my local branch before submitting for review (i.e. rebase -i and squash and reorder the patches). That's a very fundamental difference in the approach. Rietveld works on the diff level, gerrit on the git commit level. Which is what actually will get committed and thus permanently recorded. So it makes sense to get the structure as well as the result of a patch series open to review. If you feel you want to review a single humongous patch, make a separate review branch and pick the whole of the detailed branch into it with git checkout -p. As an example, how would the dev/syntax branch look when submitted uncompressed for review? That's pretty much a real-life example. And what happens with existing comments when one restructures/rebases a branch? -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Fwd: GDP Docs compilation FAILED (2011.10.18-02:49)
This has happened ever since I upgraded my Kubuntu from Natty to Oneiric a few days ago. I also encounter other random crashes when running lilypond manually. Some of them are even inside GUILE's protected areas... Any idea what might cause those random segfaults? They are reproducible, but they do not always happen with the same file. And if lilypond doesn't crash, then the resulting pdf will miss all bar lines... Cheers, Reinhold -- Weitergeleitete Nachricht -- Betreff: GDP Docs compilation FAILED (2011.10.18-02:49) Datum: Tuesday, 18. October 2011, 02:49:51 Von: Lilypond developmen lilyp...@fam.tuwien.ac.at An: reinh...@fam.tuwien.ac.at make[3]: Entering directory `/data/lilypond/build/scripts/build' mkdir -p ./out-www touch ./out-www/dummy.dep echo '*' ./out-www/.gitignore make[3]: Leaving directory `/data/lilypond/build/scripts/build' make[3]: Entering directory `/data/lilypond/build/scripts/build' true make[3]: Leaving directory `/data/lilypond/build/scripts/build' make[2]: Leaving directory `/data/lilypond/build/scripts' make[2]: Entering directory `/data/lilypond/build/flower' mkdir -p ./out-www touch ./out-www/dummy.dep echo '*' ./out-www/.gitignore make[2]: Leaving directory `/data/lilypond/build/flower' make[2]: Entering directory `/data/lilypond/build/flower' make PACKAGE=LILYPOND package=lilypond -C include WWW-1 true make[3]: Entering directory `/data/lilypond/build/flower/include' mkdir -p ./out-www touch ./out-www/dummy.dep echo '*' ./out-www/.gitignore make[3]: Leaving directory `/data/lilypond/build/flower/include' make[3]: Entering directory `/data/lilypond/build/flower/include' true make[3]: Leaving directory `/data/lilypond/build/flower/include' make[2]: Leaving directory `/data/lilypond/build/flower' make[2]: Entering directory `/data/lilypond/build/lily' mkdir -p ./out-www touch ./out-www/dummy.dep echo '*' ./out-www/.gitignore make[2]: Leaving directory `/data/lilypond/build/lily' make[2]: Entering directory `/data/lilypond/build/lily' make PACKAGE=LILYPOND package=lilypond -C include WWW-1 true make[3]: Entering directory `/data/lilypond/build/lily/include' mkdir -p ./out-www touch ./out-www/dummy.dep echo '*' ./out-www/.gitignore make[3]: Leaving directory `/data/lilypond/build/lily/include' make[3]: Entering directory `/data/lilypond/build/lily/include' true make[3]: Leaving directory `/data/lilypond/build/lily/include' make[2]: Leaving directory `/data/lilypond/build/lily' make[2]: Entering directory `/data/lilypond/build/mf' mkdir -p ./out-www touch ./out-www/dummy.dep echo '*' ./out-www/.gitignore make[2]: Leaving directory `/data/lilypond/build/mf' make[2]: Entering directory `/data/lilypond/build/mf' true make[2]: Leaving directory `/data/lilypond/build/mf' make[2]: Entering directory `/data/lilypond/build/ly' mkdir -p ./out-www touch ./out-www/dummy.dep echo '*' ./out-www/.gitignore make[2]: Leaving directory `/data/lilypond/build/ly' make[2]: Entering directory `/data/lilypond/build/ly' true make[2]: Leaving directory `/data/lilypond/build/ly' make[2]: Entering directory `/data/lilypond/build/tex' mkdir -p ./out-www touch ./out-www/dummy.dep echo '*' ./out-www/.gitignore make[2]: Leaving directory `/data/lilypond/build/tex' make[2]: Entering directory `/data/lilypond/build/tex' true make[2]: Leaving directory `/data/lilypond/build/tex' make[2]: Entering directory `/data/lilypond/build/ps' mkdir -p ./out-www touch ./out-www/dummy.dep echo '*' ./out-www/.gitignore make[2]: Leaving directory `/data/lilypond/build/ps' make[2]: Entering directory `/data/lilypond/build/ps' true make[2]: Leaving directory `/data/lilypond/build/ps' make[2]: Entering directory `/data/lilypond/build/scm' mkdir -p ./out-www touch ./out-www/dummy.dep echo '*' ./out-www/.gitignore make[2]: Leaving directory `/data/lilypond/build/scm' make[2]: Entering directory `/data/lilypond/build/scm' true make[2]: Leaving directory `/data/lilypond/build/scm' make[2]: Entering directory `/data/lilypond/build/po' mkdir -p ./out-www touch ./out-www/dummy.dep echo '*' ./out-www/.gitignore make[2]: Leaving directory `/data/lilypond/build/po' make[2]: Entering directory `/data/lilypond/build/po' true make[2]: Leaving directory `/data/lilypond/build/po' make[2]: Entering directory `/data/lilypond/build/make' mkdir -p ./out-www touch ./out-www/dummy.dep echo '*' ./out-www/.gitignore make[2]: Leaving directory `/data/lilypond/build/make' make[2]: Entering directory `/data/lilypond/build/make' true make[2]: Leaving directory `/data/lilypond/build/make' make[2]: Entering directory `/data/lilypond/build/elisp' mkdir -p ./out-www touch ./out-www/dummy.dep echo '*' ./out-www/.gitignore make[2]: Leaving directory `/data/lilypond/build/elisp' make[2]: Entering directory `/data/lilypond/build/elisp' true make[2]: Leaving directory `/data/lilypond/build/elisp' make[2]: Entering directory `/data/lilypond/build/vim' mkdir -p ./out-www touch ./out-www/dummy.dep echo '*' ./out-www/.gitignore
music variables and music templates - an idea
Hello list, I created some functions to store music in a hierarchical tree. This music store leads to the possibility to store music in one place and to get voices/parts in a defined template. If you have to put several choral pieces in one book, you can first fill all voices in this tree with a structure piece/notes/[sop|alt|ten|bas] and then later refer to that music in a common SATB-template. If your book shall have another look for all choral pieces, you only have to change the template. And if you want to combine several pieces in one bookpart, you can first \include all music definitions, then display the music where you like to. In this example file, I inserted one choral piece (SATB), wich is first displayed in a four-stave-four-lyric-system, then in a two-stave-one-lyric-system. In the underlying tree, wich is an alist, you can access values by path, wich is a list of symbols - for example (tree-get tree '(path to value)) One value can be stored in path '() Like with assoc-set!, the actual tree is not modified, but the modified is returned. These tree-functions are used in the get/put-music-functions, wich are actually defined in a closure. If I typeset pieces, I use a modified include-function, wich only includes, if the outname equals the location-name. This way I can \includeLocal a testfile, wich instantiates the current piece (wich is set before) only if I am working on that specific file: --snip-- #(define-public includeLocal (define-music-function (parser location file)(string?) (let ((outname (format ~A.ly (ly:parser-output-name parser))) (locname (car (ly:input-file-line-char-column location (if (string=? outname locname) (let ((content (ly:gulp-file file))) (ly:parser-include-string parser content))) (make-music 'SequentialMusic 'void #t --snip-- I know, this is another way to handle this multi-score-in-one-book-thing. But perhaps it includes at least some useful ideas. If this is of interest, I'd like to get respond and suggestions to improve it. Cheers, Jan-Peter \version 2.14.2 %% %%% template and music store mechanism %%% (c) 2011 by Jan-Peter Voigt %% %%% helpers #(define-public (path-string lst) (string-join (map (lambda (s)(format ~A s)) lst) / 'infix)) %%% %%% a tree in scheme %%% tree = (key . (val . (list))) % tree predicate #(define-public (tree? t) (let ((and-list (lambda (l) (let ((b #t)) (for-each (lambda (x) (set! b (and b x))) l) b (and (pair? t) (symbol? (car t)) (pair? (cdr t)) (list? (cdr (cdr t))) ;; (and-list (map (lambda (x) (tree? x)) (cdr (cdr t ) )) % create an empty tree #(define-public (tree-create sym)(cons sym (cons #f (list % set value in tree, path is a list #(define-public (tree-set! tree path val) (let ((sym (if (and (list? path)( (length path) 0))(car path) #f)) (leaf (= (length path) 0))) (if (not (tree? tree)) (set! tree (tree-create 'root))) (let ((cval (car (cdr tree))) (clst (cdr (cdr tree (set! tree (cons (car tree) (if leaf (cons val clst) (cons cval (assoc-set! clst sym (cdr (tree-set! (assoc sym clst) (if ( (length path) 1) (cdr path) '()) val )) )) ) )) ) tree)) % get value from tree, path is a list #(define-public (tree-get tree path) (let ((sym (if (and (list? path)( (length path) 0))(car path) #f)) (leaf (= (length path) 0))) (if (tree? tree) (if leaf (car (cdr tree)) (tree-get (assoc sym (cdr (cdr tree))) (if ( (length path) 1) (cdr path) '())) ) #f) )) % get branch from tree #(define-public (tree-get-tree tree path) (let ((sym (if (and (list? path)( (length path) 0))(car path) #f))) (if (tree? tree) (if sym (tree-get-tree (assoc sym (cdr (cdr tree))) (if ( (length path) 1) (cdr path) '())) tree) #f) )) % walk through the tree and call (callback path key value) % where path is the node path in the tree, key is the node name and value the value #(define-public (tree-walk tree callback . opt) (if (tree? tree) (let ((path (ly:assoc-get 'path opt (list) #f)) (dosort (ly:assoc-get 'sort opt #f #f))) (if (not (list? path)) (set! path (list path))) (callback path (car tree) (car (cdr tree))) (for-each (lambda (p) (tree-walk p callback `(path . ,(append path (list (car p `(sort . ,dosort))) (if dosort
Re: GDP Docs compilation FAILED (2011.10.18-02:49)
I haven't seen this problem yet - are you running an unoptimized binary? By some miracle, the patch I pushed today (which fixes a 0 division error in the bar line code) may fix the problem you're seeing, but I doubt that's the case, as you would have seen this problem earlier than 5 days ago. Cheers, MS On Oct 18, 2011, at 12:29 PM, Reinhold Kainhofer wrote: This has happened ever since I upgraded my Kubuntu from Natty to Oneiric a few days ago. I also encounter other random crashes when running lilypond manually. Some of them are even inside GUILE's protected areas... Any idea what might cause those random segfaults? They are reproducible, but they do not always happen with the same file. And if lilypond doesn't crash, then the resulting pdf will miss all bar lines... Cheers, Reinhold -- Weitergeleitete Nachricht -- Betreff: GDP Docs compilation FAILED (2011.10.18-02:49) Datum: Tuesday, 18. October 2011, 02:49:51 Von: Lilypond developmen lilyp...@fam.tuwien.ac.at An: reinh...@fam.tuwien.ac.at make[3]: Entering directory `/data/lilypond/build/scripts/build' mkdir -p ./out-www touch ./out-www/dummy.dep echo '*' ./out-www/.gitignore make[3]: Leaving directory `/data/lilypond/build/scripts/build' make[3]: Entering directory `/data/lilypond/build/scripts/build' true make[3]: Leaving directory `/data/lilypond/build/scripts/build' make[2]: Leaving directory `/data/lilypond/build/scripts' make[2]: Entering directory `/data/lilypond/build/flower' mkdir -p ./out-www touch ./out-www/dummy.dep echo '*' ./out-www/.gitignore make[2]: Leaving directory `/data/lilypond/build/flower' make[2]: Entering directory `/data/lilypond/build/flower' make PACKAGE=LILYPOND package=lilypond -C include WWW-1 true make[3]: Entering directory `/data/lilypond/build/flower/include' mkdir -p ./out-www touch ./out-www/dummy.dep echo '*' ./out-www/.gitignore make[3]: Leaving directory `/data/lilypond/build/flower/include' make[3]: Entering directory `/data/lilypond/build/flower/include' true make[3]: Leaving directory `/data/lilypond/build/flower/include' make[2]: Leaving directory `/data/lilypond/build/flower' make[2]: Entering directory `/data/lilypond/build/lily' mkdir -p ./out-www touch ./out-www/dummy.dep echo '*' ./out-www/.gitignore make[2]: Leaving directory `/data/lilypond/build/lily' make[2]: Entering directory `/data/lilypond/build/lily' make PACKAGE=LILYPOND package=lilypond -C include WWW-1 true make[3]: Entering directory `/data/lilypond/build/lily/include' mkdir -p ./out-www touch ./out-www/dummy.dep echo '*' ./out-www/.gitignore make[3]: Leaving directory `/data/lilypond/build/lily/include' make[3]: Entering directory `/data/lilypond/build/lily/include' true make[3]: Leaving directory `/data/lilypond/build/lily/include' make[2]: Leaving directory `/data/lilypond/build/lily' make[2]: Entering directory `/data/lilypond/build/mf' mkdir -p ./out-www touch ./out-www/dummy.dep echo '*' ./out-www/.gitignore make[2]: Leaving directory `/data/lilypond/build/mf' make[2]: Entering directory `/data/lilypond/build/mf' true make[2]: Leaving directory `/data/lilypond/build/mf' make[2]: Entering directory `/data/lilypond/build/ly' mkdir -p ./out-www touch ./out-www/dummy.dep echo '*' ./out-www/.gitignore make[2]: Leaving directory `/data/lilypond/build/ly' make[2]: Entering directory `/data/lilypond/build/ly' true make[2]: Leaving directory `/data/lilypond/build/ly' make[2]: Entering directory `/data/lilypond/build/tex' mkdir -p ./out-www touch ./out-www/dummy.dep echo '*' ./out-www/.gitignore make[2]: Leaving directory `/data/lilypond/build/tex' make[2]: Entering directory `/data/lilypond/build/tex' true make[2]: Leaving directory `/data/lilypond/build/tex' make[2]: Entering directory `/data/lilypond/build/ps' mkdir -p ./out-www touch ./out-www/dummy.dep echo '*' ./out-www/.gitignore make[2]: Leaving directory `/data/lilypond/build/ps' make[2]: Entering directory `/data/lilypond/build/ps' true make[2]: Leaving directory `/data/lilypond/build/ps' make[2]: Entering directory `/data/lilypond/build/scm' mkdir -p ./out-www touch ./out-www/dummy.dep echo '*' ./out-www/.gitignore make[2]: Leaving directory `/data/lilypond/build/scm' make[2]: Entering directory `/data/lilypond/build/scm' true make[2]: Leaving directory `/data/lilypond/build/scm' make[2]: Entering directory `/data/lilypond/build/po' mkdir -p ./out-www touch ./out-www/dummy.dep echo '*' ./out-www/.gitignore make[2]: Leaving directory `/data/lilypond/build/po' make[2]: Entering directory `/data/lilypond/build/po' true make[2]: Leaving directory `/data/lilypond/build/po' make[2]: Entering directory `/data/lilypond/build/make' mkdir -p ./out-www touch ./out-www/dummy.dep echo '*' ./out-www/.gitignore make[2]: Leaving directory `/data/lilypond/build/make' make[2]: Entering directory `/data/lilypond/build/make' true
Re: Fix the links to music samples in web-big-page (issue 1663). (issue 5276054)
Reviewers: J_lowe, Message: On 2011/10/18 05:48:08, J_lowe wrote: Graham, This fails at the basic make stage ../configure ; make -j7 I also re-ran make multiple times to see if it was 'one of those things' but it fails the same. --snip-- make[2]: Leaving directory `/home/jlowe/lilypond-git/build/Documentation/included' make: Entering an unknown directory make: *** ly-examples: No such file or directory. Stop. make: Leaving an unknown directory make[1]: *** [all] Error 2 make[1]: Leaving directory `/home/jlowe/lilypond-git/build/Documentation' make: *** [all] Error 2 jlowe@jlowe-lilybuntu2:~/lilypond-git/build$ --snip-- I'm trying to investigate but I cannot reproduce your problem. Did the patch apply properly? If it did it would have created the Documentation/ly-examples directory. Did configure proceed completely? It should have created the build/Documentation/ly-examples directory. Otherwise I don't see how you would get this error. And you also get this with just `make' instead of `make -j7', rigth? Thanks, Regards, Julien Description: Fix the links to music samples in web-big-page (issue 1663). We move all of Documentation/web/ly-examples to Documentation/ly-examples and rework the links for the split manuals. This puts the ly-examples subdir on par with the pictures subdir as a top-level subdir. Please review this at http://codereview.appspot.com/5276054/ Affected files: M Documentation/GNUmakefile A + Documentation/ly-examples/GNUmakefile A + Documentation/ly-examples/ancient-headword.ly A + Documentation/ly-examples/aucun-snippet.ly A + Documentation/ly-examples/bach-bwv610.ly A + Documentation/ly-examples/bach-schenker.ly A + Documentation/ly-examples/cary-layout.ily A + Documentation/ly-examples/cary.ly A + Documentation/ly-examples/chart.ly A + Documentation/ly-examples/example-header.ily A + Documentation/ly-examples/granados.ly A + Documentation/ly-examples/orchestra.ly A + Documentation/ly-examples/sesto-full.ly A + Documentation/ly-examples/sesto-piano.ly A + Documentation/ly-examples/sesto-violin.ly A + Documentation/ly-examples/sesto.ily A + Documentation/ly-examples/tab-example.ly A + Documentation/ly-examples/theory.ly M Documentation/web/GNUmakefile M make/website.make M python/auxiliar/postprocess_html.py Index: Documentation/GNUmakefile diff --git a/Documentation/GNUmakefile b/Documentation/GNUmakefile index 8f5006ef80a97c288aaa99908e426dc50c019840..eed10536acb89db85001b35ba77c24c4c01593dc 100644 --- a/Documentation/GNUmakefile +++ b/Documentation/GNUmakefile @@ -12,7 +12,7 @@ LANGS = $(shell $(PYTHON) $(top-src-dir)/python/langdefs.py) MANUALS_SUBDIRS = usage contributor essay \ web learning notation extending SUBDIRS = $(MANUALS_SUBDIRS) snippets logo pictures misc po css topdocs \ - included $(LANGS) + included ly-examples $(LANGS) STEPMAKE_TEMPLATES = documentation texinfo tex omf LOCALSTEPMAKE_TEMPLATES = lilypond ly @@ -228,8 +228,8 @@ $(outdir)/pictures: $(outdir)/web.texi: $(outdir)/ly-examples $(outdir)/ly-examples: - $(MAKE) -C web/ly-examples - ln -sf ../web/ly-examples/$(outdir) $@ + $(MAKE) -C ly-examples + ln -sf ../ly-examples/$(outdir) $@ endif Index: Documentation/ly-examples/GNUmakefile diff --git a/Documentation/web/ly-examples/GNUmakefile b/Documentation/ly-examples/GNUmakefile similarity index 97% rename from Documentation/web/ly-examples/GNUmakefile rename to Documentation/ly-examples/GNUmakefile index 473d16b96764b4aef9644635eda5c6988bedb421..f47ad063523d966aa604fabd596f33d8413933c9 100644 --- a/Documentation/web/ly-examples/GNUmakefile +++ b/Documentation/ly-examples/GNUmakefile @@ -1,4 +1,4 @@ -depth=../../.. +depth=../.. LOCALSTEPMAKE_TEMPLATES=lilypond ly include $(depth)/make/stepmake.make Index: Documentation/ly-examples/ancient-headword.ly diff --git a/Documentation/web/ly-examples/ancient-headword.ly b/Documentation/ly-examples/ancient-headword.ly similarity index 100% rename from Documentation/web/ly-examples/ancient-headword.ly rename to Documentation/ly-examples/ancient-headword.ly Index: Documentation/ly-examples/aucun-snippet.ly diff --git a/Documentation/web/ly-examples/aucun-snippet.ly b/Documentation/ly-examples/aucun-snippet.ly similarity index 100% rename from Documentation/web/ly-examples/aucun-snippet.ly rename to Documentation/ly-examples/aucun-snippet.ly Index: Documentation/ly-examples/bach-bwv610.ly diff --git a/Documentation/web/ly-examples/bach-bwv610.ly b/Documentation/ly-examples/bach-bwv610.ly similarity index 100% rename from Documentation/web/ly-examples/bach-bwv610.ly rename to Documentation/ly-examples/bach-bwv610.ly Index: Documentation/ly-examples/bach-schenker.ly diff --git a/Documentation/web/ly-examples/bach-schenker.ly b/Documentation/ly-examples/bach-schenker.ly similarity index 100% rename from Documentation/web/ly-examples/bach-schenker.ly rename to
Re: GDP Docs compilation FAILED (2011.10.18-02:49)
2011/10/18 Reinhold Kainhofer reinh...@fam.tuwien.ac.at: This has happened ever since I upgraded my Kubuntu from Natty to Oneiric a few days ago. I compiled binary+docs in Oneiric 64bit yesterday. Had to nuke the lily/ directory first. -- Francisco Vila. Badajoz (Spain) www.paconet.org , www.csmbadajoz.com ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fix the links to music samples in web-big-page (issue 1663). (issue 5276054)
On Tue, Oct 18, 2011 at 05:48:08AM +, pkx1...@gmail.com wrote: This fails at the basic make stage ../configure ; make -j7 oops, I should have mentioned: run ./autogen.sh --noconfigure first, then do configure and make. Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fix the links to music samples in web-big-page (issue 1663). (issue 5276054)
Julien, I have done this on my 'VM' at work - this is a single CPU Lilydev. I get the same problem with just make (not make -jx). Also see the git status after the patch apply (I ran this command after the make failed) see below. --snip-- make[2]: Leaving directory `/home/jlowe/lilypond-git/build/Documentation/included' make: Entering an unknown directory make: *** ly-examples: No such file or directory. Stop. make: Leaving an unknown directory make[1]: *** [all] Error 2 make[1]: Leaving directory `/home/jlowe/lilypond-git/build/Documentation' make: *** [all] Error 2 jlowe@jamesLBVM:~/lilypond-git/build$ git status # On branch master # Changed but not updated: # (use git add file... to update what will be committed) # (use git checkout -- file... to discard changes in working directory) # # modified: ../Documentation/GNUmakefile # modified: ../Documentation/web/GNUmakefile # modified: ../Documentation/web/ly-examples/GNUmakefile # modified: ../make/website.make # modified: ../python/auxiliar/postprocess_html.py # no changes added to commit (use git add and/or git commit -a) jlowe@jamesLBVM:~/lilypond-git/build$ --snip-- James http://codereview.appspot.com/5276054/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fix the links to music samples in web-big-page (issue 1663). (issue 5276054)
Graham, On Tue, Oct 18, 2011 at 1:06 PM, Graham Percival gra...@percival-music.ca wrote: On Tue, Oct 18, 2011 at 05:48:08AM +, pkx1...@gmail.com wrote: This fails at the basic make stage ../configure ; make -j7 oops, I should have mentioned: run ./autogen.sh --noconfigure first, then do configure and make. I thought it might be the same too, so I redid this on my single cpu VM at work. Same problem even with ./autogen.sh --noconfigure mkdir build cd build ../configure make git status gives me --snip-- jlowe@jamesLBVM:~/lilypond-git/build$ git status # On branch master # Changed but not updated: # (use git add file... to update what will be committed) # (use git checkout -- file... to discard changes in working directory) # # modified: ../Documentation/GNUmakefile # modified: ../Documentation/web/GNUmakefile # modified: ../Documentation/web/ly-examples/GNUmakefile # modified: ../make/website.make # modified: ../python/auxiliar/postprocess_html.py # no changes added to commit (use git add and/or git commit -a) jlowe@jamesLBVM:~/lilypond-git/build$ --snip-- -- -- James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Optimizes note-heads.cc and introduces robust_symbol2string. (issue 5233042)
Pushed as 8adeb99e344bf047b9b3b9b48a9e97e59e8fc4d3 and 71aa438bce0f68b0e8ab8c633b4902c971ede48b. http://codereview.appspot.com/5233042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fix the links to music samples in web-big-page (issue 1663). (issue 5276054)
Hi again, How did you apply the patch? Here I use git cl patch 5276054 and I get this commit (notice the renames): # On branch rietvield-issue-5276054 # Changes to be committed: # (use git reset HEAD^1 file... to unstage) # # modified: Documentation/GNUmakefile # renamed:Documentation/web/ly-examples/GNUmakefile - Documentation/ly-examples/GNUmakefile # renamed:Documentation/web/ly-examples/ancient-headword.ly - Documentation/ly-examples/ancient-headword.ly # renamed:Documentation/web/ly-examples/aucun-snippet.ly - Documentation/ly-examples/aucun-snippet.ly # renamed:Documentation/web/ly-examples/bach-bwv610.ly - Documentation/ly-examples/bach-bwv610.ly # renamed:Documentation/web/ly-examples/bach-schenker.ly - Documentation/ly-examples/bach-schenker.ly # renamed:Documentation/web/ly-examples/cary-layout.ily - Documentation/ly-examples/cary-layout.ily # renamed:Documentation/web/ly-examples/cary.ly - Documentation/ly-examples/cary.ly # renamed:Documentation/web/ly-examples/chart.ly - Documentation/ly-examples/chart.ly # renamed:Documentation/web/ly-examples/example-header.ily - Documentation/ly-examples/example-header.ily # renamed:Documentation/web/ly-examples/granados.ly - Documentation/ly-examples/granados.ly # renamed:Documentation/web/ly-examples/orchestra.ly - Documentation/ly-examples/orchestra.ly # renamed:Documentation/web/ly-examples/sesto-full.ly - Documentation/ly-examples/sesto-full.ly # renamed:Documentation/web/ly-examples/sesto-piano.ly - Documentation/ly-examples/sesto-piano.ly # renamed:Documentation/web/ly-examples/sesto-violin.ly - Documentation/ly-examples/sesto-violin.ly # renamed:Documentation/web/ly-examples/sesto.ily - Documentation/ly-examples/sesto.ily # renamed:Documentation/web/ly-examples/tab-example.ly - Documentation/ly-examples/tab-example.ly # renamed:Documentation/web/ly-examples/theory.ly - Documentation/ly-examples/theory.ly # modified: Documentation/web/GNUmakefile # modified: make/website.make # modified: python/auxiliar/postprocess_html.py On Tue, Oct 18, 2011 at 2:50 PM, pkx1...@gmail.com wrote: Julien, I have done this on my 'VM' at work - this is a single CPU Lilydev. I get the same problem with just make (not make -jx). Also see the git status after the patch apply (I ran this command after the make failed) see below. --snip-- make[2]: Leaving directory `/home/jlowe/lilypond-git/build/Documentation/included' make: Entering an unknown directory make: *** ly-examples: No such file or directory. Stop. make: Leaving an unknown directory make[1]: *** [all] Error 2 make[1]: Leaving directory `/home/jlowe/lilypond-git/build/Documentation' make: *** [all] Error 2 jlowe@jamesLBVM:~/lilypond-git/build$ git status # On branch master # Changed but not updated: # (use git add file... to update what will be committed) # (use git checkout -- file... to discard changes in working directory) # # modified: ../Documentation/GNUmakefile # modified: ../Documentation/web/GNUmakefile # modified: ../Documentation/web/ly-examples/GNUmakefile # modified: ../make/website.make # modified: ../python/auxiliar/postprocess_html.py # no changes added to commit (use git add and/or git commit -a) jlowe@jamesLBVM:~/lilypond-git/build$ --snip-- James http://codereview.appspot.com/5276054/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fix the links to music samples in web-big-page (issue 1663). (issue 5276054)
On Tue, Oct 18, 2011 at 3:01 PM, Julien Rioux julien.ri...@gmail.com wrote: Here I use git cl patch 5276054 Just a warning that this might not be the suggested procedure: if you do this in master it might break things, I have no idea. So if you know how to use branches, you could try that command in a branch, but otherwise don't try it in master unless you're confident that it doesn't cause problems. Cheers, Julien ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: lily-guile updates and CG: Scheme-C interface section. (issue 4917044)
I pushed the doc as b4a2cb2cf00347c477ed595f1435cc212e70ce33. Could the remaining C part of the patch be 'countdowned'? http://codereview.appspot.com/4917044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: First stab at getting script offsets right. (issue 5235052)
http://codereview.appspot.com/5235052/diff/17001/lily/script-engraver.cc File lily/script-engraver.cc (right): http://codereview.appspot.com/5235052/diff/17001/lily/script-engraver.cc#newcode206 lily/script-engraver.cc:206: Script_engraver::acknowledge_inline_accidental (Grob_info info) Doesn't this add every accidental to a script in a chord? I'm concerned there's a risk the side-positioning calculation might be incorrect, since the accidentals are shuffled around via AccidentalPlacement later. http://codereview.appspot.com/5235052/diff/17001/lily/side-position-interface.cc File lily/side-position-interface.cc (right): http://codereview.appspot.com/5235052/diff/17001/lily/side-position-interface.cc#newcode218 lily/side-position-interface.cc:218: b[ax] = e-maybe_pure_extent (common[ax], ax, pure, start, end); Accidentals have special treatment for more accurate boxes. Could you use them instead (or get the skyline from AccidentalPlacement instead)? http://codereview.appspot.com/5235052/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fix the links to music samples in web-big-page (issue 1663). (issue 5276054)
Julien, On Tue, Oct 18, 2011 at 2:01 PM, Julien Rioux julien.ri...@gmail.com wrote: Hi again, How did you apply the patch? Here I use git cl patch 5276054 and I get this commit (notice the renames): I right click on the 'download raw patch set' link in the Rietveld issue so it comes down as an issue*.diff file. The I cd into the top level of the lilypond-git dir patch -p1 ../Desktop/issue123456.diff if you'd like me to use 'git am' then send me git formatted patch by email and i can apply that for you instead. Regards -- -- James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fix the links to music samples in web-big-page (issue 1663). (issue 5276054)
On Tue, Oct 18, 2011 at 05:21:52PM +0100, Peekay Ex wrote: Julien, On Tue, Oct 18, 2011 at 2:01 PM, Julien Rioux julien.ri...@gmail.com wrote: Hi again, How did you apply the patch? Here I use if you'd like me to use 'git am' then send me git formatted patch by email and i can apply that for you instead. hmm, this is getting complicated. I'll take a look at it when I go to university at midnight. James, thanks for your efforts. Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: How do feel people about the following change in syntax?
David Kastrup d...@gnu.org writes:
David Kastrup d...@gnu.org writes:
Graham Percival gra...@percival-music.ca writes:
What happens if somebody writes
{ \with fooc4 \with bard4 }
?
Good catch. I don't think we want anything but a syntax error here.
One approach would be not to ignore Scheme expressions in a sequence
unless they evaluate to unspecified or at least a limited set of
ignorable values.
More compatible would be the approach that you can omit braces only when
a certain construct is syntactically expected somewhere: if it is to be
produced foreignly, use # or { ... }. Then
{ { \with foo } c4 { \with bar } d4 }
would be a music sequence with two Scheme expressions inside getting
ignored, and { \with foo c4 \with bar d4 } would be a syntax error.
On the other hand: why silently ignore a likely side-effect-free
expression? It is likely to be a programmer error. So I lean towards
ignoring only expressions with unspecified value (basically all
Scheme assignments) for the first attempt. If tests with real-world
documents show this to be too disruptive, one can think about
alternatives.
For a first test, I made Lilypond barf on everything non-unspecified. I
did not get through with make all mostly because of several instances
of module-define! which chooses to return a boolean. What a nuisance.
I changed the error condition such that booleans were also considered
acceptable. Apart from drumpitch-init.ly which chose to use map where
for-each would have been appropriate, make all succeeded and make test
is not failing all that much (unfortunately, the magic grep command
for getting the bad source files does not work, and apparently the
problematic files don't get deleted by make either when I call
non_fatal_error so I get success on a second run without a make
test-clean in between. I need some more sleuthing). All in all, looks
promising with regard to not causing all too much breakage to existing
code.
After all, the Lilypond sources are more likely to contain weird
embedded Scheme expressions called for side-effect but returning
specific values than typical user code does.
It might make sense to introduce a syntax change like that in two
stages: in the first stage, one just complains about embedded Scheme
that could be mistaken for something useful. Only in the second stage,
one does not complain but interprets it accordingly.
--
David Kastrup
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Glyphs for Kievan Notation (issue 4951062)
Fixed the issues addressed by Bertrand. What still remains: 1. Implementing beams 2. Changing the spacing so that notes in a phrasing slur are closer together. 3. Remove extra space after final note. Comments much appreciated. http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Glyphs for Kievan Notation (issue 4951062)
LGTM. Two tiny changes and it'll be ready to push. http://codereview.appspot.com/4951062/diff/78001/ly/engraver-init.ly File ly/engraver-init.ly (right): http://codereview.appspot.com/4951062/diff/78001/ly/engraver-init.ly#newcode1107 ly/engraver-init.ly:1107: \remove Stem_engraver Sorry, I made a mistake. This line is producing errors when we use the kievanvoice/staff. You have to remove this and add a \override Stem #'stencil = ##f instead. http://codereview.appspot.com/4951062/diff/78001/ly/engraver-init.ly#newcode1114 ly/engraver-init.ly:1114: \override Slur #'transparent = ##t Could you change 'transparent' into 'stencil'? With transparent, the stem is invisible, but still there. The calculus of grob positions can be disturbed by that. http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fix the links to music samples in web-big-page (issue 1663). (issue 5276054)
On Tue, Oct 18, 2011 at 6:21 PM, Peekay Ex pkx1...@gmail.com wrote: Julien, On Tue, Oct 18, 2011 at 2:01 PM, Julien Rioux julien.ri...@gmail.com wrote: Hi again, How did you apply the patch? Here I use git cl patch 5276054 and I get this commit (notice the renames): I right click on the 'download raw patch set' link in the Rietveld issue so it comes down as an issue*.diff file. The I cd into the top level of the lilypond-git dir patch -p1 ../Desktop/issue123456.diff git apply ../Desktop/issue123456.diff seems to work better than patch. Cheers, Julien ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Fix the links to music samples in web-big-page (issue 1663). (issue 5276054)
On Tue, Oct 18, 2011 at 3:07 PM, Julien Rioux julien.ri...@gmail.com wrote: On Tue, Oct 18, 2011 at 3:01 PM, Julien Rioux julien.ri...@gmail.com wrote: Here I use git cl patch 5276054 Just a warning that this might not be the suggested procedure: if you do this in master it might break things, I have no idea. So if you know how to use branches, you could try that command in a branch, but otherwise don't try it in master unless you're confident that it doesn't cause problems. Cheers, Julien git cl patch --help reveals the command-line option -n, --no-commit don't commit after patch applies which would be equivalent to using patch -p1 as you were doing. To sum it up, this one-liner downloads the patch for you and apply it locally without committing: git cl patch -n 5276054 ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: How do feel people about the following change in syntax?
David Kastrup d...@gnu.org writes: For a first test, I made Lilypond barf on everything non-unspecified. I did not get through with make all mostly because of several instances of module-define! which chooses to return a boolean. What a nuisance. I changed the error condition such that booleans were also considered acceptable. Apart from drumpitch-init.ly which chose to use map where for-each would have been appropriate, make all succeeded and make test is not failing all that much (unfortunately, the magic grep command for getting the bad source files does not work, and apparently the problematic files don't get deleted by make either when I call non_fatal_error so I get success on a second run without a make test-clean in between. I need some more sleuthing). All in all, looks promising with regard to not causing all too much breakage to existing code. After all, the Lilypond sources are more likely to contain weird embedded Scheme expressions called for side-effect but returning specific values than typical user code does. It might make sense to introduce a syntax change like that in two stages: in the first stage, one just complains about embedded Scheme that could be mistaken for something useful. Only in the second stage, one does not complain but interprets it accordingly. Hm. The bad cases are mostly due to Scheme letting a function like hashq-set! or set-object-property! return a value. How stupid. A first measure had been the creation of (define-macro (define-void-function . rest) `(define-scheme-function ,@rest (begin))) and using that instead of define-scheme-function in music-functions-init.ly (up to now, Scheme functions are used there only for effect rather than value). There are still things like #(set-object-property! ...) in the source. Redefining all those would likely be a bit overkill, so basically it will be advisable to use something like \ignore #(set-object-property! ... or \void #(set-object-property! ... to silence the more obstinate Scheme expressions. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: How do feel people about the following change in syntax?
David Kastrup d...@gnu.org writes: David Kastrup d...@gnu.org writes: It might make sense to introduce a syntax change like that in two stages: in the first stage, one just complains about embedded Scheme that could be mistaken for something useful. Only in the second stage, one does not complain but interprets it accordingly. Hm. The bad cases are mostly due to Scheme letting a function like hashq-set! or set-object-property! return a value. How stupid. A first measure had been the creation of (define-macro (define-void-function . rest) `(define-scheme-function ,@rest (begin))) and using that instead of define-scheme-function in music-functions-init.ly (up to now, Scheme functions are used there only for effect rather than value). There are still things like #(set-object-property! ...) in the source. Redefining all those would likely be a bit overkill, so basically it will be advisable to use something like \ignore #(set-object-property! ... or \void #(set-object-property! ... to silence the more obstinate Scheme expressions. On the plus side, I get, say, cue-clef-after-barline.ly:28:38: error: ignoring specific Scheme value \revert Score.BarLine #'space-alist #'cue-clef I which clearly points out a programming error. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: GDP Docs compilation FAILED (2011.10.18-02:49)
Am Tuesday, 18. October 2011, 13:34:14 schrieb Francisco Vila: 2011/10/18 Reinhold Kainhofer reinh...@fam.tuwien.ac.at: This has happened ever since I upgraded my Kubuntu from Natty to Oneiric a few days ago. I compiled binary+docs in Oneiric 64bit yesterday. Had to nuke the lily/ directory first. That error is on a clean build from scratch (the build dir is erased every night before the build) on an Oneiric 32-bit system... Mike's patch also didn't fix it (happened again tonight, at the exact same spot). Cheers, Reinhold -- -- Reinhold Kainhofer, reinh...@kainhofer.com, http://reinhold.kainhofer.com/ * Financial Actuarial Math., Vienna Univ. of Technology, Austria * http://www.fam.tuwien.ac.at/, DVR: 0005886 * LilyPond, Music typesetting, http://www.lilypond.org ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCH: Countdown to 20111020
For 21:00 MDT Thursday October 20 Issue 983 http://code.google.com/p/lilypond/issues/detail?id=983: relative location of css/ and pictures/ dir - R5285053 http://codereview.appspot.com/5285053/ Issue 1917 http://code.google.com/p/lilypond/issues/detail?id=1917: Hyperlinks in web-big-page.html do not work - R5295041 http://codereview.appspot.com/5295041/ Issue 1952 http://code.google.com/p/lilypond/issues/detail?id=1952: Patch: Sketch for broken beams with consistent slopes - R 4961041 http://codereview.appspot.com/4961041/ Issue 1974 http://code.google.com/p/lilypond/issues/detail?id=1974: Fix the 404 on contributor-big-page and contributor/website-build - R 5268050 http://codereview.appspot.com/5268050/ Rietveld-only? 4917044 http://codereview.appspot.com/4917044/: lily-guile updates and CG: Scheme-C interface section. Cheers, Colin -- I've learned that you shouldn't go through life with a catcher's mitt on both hands. You need to be able to throw something back. -Maya Angelou, poet (1928- ) ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Adapting Lilypond Rendering Engine for iPad
On Tue, Oct 18, 2011 at 08:39:14PM -0700, kieran coulter wrote: It seems like they've relaxed those restrictions since 2010, but I could be wrong. I would want solid evidence of this. Look into the Battle of Westnoth fiasco -- not that I blame apple for this. As far as I know, their license agreement is clearly incompatible with the GPL; it was certain Wesnoth developers who knowingly ignored that and then got burned when their app was pulled. What might be the main obstacles I would run into, and are any insurmountable? Biggest obstacle: licensing, and AFAIK this is insurmountable unless you have enough shares to force Apple to change their policy. Since their whole infrastructure is built around their walled garden, I think you'd need to own at least 30% of the company's shares before you had any chance of forcing a policy change. Sorry. - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
