date:20120306

On Mon, Mar 5, 2012 at 11:17 PM, Graham Percival
 wrote:
> On Mon, Mar 05, 2012 at 10:48:28PM +0100, Janek Warchoł wrote:
>> Graham, i understand that you'll be our project administrator.  When
>> Ideas List will be up, you'll have to register at
>> http://www.google-melange.com/gsoc/homepage/google/gsoc2012 and fill
>> our application (it consists of answering the 16 questions - for which
>> we already have answers - and agreeing to admin agreement).
>
> What happens about the tax form?  I'm not signing any legal
> document unless I'm certain it's the right thing.  Is GNU
> submitting that "foreign income" thing for us ? ... although I
> suppose that GNU is an American organization, so they'd file a
> different tax form?

I've asked on #gsoc IRC channel.  The situation in our case is as follows:
- we have no legal body, so we would be represented by an individual.
This person will act as LilyPond Mentoring Organization inside GSoC,
but this doesn't mean any legal implications outside GSoC.  It means
doing administration stuff for GSoC.
- this person registers at GSoC and files LilyPond application, no
legal documents are needed for that.  The only legal outcome is that
this person agrees to be LilyPond admin for GSoC.
- from Google's point of view, this person is "working for Google"
during GSoC (but it doesn't mean you become Google employee).  $500
for mentoring organization is just a payment for this work.
- To send this payment, Google needs tax-related documents.  If the
admin is not a US person, it needs just a declaration of this fact
(that's what W-8BEN is used for).  You don't need to be a US taxpayer.
 I repeat: non-US admin has to file W-8BEN form that roughly says
"hey, US government, i'm not American and this money is none of your
business".
- the $500 is an income for the admin, so he may need to pay taxes in
his country.
- i was (unofficially) told that if you don't send the W-8BEN form,
Google doesn't get upset and simply doesn't send you the money,
especially if you notify them about it.

Bottom line: all the tax stuff is related to the admin payment, not to
the participation in GSoC itself.

Graham, does this answer your question?

Janek

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Wikimedia and LilyPond

On Tue, Mar 6, 2012 at 12:13 PM, David Kastrup  wrote:
>
> As one can see in
> https://bugzilla.wikimedia.org/show_bug.cgi?id=7355>, LilyPond
> plugins are not considered safe to use in Wikimedia because of Denial of
> Service concerns.
>
> However, a sizable number of contributors could likely be expected to
> actually run LilyPond on their own computer.  So can anybody more
> familiar with HTML and browser technologies figure out what would be
> required to create, say, a Firefox browser plugin that will submit
> content structured as SVG plus source code leading to essentially the
> same results?  If the music processes were run on the system of the
> contributor, the DoS concerns would be addressed.

+1
(i'm not familiar with HTML and browser technologies, sorry... but i
can do testing if someone writes the plugin)

Janek

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Google Summer of Code, LilyPond and GNU

2012-03-06 Thread Graham Percival

On Tue, Mar 06, 2012 at 01:22:42PM +0100, Janek Warchoł wrote:
> On Mon, Mar 5, 2012 at 11:17 PM, Graham Percival
>  wrote:
> > What happens about the tax form?  I'm not signing any legal
> > document unless I'm certain it's the right thing.  Is GNU
> > submitting that "foreign income" thing for us ? ... although I
> > suppose that GNU is an American organization, so they'd file a
> > different tax form?
> 
> I've asked on #gsoc IRC channel.

Thanks for clarifying this!

> - we have no legal body, so we would be represented by an individual.
> This person will act as LilyPond Mentoring Organization inside GSoC,
> but this doesn't mean any legal implications outside GSoC.  It means
> doing administration stuff for GSoC.

ok.

> - i was (unofficially) told that if you don't send the W-8BEN form,
> Google doesn't get upset and simply doesn't send you the money,
> especially if you notify them about it.

Ok, if I'm the admin person, that is what I would do.  Some people
might view that as a waste of $500 (or more; IIRC it's $500 for
each student).  If so, then speak up and offer to be this admin
person instead.

- Graham

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Google Summer of Code, LilyPond and GNU

On Tue, Mar 6, 2012 at 1:38 PM, Graham Percival
 wrote:
> Let's see if we can rescue this somehow.
>
> On Tue, Mar 06, 2012 at 09:52:00AM +0100, Janek Warchoł wrote:
>> On Mon, Mar 5, 2012 at 11:17 PM, Graham Percival
>>  wrote:
>> > No.  Put the patch on rietveld, and once people have commented, it
>> > gets pushed to staging.
>>
>> Aaargh!  This will take 2 or 3 days.  As a part of our application to
>> GSoC we *must* include URL to our ideas list.  So we must get it
>> online As Soon As Possible!
>
> I'm not saying it needs to wait for a full countdown, but I think
> we should have it available for comment for some amount of time.

ah, ok.

>> I guess i'm stupid
>> and ugly and don't know how to satisfy your question and handle all
>> this, can you help me?
>
> First, yes I'll try to help you and get something worked out.

Thanks!

> Second, don't sacrifice family or university for lilypond.
> David's situation is not good, but that is ultimately his
> responsibility.  I don't think that he would want you to do poorly
> in university because of worrying about him.  The situation for
> lilypond in general is no different: this is a volunteer, hobby
> project.  It must come after family, education, and work.
> I appreciate the effort you have been putting into this, but I
> encourage you to shift your priorities.

That's unlikely, i'm very stubborn.  I'd rather try to make
LilyPond/music engraving my source of income.

> I don't want the money.  I have been very consistent about that.
> I don't want the $500, and I don't want the income.  My personal
> taxes are complicated enough as they are; I have income from two
> different countries, I have over CDN$ 99,000 of "education tax
> credit" saved up (completely legal; I've been a student since
> 1997, almost all full-time); the tax auditors naturally look
> closely at my submissions.

i didn't know that.  sorry.

> With regards to that form, I don't know what to put for box 2
> "Country of incorportation or organization".  I'm not an
> incorporation or organization... or is there a special tax
> definition of "incorporation" that includes "private individuals"?
> hmm.

IIRC the instruction says an individual leaves this blank.

> Ignoring that, what should I do for box 4 "permanent address" ?
> I'm a student, soon to start doing a postdoc life where I switch
> to a different continent every 6 to 12 months.

As far as i understand, this document is for Google and i've read that
they don't care for changing address as long as it's outside US.

Besides, i don't think this matters unless you're going to move during GSoC.

> Woah, part III "Notional Principal Contracts"!!!  "I have provided
> or will provide a statement that identifies those notional
> principal contracts from which the income is not effectively
> connected with the conduct of a trade or business in the United
> States. I agree to update this statement as required.  "
> What on earth does that mean?!  I'm supposed to agree to send an
> affidavit saying that the money from google doesn't have anything
> to do with a business in the US?  no wait, that's "notorized", no
> "notional".  Huh, I guess I'd better spend half an hour looking
> into the definition of all those words.
>
> Part IV Certification.  "Under penalties of perjury, I declare
> that I have examined the information on this form and to the best
> of my knowledge and belief it is true,"
>
> I cannot do that.  Not without spending probably a full working
> day looking up legal definitions for United States tax law.  It's
> not because I'm actively worried that the US government is going
> to give my brother a hard time because of this form, nor am I
> actively worried that they'll extradite me on some legal
> technicality because I might have made a mistake in filling out
> the form.  I cannot sign this form because I view my word as my
> bond.  It would be dishonorable for me to make a claim unless I am
> totally certain that I am correct.

That's something i can understand.

> Janek?  I know that you want to be a student, but maybe you'd
> consider being the official admin for us instead, and keep the
> $500?  You're much more familiar with GSoC than I am.

unfortunately not.  Only participating in GSoC as a student will
enable me to spend all my summer on LilyPond, and that's what i want
to do.


On Tue, Mar 6, 2012 at 1:41 PM, Graham Percival
 wrote:
> On Tue, Mar 06, 2012 at 01:22:42PM +0100, Janek Warchoł wrote:
>> i was (unofficially) told that if you don't send the W-8BEN form,
>> Google doesn't get upset and simply doesn't send you the money,
>> especially if you notify them about it.
>
> Ok, if I'm the admin person, that is what I would do.  Some people
> might view that as a waste of $500 (or more; IIRC it's $500 for
> each student).

Yes, that's what the program FAQ says.  I hope that if we're accepted
we'll have at least 2 students.

best
Janek

___
lilypond-devel mailing list
li

Re: release candidate blocked due to issues to verify

On Fri, Mar 2, 2012 at 1:00 PM, Graham Percival
 wrote:
> We now have zero Critical issues, so I'd like to have another
> release canddiate.  Unfortunately, there is still at least one
> "issue to verify" in the list for 2.15.31, so I will not make a
> release.
>
> http://code.google.com/p/lilypond/issues/list?can=7

No issues to verify in 2.15.32 list, too, so i hope we'll release new
Candidate when 2356 is counted down.

cheers,
Janek

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Gets vertical skylines from grob stencils (issue 5626052)


Mike & all,

i did a quick compile with patchset 36 and unfortunately didn't notice
significant speedups from previous version.

Compilation time differences vary widely depending on music (from 5% to
100% longer)


PROCESSING  ../dynamics.ly  WITH MASTER: --

real0m0.762s
user0m0.656s
sys 0m0.076s

PROCESSING  ../dynamics.ly  WITH SKYLINES: 

real0m0.799s
user0m0.692s
sys 0m0.080s


PROCESSING  ../eja-mater/Eja-Mater.ly  WITH MASTER: --

real0m7.324s
user0m6.488s
sys 0m0.528s

PROCESSING  ../eja-mater/Eja-Mater.ly  WITH SKYLINES: 

real0m14.040s
user0m12.185s
sys 0m1.132s


PROCESSING  ../Epifania/Eja_Mater_klarnet.ly  WITH MASTER:
--

real0m2.462s
user0m2.120s
sys 0m0.192s

PROCESSING  ../Epifania/Eja_Mater_klarnet.ly  WITH SKYLINES:


real0m3.314s
user0m2.888s
sys 0m0.256s


PROCESSING  ../Epifania/Gabriel's_Oboe/choir.ly  WITH MASTER:
--

real0m2.539s
user0m2.200s
sys 0m0.200s

PROCESSING  ../Epifania/Gabriel's_Oboe/choir.ly  WITH SKYLINES:


real0m4.081s
user0m3.460s
sys 0m0.344s


PROCESSING  ../Epifania/He_trusted_in_God/choir.ly  WITH MASTER:
--

real0m5.468s
user0m4.848s
sys 0m0.348s

PROCESSING  ../Epifania/He_trusted_in_God/choir.ly  WITH SKYLINES:


real0m11.347s
user0m9.621s
sys 0m0.988s


PROCESSING  ../Epifania/He_trusted_in_God/continuo.ly  WITH MASTER:
--

real0m2.201s
user0m1.920s
sys 0m0.184s

PROCESSING  ../Epifania/He_trusted_in_God/continuo.ly  WITH SKYLINES:


real0m2.440s
user0m2.168s
sys 0m0.176s


PROCESSING  ../Epifania/He_trusted_in_God/full_score.ly  WITH MASTER:
--

real0m8.185s
user0m7.492s
sys 0m0.412s

PROCESSING  ../Epifania/He_trusted_in_God/full_score.ly  WITH SKYLINES:


real0m14.932s
user0m12.901s
sys 0m1.248s


PROCESSING  ../Epifania/He_trusted_in_God/viola.ly  WITH MASTER:
--

real0m1.779s
user0m1.552s
sys 0m0.164s

PROCESSING  ../Epifania/He_trusted_in_God/viola.ly  WITH SKYLINES:


real0m1.970s
user0m1.748s
sys 0m0.136s


PROCESSING  ../Epifania/He_trusted_in_God/violin_I.ly  WITH MASTER:
--

real0m1.582s
user0m1.372s
sys 0m0.152s

PROCESSING  ../Epifania/He_trusted_in_God/violin_I.ly  WITH SKYLINES:


real0m1.796s
user0m1.536s
sys 0m0.184s


PROCESSING  ../Epifania/He_trusted_in_God/violin_II.ly  WITH MASTER:
--

real0m1.699s
user0m1.520s
sys 0m0.124s

PROCESSING  ../Epifania/He_trusted_in_God/violin_II.ly  WITH SKYLINES:


real0m1.954s
user0m1.708s
sys 0m0.172s


PROCESSING  ../Epifania/Jesus_bleibet_meine_Freude/choir.ly  WITH
MASTER: --

real0m2.416s
user0m2.152s
sys 0m0.140s

PROCESSING  ../Epifania/Jesus_bleibet_meine_Freude/choir.ly  WITH
SKYLINES: 

real0m4.625s
user0m3.616s
sys 0m0.468s


PROCESSING  ../Epifania/Jesus_bleibet_meine_Freude/full_score.ly  WITH
MASTER: --

real0m0.684s
user0m0.580s
sys 0m0.056s

PROCESSING  ../Epifania/Jesus_bleibet_meine_Freude/full_score.ly  WITH
SKYLINES: 

real0m0.680s
user0m0.552s
sys 0m0.068s


PROCESSING
../Epifania/Nad_Betlejem_w_ciemną_noc/Nad_Betlejem_w._orkiestrowa_3_systemy.ly
 WITH MASTER: --

real0m2.039s
user0m1.700s
sys 0m0.152s

PROCESSING
../Epifania/Nad_Betlejem_w_ciemną_noc/Nad_Betlejem_w._orkiestrowa_3_systemy.ly
 WITH SKYLINES: 

real0m3.326s
user0m2.820s
sys 0m0.260s


PROCESSING  ../Epifania/O_Matko_miłościwa/choir.ly  WITH MASTER:
--

real0m4.176s
user0m3.688s
sys 0m0.296s

PROCESSING  ../Epifania/O_Matko_miłościwa/choir.ly  WITH SKYLINES:


real0m8.384s
user0m7.144s
sys 0m0.780s


PROCESSING  ../Epifania/O_Matko_miłościwa/continuo.ly  WITH MASTER:
--

real0m0.861s
user0m0.752s
sys 0m0.068s

PROCESSING  ../Epifania/O_Matko_miłościwa/continuo.ly  WITH SKYLINES:


real0m0.873s
user0m0.740s
sys 0m0.076s


PROCESSING  ../Epifania/O_Matko_miłościwa/full_score.ly  WITH MASTER:
--

real0m4.027s
user0m3.652s
sys 0m0.248s

PROCESSING  ../Epifania/O_Matko_miłościwa/full_score.ly  WITH SKYLINES:


real0m8.267s
user0m7.156s
sys 0m0.668s


PROCESSING  ../Epifania/O_Matko_miłościwa/viola.ly  WITH MASTER:
--

real0m0.878s
user0m0.768s
sys 0m0.072s

PROCESSING  ../Epifania/O_Matko_miłościwa/viola.ly  WITH SKYLINES:


real0m0.869s
user0m0.772s
sys 0m0.060s


PROCESSING  ../Epifania/O_Matko_miłościwa/violin_I.ly  WITH MASTER:
--

real0m0.880s
user0m0.756s
sys 0m0.084s

PROCESSING  ../Epifania/

Re: Cross-staff stem engraver (was: New frog in an empty pond?)

On Sat, Mar 3, 2012 at 5:26 AM, Pavel Roskin  wrote:
> Hello!
>
> On Tue, 28 Feb 2012 15:14:29 -0800
> Joe Neeman  wrote:
>
>> Don't use ly:axis-group-interface::add-element, because stems don't
>> implement the axis-group-interface. (Removing this will also remove
>> the axes warning.) Instead, use ly:grob-set-parent!. You'll probably
>> want to set both the X parent and the Y parent. Then the X and Y
>> offsets of new-stem will be measured relative to stem (instead of
>> relative to the whole system, which is the default).
>
> OK, this is what I have now.  I think it's a pretty good solution.
>
> The code is capable of creating multiple cross-staff stems per moment.
> It's possible to connect more than two stems as long as they lie on the
> same line.  There is a workaround for a problem with Lilypond 2.14 that
> has a flag as part of the stem.
>
> I spent way too much time on the issue, but it helped me learn
> Scheme and Lilypond.
>
> I'll be on vacation next two weeks, so I'm not sure I'll be able to
> work on Lilypond.  So I want to post my results.
>
> I tried posting this on LSR, but it won't accept it.  I get a popup
> message saying "empty output from Lilypond" or something like that.  I
> guess it's because LSR still runs Lilypond 2.12.x.  Unfortunately, I
> have no time for backports.
>
> I'm attaching the Scheme code with a convoluted example (3 staves with
> 3 voices on each).

I don't have the time to dive into details, but the output looks good!
Be sure to post it on Rietveld for a review when you come back.

cheers,
Janek

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: MacOS X development and support

2012-03-06 Thread David Kastrup

Colin Hall  writes:

> Hi,
>
> I'm interested to improve the pace and quality of development of
> Lilypond for MacOS X. I'd like to know if the developers are
> supportive of this, and get your advice on how to best direct my
> efforts.
>
> First, a few statements to solicit information. I'm keen, but
> ignorant. I don't know which devs work on MacOS X development, for
> instance. This isn't a witch hunt. Simple "Agree" "Disagree" would be
> helpful:
>
> Development of code specific to the MacOS X platforms, especially
> Lilypad, is slow.

Looks like it.

> We don't have devs or bug squadders with access to Mac hardware to
> verify new releases.

You have a better overview than I have.

> We need more developers working on MacOS X.

Yes and no.  Most of the problems we had were "GUB" problems.  The
MacOSX problems mostly were a total lack of timely feedback and
system-specific knowledge to deal with GUB problems.  But it is not like
the principal situation would be better for other platforms.  We need
timely tests and feedback of MacOSX (I mean, get real: would we even
notice if the FreeBSD build did not work?).

Oh, by the way, Google's first hit for "LilyPond download" is
http://lilypond.org/web/install/> which states "When we have
whetted your appetite for LilyPond, then this is the right page."
Unfortunately, it is the wrong page since it advocates LilyPond 2.12.
Any hope we can at some point of time take those offline?

Back to topic:

> We don't need MacOS X developers. We just need someone to maintain the
> MacOS X aspects of GUB and direct those devs who can help with
> patches.

Uh, yes.

-- 
David Kastrup

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Web: add GSoC ideas list (issue 5753059)

Reviewers: Graham Percival, carl.d.sorensen_gmail.com, MikeSol, lemzwerg,  
Reinhold, joeneeman,


Message:
Please review asap, it's only a couple days left before application
deadline.


http://codereview.appspot.com/5753059/diff/1/Documentation/web/community.itexi
File Documentation/web/community.itexi (right):

http://codereview.appspot.com/5753059/diff/1/Documentation/web/community.itexi#newcode983
Documentation/web/community.itexi:983: @subheading Adding special
variant of font glyphs
i've decided that it doesn't make logical sense to mix these glyph
variants with objects horizontal spacing.  It's completely unrelated.

Description:
Web: add GSoC ideas list

A list of suggested projects for Google Summer of Code
students is necessary to participate in the program.

Please review this at http://codereview.appspot.com/5753059/

Affected files:
  M Documentation/web/community.itexi



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Regtests for 2.15.32

2012-03-06 Thread Phil Holmes


Official regtests are nice and clean.

--
Phil Holmes



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Web: add GSoC ideas list (issue 5753059)

2012-03-06 Thread PhilEHolmes


A few comments on the text, but otherwise LGTM.


http://codereview.appspot.com/5753059/diff/1/Documentation/web/community.itexi
File Documentation/web/community.itexi (right):

http://codereview.appspot.com/5753059/diff/1/Documentation/web/community.itexi#newcode83
Documentation/web/community.itexi:83: * GSoC::
Are you missing a space before the bullet?

http://codereview.appspot.com/5753059/diff/1/Documentation/web/community.itexi#newcode914
Documentation/web/community.itexi:914: has a grace note and the other
don't.
don't -> doesn't

http://codereview.appspot.com/5753059/diff/1/Documentation/web/community.itexi#newcode969
Documentation/web/community.itexi:969: Default shape of slur and tie
curves is often unsatisfactory.
The default shape ...

http://codereview.appspot.com/5753059/diff/1/Documentation/web/community.itexi#newcode973
Documentation/web/community.itexi:973: deciding on intended output and
writing the actual code.
deciding on the intended ...

http://codereview.appspot.com/5753059/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Web: add GSoC ideas list (issue 5753059)

2012-03-06 Thread Mark Knoop

At 17:01 on 06 Mar 2012, janek.lilyp...@gmail.com wrote:
>Reviewers: Graham Percival, carl.d.sorensen_gmail.com, MikeSol,
>lemzwerg, Reinhold, joeneeman,
>
>Message:
>Please review asap, it's only a couple days left before application
>deadline.

line 912: s/counfusing/confusing/


-- 
Mark Knoop

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

old web pages

2012-03-06 Thread Graham Percival

On Tue, Mar 06, 2012 at 04:01:44PM +0100, David Kastrup wrote:
> Oh, by the way, Google's first hit for "LilyPond download" is
> http://lilypond.org/web/install/> which states "When we have
> whetted your appetite for LilyPond, then this is the right page."
> Unfortunately, it is the wrong page since it advocates LilyPond 2.12.
> Any hope we can at some point of time take those offline?

Somebody did work on this a few months ago, and we got a step or
two closer, but we're not there yet.  In particular, taking down
(or renaming) those old directories would break the translations.

Somebody who cares about translations needs to work on the website
build system.  It's exactly the same situation as saving the pdf
files.

- Graham

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Web: add GSoC ideas list (issue 5753059)

2012-03-06 Thread graham


If you add a new section to the website without changing the relevant
part of Documentation/lilypond-texi2html.init, the colors will get
messed up.  See line 1516.


http://codereview.appspot.com/5753059/diff/1/Documentation/web/community.itexi
File Documentation/web/community.itexi (right):

http://codereview.appspot.com/5753059/diff/1/Documentation/web/community.itexi#newcode83
Documentation/web/community.itexi:83: * GSoC::
On 2012/03/06 17:12:51, PhilEHolmes wrote:

Are you missing a space before the bullet?


no, that's fine.

http://codereview.appspot.com/5753059/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Web: add GSoC ideas list (issue 5753059)


New patchset.

On Tue, Mar 6, 2012 at 6:36 PM,   wrote:

If you add a new section to the website without changing the relevant
part of Documentation/lilypond-texi2html.init, the colors will get
messed up.  See line 1516.


done.
Actually, i think that one entry was already missing before my change,
so i've added two.


http://codereview.appspot.com/5753059/diff/1/Documentation/web/community.itexi
File Documentation/web/community.itexi (right):

http://codereview.appspot.com/5753059/diff/1/Documentation/web/community.itexi#newcode914
Documentation/web/community.itexi:914: has a grace note and the other
don't.
On 2012/03/06 17:12:51, PhilEHolmes wrote:

don't -> doesn't


Done.

http://codereview.appspot.com/5753059/diff/1/Documentation/web/community.itexi#newcode969
Documentation/web/community.itexi:969: Default shape of slur and tie
curves is often unsatisfactory.
On 2012/03/06 17:12:51, PhilEHolmes wrote:

The default shape ...


Done.

http://codereview.appspot.com/5753059/diff/1/Documentation/web/community.itexi#newcode973
Documentation/web/community.itexi:973: deciding on intended output and
writing the actual code.
On 2012/03/06 17:12:51, PhilEHolmes wrote:

deciding on the intended ...


Done.

http://codereview.appspot.com/5753059/diff/5001/Documentation/lilypond-texi2html.init
File Documentation/lilypond-texi2html.init (right):

http://codereview.appspot.com/5753059/diff/5001/Documentation/lilypond-texi2html.init#newcode1514
Documentation/lilypond-texi2html.init:1514: 'download' => [2, 2, 2, 3,
3, 4],
that's funny, why do we start with 2?

http://codereview.appspot.com/5753059/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Web: add GSoC ideas list (issue 5753059)

2012-03-06 Thread Carl . D . Sorensen


Looks pretty good to me.

Carl



http://codereview.appspot.com/5753059/diff/5001/Documentation/web/community.itexi
File Documentation/web/community.itexi (right):

http://codereview.appspot.com/5753059/diff/5001/Documentation/web/community.itexi#newcode1012
Documentation/web/community.itexi:1012: @subheading Better tabulature
support
s/tabulature/tablature/

http://codereview.appspot.com/5753059/diff/5001/Documentation/web/community.itexi#newcode1021
Documentation/web/community.itexi:1021: create tabulature input mode
(currently musical information is entered
s/tabulature/tablature/g

http://codereview.appspot.com/5753059/diff/5001/Documentation/web/community.itexi#newcode1039
Documentation/web/community.itexi:1039: @strong{Recommended knowledge:}
tabulature notation familiarity
s/tabulature/tablature/g

http://codereview.appspot.com/5753059/diff/5001/Documentation/web/community.itexi#newcode1043
Documentation/web/community.itexi:1043: @subheading Clean up various
compilation warinings
s/warinings/warnings/

http://codereview.appspot.com/5753059/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Web: add GSoC ideas list (issue 5753059)


Fixed


http://codereview.appspot.com/5753059/diff/5001/Documentation/web/community.itexi
File Documentation/web/community.itexi (right):

http://codereview.appspot.com/5753059/diff/5001/Documentation/web/community.itexi#newcode1012
Documentation/web/community.itexi:1012: @subheading Better tabulature
support
On 2012/03/06 18:27:21, Carl wrote:

s/tabulature/tablature/


Done.

http://codereview.appspot.com/5753059/diff/5001/Documentation/web/community.itexi#newcode1021
Documentation/web/community.itexi:1021: create tabulature input mode
(currently musical information is entered
On 2012/03/06 18:27:21, Carl wrote:

s/tabulature/tablature/g


Done.

http://codereview.appspot.com/5753059/diff/5001/Documentation/web/community.itexi#newcode1039
Documentation/web/community.itexi:1039: @strong{Recommended knowledge:}
tabulature notation familiarity
On 2012/03/06 18:27:21, Carl wrote:

s/tabulature/tablature/g


Done.

http://codereview.appspot.com/5753059/diff/5001/Documentation/web/community.itexi#newcode1043
Documentation/web/community.itexi:1043: @subheading Clean up various
compilation warinings
On 2012/03/06 18:27:21, Carl wrote:

s/warinings/warnings/


Done.

http://codereview.appspot.com/5753059/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Web: add GSoC ideas list (issue 5753059)

2012-03-06 Thread graham


LGTM.  Wait another few hours (until 21:00 or 22:00 UST), then push to
staging.  If you're going to bed before then, go ahead and push to
staging earlier.  If there's problems that aren't noticed before you
push it, we can fix the page later.  Make sure it's in staging before
James runs patch staging-merge at midnight.


http://codereview.appspot.com/5753059/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Ubuntu 12.04 as a LilyDev

Hello,

I've just been seeing if Ubuntu 12.04 is going to cause any
significant problems for the next major LilyDev upgrade.

I had no problems at all.

12.04 is still in beta

1.
https://wiki.ubuntu.com/PrecisePangolin/TechnicalOverview/Beta1#Download_the_Beta_1

This was the image I used

http://ubuntu.virginmedia.com/releases//precise/ubuntu-12.04-beta1-desktop-i386.iso

2. Then after installing as a VM downloaded a further 170mb of Ubuntu
'software updates'

3. Reboot (as prompted) and then following the CG here:

http://lilypond.org/doc/v2.15/Documentation/contributor/requirements-for-compiling-lilypond

sudo apt-get build-dep lilypond

That's about 298mb of more downloads.

4. Extra software that I needed to download

i. dblatex (required for make doc)
ii. autoconf (required for well ./autogen.sh)
iii. git (and gitk if you so wish)

5. Download lilygit-tcl and run it then fill in your name and email
and 'get source'. Wait until that all downloads.

6. when I run ../configure I get:

--snip--

checking build system type... i686-pc-linux-gnu
checking host system type... i686-pc-linux-gnu
checking Package... LILYPOND
checking builddir... /home/james/lilypond-git/build
checking for stepmake... ../stepmake (${datarootdir}/stepmake not found)
checking for gmake... no
checking for make... make
checking for find... find
checking for tar... tar
checking for bash... /bin/bash
checking for python... python
checking python version... 2.7.2
checking for python... /usr/bin/python
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables...
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking whether compiler understands -pipe... yes
checking for IEEE-conformance compiler flags... none
checking for fc-list... fc-list
checking New Century Schoolbook PFB files...
/usr/share/fonts/type1/gsfonts/c059016l.pfb
/usr/share/fonts/type1/gsfonts/c059036l.pfb
/usr/share/fonts/type1/gsfonts/c059033l.pfb
/usr/share/fonts/type1/gsfonts/c059013l.pfb
checking for python... /usr/bin/python
checking /usr/bin/python version... 2.7.2
checking for /usr/bin/python... /usr/bin/python
checking for g++... g++
checking whether we are using the GNU C++ compiler... yes
checking whether g++ accepts -g... yes
checking how to run the C++ preprocessor... g++ -E
checking for grep that handles long lines and -e... /bin/grep
checking for egrep... /bin/grep -E
checking gcc version... 4.6.3
checking whether we are using the GNU C++ compiler... (cached) yes
checking whether g++ accepts -g... (cached) yes
checking g++ version... 4.6.3
checking options for known g++ tail call bug... -fno-optimize-sibling-calls
checking whether explicit instantiation is needed... no
checking for stl.data () method... yes
checking for ar... ar
checking for ranlib... ranlib
checking for dlopen in -ldl... yes
checking for dlopen... yes
checking for bison... bison -y
checking for bison... bison
checking bison version... 2.5
checking for flex... flex
checking for ANSI C header files... yes
checking for sys/types.h... yes
checking for sys/stat.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for memory.h... yes
checking for strings.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for unistd.h... yes
checking FlexLexer.h usability... yes
checking FlexLexer.h presence... yes
checking for FlexLexer.h... yes
checking for yyFlexLexer.yy_current_buffer... no
checking FlexLexer.h location... /usr/include/FlexLexer.h
checking language... English
checking for gettext in -lintl... no
checking for gettext... yes
checking for msgfmt... msgfmt
checking for mf-nowin... mf-nowin
checking for mpost... mpost
checking for working metafont mode... ljfour
checking for kpsewhich... kpsewhich
checking for guile-config... guile-config
checking guile-config version... 1.8.8
checking guile compile flags... -pthread
checking guile link flags... -pthread -lguile -lltdl
-Wl,-Bsymbolic-functions -lgmp -lcrypt -lm -lltdl
checking libguile.h usability... yes
checking libguile.h presence... yes
checking for libguile.h... yes
checking for scm_boot_guile in -lguile... yes
checking for scm_boot_guile... yes
checking for scm_t_hash_fold_fn... no
checking for scm_t_hash_handle_fn... no
checking for scm_t_subr... no
checking for usable C++ demangler... yes
checking GUILE rational bugfix... ok
checking for python-config... python-config
checking Python.h usability... yes
checking Python.h presence... yes
checking for Python.h... yes
checking for gs... gs
checking for gs... /usr/bin/gs
checking /usr/bin/gs version... 9.05
checking for fontforge... fontforge
checking for fontforge... /usr/bin/fontforge
checking /usr/bin/fontforge version... 20110222
checking for fo

Re: Ubuntu 12.04 as a LilyDev

2012-03-06 Thread David Kastrup

James  writes:

> Hello,
>
> I've just been seeing if Ubuntu 12.04 is going to cause any
> significant problems for the next major LilyDev upgrade.

> checking gcc version... 4.6.3

Wow.  It was released on March 1 or so IIRC.

-- 
David Kastrup


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Ubuntu 12.04 as a LilyDev

On Tue, Mar 6, 2012 at 8:25 PM, James  wrote:
> Hello,
>
> I've just been seeing if Ubuntu 12.04 is going to cause any
> significant problems for the next major LilyDev upgrade.
> [...]
> make and make doc work fine (well make doc completes with no errors I
> haven't actually looked through all the PDFs but the LM looked fine on
> a quick skim).
>
> I'm not going to comment on the Unity interface as I know that is a
> sore topic for some users, but apart from figuring out how to get an
> xterm (alt-f2 then type xterm!) it was pretty pain free. It's
> certainly a smoother experience than 10.04 (if one cares about that
> subtlety) even in a VM.
>
> Compilation times are no quicker/slower it seems, although I haven't
> 'watched' a make doc for a few months now (I just kick off the command
> and go and have a life, it's all done when I get back) so I thought it
> had 'hung' as I am conditioned with my few years of making doc of a
> constant stream 'matrix like' of screenout put. But this stuttered and
> stopped so much I really thought something was wrong, Then I
> realised...
>
> Well 'squashed' Mr Phil! :)
>
> Anyway, hope this was useful or interesting at the very least.

It was!  Maybe LilyDev 2.0 should be Ubuntu 12.04.
The only thing that concerns me is xterm.  Do i understand correctly
that it's the only available terminal?  The default one in current
LilyDev is much better, has tabs and all eye-candy a terminal can
have.

thanks,
Janek

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Ubuntu 12.04 as a LilyDev

Hello,

2012/3/6 Janek Warchoł :
> On Tue, Mar 6, 2012 at 8:25 PM, James  wrote:
>> Hello,
>>
>> I've just been seeing if Ubuntu 12.04 is going to cause any
>> significant problems for the next major LilyDev upgrade.
>> [...]
>> make and make doc work fine (well make doc completes with no errors I
>> haven't actually looked through all the PDFs but the LM looked fine on
>> a quick skim).
>>
>> I'm not going to comment on the Unity interface as I know that is a
>> sore topic for some users, but apart from figuring out how to get an
>> xterm (alt-f2 then type xterm!) it was pretty pain free. It's
>> certainly a smoother experience than 10.04 (if one cares about that
>> subtlety) even in a VM.
>>
>> Compilation times are no quicker/slower it seems, although I haven't
>> 'watched' a make doc for a few months now (I just kick off the command
>> and go and have a life, it's all done when I get back) so I thought it
>> had 'hung' as I am conditioned with my few years of making doc of a
>> constant stream 'matrix like' of screenout put. But this stuttered and
>> stopped so much I really thought something was wrong, Then I
>> realised...
>>
>> Well 'squashed' Mr Phil! :)
>>
>> Anyway, hope this was useful or interesting at the very least.
>
> It was!  Maybe LilyDev 2.0 should be Ubuntu 12.04.

No we have to think about GUB and the fact that 12.04 is still in
beta. I think as has been suggested by Graham that we'll do another
round on 10.04 with LilyDev 2.5 and then once 12.04 has bedded in a
bit then move. I need also to make sure that remastersys (which is
what we use to build the ISO) works on 12.04 - I haven't tried that
yet.

> The only thing that concerns me is xterm.  Do i understand correctly
> that it's the only available terminal?

No, you understand that that was the only thing I could think to type
for a terminal at that moment :)

> The default one in current
> LilyDev is much better, has tabs and all eye-candy a terminal can
> have.

Quite.

James


-- 
--

James

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: LilyPond 2.14.2 is in Ubuntu 12.04 software centre

Francisco,

On 5 March 2012 23:41, Francisco Vila  wrote:
> 2012/3/5 James :
>> Hello,
>>
>> Just in case anyone was interested. Thanks to whoever sorted this out
>> - it used to be 2.11 or even 2.10 not so many months ago.
>
> 330.7 MB to download, 905.2 MB when installed?
>
> Synaptic says size 4293 kB, download 1535 kB for v 2.12.3-7ubuntu1 in
> my Ubuntu 11.04 system.
>
> Looks very wrong. Or, does that include all of texlive or something?


http://packages.ubuntu.com/precise/lilypond

and then see

http://packages.ubuntu.com/precise/lilypond-doc

?

I don't pretend to understand this.

Regards

-- 
--

James

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Ubuntu 12.04 as a LilyDev

On Tue, Mar 6, 2012 at 9:22 PM, James  wrote:
> Hello,
>
> 2012/3/6 Janek Warchoł :
>> Maybe LilyDev 2.0 should be Ubuntu 12.04.
>
> No we have to think about GUB and the fact that 12.04 is still in
> beta. I think as has been suggested by Graham that we'll do another
> round on 10.04 with LilyDev 2.5 and then once 12.04 has bedded in a
> bit then move. I need also to make sure that remastersys (which is
> what we use to build the ISO) works on 12.04 - I haven't tried that
> yet.
>
>> The only thing that concerns me is xterm.  Do i understand correctly
>> that it's the only available terminal?
>
> No, you understand that that was the only thing I could think to type
> for a terminal at that moment :)

ok.
thanks,
Janek

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Gets vertical skylines from grob stencils (issue 5626052)

2012-03-06 Thread Joe Neeman

2012/3/6 

> Mike & all,
>
> i did a quick compile with patchset 36 and unfortunately didn't notice
> significant speedups from previous version.
>

Could you try the dev/jneem branch in git? It has some optimizations. If
that doesn't help, could you please send me some of the worst files?

Cheers,
Joe
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Ubuntu 12.04 as a LilyDev

2012-03-06 Thread Francisco Vila

2012/3/6 Janek Warchoł :
> The only thing that concerns me is xterm.  Do i understand correctly
> that it's the only available terminal?  The default one in current
> LilyDev is much better, has tabs and all eye-candy a terminal can
> have.

What does Ctrl+Alt+T do?
-- 
Francisco Vila. Badajoz (Spain)
www.paconet.org , www.csmbadajoz.com

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

PATCH: Countdown to 20120308

2012-03-06 Thread Colin Campbell


For 20:00 MST Thursday March 8

Issue 2376 : 
Automatic footnotes on \null markups causes unexpected results - R



   5755058 


Cheers,
Colin

--
Every man is a damned fool for at least five minutes every day. Wisdom 
consists in not exceeding the limit.

- Elbert Hubbard, author, editor, printer (1856-1915)
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: LilyPond 2.14.2 is in Ubuntu 12.04 software centre

2012-03-06 Thread Łukasz Czerwiński

On 6 March 2012 21:36, James  wrote:

> Francisco,
>
> On 5 March 2012 23:41, Francisco Vila  wrote:
> > 2012/3/5 James :
> >> Hello,
> >>
> >> Just in case anyone was interested. Thanks to whoever sorted this out
> >> - it used to be 2.11 or even 2.10 not so many months ago.
> >
> > 330.7 MB to download, 905.2 MB when installed?
> >
> > Synaptic says size 4293 kB, download 1535 kB for v 2.12.3-7ubuntu1 in
> > my Ubuntu 11.04 system.
> >
> > Looks very wrong. Or, does that include all of texlive or something?
>
>
> http://packages.ubuntu.com/precise/lilypond
>
> and then see
>
> http://packages.ubuntu.com/precise/lilypond-doc
>
> ?
>
> I don't pretend to understand this.
>
> Regards


It looks like lilypond really includes texlive - it can be found in
lilypond-data (http://packages.ubuntu.com/precise/lilypond-data).

Łukasz
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Ubuntu 12.04 as a LilyDev

Hello

2012/3/6 Francisco Vila :
> 2012/3/6 Janek Warchoł :
>> The only thing that concerns me is xterm.  Do i understand correctly
>> that it's the only available terminal?  The default one in current
>> LilyDev is much better, has tabs and all eye-candy a terminal can
>> have.
>
> What does Ctrl+Alt+T do?

;)

Bingo!

James


-- 
--

James

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Uses derived_mark to avoid segfault (issue 5729051)

2012-03-06 Thread mtsolo

http://codereview.appspot.com/5729051/diff/6001/lily/span-bar-stub-engraver.cc
File lily/span-bar-stub-engraver.cc (right):

http://codereview.appspot.com/5729051/diff/6001/lily/span-bar-stub-engraver.cc#newcode35
lily/span-bar-stub-engraver.cc:35: these four contexts.
On 2012/03/04 21:35:57, Keith wrote:

You said later that only two SpanBarStubs are created, so
"creation of SpanBarStubs will be contemplated in each of these four

contexts."

Fixed.

http://codereview.appspot.com/5729051/diff/6001/lily/span-bar-stub-engraver.cc#newcode160
lily/span-bar-stub-engraver.cc:160: // removes all unused contexts
On 2012/03/06 12:19:04, dak wrote:

On 2012/03/04 10:47:17, Neil Puttock wrote:
> Is it feasible to listen for RemoveContext instead?  At least then

you only

need
> to rebuild axis_groups_ when contexts die.

I'd second this suggestion.  It should give more reliable lifetimes,

and also

cause a better correlation of "parsed object should be dead" messages

with

realities.

Unfortunately this is not possible.  I tried, but it looks like
listeners in the way you're talking about are not possible in engravers.

http://codereview.appspot.com/5729051/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Issue 2376: Automatic footnotes on \null markups causes unexpected results (issue 5755058)

2012-03-06 Thread mtsolo



http://codereview.appspot.com/5755058/diff/1/lily/page-breaking.cc
File lily/page-breaking.cc (right):

http://codereview.appspot.com/5755058/diff/1/lily/page-breaking.cc#newcode584
lily/page-breaking.cc:584: }
Just a C++ question - do these lines implicitly call the copy
constructor to create footnote_stencil so that footnote_stencil is a
copy of foot?  I'm not familiar with this syntax for copying, so I just
wanted to be sure that this is what these lines were doing.

http://codereview.appspot.com/5755058/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Web: add GSoC ideas list (issue 5753059)

pushed as cc5223ac26a5713c5901c02edf2868c26be10542.

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 2376: Automatic footnotes on \null markups causes unexpected results (issue 5755058)

2012-03-06 Thread dak


Reviewers: MikeSol,


http://codereview.appspot.com/5755058/diff/1/lily/page-breaking.cc
File lily/page-breaking.cc (right):

http://codereview.appspot.com/5755058/diff/1/lily/page-breaking.cc#newcode584
lily/page-breaking.cc:584: }
On 2012/03/07 07:30:42, MikeSol wrote:

Just a C++ question - do these lines implicitly call the copy

constructor to

create footnote_stencil so that footnote_stencil is a copy of foot?

I'm not

familiar with this syntax for copying, so I just wanted to be sure

that this is

what these lines were doing.


The first line calls the assignment operator.  The second line just
resets the foot pointer to point at footnote_stencil.

It would likely be cleaner to just pass a pointer to footnote_stencil
(which is constructed as a null Stencil as far as I can see) in either
case.  Since the special case "foot == 0" would then be ruled out in
advance (do you need the error message?  Can add_footnotes_to_footer
deal with a null stencil?) one could in a more C++-like manner pass foot
in by reference instead of by pointer.

I did not want to meddle with the logic of the code: I just made sure
that it copied what was needed.  If you say that add_footnotes_to_footer
can deal with getting a null stencil for starters, that's what I would
prefer using.  Incidentally, the length of the axes of a null stencil
should turn out to be 0, so this would remove a few special cases as
well.

Description:
Issue 2376: Automatic footnotes on \null markups causes unexpected
results

The page layout routines passed around pointers to stencils rather
indiscriminately and worked on them rather than on stencil copies.

Sort of copy-on-write without the copy.  This tries working on actual
copies where appropriate.

Please review this at http://codereview.appspot.com/5755058/

Affected files:
  M lily/page-breaking.cc
  M lily/page-layout-problem.cc


Index: lily/page-breaking.cc
diff --git a/lily/page-breaking.cc b/lily/page-breaking.cc
index  
61a4e82f91d3098baf29e77b800a622749902522..0eee8e90a45f346a84caffeac89925da05390857  
100644

--- a/lily/page-breaking.cc
+++ b/lily/page-breaking.cc
@@ -574,14 +574,21 @@ Page_breaking::draw_page (SCM systems, SCM  
configuration, int page_num, bool las

   p->set_property ("lines", paper_systems);
   p->set_property ("configuration", configuration);

+  Stencil footnote_stencil;
+
   Stencil *foot = unsmob_stencil (p->get_property ("foot-stencil"));
+  if (foot)
+{
+  footnote_stencil = *foot;
+  foot = &footnote_stencil;
+}

   SCM footnotes = Page_layout_problem::get_footnotes_from_lines (systems);

   Page_layout_problem::add_footnotes_to_footer (footnotes, foot, book_);

   if (foot)
-p->set_property ("foot-stencil", foot->smobbed_copy ());
+p->set_property ("foot-stencil", footnote_stencil.smobbed_copy ());
   scm_apply_1 (page_stencil, page, SCM_EOL);

   return page;
Index: lily/page-layout-problem.cc
diff --git a/lily/page-layout-problem.cc b/lily/page-layout-problem.cc
index  
6320827c767a74b07078d328eb7041d7649f6179..82be7f204fe11223d15050ccebbf01c2d28a2dc9  
100644

--- a/lily/page-layout-problem.cc
+++ b/lily/page-layout-problem.cc
@@ -162,7 +162,7 @@ Page_layout_problem::add_footnotes_to_lines (SCM lines,  
int counter, Paper_book

 by passing its results downstream.
   */
   vector footnote_number_markups; // Holds the numbering markups.
-  vector footnote_number_stencils; // Holds translated versions  
of the stencilized numbering markups.
+  vector footnote_number_stencils; // Holds translated versions  
of the stencilized numbering markups.

   for (vsize i = 0; i < fn_count; i++)
 {
   if (fn_grobs[i])
@@ -176,36 +176,39 @@ Page_layout_problem::add_footnotes_to_lines (SCM  
lines, int counter, Paper_book

   if (!s)
 {
   programming_error ("Your numbering function needs to return a  
stencil.");

-  markup = SCM_EOL;
-  s = new Stencil (Box (Interval (0, 0), Interval (0, 0)),  
SCM_EOL);

+ footnote_number_markups.push_back (SCM_EOL);
+  footnote_number_stencils.push_back (Stencil (Box (Interval (0,  
0), Interval (0, 0)), SCM_EOL));

 }
-  footnote_number_markups.push_back (markup);
-  footnote_number_stencils.push_back (s);
+  else
+   {
+ footnote_number_markups.push_back (markup);
+ footnote_number_stencils.push_back (*s);
+   }
   counter++;
 }

   // find the maximum X_AXIS length
   Real max_length = -infinity_f;
   for (vsize i = 0; i < fn_count; i++)
-max_length = max (max_length, footnote_number_stencils[i]->extent  
(X_AXIS).length ());
+max_length = max (max_length, footnote_number_stencils[i].extent  
(X_AXIS).length ());


   /*
 translate each stencil such that it attains the correct maximum length  
and bundle the

 footnotes into a scheme object.
   */
-  SCM *tail = &numbers;
-  SCM *in_text_tail = &in_text_numbers;

   for (vsize i = 0; i < fn_count; i++)
 {
-  *in_text_t

Re: Gets vertical skylines from grob stencils (issue 5626052)