Re: PATCH: Countdown to 20120517
Marc Hohl m...@hohlart.de writes: Am 16.05.2012 05:23, schrieb Colin Campbell: [...] Issue 2497 http://code.google.com/p/lilypond/issues/detail?id=2497: restrainOpenStrings: please fix snippet in Documentation/notation/fretted-strings.itely - R 6206072 http://codereview.appspot.com/6206072/ [...] Issue 1320 http://code.google.com/p/lilypond/issues/detail?id=1320: Enhancement: user-customizable barlines through a Scheme interface. - R 6210049 http://codereview.appspot.com/6210049/ I can't push these myself – I can send patches via email. Who will push these for me? If you send git format-patch patches, I can do that. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: web: update GSoC subpage (issue 6190068)
pushed as ae4701688c122849fc9228b6806f20e6f23d2a7d, closed. thanks, janek http://codereview.appspot.com/6190068/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: Countdown to 20120517
On 12-05-17 11:55 PM, Marc Hohl wrote: Am 16.05.2012 05:23, schrieb Colin Campbell: [...] Issue 2497 http://code.google.com/p/lilypond/issues/detail?id=2497: restrainOpenStrings: please fix snippet in Documentation/notation/fretted-strings.itely - R 6206072 http://codereview.appspot.com/6206072/ [...] Issue 1320 http://code.google.com/p/lilypond/issues/detail?id=1320: Enhancement: user-customizable barlines through a Scheme interface. - R 6210049 http://codereview.appspot.com/6210049/ I can't push these myself – I can send patches via email. Who will push these for me? Regards, Marc ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel If you send them to me, Marc, I can push them tonight for you. Colin -- I've learned that you shouldn't go through life with a catcher's mitt on both hands. You need to be able to throw something back. -Maya Angelou, poet (1928- ) ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: Countdown to 20120517
Colin Campbell c...@shaw.ca writes: On 12-05-17 11:55 PM, Marc Hohl wrote: Am 16.05.2012 05:23, schrieb Colin Campbell: [...] Issue 2497 http://code.google.com/p/lilypond/issues/detail?id=2497: restrainOpenStrings: please fix snippet in Documentation/notation/fretted-strings.itely - R 6206072 http://codereview.appspot.com/6206072/ [...] Issue 1320 http://code.google.com/p/lilypond/issues/detail?id=1320: Enhancement: user-customizable barlines through a Scheme interface. - R 6210049 http://codereview.appspot.com/6210049/ I can't push these myself – I can send patches via email. Who will push these for me? If you send them to me, Marc, I can push them tonight for you. I have already pushed them, and they are in master by now. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: transferring file from mac osx to windows 7
On Tue, May 15, 2012 at 05:04:08PM +0100, Colin Hall wrote: On Mon, May 14, 2012 at 02:23:18PM -0700, trandrusiii wrote: I am trying to move a file from mac osx to windows 7 however when I try to paste text in the file maxes out. When I try opening the file directly, all the formatting is lost and becomes impossible to work on. Is this a limitation of the software? Thanks for telling us about this, trandrusiii. Can you send a copy of the mac osx file that is giving you this trouble? Did you manage to find a solution to your problem, trandrusiii? If you need it investigated, please send the file. Cheers, Colin. -- Colin Hall ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Cppcheck reports
Hello
2012/5/17 Julien Nabet serval2...@yahoo.fr
I'm not top posting.
Hello,
I just git clone Lilypond project and launched cppcheck (git updated
today).
I thought it could interest you, here are some examples :
[lily/tuplet-bracket.cc:594] - [lily/tuplet-bracket.cc:594]: (style) Same
expression on both sides of '-'
592 if (!follow_beam)
593 {
594 points.push_back (Offset (x0 - x0, staff[dir]));
595 points.push_back (Offset (x1 - x0, staff[dir]));
596 }
[lily/tie-engraver.cc:240]: (performance) Prefer prefix ++/-- operators for
non-primitive types
240 for (; it heads_to_tie_.end (); it++)
241 report_unterminated_tie (*it);
(+ it's safer to use it != heads_to_tie_.end ())
[lily/paper-book.cc:346]: (performance) Possible inefficient checking for
'cols'
emptiness
346 if (cols.size ())
347 {
348 Paper_column *col = dynamic_castPaper_column *
(cols.back ());
349 col-set_property (symbol, permission);
350 col-find_prebroken_piece (LEFT)-set_property (symbol,
permission);
351 }
If you're interested, I can send you the full report (since there's no
possibility of attachment), just tell me where I can send it.
Julien.
This need some discussion before tracking an issue, I think - therefore
cc-ing devel...
Marek Klein,
bug squad member
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Cppcheck reports
On 5/18/12 1:42 PM, Marek Klein ma...@gregoriana.sk wrote:
Hello
2012/5/17 Julien Nabet serval2...@yahoo.fr
I'm not top posting.
Hello,
I just git clone Lilypond project and launched cppcheck (git updated
today).
I thought it could interest you, here are some examples :
[lily/tuplet-bracket.cc:594] - [lily/tuplet-bracket.cc:594]: (style) Same
expression on both sides of '-'
592 if (!follow_beam)
593 {
594 points.push_back (Offset (x0 - x0, staff[dir]));
595 points.push_back (Offset (x1 - x0, staff[dir]));
596 }
[lily/tie-engraver.cc:240]: (performance) Prefer prefix ++/-- operators
for
non-primitive types
240 for (; it heads_to_tie_.end (); it++)
241 report_unterminated_tie (*it);
(+ it's safer to use it != heads_to_tie_.end ())
[lily/paper-book.cc:346]: (performance) Possible inefficient checking for
'cols'
emptiness
346 if (cols.size ())
347 {
348 Paper_column *col = dynamic_castPaper_column *
(cols.back ());
349 col-set_property (symbol, permission);
350 col-find_prebroken_piece (LEFT)-set_property (symbol,
permission);
351 }
If you're interested, I can send you the full report (since there's no
possibility of attachment), just tell me where I can send it.
Julien.
This need some discussion before tracking an issue, I think - therefore
cc-ing devel...
I think that it would be worth creating an issue, and attaching the output
file from cppcheck, as long as the file is not too long.
At any rate, I'd like to see the output file.
Thanks,
Carl
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Make \footnote work via \tweak (issue 6195098)
There are a few questionable things in the docs, but I gather that the
main point of this patch is the code change, so maybe it's ok to push
this patch anyway and fix the docs later.
http://codereview.appspot.com/6195098/diff/14002/Documentation/notation/input.itely
File Documentation/notation/input.itely (right):
http://codereview.appspot.com/6195098/diff/14002/Documentation/notation/input.itely#newcode1048
Documentation/notation/input.itely:1048:
Could we get a @lilypond here? All those @var{}s are going to turn away
some readers. To quote somebody or other: show, not tell. If
necessary, show and tell.
http://codereview.appspot.com/6195098/diff/14002/Documentation/notation/input.itely#newcode1057
Documentation/notation/input.itely:1057: @item offset
I'd prefer a newline before each @item other than the first one, but
that's kind-of nitpicking so I don't mind if you don't bother.
http://codereview.appspot.com/6195098/diff/14002/Documentation/notation/input.itely#newcode1101
Documentation/notation/input.itely:1101: e\noBeam c4 d4
do we really need a \noBeam in here to confuse things? IMO the example
would stand on its own without a noBeam, possibly after altering the
music to suit.
http://codereview.appspot.com/6195098/diff/14002/Documentation/notation/input.itely#newcode1225
Documentation/notation/input.itely:1225: -\footnote
if this still refers to the a'4 then could it also be indented two
space? If you want to show more indentation, then maybe add another two
spaces for the \markup that belongs to the \footnote?
http://codereview.appspot.com/6195098/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Make \footnote work via \tweak (issue 6195098)
On 2012/05/18 21:02:49, Graham Percival wrote: There are a few questionable things in the docs, but I gather that the main point of this patch is the code change, so maybe it's ok to push this patch anyway and fix the docs later. I would like to let Carl field this if possible. This is sorta-squishylike issue 2505, and given the current chaos of Critical code changes I have in the queue, I'd prefer not rewinding countdowns for mostly minor documentation improvements that overlap with his planned documentation cleanup. http://codereview.appspot.com/6195098/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Make \footnote work via \tweak (issue 6195098)
On 2012/05/18 22:09:19, dak wrote: I would like to let Carl field this if possible. This is sorta-squishylike issue 2505, and given the current chaos of Critical code changes I have in the queue, I'd prefer not rewinding countdowns for mostly minor documentation improvements that overlap with his planned documentation cleanup. I will field it. Thanks, Carl http://codereview.appspot.com/6195098/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Cppcheck reports
Thanks for the file, Julien. I have split the warnings into various issues. See issues 2545, 2546, and 2548 through 2554 on the issue tracker. http://code.google.com/p/lilypond/issues/detail?id=2545colspec=ID%20Type%2 0Status%20Stars%20Owner%20Patch%20Needs%20Summary http://code.google.com/p/lilypond/issues/detail?id=2546colspec=ID%20Type%2 0Status%20Stars%20Owner%20Patch%20Needs%20Summary etc. Julien, if you want to fix any of these, I'd be happy to help you get patches reviewed and pushed. Here's instructions on uploading a patch for review: http://lilypond.org/doc/v2.15/Documentation/contributor/commits-and-patches #uploading-a-patch-for-review Thanks, Carl ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: Countdown to 20120517
On 12-05-18 06:27 AM, David Kastrup wrote: Colin Campbellc...@shaw.ca writes: On 12-05-17 11:55 PM, Marc Hohl wrote: Am 16.05.2012 05:23, schrieb Colin Campbell: [...] Issue 2497 http://code.google.com/p/lilypond/issues/detail?id=2497: restrainOpenStrings: please fix snippet in Documentation/notation/fretted-strings.itely - R 6206072 http://codereview.appspot.com/6206072/ [...] Issue 1320 http://code.google.com/p/lilypond/issues/detail?id=1320: Enhancement: user-customizable barlines through a Scheme interface. - R 6210049http://codereview.appspot.com/6210049/ I can't push these myself – I can send patches via email. Who will push these for me? If you send them to me, Marc, I can push them tonight for you. I have already pushed them, and they are in master by now. Ah well, such is life on this side of the Pond: try to give James a hand, and the Monster Machine blows by me while he has a narscuppatea, offer to push a patch or two and get pipped by a 7-hour head start . . . Colin Chronologically Challenged Campbell -- I've learned that you shouldn't go through life with a catcher's mitt on both hands. You need to be able to throw something back. -Maya Angelou, poet (1928- ) ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: PATCH: Countdown to 20120517
Colin Campbell c...@shaw.ca writes: On 12-05-18 06:27 AM, David Kastrup wrote: I have already pushed them, and they are in master by now. Ah well, such is life on this side of the Pond: try to give James a hand, and the Monster Machine blows by me while he has a narscuppatea, offer to push a patch or two and get pipped by a 7-hour head start . . . Colin Chronologically Challenged Campbell The mouse police never sleeps. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
