Re: Rewrite of Midi.c in Python (issue 7016046)

2012-12-27 Thread benko . pal

SGTM

python/midi.c should be removed (this may involve some make changes)
midi files are seen neither in the web interface, nor in the downloaded
patch.

https://codereview.appspot.com/7016046/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: canonicalise notional octave of tonic (issue 7019045)

2012-12-27 Thread benko . pal

LGTM

https://codereview.appspot.com/7019045/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Issue 3049: Parser outputs Lyric events for illegal note names (issue 7017044)

2012-12-27 Thread benko . pal

LGTM

https://codereview.appspot.com/7017044/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Simplify several library functions. (issue 7020044)

2012-12-27 Thread lemzwerg

Everything looks very nice!  I just wonder how it comes that those
simplifications haven't been done from the very beginning: Is it
possible that functions like `any' or `every' are new in Scheme?

https://codereview.appspot.com/7020044/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Dual license the files under mf/ using OFL. (issue 6970046)

2012-12-27 Thread lemzwerg

Sorry for being late.

LGTM, with a (not so) minor nit.


https://codereview.appspot.com/6970046/diff/1/LICENSE.OFL
File LICENSE.OFL (right):

https://codereview.appspot.com/6970046/diff/1/LICENSE.OFL#newcode2
LICENSE.OFL:2: Copyright (c) 1996, 1997, ..., 2012, The LilyPond authors
(lilypond.org)
I strongly suggest to use

  Copyright (c) 1996-2012 The LilyPond authors (lilypond.org)

which is the canonical form w.r.t. a range of copyrighted years.

https://codereview.appspot.com/6970046/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


PATCH: Countdown to 20121230

2012-12-27 Thread Colin Campbell

For 20:00 MST Sunday December 30

Documentation:
   Issue 3051 
http://code.google.com/p/lilypond/issues/detail?id=3051: [DOC]Update 
Contributor’s Guide 5.2 to mention use of LSR - R 7013043 
https://codereview.appspot.com/7013043/
   Issue 3015 
http://code.google.com/p/lilypond/issues/detail?id=3015: Move Appendix 
C to the NR, LilyPond Grammar, to the CG - R 6948070 
https://codereview.appspot.com/6948070/


Enhancement:
   Issue 3063 
http://code.google.com/p/lilypond/issues/detail?id=3063: Make 
\articulate handle grace notes - R 7017045 
https://codereview.appspot.com/7017045/
   Issue 3058 
http://code.google.com/p/lilypond/issues/detail?id=3058: Patch: Make 
lexer more robust against unexpected EOF - R 7003053 
https://codereview.appspot.com/7003053/


Maintainability:
 Issue 847 
http://code.google.com/p/lilypond/issues/detail?id=847: python scripts 
should add an autogenerated marker - R 7021043 
https://codereview.appspot.com/7021043/


Ugly:
Issue 2527 
http://code.google.com/p/lilypond/issues/detail?id=2527: Finger-flag 
collision - R 6827072 https://codereview.appspot.com/6827072/


Warning:
Issue 3060 
http://code.google.com/p/lilypond/issues/detail?id=3060: False 
warnings produced by simultaneous key changes - R 7019045 
https://codereview.appspot.com/7019045/




Cheers,
Colin

--
I've learned that you shouldn't go through life with a catcher's mitt on both 
hands.
You need to be able to throw something back.
-Maya Angelou, poet (1928- )

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Web: Added New Page Acknowledgements.itexi (issue 6948068)

2012-12-27 Thread pkx166h

author James Lowe pkx1...@gmail.com
 Mon, 17 Dec 2012 21:27:45 + (21:27 +)
committer James Lowe pkx1...@gmail.com
 Fri, 28 Dec 2012 07:14:37 + (07:14 +)
commit5d83b53ee321d8890d792191032b1fe352577517

https://codereview.appspot.com/6948068/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


New Catalan PO file for 'lilypond' (version 2.15.95)

2012-12-27 Thread Translation Project Robot
Hello, gentle maintainer.

This is a message from the Translation Project robot.

A revised PO file for textual domain 'lilypond' has been submitted
by the Catalan team of translators.  The file is available at:

http://translationproject.org/latest/lilypond/ca.po

(We can arrange things so that in the future such files are automatically
e-mailed to you when they arrive.  Ask at the address below if you want this.)

All other PO files for your package are available in:

http://translationproject.org/latest/lilypond/

Please consider including all of these in your next release, whether
official or a pretest.

Whenever you have a new distribution with a new version number ready,
containing a newer POT file, please send the URL of that distribution
tarball to the address below.  The tarball may be just a pretest or a
snapshot, it does not even have to compile.  It is just used by the
translators when they need some extra translation context.

The following HTML page has been updated:

http://translationproject.org/domain/lilypond.html

If any question arises, please contact the translation coordinator.

Thank you for all your work,

The Translation Project robot, in the
name of your translation coordinator.
coordina...@translationproject.org


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel