Re: Removes '-signs in vectors - follow-up (issue 7834043)
Hi, On Wed, Apr 3, 2013 at 1:41 AM, thomasmorle...@googlemail.com wrote: On 2013/04/02 21:35:23, janek wrote: Is this patch still valid? I don't see any ' signs being removed, Meanwhile I removed the '-signs from the relevant snippets in LSR as well. I wasn't aware that a new release would contain them. So it is indeed invalid. git grep #'# only returns some occurrences in doc-translations. What to do? Close the issue? I think so - both this and tracker issue, possibily with a comment. only some semi-random side-effects here and there. What do you mean here? All remaining changes, which look strange - removed lines, changed comments, etc. best, Janek ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Removes '-signs in vectors - follow-up (issue 7834043)
Janek Warchoł janek.lilyp...@gmail.com writes: Hi, On Wed, Apr 3, 2013 at 1:41 AM, thomasmorle...@googlemail.com wrote: On 2013/04/02 21:35:23, janek wrote: Is this patch still valid? I don't see any ' signs being removed, Meanwhile I removed the '-signs from the relevant snippets in LSR as well. I wasn't aware that a new release would contain them. makelsr takes everything from the LSR that has not been superseded by a snippet in the new directory. So it is indeed invalid. More likely Fixed, but Patch-abandoned (or tag removed altogether) since the fix did not travel via the patch and the standard repository mechanism. Perhaps double-check that the % end verbatim occurs only where expected in master, and then close as fixed, possibly with the version number where the fix traveled in via makelsr. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Allows minimum-length to work for end-of-line spanners. (issue 7453046)
Hi all, On Wed, Apr 3, 2013 at 12:57 AM, d...@gnu.org wrote: On 2013/04/02 22:34:53, janek wrote: This should not be an excuse for broken code, but i think that we can accept patches that are iterations towards Ultimate Solution. This one is an iteration away from a proper solution since it increases the inconsistency of minimum-length. As i see it, Mike's patch doesn't make matters worse - it's just a piece of duct tape to make a temporary solution (i.e. current messy code) less broken. No, it makes it _more_ broken in order to paper over an annoying consequence of the brokenness. I think that we could add a FIXME to it and accept it, because it's not making future rewrite harder (at least it seems so to me). How does an increase in the inconsistency of minimum-length _not_ make a future rewrite harder? Also, we're trying to make a stable release soon, so this is not a good time to start rewriting big pieces of code. It is not a good time shoving in behavior that is not going to survive into the next stable release (assuming that this _is_ going to be fixed in a sensible manner) either. The behavior of our stable releases should not be erratic but rather increasingly reliable. Well, i don't insist on sharing my point of view. I think we can agree to differ. However, if we only accepted code changes that were implementing the Ultimate Solution, i'm afraid that the development process would grind to a halt - Ultimate Solutions are obvioulsly best, but they take much much more time to implement, and usually only experts can write them. That's the ultimate excuse to never bother about doing things right. Hmm. What about doing something constructive, then? There is one big let's do things right patch that needs review. Despite a lot of effort spent by its author on writing a detailed description to attract reviewers, only one person cared to review it: codereview.appspot.com/7768043 best, Janek ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: point-and-click in SVG
On Wed, Apr 3, 2013 at 1:16 AM, Graham Percival gra...@percival-music.ca wrote: The archives show a few half-hearted attempts to get this working, but no actual patches other than Mike's lily dances patch from Dec 2010 which wasn't merged. I've got a patch which adds point-and-click, https://codereview.appspot.com/8273045 but it's sub-optimal at the moment because you need to click slightly away from the note -- a directly click on the notehead does nothing. This is because output-svg.scm's (grob-cause ...) is called *before* drawing the path of the notehead, and SVG has no z-index. The question is this: what calls grob-cause? Well, it seems that grob-cause is set in lily/grob.cc Grob::get_print_stencil, but i'm not sure if this helps you at all, because this function seems to be almost unused.. Sorry not to be of help. Janek ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Allows minimum-length to work for end-of-line spanners. (issue 7453046)
Janek Warchoł janek.lilyp...@gmail.com writes: Hmm. What about doing something constructive, then? There is one big let's do things right patch that needs review. Despite a lot of effort spent by its author on writing a detailed description to attract reviewers, only one person cared to review it: codereview.appspot.com/7768043 If you bothered to look, you'd have found that in spite of daring to take off a week of vacation from a year of LilyPond development, I committed about half a dozen fixes of problems and regressions that impeded getting to stable release quality while also running a batch of Patchy tests. I apologize if I don't seem to have the time to review post-stable release material thoroughly. There is also the question of preparing the EU proposal. So I apologize if I don't appear to have the time to be constructive. It definitely looks like I should call off the stable release for good as nobody else wants to get bothered with its consequences and it is not like I don't have enough other stuff on my hand. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Allows minimum-length to work for end-of-line spanners. (issue 7453046)
David, On Wed, Apr 3, 2013 at 12:15 PM, David Kastrup d...@gnu.org wrote: Janek Warchoł janek.lilyp...@gmail.com writes: Hmm. What about doing something constructive, then? There is one big let's do things right patch that needs review. Despite a lot of effort spent by its author on writing a detailed description to attract reviewers, only one person cared to review it: codereview.appspot.com/7768043 If you bothered to look, you'd have found that in spite of daring to take off a week of vacation from a year of LilyPond development, I committed about half a dozen fixes of problems and regressions that impeded getting to stable release quality while also running a batch of Patchy tests. I apologize if I don't seem to have the time to review post-stable release material thoroughly. There is also the question of preparing the EU proposal. So I apologize if I don't appear to have the time to be constructive. It definitely looks like I should call off the stable release for good as nobody else wants to get bothered with its consequences and it is not like I don't have enough other stuff on my hand. I apologize for making it look like i blamed you for the situation. This was not my intention; it's not your fault that issue 3239 was reviewed by one person only. You're not responsible for reviewing everything, and i certainly don't demand that you review something when you're on vacation (issue 3239 was up for review before your vacation, but this still doesn't mean that you have any duty to review it). I was indeed quite surprised to see you being so active during last week, to the point that i wasn't sure if i remembered the date of your vacation correctly. I also believe that you deserved your vacation, and i'm sorry that you didn't have more vacations during this year. My only intention in writing the previous message was to point out that doing things right is hard and that even thoroughly described patches don't get much reviews, which is discouraging (that's only stating a fact, i'm not blaming anyone for this). Janek PS i'm not sure what you mean by reviewing thoroughly. I never expect anyone to do more than read commit messages and Rietveld diffs once; that's why i spend so much time on polishing commit messages. If anything is unclear after this first reading, i expect everyone to ask me, even if such questions may look silly. ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Define call-after-session for cleanup called after every file (issue 8310043)
LGTM https://codereview.appspot.com/8310043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Issue 3290: Appendix 4, Predefined fretboard diagram: wrong chords are displayed (issue 8320043)
LGTM Trevor https://codereview.appspot.com/8320043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: rewrite Self_alignment_interface (issue 7768043)
Code not tested or even eye-balled.
https://codereview.appspot.com/7768043/diff/76001/input/regression/text-spanner-attachment-alignment.ly
File input/regression/text-spanner-attachment-alignment.ly (right):
https://codereview.appspot.com/7768043/diff/76001/input/regression/text-spanner-attachment-alignment.ly#newcode21
input/regression/text-spanner-attachment-alignment.ly:21: \repeat unfold
2 {c'4 _ \markup { FAT } }
What does (1 . -1) do? I saw nothing in any of the
commit messages about changing the user interface
(but they are so long maybe I missed it)
https://codereview.appspot.com/7768043/diff/76001/input/regression/unassociated-lyrics-alignment.ly
File input/regression/unassociated-lyrics-alignment.ly (right):
https://codereview.appspot.com/7768043/diff/76001/input/regression/unassociated-lyrics-alignment.ly#newcode12
input/regression/unassociated-lyrics-alignment.ly:12: \new Lyrics {
\lyricmode { foo2 bar aaa1 mmm1 } }
I see the durations on the syllables are the same as those
on the notes. What happens if they differ? In particular
if a syllable is placed between two notes?
https://codereview.appspot.com/7768043/diff/76001/scm/define-grob-properties.scm
File scm/define-grob-properties.scm (right):
https://codereview.appspot.com/7768043/diff/76001/scm/define-grob-properties.scm#newcode807
scm/define-grob-properties.scm:807: @code{'(-1 . 1)} will result in
grobs' left edge being aligned to
OK, I understand now.
https://codereview.appspot.com/7768043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Allows minimum-length to work for end-of-line spanners. (issue 7453046)
Janek Warchoł janek.lilyp...@gmail.com writes: I also believe that you deserved your vacation, and i'm sorry that you didn't have more vacations during this year. Actually, I also visited the lady in Zürich last year (don't know how long she'll be around) for whose father my accordion had been built in 1960, so it's been two weeks. Sorry for the inaccuracy. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Allows minimum-length to work for end-of-line spanners. (issue 7453046)
On Wed, Apr 3, 2013 at 7:23 PM, David Kastrup d...@gnu.org wrote: Janek Warchoł janek.lilyp...@gmail.com writes: I also believe that you deserved your vacation, and i'm sorry that you didn't have more vacations during this year. Actually, I also visited the lady in Zürich last year (don't know how long she'll be around) for whose father my accordion had been built in 1960, Ah, i remember that accordion well :) Very cool :) so it's been two weeks. Sorry for the inaccuracy. No problem. I still think that you deserved more. Janek ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: rewrite Self_alignment_interface (issue 7768043)
Thanks for the review!
On 2013/04/03 17:12:14, Trevor Daniels wrote:
Code not tested or even eye-balled.
If you're considering eye-balling it, i strongly recommend viewing it in
a branch (dev/janek-alignment) - hopefully commit descriptions will help
understand respective changes in the code.
https://codereview.appspot.com/7768043/diff/76001/input/regression/unassociated-lyrics-alignment.ly
File input/regression/unassociated-lyrics-alignment.ly (right):
https://codereview.appspot.com/7768043/diff/76001/input/regression/unassociated-lyrics-alignment.ly#newcode12
input/regression/unassociated-lyrics-alignment.ly:12: \new Lyrics {
\lyricmode { foo2 bar aaa1 mmm1 } }
On 2013/04/03 17:12:14, Trevor Daniels wrote:
I see the durations on the syllables are the same as those
on the notes. What happens if they differ? In particular
if a syllable is placed between two notes?
Then the center of the syllable will be aligned to the appropriate point
between these notes, much like Dynamics attached to spacer rests:
\paper {
ragged-right = ##f
}
{
c'4\ c'\! d'\ e'\!
f'1 { s4 s4\ s4\ s4\! }
}
{ c'4 c' d' e' f'1 }
\new Lyrics \lyricmode {
4 !4 4 !4
\skip4 4 4 !4
}
(output attached to tracker issue)
Do you think that this should be part of the regtest?
https://codereview.appspot.com/7768043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Suggested patch to make midiMaximumVolume take effect without initial dynamic
Hi Anders, On 9 March 2013 19:57, Anders Pilegaard arrowy...@gmail.com wrote: Hello all. This is getting a bit long, so here's a brief overview of what's in this mail: - I'm proposing a patch ... I apologize for not looking at your patch earlier - fortunately James took care of tracking and pushing it (thanks for saving the day, James!). I have to say that i'm *very* impressed by the detailed explanation you provided - the commit message is excellent! Many thanks for it! In fact, i don't think i remember any patch that was so well explained. I've added you to the list of contributors (http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=commit;h=987ac72dd0e893792521260fec6a065d1d49c4a6) - your name should appear on the website in a day or two. I'd also like to thank you personally - i sing in a choir, too, and we use some Lilypond scores, as well as Lily-made MIDI files. I've noticed this issue before, and it bothered me a bit, but i didn't get to fixing it... So, thank you again! Is there any particular bug that bothers you? I could see if i'd be able to fix it. Again, i'm very sorry that i didn't get in touch with you earlier. You did an excellent job! all the best, Janek ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Define call-after-session for cleanup called after every file (issue 8310043)
LGTM. You've done a load of good work on introducing the session architecture, so why not let people know about it, even if it's only via a comment in lily.scm? Cheers, Ian https://codereview.appspot.com/8310043/diff/1/scm/lily.scm File scm/lily.scm (right): https://codereview.appspot.com/8310043/diff/1/scm/lily.scm#newcode45 scm/lily.scm:45: ;; ;; Session-handling variables and procedures. ;; ;; Sessions are used to ensure that environments are kept ;; separate when LilyPond is called to compile several ;; files on the command line, and there is no 'bleed-over' ;; between the source files ;; https://codereview.appspot.com/8310043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: point-and-click in SVG
Graham Percival writes: I've got a patch which adds point-and-click, Nice! This is because output-svg.scm's (grob-cause ...) is called *before* drawing the path of the notehead, and SVG has no z-index. What if you have grob-cause set a grob-cause for the subsequent notehead/grob to pick up and draw? Something like (define cause #f) (define (grob-cause offset grob) (set! cause (ly:format ...))) (define (named-glyph font name) (dispatch `(fontify ,font ,name ,cause))) would that work? Can some of this code be shared with output-ps and moved to output-lib.scm? Greetings, Jan -- Jan Nieuwenhuizen jann...@gnu.org | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar® http://AvatarAcademy.nl ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
