Re: Doc: Add @funindex for \newSpacingSection (3185) (issue 8762045)

[graham]

LGTM

https://codereview.appspot.com/8762045/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Point and Click does not work on Windows

[Eluze]

ArnoldTheresius wrote
> 
> Eluze wrote
>> and finally (?) if the editor associated with the .ly file extension
>> could be launched… (it is stored in
>> HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Explorer\FileExts\.ly\userchoice)
> The first three should be simple:
>   ("context" . "context /g%(column)s:%(line)s %(file)s")
>   ("notepad++" . "notepad++ -n%(line)s -c%(column)s %(file)s")
>   ("pspad" . "pspad -%(line)s %(file)s")
> 
> To select on than it's enough to set the env. var. like
>LYEDITOR=pspad
> 
> For the last one I need to check how scheme can read the windows registry.
> Hopefully I find this information.

if this is possible we could abandon the entry LYEDITOR?! (at least for
windows)

Eluze



--
View this message in context: 
http://lilypond.1069038.n5.nabble.com/Point-and-Click-does-not-work-on-Windows-tp115986p144657.html
Sent from the Dev mailing list archive at Nabble.com.

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Gives MetronomeMark default skyline-horizontal-padding of 0.2 (issue 8632044)

[janek . lilypond]

LGTM

https://codereview.appspot.com/8632044/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add changes entry for Mike's work on skylines. (issue 8613043)

[Janek Warchoł]

2013/4/17 Keith OHara :
> On Tue, 16 Apr 2013 04:10:32 -0700, Janek Warchoł 
> wrote:
>
>> 2013/4/16  :
>>> So what we need is not a vote.  What we need is as much feedback as we
>>> can get about cases considered problematic, and we need to see whether
>>> we can change defaults in a way where they cease being a problem, at
>>> least to the degree where people will not bother fiddling with
>>> overrides in order to get rid of them.
>>
>> I agree except for the fact that i already think its impossible to
>> tweak defaults to achieve this.
>
>
> Then let's un-tweak the defaults for Lyrics.  Sure, some padding helped in
> your "Tota pulchra" but it might result in wrong placement in other cases,
> so we should remove it:
>
> \new ChoirStaff <<
>   \new Lyrics = "s"
>   \new Staff = "staff" <<
> \new Voice = "s"  \transpose c c'' { \voiceOne d4 d }
> \new Voice = "a"  \transpose c c' { \voiceTwo d4 d } >>
>   \new Lyrics = "s" \with { alignAboveContext = "staff" }
>   \context Lyrics = "s" \lyricsto "s" { Ni }
>   \context Lyrics = "a" \lyricsto "a" { j  lli } >>
> \layout { \context {\Lyrics
> \override VerticalAxisGroup #'nonstaff-relatedstaff-spacing = #'()
> \override LyricText #'skyline-horizontal-padding = #0 }}

Well, that's indeed amazingly ugly example.
I apologize if my email sounded unfriedndly and/or disparaging.  I
agree that we need sane defaults for skylines, and i admit that
there's room for improvement from the current state.  I'll report any
problematic skyline case if i encounter one.

all the best,
Janek

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Gives DynamicTextSpanner a default skyline-horizontal-padding (issue 8799045)

[janek . lilypond]

LGTM

https://codereview.appspot.com/8799045/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

PATCHES: Countdown for April 20th 2013 - 19:00 GMT

[James]

Hello

*Countdown – April 20th 2013 – 19:00 GMT* *
* *
* *
* *
*




 
828
Defect
Keith O'Hara Push New time signatures should be inserted between repeat
barlines  
3309
Enhancement
Janek Warchol Push Patch: change OctavateEight to ClefModifier
3285
Documentation
Trevor Daniels Push Documentation suggestions
3289
Critical
Mike Solomon Push Cross-voice arpeggio moves accidental away from notehead
  Regression  
3311
Critical
Keith O'Hara Push slur skylines look weird after we allowed zero-width
buildings   Regression




 
2658
Defect
David Kastrup Countdown wrong stem rendering (inconsistent thickness)
3280
Documentation
Trevor Daniels Countdown NR and allocating a tweak
3195
Documentation
Trevor Daniels Countdown missing \consists "Rhythmic_column_engraver" in
doc example  
3185
Documentation
Trevor Daniels Countdown Add newSpacingSection to the index
3136
Ugly
Julien Rioux Countdown lilypond-book - automatic line width detection fails
because of the included file




 
3322
Enhancement
David Kastrup review Patch: Add callback factory
grob::inherit-parent-property
3320
Ugly
Mike Solomon review Dynamic spanner vertical spacing   Regression
3313
Enhancement
David Nalesnik review Patch: Add the command \offset to LilyPond
3307
Ugly
David Kastrup review Rest positions incorrect with non-standard line count
3207
Ugly
Mike Solomon review too extreme skylining for \tempo text   Regression
 
3175
Documentation
Trevor Daniels review [DOC] Notation Reference 1.6.2 Modifying single
staves - customizing staff positions
3159
Documentation
Trevor Daniels review Rewrite \transposition examples in notation manual
3134
Enhancement
Mike Solomon review Patch: Removes the translate_axis call from
axis-group-interface outside-staff positioning.
3080

Re: Add callback factory grob::inherit-parent-property (issue 8726045)

[m...@mikesolomon.org]

On 17 avr. 2013, at 21:45, d...@gnu.org wrote:

> Reviewers: MikeSol,
> 
> Message:
> On 2013/04/17 18:27:05, MikeSol wrote:
>> Hey, I hadn't seen this. I just finished writing an equivalent patch.
> Yours is
>> better, so keep it.  You can use this for the
> inherit-X-parent-visibility and
>> eliminate the inherit-Y-parent-visibility callback, which is cruft and
> can be
>> replaced with the X one.
> 
> I did not actually replace anything because I was not sure of the intent
> of the code matching the actual code.
> 
> inherit-x-parent-visibility is used only once, so is
> inherent-y-parent-visibility.
> 
> Apart from the axis discrepancy, the only visible difference is that
> inherit-x-parent-visibility has a default of all-invisible, while
> inherit-y-parent-visibility has a default of '() and thus can
> distinguish the default use, possibly substituting something else.

I think the y callback should have never been added - you should use the x one 
instead.  I tested out replacing the y with x and didn't see any visual 
changes, so it should be ok.  I think the X parent of a FootnoteItem is the Y 
parent anyway.

Cheers,
MS
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add callback factory grob::inherit-parent-property (issue 8726045)

[dak]

Reviewers: MikeSol,

Message:
On 2013/04/17 18:27:05, MikeSol wrote:

Hey, I hadn't seen this. I just finished writing an equivalent patch.

Yours is

better, so keep it.  You can use this for the

inherit-X-parent-visibility and

eliminate the inherit-Y-parent-visibility callback, which is cruft and

can be

replaced with the X one.


I did not actually replace anything because I was not sure of the intent
of the code matching the actual code.

inherit-x-parent-visibility is used only once, so is
inherent-y-parent-visibility.

Apart from the axis discrepancy, the only visible difference is that
inherit-x-parent-visibility has a default of all-invisible, while
inherit-y-parent-visibility has a default of '() and thus can
distinguish the default use, possibly substituting something else.

I was planning to remove _both_ functions here.  The question is what
call to replace inherit-y-parent-visibility with: use rather the X or Y
axis parent, and which default to use.  I am not familiar with the
footnote code enough to make that decision, so I was planning on leaving
the actual replacement with you.

I think there are several other rarely used callbacks which would
warrant replacing by a call to grob::inherit-parent-property since that
puts the programmer-interesting information right in define-grobs.scm
and does not scatter it to other files.

Description:
Add callback factory grob::inherit-parent-property

"@var{grob} callback generator for inheriting a @var{property} from
an @var{axis} parent, defaulting to @var{default} if there is no
parent or the parent has no setting."

Please review this at https://codereview.appspot.com/8726045/

Affected files:
  M scm/output-lib.scm


Index: scm/output-lib.scm
diff --git a/scm/output-lib.scm b/scm/output-lib.scm
index  
4533cf2a965a8c95eb22b3dcf84d21dc2e5ad8f7..f424931c2d410f74c4282a5bcf19b87a1d56e422  
100644

--- a/scm/output-lib.scm
+++ b/scm/output-lib.scm
@@ -1099,6 +1099,19 @@ and draws the stencil based on its coordinates.
 (define-public ((grob::calc-property-by-non-event-cause prop) grob)
   (ly:grob-property (non-event-cause grob) prop))

+
+;; general inheritance
+
+(define-public ((grob::inherit-parent-property axis property . default)  
grob)

+  "@var{grob} callback generator for inheriting a @var{property} from
+an @var{axis} parent, defaulting to @var{default} if there is no
+parent or the parent has no setting."
+  (let ((parent (ly:grob-parent grob axis)))
+(cond
+ ((ly:grob? parent)
+  (apply ly:grob-property parent property default))
+ ((pair? default) (car default))
+ (else '()

 
 ;; fret boards



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Add callback factory grob::inherit-parent-property (issue 8726045)

[mtsolo]

Hey, I hadn't seen this. I just finished writing an equivalent patch.
Yours is better, so keep it.  You can use this for the
inherit-X-parent-visibility and eliminate the
inherit-Y-parent-visibility callback, which is cruft and can be replaced
with the X one.

https://codereview.appspot.com/8726045/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Point and Click does not work on Windows

[ArnoldTheresius]

Eluze wrote
> ...
> it would be nice to add a few more editors, e.g. (for windows)
> 
> context.exe/g
> 
> :
> 
>  file
> notepad++.exe   -n
> 
>  -c
> 
>  file
> pspad.exe  -
> 
>  file
> 
> and finally (?) if the editor associated with the .ly file extension could
> be launched… (it is stored in
> HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Explorer\FileExts\.ly\userchoice)
> 
> thanks!
> Eluze

The first three should be simple:
  ("context" . "context /g%(column)s:%(line)s %(file)s")
  ("notepad++" . "notepad++ -n%(line)s -c%(column)s %(file)s")
  ("pspad" . "pspad -%(line)s %(file)s")

To select on than it's enough to set the env. var. like
   LYEDITOR=pspad

For the last one I need to check how scheme can read the windows registry.
Hopefully I find this information.

ArnoldTheresius



--
View this message in context: 
http://lilypond.1069038.n5.nabble.com/Point-and-Click-does-not-work-on-Windows-tp115986p144634.html
Sent from the Dev mailing list archive at Nabble.com.

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Point and Click does not work on Windows

[Eluze]

ArnoldTheresius wrote
> in relation to issue 3306
> [http://code.google.com/p/lilypond/issues/detail?id=3306]
> I analized the point-and-click problem on my Win7/64 computer.
> (Why does it not work out of the box after installation?)
*
> Here the result:
*
> 
*
> Modifications to $INSTDIR/usr/share/lilypond/current/scm/editor.scm:
*
> 
/
>   (define editor-command-template-alist
> -   '(("emacs" .  "emacsclient --no-wait +%(line)s:%(column)s %(file)s ||
> (emacs +%(line)s:%(column)s %(file)s&)")
> +   `(("emacs" .  "emacsclient --no-wait +%(line)s:%(column)s %(file)s ||
> (emacs +%(line)s:%(column)s %(file)s&)")
>   ("gvim" . "gvim --remote +:%(line)s:norm%(column)s %(file)s")
>   ("uedit32" . "uedit32 %(file)s -l%(line)s -c%(char)s")
>   ("nedit" . "nc -noask +%(line)s %(file)s")
>   ("gedit" . "gedit +%(line)s %(file)s")
>   ("jedit" . "jedit -reuseview %(file)s +line:%(line)s")
>   ("syn" . "syn -line %(line)s -col %(char)s %(file)s")
> - ("lilypad" . "lilypad +%(line)s:%(char)s %(file)s")))
> + ("lilypad" . ,(if (eq? PLATFORM 'windows)
> + "start lilypad +%(line)s:%(char)s %(file)s"
> + "lilypad +%(line)s:%(char)s %(file)s"
/
> 

hi Arnold

that was really worth waiting 

it would be nice to add a few more editors, e.g. (for windows)

context.exe/g: file
notepad++.exe   -n -c file
pspad.exe  - file

and finally (?) if the editor associated with the .ly file extension could
be launched… (it is stored in
HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Explorer\FileExts\.ly\userchoice)

thanks!
Eluze






--
View this message in context: 
http://lilypond.1069038.n5.nabble.com/Point-and-Click-does-not-work-on-Windows-tp115986p144633.html
Sent from the Dev mailing list archive at Nabble.com.

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Gives MetronomeMark default skyline-horizontal-padding of 0.2 (issue 8632044)

[lemzwerg]

LGTM.

https://codereview.appspot.com/8632044/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Gives DynamicTextSpanner a default skyline-horizontal-padding (issue 8799045)

[lemzwerg]

LGTM.

https://codereview.appspot.com/8799045/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel