PATCHES: Countdown for July 27 - 06:00 GMT
Hello, *Countdown – July 27 – 06:00 GMT* * * * * * * * * 3462http://code.google.com/p/lilypond/issues/detail?id=3462q=label%3APatch-reviewsort=modified%20patchcolspec=ID%20Type%20Status%20Stars%20Owner%20Patch%20Needs%20Summary%20Modified Enhancement Julien Rioux Push Patch: Support for testing min and max versions of Python. 3121http://code.google.com/p/lilypond/issues/detail?id=3121q=label%3APatch-reviewsort=modified%20patchcolspec=ID%20Type%20Status%20Stars%20Owner%20Patch%20Needs%20Summary%20Modified Build Julien Rioux Push Bad dependencies for notation manual appendices? 3461http://code.google.com/p/lilypond/issues/detail?id=3461q=label%3APatch-reviewsort=modified%20patchcolspec=ID%20Type%20Status%20Stars%20Owner%20Patch%20Needs%20Summary%20Modified Enhancement Julien Rioux Push Patch: Support for testing min and max versions of Guile. 3469http://code.google.com/p/lilypond/issues/detail?id=3469q=label%3APatch-reviewsort=modified%20patchcolspec=ID%20Type%20Status%20Stars%20Owner%20Patch%20Needs%20Summary%20Modified Enhancement Thomas Morely Push Patch: adding markup-commands \oval and \ellipse 3471http://code.google.com/p/lilypond/issues/detail?id=3471q=label%3APatch-countdownsort=patchcolspec=ID%20Type%20Status%20Stars%20Owner%20Patch%20Summary%20Modified Enhancement David Kastrup countdown Patch: Allow decimal fractions with non-empty parts before and after '.' in music 3407http://code.google.com/p/lilypond/issues/detail?id=3407q=label%3APatch-countdownsort=patchcolspec=ID%20Type%20Status%20Stars%20Owner%20Patch%20Summary%20Modified Documentation Phil Holmes countdown Doc: Learning Manual example is not as described Regression *Patches moved to 'Needs Work' this countdown* 3472http://code.google.com/p/lilypond/issues/detail?id=3472q=Patch%3Dneeds_workcolspec=ID%20Type%20Status%20Stars%20Owner%20Patch%20Needs%20Summary Enhancement David Nalesnik needs_work Patch: input/regression/scheme-text-spanner.ly: fix problem with constants James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: input/regression/scheme-text-spanner.ly: fix problem with constants (issue 11614044)
Instead, complete-grob-entry (or whatever it was called) needs to be changed in order to work non-destructively. It does not make sense to do this separately from the original code. OK, I won't bother yet with add-grob-definition here, but I wonder: if I use copy-tree on a literal expression, is it alright to modify the resulting list with assoc-set! and the like? In other words, does copying the list create another literal that I should again refrain from tampering with? I ask because the following attempt at avoidance looks like overkill to me: #(define (add-grob-definition grob-name grob-entry) (let* ((meta (assoc 'meta grob-entry)) (meta-entry (cdr meta)) (class (assoc-get 'class meta-entry)) (ifaces (assoc 'interfaces meta-entry)) (ifaces-entry (cdr ifaces)) (ifaces-entry (append (case class ((Item) '(item-interface)) ((Spanner) '(spanner-interface)) ((Paper_column) '((item-interface paper-column-interface))) ((System) '((system-interface spanner-interface))) (else '(unknown-interface))) ifaces-entry)) (ifaces-entry (uniq-list (sort ifaces-entry symbol?))) (ifaces-entry (cons 'grob-interface ifaces-entry)) (ifaces (cons (car ifaces) ifaces-entry)) (meta-entry (acons 'name grob-name meta-entry)) (meta-entry (map (lambda (x) (if (eq? (car x) 'interfaces) ifaces x)) meta-entry)) (meta (cons (car meta) meta-entry)) (grob-entry (map (lambda (x) (if (eq? (car x) 'meta) meta x)) grob-entry))) (set-object-property! grob-name 'translation-type? list?) (set-object-property! grob-name 'is-grob? #t) (set! all-grob-descriptions (cons (cons grob-name grob-entry) all-grob-descriptions Thanks for your patience! David https://codereview.appspot.com/11614044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Fwd: New Feature: musicxml2ly should consider colors of noteheads and stems
Forwarding to devel list - this is more patch proposal than bug report. Please comment if we need tracker issue for this... -- Forwarded message -- From: DaLa d.la...@gmx.de Date: 2013/7/20 Subject: New Feature: musicxml2ly should consider colors of noteheads and stems To: bug-lilyp...@gnu.org Hello, many thanks for all the software of the lilypond project. Yesterday I colored some noteheads in a piece of music using the format musicxml. I learned: the format musicxml supports color attributes for noteheads and stems. Unfortunately the script musicxml2ly.py in lilypond version 2.16.2-1 seems to ignore color attributes of noteheads and stems. I therefore would like to recommend the following changes in the scripts * musicxml2ly.py * musicexp.py I have made some simple tests - the changes seem to work. Maybe some additional regression tests are necessary. (and: I'm not familiar with the methods pre_note_ly of the Event classes - must they consider the color attribute? I don't know.) Thank You DaLa - - - [musicxml2ly.py, line 1610] def musicxml_notehead_to_lily (nh): #function changed: additionally process color attribute styles = [] # Notehead style style = notehead_styles_dict.get (nh.get_text ().strip (), None) style_elm = musicexp.NotestyleEvent () if style: style_elm.style = style if hasattr (nh, 'filled'): style_elm.filled = (getattr (nh, 'filled') == yes) if hasattr (nh, 'color'): style_elm.color = hex_to_color (getattr (nh, 'color')) if style_elm.style or (style_elm.filled != None) or (style_elm.color != None): styles.append (style_elm) # parentheses if hasattr (nh, 'parentheses') and (nh.parentheses == yes): styles.append (musicexp.ParenthesizeEvent ()) return styles def musicxml_stem_to_lily (st): #function added: process stem color attribute styles = [] # Stem style style_elm = musicexp.StemstyleEvent () if hasattr (st, 'color'): style_elm.color = hex_to_color (getattr (st, 'color')) if (style_elm.color != None): styles.append (style_elm) return styles [musicexp.py, line 1247] class NotestyleEvent (Event): #class changed: additional attribute color def __init__ (self): Event.__init__ (self) self.style = None self.filled = None self.color = None def pre_chord_ly (self): return_string = '' if self.style: return_string += \\once \\override NoteHead #'style = #%s % self.style if self.color: return_string += \\once \\override NoteHead #'color = #(rgb-color %s %s %s) % (self.color[0], self.color[1], self.color[2]) return return_string def pre_note_ly (self, is_chord_element): if self.style and is_chord_element: return \\tweak #'style #%s % self.style else: return '' def ly_expression (self): return self.pre_chord_ly () class StemstyleEvent (Event): #class added def __init__ (self): Event.__init__ (self) self.color = None def pre_chord_ly (self): if self.color: return \\once \\override Stem #'color = #(rgb-color %s %s %s) % (self.color[0], self.color[1], self.color[2]) else: return '' def pre_note_ly (self, is_chord_element): return '' def ly_expression (self): return self.pre_chord_ly () ___ bug-lilypond mailing list bug-lilyp...@gnu.org https://lists.gnu.org/mailman/listinfo/bug-lilypond ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
