Re: [Lilypond-auto] Issue 3818 in lilypond: Patch: stencil.scm: addmake-path-stencil function
Trevor Daniels wrote > It seems you're not authorised to change the labels, so I've done it for > you. Ok, thanks! -Paul -- View this message in context: http://lilypond.1069038.n5.nabble.com/Re-Lilypond-auto-Issue-3818-in-lilypond-Patch-stencil-scm-addmake-path-stencil-function-tp158369p158370.html Sent from the Dev mailing list archive at Nabble.com. ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: [Lilypond-auto] Issue 3818 in lilypond: Patch: stencil.scm: addmake-path-stencil function
> Comment #3 on issue 3818 by paulwmor...@gmail.com: Patch: stencil.scm: add > make-path-stencil function > http://code.google.com/p/lilypond/issues/detail?id=3818 > > Attempting to change label to "new" to trigger automated tests. I don't > see any interface for editing labels, just this comment field and a link to > attach a file. (Maybe I don't have sufficient privileges to edit labels?) > Maybe you just enter them as text here in the comment? Here goes, but I > doubt this will work, except maybe for comic effect... > > Labels: -Patch-countdown Patch-new It seems you're not authorised to change the labels, so I've done it for you. Trevor ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: stencil.scm: add make-path-stencil function (issue 54050043)
On 2014-01-23 15:50, Trevor Daniels wrote: Yes. Go to the issue tracker 3818, click in the box at the bottom to enter a comment, and set the label Patch-countdown to Patch-new, and save. Ah, that makes sense, thanks. However, when I start to enter a comment I don't see any interface for editing labels, just the comment field and a link to attach a file. Should I see a menu or a separate labels field or something? Maybe I do not have sufficient privileges to edit labels? Thanks again, -Paul ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: stencil.scm: add make-path-stencil function (issue 54050043)
Paul Morris wrote Thursday, January 23, 2014 10:44 PM > This second patch set appeared successfully on Rietveld, but it looks like > the automatic test to confirm that it passes make, make check, and make docs > was not triggered: > http://code.google.com/p/lilypond/issues/detail?id=3818 > > So how to handle this? Is there something I can do at this point to get > Patchy to do its thing? Yes. Go to the issue tracker 3818, click in the box at the bottom to enter a comment, and set the label Patch-countdown to Patch-new, and save. Trevor ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: stencil.scm: add make-path-stencil function (issue 54050043)
Am 23.01.2014 23:44, schrieb Paul Morris: paulwmorris wrote On 2014/01/18 04:52:51, lemzwerg wrote: A minor thing: We use two spaces after a full stop in documentation strings. (At least it should be like that in general.) Done. https://codereview.appspot.com/54050043/ This second patch set appeared successfully on Rietveld, but it looks like the automatic test to confirm that it passes make, make check, and make docs was not triggered: http://code.google.com/p/lilypond/issues/detail?id=3818 I think this is because when I submitted the patch using git cl I made a mistake when entering my password for my google account. It seems you only get one chance to get it right. (I realize you can store it so it is used automatically, but I'd rather enter it manually for security reasons.) Yes, I ran into this too. So how to handle this? Is there something I can do at this point to get Patchy to do its thing? The changes compared to the first patch set are quite minor and harmless but I understand that the tests should still be run as part of the process. (If more changes/patches are necessary after review then this may be moot...?) IIUC you can go to the issue at code.google.com and change it from patch-review to patch-new. (hope that's correct) Urs Thanks and apologies, -Paul -- View this message in context: http://lilypond.1069038.n5.nabble.com/stencil-scm-add-make-path-stencil-function-issue-54050043-tp158152p158365.html Sent from the Dev mailing list archive at Nabble.com. ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: stencil.scm: add make-path-stencil function (issue 54050043)
paulwmorris wrote > On 2014/01/18 04:52:51, lemzwerg wrote: >> A minor thing: We use two spaces after a full stop in documentation >> strings. >> (At least it should be like that in general.) > > Done. > > https://codereview.appspot.com/54050043/ This second patch set appeared successfully on Rietveld, but it looks like the automatic test to confirm that it passes make, make check, and make docs was not triggered: http://code.google.com/p/lilypond/issues/detail?id=3818 I think this is because when I submitted the patch using git cl I made a mistake when entering my password for my google account. It seems you only get one chance to get it right. (I realize you can store it so it is used automatically, but I'd rather enter it manually for security reasons.) So how to handle this? Is there something I can do at this point to get Patchy to do its thing? The changes compared to the first patch set are quite minor and harmless but I understand that the tests should still be run as part of the process. (If more changes/patches are necessary after review then this may be moot...?) Thanks and apologies, -Paul -- View this message in context: http://lilypond.1069038.n5.nabble.com/stencil-scm-add-make-path-stencil-function-issue-54050043-tp158152p158365.html Sent from the Dev mailing list archive at Nabble.com. ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Shape of individual ties in chords
On Thu, Jan 23, 2014 at 8:01 AM, David Nalesnik wrote: > >> >>> >> There's also the attached file (which comes from >> http://www.mail-archive.com/lilypond-devel@gnu.org/msg47432/shape-tie-columns.ly) >> which will work with broken ties. >> >> > Here are some more useful values: \shapeTieColumn #'( ( () ((0 . 0.5) (0 . 0.5) (0 . 0.5) (0 . 0.5)) ) ; bottom ( () ((0 . 0) (0.33 . -0.25) (0.67 . -0.25) (1.0 . 0))) ; middle ( () ((0 . -0.5) (0 . -0.5) (0 . -0.5) (0 . -0.5)) ) ) % top ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: midi control done twice
On 22/01/14 18:16, Devon Schudy wrote:
James wrote:
is this worth an @KNOWNISSUE in the midi section?
I suppose so. "Changes to @code{midiInstrument} and other MIDI options
at the beginning of a staff sometimes appear twice in MIDI output."?
http://code.google.com/p/lilypond/issues/detail?id=3823
James
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Shape of individual ties in chords
Hi again, On Thu, Jan 23, 2014 at 8:01 AM, David Nalesnik wrote: > Hi, > > > On Wed, Jan 22, 2014 at 4:55 PM, Thomas Morley > wrote: > > >> Below some coding just to show that it can be done. >> It's a very first sketch, several issues are present (p.e. linebreak) >> Might be a starting point, though. >> >> > There's also the attached file (which comes from > http://www.mail-archive.com/lilypond-devel@gnu.org/msg47432/shape-tie-columns.ly) > which will work with broken ties. > > I should point out that in the example, the first part of the broken ties is left alone: () there is equivalent to ((0 . 0) (0 . 0) (0 . 0) (0 . 0)). --David ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Shape of individual ties in chords
Hi,
On Wed, Jan 22, 2014 at 4:55 PM, Thomas Morley wrote:
> Below some coding just to show that it can be done.
> It's a very first sketch, several issues are present (p.e. linebreak)
> Might be a starting point, though.
>
>
There's also the attached file (which comes from
http://www.mail-archive.com/lilypond-devel@gnu.org/msg47432/shape-tie-columns.ly)
which will work with broken ties.
HTH,
David
\version "2.18.0"
function for offsetting control-points of a TieColumn %
shapeTieColumn =
#(define-music-function (parser location all-offsets) (list?)
#{
\once \override TieColumn #'after-line-breaking =
#(lambda (grob)
(let ((ties (ly:grob-array->list (ly:grob-object grob 'ties
(for-each
(lambda (tie offsets-for-broken-pair)
(let* ((orig (ly:grob-original tie))
(siblings (ly:spanner-broken-into orig)))
(for-each
(lambda (piece offsets-for-piece)
(if (pair? offsets-for-piece)
(set! (ly:grob-property piece 'control-points)
(map
(lambda (x y) (coord-translate x y))
(ly:tie::calc-control-points piece)
offsets-for-piece
(if (null? siblings)
(list orig)
siblings)
offsets-for-broken-pair)))
ties all-offsets)))
#})
%% EXAMPLE %
{
1 ~
\break
q
\break
q ~
\shapeTieColumn #'(
( () ((0 . 1) (0 . 1) (0 . 1) (0 . 1)) )
( () ((0 . -0.1) (0.5 . -0.4) (1.5 . -0.4) (2 . -0.1)))
( () ((0 . -2) (0 . -1) (0 . -1) (0 . -1)) ) )
\break
q
}
\layout {
indent = 0
ragged-right = ##t
}___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
