Issue 3992: Fix dodecaphonic-no-repeat (issue 110570043 by david.nales...@gmail.com)
Reviewers: , Message: Please review. Thanks. Description: Issue 3992: Fix dodecaphonic-no-repeat Incorporate renaming of localKeySignature to localAlterations. The function dodecaphonic-no-repeat-rule now considers alterations. Improvement to code comments. Improve code formatting. Please review this at https://codereview.appspot.com/110570043/ Affected files (+17, -13 lines): M scm/music-functions.scm Index: scm/music-functions.scm diff --git a/scm/music-functions.scm b/scm/music-functions.scm index 791547706f4e8f6faf302bbd0e46a72a5dcb575b..83cee5ce995f0f131341bd1d88c3abb31821fd10 100644 --- a/scm/music-functions.scm +++ b/scm/music-functions.scm @@ -1580,7 +1580,8 @@ For convenience, returns @code{0} if entry is @code{#f}." 0)) (define-public (find-pitch-entry keysig pitch accept-global accept-local) - "Return the first entry in @var{keysig} that matches @var{pitch}. + "Return the first entry in @var{keysig} that matches @var{pitch} +by notename and octave. Alteration is not considered. @var{accept-global} states whether key signature entries should be included. @var{accept-local} states whether local accidentals should be included. If no matching entry is found, @var{#f} is returned." @@ -1620,15 +1621,19 @@ look at bar lines nor different accidentals at the same note name." note (just as in the dodecaphonic accidental style) @emph{except} if the note is immediately preceded by a note with the same pitch. This is a common accidental style in contemporary notation." - (let* ((keysig (ly:context-property context 'localKeySignature)) - (entry (find-pitch-entry keysig pitch #t #t))) + (let* ((keysig (ly:context-property context 'localAlterations)) + (entry (find-pitch-entry keysig pitch #f #t))) (if (not entry) - (cons #f #t) - (let* ((entrymp (key-entry-measure-position entry)) -(entrybn (key-entry-bar-number entry))) - (cons #f - (not - (and (equal? entrybn barnum) (equal? entrymp measurepos + (cons #f #t) + (let ((entrymp (key-entry-measure-position entry)) + (entrybn (key-entry-bar-number entry)) + (entryalt (key-entry-alteration entry)) + (alt (ly:pitch-alteration pitch))) + (cons #t + (not (and (equal? entrybn barnum) + (or (equal? measurepos entrymp) + (ly:moment- `(Staff ,(make-accidental-rule 'same-octave 0) - ,dodecaphonic-no-repeat-rule) - '() - context)) + `(Staff ,dodecaphonic-no-repeat-rule) + '() + context)) ;; Variety of the dodecaphonic style. Each note gets an accidental, ;; except notes that were already handled in the same measure. ((equal? style 'dodecaphonic-first) ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: \retrograde fails on slurs (issue 110540043 by d...@gnu.org)
Thanks. LGTM. https://codereview.appspot.com/110540043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: \retrograde fails on slurs (issue 110540043 by d...@gnu.org)
Reviewers: lemzwerg, Message: On 2014/07/13 15:27:37, lemzwerg wrote: LGTM. https://codereview.appspot.com/110540043/diff/1/scm/modal-transforms.scm File scm/modal-transforms.scm (right): https://codereview.appspot.com/110540043/diff/1/scm/modal-transforms.scm#newcode134 scm/modal-transforms.scm:134: \n(see). @code{transposer-factory} Instead of the (see)? Yeah, looks pretty nonsensical on second thought. I just wanted a different line wrap in order to keep Emacs from considering everything after (see ... as a function, but it seems uncalled for anyway. Description: \retrograde fails on slurs The section "Retrograde" in the Notation Reference is affected. This became likely exposed with issue 2240; the corresponding regtest does not cover it. The problem was existent previously for slurs and other spans inside of chords. Also contains commit: Add slur to modal-transform regtest motif Please review this at https://codereview.appspot.com/110540043/ Affected files (+7, -4 lines): M input/regression/modal-transforms.ly M scm/modal-transforms.scm Index: input/regression/modal-transforms.ly diff --git a/input/regression/modal-transforms.ly b/input/regression/modal-transforms.ly index d514a92a09bcf727e3d527143cc6e3590fa9940d..9ff66c157b4c87944671faab8dba95f1b75a9257 100644 --- a/input/regression/modal-transforms.ly +++ b/input/regression/modal-transforms.ly @@ -9,8 +9,8 @@ cOctatonicScale = { ges' aes' a' b' } motif = { - c'8. ees'16 ges'8. a'16 - b'8. aes'16 f'8. d'16 + c'8. ees'16( ges'8. a'16 + b'8.) aes'16 f'8. d'16 } \score { Index: scm/modal-transforms.scm diff --git a/scm/modal-transforms.scm b/scm/modal-transforms.scm index 3e31f660e4e7e10fdd3a6a40cf14f3dce7d0b3a8..cbd2042fa0049ebbacb8d6273ee9b14a3c9aa8e8 100644 --- a/scm/modal-transforms.scm +++ b/scm/modal-transforms.scm @@ -130,8 +130,8 @@ LilyPond scheme pitches, e.g. @code{(ly:make-pitch 0 2 0)} "Recurse through @var{music}, extracting pitches. Returns a list of pitch objects, e.g @code{'((ly:make-pitch 0 2 0) (ly:make-pitch 0 4 0) ... )} -Typically used to construct a scale for input to transposer-factory -(see). +Typically used to construct a scale for input to transposer-factory\ +\n(see). " (let ((elements (ly:music-property music 'elements)) @@ -192,12 +192,15 @@ Typically used to construct a scale for input to transposer-factory ;; inversion and retrograding. (let* ((elements (ly:music-property music 'elements)) + (arts (ly:music-property music 'articulations)) (reversed (reverse elements)) (element (ly:music-property music 'element)) (span-dir (ly:music-property music 'span-direction))) (ly:music-set-property! music 'elements reversed) +(for-each retrograde-music arts) + (if (ly:music? element) (ly:music-set-property! music 'element ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
\retrograde fails on slurs (issue 110540043 by d...@gnu.org)
LGTM. https://codereview.appspot.com/110540043/diff/1/scm/modal-transforms.scm File scm/modal-transforms.scm (right): https://codereview.appspot.com/110540043/diff/1/scm/modal-transforms.scm#newcode134 scm/modal-transforms.scm:134: \n(see). @code{transposer-factory} https://codereview.appspot.com/110540043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: LilyPond meeting 2014?
Janek Warchoł writes: > 2014-07-13 10:53 GMT+02:00 Marc Hohl : >> Am 12.07.2014 19:58, schrieb Mike Solomon: >>> I’d love to meet up but I am in gig mode as well towards the end of the >>> summer and we have a newborn in the house. >> >> >> Hey, congratulations! The nights are quiet, yes? ;-) >> All the best for all of you! > > I suppose at nights they're rehearsing the Queen of the Night coloraturas ;-) Oh, lots of time. One would already call https://www.youtube.com/watch?v=F9ijwfRTv0o> a young performer. There is also https://www.youtube.com/watch?v=sF0zePMxxys> but frankly, I cannot understand a word. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: LilyPond meeting 2014?
2014-07-13 10:53 GMT+02:00 Marc Hohl : > Am 12.07.2014 19:58, schrieb Mike Solomon: >> I’d love to meet up but I am in gig mode as well towards the end of the >> summer and we have a newborn in the house. > > > Hey, congratulations! The nights are quiet, yes? ;-) > All the best for all of you! I suppose at nights they're rehearsing the Queen of the Night coloraturas ;-) cheers, Janek ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: typo/oversight in align-interface.cc and page-layout-problem.cc (issue 115770043 by thomasmorle...@gmail.com)
LGTM. https://codereview.appspot.com/115770043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
typo/oversight in align-interface.cc and page-layout-problem.cc (issue 115770043 by thomasmorle...@gmail.com)
Reviewers: , Message: please review Description: typo/oversight in align-interface.cc and page-layout-problem.cc issue 4008 fix oversight in doc-string of align-interface.cc fix typo in comment of page-layout-problem.cc Please review this at https://codereview.appspot.com/115770043/ Affected files (+2, -2 lines): M lily/align-interface.cc M lily/page-layout-problem.cc Index: lily/align-interface.cc diff --git a/lily/align-interface.cc b/lily/align-interface.cc index f9e0e06345187c2534cc69528d130e5bd40359fb..36bfec72a4854cfe7be89f50ceae08fde4b76bdb 100644 --- a/lily/align-interface.cc +++ b/lily/align-interface.cc @@ -367,7 +367,7 @@ Align_interface::set_ordered (Grob *me) ADD_INTERFACE (Align_interface, "Order grobs from top to bottom, left to right, right to left" " or bottom to top. For vertical alignments of staves, the" - " @code{break-system-details} of the left" + " @code{line-break-system-details} of the left" " @rinternals{NonMusicalPaperColumn} may be set to tune" " vertical spacing.", Index: lily/page-layout-problem.cc diff --git a/lily/page-layout-problem.cc b/lily/page-layout-problem.cc index 52720d54490738c1579e09d218b0a6cf688f786b..3a1a84cfc5add27da5165e2f8bcffe7399040bbf 100644 --- a/lily/page-layout-problem.cc +++ b/lily/page-layout-problem.cc @@ -35,7 +35,7 @@ #include "text-interface.hh" /* - Returns the number of footntoes associated with a given line. + Returns the number of footnotes associated with a given line. */ vector ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Catalan translation priority 1 (issue 102170048)
- Original Message - From: "Francisco Vila" To: "James" Cc: "LilyPond-Devel list" ; "Translations list at lilynet" Sent: Sunday, June 08, 2014 12:53 AM Subject: Re: Catalan translation priority 1 (issue 102170048) 2014-06-08 0:14 GMT+02:00 James : On 07/06/14 19:09, walter.gar...@upf.edu wrote: I'm contributing the Catalan translation of the Documentation. I have translated (I believe) all files in Priority 1. https://codereview.appspot.com/102170048/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel I am fwding to the translation list who know how to handle this type of request (as per the contributor's guide). http://lilypond.org/doc/v2.19/Documentation/contributor-big-page#translating-the-documentation Thanks, James. Walter, I will create a new Doc language after a few checks. Will take care of this as soon as I find a time window. -- Francisco Vila. Badajoz (Spain) www.paconet.org , www.csmbadajoz.com When the documentation is compiled, we now get lots of errors about missing Catalan translations from create-weblinks-itexi.py. Would any of the translators be able to add a Catalan section to this script, and complete the translations? Thanks. -- Phil Holmes ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: LilyPond meeting 2014?
Am 12.07.2014 19:58, schrieb Mike Solomon: On Jul 12, 2014, at 3:48 PM, Marc Hohl wrote: [...] I’d love to meet up but I am in gig mode as well towards the end of the summer and we have a newborn in the house. Hey, congratulations! The nights are quiet, yes? ;-) All the best for all of you! Marc Hope you guys can work something out! I’d definitely attend as much as I could over IRC. ~Mike ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel