Re: Incipits - not alignment, but help with bug fixes

2014-08-22 Thread David Kastrup
Phil Holmes  writes:

> There are currently two problems (alignment discussion notwithstanding and 
> which I'm not ignoring, but would prefer to park temporarily) with my 
> proposed incipit code.  1) If indent is not set explicitly in the \layout 
> block, it throws an error; 2) If instrumentName is not set explicitly in 
> the score containing the incipit, no incipit is output.
>
> For 1), the optimum answer would apppear to be to check whether indent has 
> been set, and if it hasn't, set it to the value of indent-default which is 
> set in paper-defaults-init.ly as "indent-default = 15\mm".  However, 
> trying to access that variable fails: "test = \indent-default" results 
> in "error: unknown escaped string: `\indent-default'".  Does anyone know 
> why this is and whether there's an alternative way to access that variable 
> value?
>
> If it's not possible to get the value, we could set a variable to what we 
> know its value to be, and then use that.  The following code works:
>
> indent-incipit-default = 15\mm
> line-width = #(primitive-eval
>   '(or (false-if-exception (* 1.0 indent))
>   (* 1.0 indent-incipit-default)))
>
> But all those (* 1.0 variable) lines aren't pretty, but I don't know 
> better syntax.  Would appreciate help here.

Just indent and indent-incipit-default (strip the parens off) should
work actually.

> For 2), the only solution I know is that we would have to add 'Note that 
> instrumentName must be set in the music for the incipit to be produced.  
> If no instrument name is required then use \set Staff.instrumentName = 
> #""' in the documentation.  Is there a better solution?

This is so much a royal pain to get stuff passed properly.  How do we
fare when things like choir brackets get involved?  If that would result
in unacceptable output, it would be a good excuse to rework
Instrument_name_engraver or whatever else is needed on the C++ level to
get a saner hook of incipits into the code.

-- 
David Kastrup

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Get rid of lilypond-book warning for "indent=1.5cm" in essay (issue 127700043 by d...@gnu.org)

2014-08-22 Thread davide . liessi

I am pretty sure this cropped up in some bug tracker or mailing list
communication but I am quite unable to find any reference.


Reference to mailing list:
http://lists.gnu.org/archive/html/lilypond-user/2014-08/msg00168.html

https://codereview.appspot.com/127700043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Re: Get rid of lilypond-book warning for "indent=1.5cm" in essay (issue 127700043 by d...@gnu.org)

2014-08-22 Thread dak

Reviewers: lemzwerg,

Message:
On 2014/08/22 10:15:39, lemzwerg wrote:

LGTM.  This is the kind of patches that I would immediately apply to

staging,

not wasting a whole build cycle...


Well, there was a preceding mailing list communication, so it is nice to
have an issue to refer people to.  Other than that: yeah, probably
pretty uncontentious.

Description:
Get rid of lilypond-book warning for "indent=1.5cm" in essay

The reported warning is

lilypond-book: warning: deprecated ly-option used: indent=1.5cm
lilypond-book: warning: compatibility mode translation:
indent=1.50\cm

I am pretty sure this cropped up in some bug tracker or mailing list
communication but I am quite unable to find any reference.

Please review this at https://codereview.appspot.com/127700043/

Affected files (+4, -4 lines):
  M Documentation/de/essay/engraving.itely
  M Documentation/es/essay/engraving.itely
  M Documentation/essay/engraving.itely
  M Documentation/fr/essay/engraving.itely


Index: Documentation/de/essay/engraving.itely
diff --git a/Documentation/de/essay/engraving.itely  
b/Documentation/de/essay/engraving.itely
index  
fbc27ef8fe2c5f5e7c29c6118b919aafdfb11adf..cc8066e71777684631f0e24c2f04ac21f85aa05e  
100644

--- a/Documentation/de/essay/engraving.itely
+++ b/Documentation/de/essay/engraving.itely
@@ -481,7 +481,7 @@ friedlich nebeneinander auf der gleichen Seite  
erscheinen:

 @c line weights be scaled for small staves?

 @c Grieg's Violin Sonata Op. 45
-@lilypond[indent=1.5cm]
+@lilypond[indent=1.5\cm]
 global = {
   \time 6/8
   \key c \minor
Index: Documentation/es/essay/engraving.itely
diff --git a/Documentation/es/essay/engraving.itely  
b/Documentation/es/essay/engraving.itely
index  
7f78637b789147f276e917721c795583e548d44f..f3f1ca40ed568162872389f4fe5e88ad5fa8bd31  
100644

--- a/Documentation/es/essay/engraving.itely
+++ b/Documentation/es/essay/engraving.itely
@@ -491,7 +491,7 @@ used together on the same page:
 @c line weights be scaled for small staves?

 @c Grieg's Violin Sonata Op. 45
-@lilypond[indent=1.5cm]
+@lilypond[indent=1.5\cm]
 global = {
   \time 6/8
   \key c \minor
Index: Documentation/essay/engraving.itely
diff --git a/Documentation/essay/engraving.itely  
b/Documentation/essay/engraving.itely
index  
5136a331e04fc3174a33372d598dd12979c9a39b..7797a5468a21323bba277eb467a4f3ef63aca259  
100644

--- a/Documentation/essay/engraving.itely
+++ b/Documentation/essay/engraving.itely
@@ -451,7 +451,7 @@ This also allows staves of different sizes to coexist  
peacefully when

 used together on the same page:

 @c Grieg's Violin Sonata Op. 45
-@lilypond[indent=1.5cm]
+@lilypond[indent=1.5\cm]
 global = {
   \time 6/8
   \key c \minor
Index: Documentation/fr/essay/engraving.itely
diff --git a/Documentation/fr/essay/engraving.itely  
b/Documentation/fr/essay/engraving.itely
index  
430e225240599b380e5690e69f1b87a7ea317618..1f41b047b037ece18664dc72de2735ab33429457  
100644

--- a/Documentation/fr/essay/engraving.itely
+++ b/Documentation/fr/essay/engraving.itely
@@ -486,7 +486,7 @@ Ceci permet par ailleurs de faire coexister  
harmonieusement

 plusieurs portées de taille différente sur une même page :

 @c Grieg's Violin Sonata Op. 45
-@lilypond[indent=1.5cm]
+@lilypond[indent=1.5\cm]
 global = {
   \time 6/8
   \key c \minor


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Get rid of lilypond-book warning for "indent=1.5cm" in essay (issue 127700043 by d...@gnu.org)

2014-08-22 Thread lemzwerg

LGTM.  This is the kind of patches that I would immediately apply to
staging, not wasting a whole build cycle...


https://codereview.appspot.com/127700043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel


Incipits - not alignment, but help with bug fixes

2014-08-22 Thread Phil Holmes
There are currently two problems (alignment discussion notwithstanding and 
which I'm not ignoring, but would prefer to park temporarily) with my 
proposed incipit code.  1) If indent is not set explicitly in the \layout 
block, it throws an error; 2) If instrumentName is not set explicitly in 
the score containing the incipit, no incipit is output.

For 1), the optimum answer would apppear to be to check whether indent has 
been set, and if it hasn't, set it to the value of indent-default which is 
set in paper-defaults-init.ly as "indent-default = 15\mm".  However, 
trying to access that variable fails: "test = \indent-default" results 
in "error: unknown escaped string: `\indent-default'".  Does anyone know 
why this is and whether there's an alternative way to access that variable 
value?

If it's not possible to get the value, we could set a variable to what we 
know its value to be, and then use that.  The following code works:

indent-incipit-default = 15\mm
line-width = #(primitive-eval
  '(or (false-if-exception (* 1.0 indent))
  (* 1.0 indent-incipit-default)))

But all those (* 1.0 variable) lines aren't pretty, but I don't know 
better syntax.  Would appreciate help here.

For 2), the only solution I know is that we would have to add 'Note that 
instrumentName must be set in the music for the incipit to be produced.  
If no instrument name is required then use \set Staff.instrumentName = 
#""' in the documentation.  Is there a better solution?


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel