Issue 4186: Remove the single-C time signature style (issue 186630043 by nine.fierce.ball...@gmail.com)
Reviewers: ,
Description:
Issue 4186: Remove the single-C time signature style
Remove the single-C time signature style that was added in commit
40b0982cb4f00317c3d50c7f1d4e26fde912f3cd to address Issue 3286.
The later commit 145389636e81237d560aba4d04abcb89fa60cd9c allows
the user to define new time signature styles, which is a more
flexible solution.
Please review this at https://codereview.appspot.com/186630043/
Affected files (+0, -29 lines):
D input/regression/time-signature-single-c.ly
M scm/time-signature-settings.scm
Index: input/regression/time-signature-single-c.ly
diff --git a/input/regression/time-signature-single-c.ly
b/input/regression/time-signature-single-c.ly
deleted file mode 100644
index
5e115e4070e6f2e11dece52717e6c1b9ca4c4867..
--- a/input/regression/time-signature-single-c.ly
+++ /dev/null
@@ -1,20 +0,0 @@
-\version 2.19.16
-
-\header {
- texidoc = The single-C time signature style prints a C for any time
signature with 4 in the numerator and prints a cut-C for any time signature
with 2 in the numerator.
-}
-
-\layout { indent = 0 }
-
-\new Staff {
- \relative f' {
-\override Staff.TimeSignature.style = #'single-C
-\time 1/2 f2^1/2
-\time 2/2 f2^2/2 f
-\time 2/1 f1^2/1 f
-\time 3/4 f4^3/4 f f
-\time 4/4 f4^4/4 f f f
-\time 4/2 f2^4/2 f f f
-\time 4/1 f1^4/1 f f f
- }
-}
Index: scm/time-signature-settings.scm
diff --git a/scm/time-signature-settings.scm
b/scm/time-signature-settings.scm
index
bee620eb9fc7e1fe20adbf0a5e948d5bdc5aeb6a..f55c76c0b687e2d28c742c77508278b16d5253d0
100644
--- a/scm/time-signature-settings.scm
+++ b/scm/time-signature-settings.scm
@@ -394,15 +394,6 @@ a fresh copy of the list-head is made.
(add-simple-time-signature-style 'C make-c-time-signature-markup)
(add-simple-time-signature-style 'default make-c-time-signature-markup)
-(define-public (make-single-c-time-signature-markup fraction)
- Make markup for the `single-C' time signature style.
- (let ((n (car fraction)))
-(if (or (= n 2) (= n 4)) ; numerator only
-(make-glyph-time-signature-markup 'C (cons n n))
-(make-compound-meter-markup n
-
-(add-simple-time-signature-style 'single-C
make-single-c-time-signature-markup)
-
;;;
;;; Measure length calculation of (possibly complex) compound time
signatures
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Issue 4212: fix out-of-bounds index in division_maior() (issue 189420043 by nine.fierce.ball...@gmail.com)
On 2015/01/01 23:08:56, Dan Eble wrote: On 2015/01/01 22:57:31, benko.pal wrote: https://codereview.appspot.com/189420043/diff/1/lily/breathing-sign.cc File lily/breathing-sign.cc (right): https://codereview.appspot.com/189420043/diff/1/lily/breathing-sign.cc#newcode122 lily/breathing-sign.cc:122: if (ydim[DOWN] val line_pos.begin () it - 1) I'd rather write line_pos.begin () + 1 it but good catch anyway, thanks! I also find the whole surrounding code difficult to read, but I don't want to spend any more time on this than I have to. Thanks for the feedback. your code is fine, I withdraw my suggestion (I should never hurry a review). thanks again! https://codereview.appspot.com/189420043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Issue 4212: fix out-of-bounds index in division_maior() (issue 189420043 by nine.fierce.ball...@gmail.com)
Reviewers: , Description: Issue 4212: fix out-of-bounds index in division_maior() Please review this at https://codereview.appspot.com/189420043/ Affected files (+1, -1 lines): M lily/breathing-sign.cc Index: lily/breathing-sign.cc diff --git a/lily/breathing-sign.cc b/lily/breathing-sign.cc index 2cbe20e303d9318bfc3eaeb103f0ae946e731b11..6ec306dde461fbc8a70878d86f178700284e1eaa 100644 --- a/lily/breathing-sign.cc +++ b/lily/breathing-sign.cc @@ -119,7 +119,7 @@ Breathing_sign::divisio_maior (SCM smob) ydim[DOWN]); assert (line_pos.begin () it); double val = (it[-1] + it[0]) / 2; - if (ydim[DOWN] val line_pos.begin () it + 1) + if (ydim[DOWN] val line_pos.begin () it - 1) val = (it[-2] + it[-1]) / 2; ydim.add_point (val); ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Issue 4212: fix out-of-bounds index in division_maior() (issue 189420043 by nine.fierce.ball...@gmail.com)
On 2015/01/01 22:57:31, benko.pal wrote: https://codereview.appspot.com/189420043/diff/1/lily/breathing-sign.cc File lily/breathing-sign.cc (right): https://codereview.appspot.com/189420043/diff/1/lily/breathing-sign.cc#newcode122 lily/breathing-sign.cc:122: if (ydim[DOWN] val line_pos.begin () it - 1) I'd rather write line_pos.begin () + 1 it but good catch anyway, thanks! I also find the whole surrounding code difficult to read, but I don't want to spend any more time on this than I have to. Thanks for the feedback. https://codereview.appspot.com/189420043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Doc; CG - add more specific note for Guile (issue 193870043 by pkx1...@gmail.com)
https://codereview.appspot.com/193870043/diff/1/Documentation/included/compile.itexi File Documentation/included/compile.itexi (right): https://codereview.appspot.com/193870043/diff/1/Documentation/included/compile.itexi#newcode78 Documentation/included/compile.itexi:78: (1.8.8 - version 2.x is not currently supported) I think we're currently shipping Guile 1.8.7. Has Lily been tested with 1.8.8? Just a query. Trevor https://codereview.appspot.com/193870043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Issue 4212: fix out-of-bounds index in division_maior() (issue 189420043 by nine.fierce.ball...@gmail.com)
https://codereview.appspot.com/189420043/diff/1/lily/breathing-sign.cc File lily/breathing-sign.cc (right): https://codereview.appspot.com/189420043/diff/1/lily/breathing-sign.cc#newcode122 lily/breathing-sign.cc:122: if (ydim[DOWN] val line_pos.begin () it - 1) I'd rather write line_pos.begin () + 1 it but good catch anyway, thanks! https://codereview.appspot.com/189420043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Ready lilypond-mode for packaging for emacs 24 package system, such that lilypond-mode will work wi… (issue 191260043 by pe...@thoughtspot.net)
Just for the record this is logged as https://code.google.com/p/lilypond/issues/detail?id=4230 James https://codereview.appspot.com/191260043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Doc; CG - add more specific note for Guile (issue 193870043 by pkx1...@gmail.com)
Reviewers: Trevor Daniels,
Message:
On 2015/01/02 00:09:19, Trevor Daniels wrote:
https://codereview.appspot.com/193870043/diff/1/Documentation/included/compile.itexi
File Documentation/included/compile.itexi (right):
https://codereview.appspot.com/193870043/diff/1/Documentation/included/compile.itexi#newcode78
Documentation/included/compile.itexi:78: (1.8.8 - version 2.x is not
currently
supported)
I think we're currently shipping Guile 1.8.7. Has Lily been tested
with 1.8.8?
Just a query.
Trevor
Oh, I just did
guile --version on my own System to see what it was I had installed and
it came up with 1.8.8.
(also guile-1.8 --version returns the same thing)
I *assume* therefore that when I build LP from master and run it it is
using 1.8.8 I do not have an pre-installed Linux or Windows system to
test this.
James
Description:
Doc; CG - add more specific note for Guile
Issue 4228
Updated version of Guile to the latest 1.8.x currently
working with LilyPond and added that version 2.x is
not (currently) supported.
Please review this at https://codereview.appspot.com/193870043/
Affected files (+1, -1 lines):
M Documentation/included/compile.itexi
Index: Documentation/included/compile.itexi
diff --git a/Documentation/included/compile.itexi
b/Documentation/included/compile.itexi
index
cc2894019faf699194c5499614f71d772a22fb6b..31e68c46a110350123e8c004d142806ab4ef28d2
100644
--- a/Documentation/included/compile.itexi
+++ b/Documentation/included/compile.itexi
@@ -75,7 +75,7 @@ installed by default)
newer)
@item @uref{http://www.gnu.org/software/guile/guile.html, Guile}
-(1.8.2 or newer)
+(1.8.8 - version 2.x is not currently supported)
@item @uref{http://www.pango.org/, Pango} (1.12 or newer)
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCHES: Countdown for January 4th. 2014
Hello, Here is the current patch countdown list. The next countdown will be on January 4th. You can always view the most current countdown list here: http://code.google.com/p/lilypond/issues/list?q=Patch%3Apush%2Ccountdown%2Creview%2Cnew%2Cwaitingcolspec=Patch%20Owner%20ID%20Summarysort=patch PUSH: Keith OHara: danger of a runaway loop http://code.google.com/p/lilypond/issues/detail?id=4229 COUNTDOWN: David Kastrup: Patch: lilypond-what-beat.el: make No | before point a message rather than an error http://code.google.com/p/lilypond/issues/detail?id=4237 David Kastrup: Patch: lilypond-what-beat.el: heed stand-alone durations in music lengths http://code.google.com/p/lilypond/issues/detail?id=4234 Dan Eble: Patch: Improve partcombine multi-measure rest handling. http://code.google.com/p/lilypond/issues/detail?id=4233 David Kastrup: Patch: lilypond-what-beat.el: Allow \tuplet to work like \times http://code.google.com/p/lilypond/issues/detail?id=4232 Keith OHara: inefficient code in auto-beaming http://code.google.com/p/lilypond/issues/detail?id=4231 Keith OHara: trying to freeze in time from unusual time signatures http://code.google.com/p/lilypond/issues/detail?id=4180 REVIEW: James Lowe: Doc: Contributor Guide - be more explicit for Guile Version 1.8.2 http://code.google.com/p/lilypond/issues/detail?id=4228 Dan Eble: Breathing_sign: possible use of uninitialized data http://code.google.com/p/lilypond/issues/detail?id=4212 Dan Eble: Remove single-C time signature style http://code.google.com/p/lilypond/issues/detail?id=4186 WAITING: Urs Liska: Patch: Add original-breaks.ly commands http://code.google.com/p/lilypond/issues/detail?id=4155 Urs Liska: Patch: Issue 3916: Add \alternatingTimeSignatures http://code.google.com/p/lilypond/issues/detail?id=3918 Mike Solomon: Patch: Prevents vertical axis groups with empty skylines http://code.google.com/p/lilypond/issues/detail?id=3156 Mike Solomon: Patch: Removes the translate_axis call from axis-group-interface outside-staff positioning. http://code.google.com/p/lilypond/issues/detail?id=3134 David Kastrup: Patch: Implement music functions in Scheme rather than C++ http://code.google.com/p/lilypond/issues/detail?id=2716 Thank you, Happy new Year! James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
