Re: Allow independent adjustment of minimum length for spanner siblings (issue 201140043 by david.nales...@gmail.com)
https://codereview.appspot.com/201140043/diff/20001/lily/spanner.cc File lily/spanner.cc (right): https://codereview.appspot.com/201140043/diff/20001/lily/spanner.cc#newcode404 lily/spanner.cc:404: Rod r; Perhaps we should call this rod something else to underscore that it's not the same rod as the one declared above. Sure, it's fine because the last r was declared in a nested scope and 'r' is for rod!, but this is unnecessarily confusing (even after moving the declaration from where it was originally, which was really obscure). https://codereview.appspot.com/201140043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Allow independent adjustment of minimum length for spanner siblings (issue 201140043 by david.nales...@gmail.com)
https://codereview.appspot.com/201140043/diff/1/input/regression/minimum-length-after-break.ly File input/regression/minimum-length-after-break.ly (right): https://codereview.appspot.com/201140043/diff/1/input/regression/minimum-length-after-break.ly#newcode15 input/regression/minimum-length-after-break.ly:15: \override Tie.minimum-length-after-break = 20 On 2015/02/05 23:34:22, thomasmorley651 wrote: On 2015/02/05 22:51:06, david.nalesnik wrote: On 2015/02/05 22:31:33, thomasmorley651 wrote: I'd use \once \override ... Though, that's only me I'm happy to change that. Would you use \once with the other overrides in the file? I'd always use \once. But again, it's only me, what do others think? I went ahead and changed to \once. The object being overridden changes, and the Scheme music representation isn't any shorter, but \once might prevent problems should the test be extended. (Done.) https://codereview.appspot.com/201140043/diff/1/input/regression/minimum-length-after-break.ly#newcode16 input/regression/minimum-length-after-break.ly:16: a1~ On 2015/02/05 23:34:22, thomasmorley651 wrote: On 2015/02/05 22:51:06, david.nalesnik wrote: On 2015/02/05 22:31:34, thomasmorley651 wrote: I assume it works for chords as well. I'd add at least one example with chords and Tie or Glissando Instead of the one regtest, I could have two. The first would show a tied chord, and I would show how you can use 'minimum-length and 'minimum-length-after-break in various combinations. The second would be this regtest, and I could take out the tie example so there's no overlap with the other test. What do you think? I can't see an advantage in having two regtests. I'd prefer to extend this one. After discovering an issue (corrected in patch set #2), I'm leaning towards a regtest specifically aimed at showing how minimum-distance and minimum-distance-after-break relate. They ought to produce the same results in the spanner piece after the break. The C++ code uses these values in a way that is not easy to understand, and I think there should be a check for future changes to the springs-and-rods callback. https://codereview.appspot.com/201140043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Allow independent adjustment of minimum length for spanner siblings (issue 201140043 by david.nales...@gmail.com)
https://codereview.appspot.com/201140043/diff/20001/lily/spanner.cc File lily/spanner.cc (right): https://codereview.appspot.com/201140043/diff/20001/lily/spanner.cc#newcode394 lily/spanner.cc:394: /* Minor nit: Please use spaces, not tabs. https://codereview.appspot.com/201140043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Allow independent adjustment of minimum length for spanner siblings (issue 201140043 by david.nales...@gmail.com)
LGTM. https://codereview.appspot.com/201140043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: lilypond 2.19.15 compilation problem
when i try make doc i have :
https://pastebin.franceserv.fr/737
and
*** Can't find macros.itexi, skipping (l. 20)
Max error number exceeded
Documentation/topdocs/INSTALL.texilog.log (END)
Le Wed, 4 Feb 2015 13:41:31 +0100,
major_ghz major_...@electronique-libre.org a écrit :
$ ./configure
checking build system type... i686-pc-linux-gnu
checking host system type... i686-pc-linux-gnu
checking Package... LILYPOND
checking builddir... /home//Téléchargements/lilypond-2.19.15
checking for stepmake... ./stepmake (${datarootdir}/stepmake not
found) checking for gmake... no
make[2]: Entering directory
'/home//Téléchargements/lilypond-2.19.15/Documentation/topdocs'
/home//Téléchargements/lilypond-2.19.15/scripts/build/out/run-and-check
LANG= makeinfo --enable-encoding --error-limit=0 -I ./out
-I /home//Téléchargements/lilypond-2.19.15/Documentation -I.
-I./out --no-split --no-headers --output out/INSTALL.txt
out/INSTALL.texi INSTALL.makeinfotxt.log
Please check the logfile INSTALL.makeinfotxt.log for errors
/home//Téléchargements/lilypond-2.19.15/stepmake/stepmake/texinfo-rules.make:77:
recipe for target 'out/INSTALL.txt' failed make[2]: ***
[out/INSTALL.txt] Error 1 make[2]: Leaving directory
'/home//Téléchargements/lilypond-2.19.15/Documentation/topdocs'
/home//Téléchargements/lilypond-2.19.15/stepmake/stepmake/generic-targets.make:6:
recipe for target 'all' failed make[1]: *** [all] Error 2
make[1]: Leaving directory
'/home//Téléchargements/lilypond-2.19.15/Documentation'
/home//Téléchargements/lilypond-2.19.15/stepmake/stepmake/generic-targets.make:6:
recipe for target 'all' failed make: *** [all] Error 2
i have no idear what can i do...
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
