NR 3.3.2: nitpicks in lily example (issue 284060044 by simon.albre...@mail.de)

[simon . albrecht]

Reviewers: ,

Message:
Sorry, I made a mess and had to create a new Rietveld issue. I’m not
quite familiar with the process yet…

Well, this is to Harm’s comments.
I wasn’t quite sure about indenting arguments to \partcombine, but I
prefer having all in one line anyway.

Description:
NR 3.3.2: nitpicks in lily example

add a missing space
better code formatting with \partcombine
remove printPartCombineTexts setting

Please review this at https://codereview.appspot.com/284060044/

Affected files (+3, -9 lines):
  M Documentation/notation/input.itely


Index: Documentation/notation/input.itely
diff --git a/Documentation/notation/input.itely  
b/Documentation/notation/input.itely
index  
768fab6841c563696285c4d17854804bd2af49e6..ccfad7c9a70c32b5a69914df692a02e27cb72f0f  
100644

--- a/Documentation/notation/input.itely
+++ b/Documentation/notation/input.itely
@@ -2126,7 +2126,7 @@ sopranoMusic = \relative { a'4 b c b8( a) }
 altoMusic = \relative { e'4 e e f }
 tenorMusic = \relative { c'4 b e d8( c) }
 bassMusic = \relative { a4 gis a d, }
-allLyrics = \lyricmode {King of glo -- ry }
+allLyrics = \lyricmode { King of glo -- ry }
 <<
   \new Staff = "Soprano" \sopranoMusic
   \new Lyrics \allLyrics
@@ -2144,17 +2144,11 @@ allLyrics = \lyricmode {King of glo -- ry }
   \new Lyrics \allLyrics
   \new PianoStaff <<
 \new Staff = "RH" {
-  \set Staff.printPartCombineTexts = ##f
-  \partcombine
-  \sopranoMusic
-  \altoMusic
+  \partcombine \sopranoMusic \altoMusic
 }
 \new Staff = "LH" {
-  \set Staff.printPartCombineTexts = ##f
   \clef "bass"
-  \partcombine
-  \tenorMusic
-  \bassMusic
+  \partcombine \tenorMusic \bassMusic
 }
   >>
 >>


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

4717: Replace incorrect naming rule in LM (issue 284070043 by simon.albre...@mail.de)

[simon . albrecht]

Reviewers: ,

Message:
I promise to learn how to use git cl  correctly :-/
For now, it’s no real problem that it’s an entirely new Rietveld issue,
since I didn’t retain anything from the first approach.

Upon your comments, I replaced the former incorrect wording by a
statement merely expressing a _convention_ of using only alphabetic
characters.  A thorough explanation for the naming rules/conventions in
the NR needs to be done, but that seems to be a major task; I couldn’t
quite find an appropriate place.  IMO it /might/ make sense to make an
entire new chapter about such syntax requirements, either between 3.3
and 3.4 or at 3.3.4.

Description:
4717: Replace incorrect naming rule in LM

This replaces the incorrect rule about naming variables with a
simple reference to the 'alphabetic-only' _convention_.
A thorough explanation in the NR remains to be done.

Please review this at https://codereview.appspot.com/284070043/

Affected files (+1, -2 lines):
  M Documentation/learning/common-notation.itely


Index: Documentation/learning/common-notation.itely
diff --git a/Documentation/learning/common-notation.itely  
b/Documentation/learning/common-notation.itely
index  
9ce651fc02c13e40cff9363c6f5ab49317c934d8..1f68b2b5c7a11db6d3d7d44fda360b4eb21f5e13  
100644

--- a/Documentation/learning/common-notation.itely
+++ b/Documentation/learning/common-notation.itely
@@ -1340,8 +1340,7 @@ cello = \new Staff {
 @end lilypond

 @noindent
-The name of a variable must have alphabetic characters only, no
-numbers, underscores, or dashes.
+By convention, variable names consist of alphabetic characters only.

 Variables must be defined @emph{before} the main music
 expression, but may be used as many times as required anywhere after


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

stencil.scm: make args optional in stencil-whiteout (issue 284980043 by paulwmor...@gmail.com)

[paulwmorris]

Reviewers: ,

Message:
Please review, thanks.
-Paul

Description:
stencil.scm: make args optional in stencil-whiteout

Please review this at https://codereview.appspot.com/284980043/

Affected files (+2, -1 lines):
  M scm/stencil.scm


Index: scm/stencil.scm
diff --git a/scm/stencil.scm b/scm/stencil.scm
index  
bec03016505e4cc5317061f08d2b80f5e416e53f..950d99f9cb8e2b1e61baf87638e81b558105766a  
100644

--- a/scm/stencil.scm
+++ b/scm/stencil.scm
@@ -801,7 +801,8 @@ the white outline extends past the extents of stencil  
@var{stil}."

 (stencil-with-color (ly:round-filled-box x-ext y-ext blot) color)
 stil)))

-(define-public (stencil-whiteout stil style thickness line-thickness)
+(define*-public (stencil-whiteout stil #:optional (style 'box)
+ (thickness '()) (line-thickness 0.1))
   "@var{style} is a symbol that determines the shape of the white
 background.  @var{thickness} is how far, as a multiple of
 @var{line-thickness}, the white background extends past the extents



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

NR 3.3.2: nitpicks in lily example (issue 284060043 by simon.albre...@mail.de)

[simon . albrecht]

Reviewers: ,

Message:
Please review.

Description:
NR 3.3.2: nitpicks in lily example

add a missing space
and use a layout block instead of duplicating code

Please review this at https://codereview.appspot.com/284060043/

Affected files (+7, -3 lines):
  M Documentation/notation/input.itely


Index: Documentation/notation/input.itely
diff --git a/Documentation/notation/input.itely  
b/Documentation/notation/input.itely
index  
768fab6841c563696285c4d17854804bd2af49e6..62e13f0592a68586916978b3ae24894ab60e1240  
100644

--- a/Documentation/notation/input.itely
+++ b/Documentation/notation/input.itely
@@ -2126,7 +2126,7 @@ sopranoMusic = \relative { a'4 b c b8( a) }
 altoMusic = \relative { e'4 e e f }
 tenorMusic = \relative { c'4 b e d8( c) }
 bassMusic = \relative { a4 gis a d, }
-allLyrics = \lyricmode {King of glo -- ry }
+allLyrics = \lyricmode { King of glo -- ry }
 <<
   \new Staff = "Soprano" \sopranoMusic
   \new Lyrics \allLyrics
@@ -2144,19 +2144,23 @@ allLyrics = \lyricmode {King of glo -- ry }
   \new Lyrics \allLyrics
   \new PianoStaff <<
 \new Staff = "RH" {
-  \set Staff.printPartCombineTexts = ##f
   \partcombine
   \sopranoMusic
   \altoMusic
 }
 \new Staff = "LH" {
-  \set Staff.printPartCombineTexts = ##f
   \clef "bass"
   \partcombine
   \tenorMusic
   \bassMusic
 }
   >>
+  \layout {
+\context {
+  \Staff
+  printPartCombineTexts = ##f
+}
+  }
 >>
 @end lilypond




___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: LM 2.4.1: More accurate description of variable naming rules (issue 280560043 by simon.albre...@mail.de)

[Simon Albrecht]

On 29.12.2015 23:01, pkx1...@gmail.com wrote:


https://codereview.appspot.com/280560043/diff/20001/Documentation/learning/common-notation.itely 


File Documentation/learning/common-notation.itely (right):

https://codereview.appspot.com/280560043/diff/20001/Documentation/learning/common-notation.itely#newcode1347 


Documentation/learning/common-notation.itely:1347:
I'd probably concur with this for the Learning Manual.

Just keep it simple, then use an @ref to the Notation and explain it
more detail there.


Thanks for your opinions. I’ve made a new attempt now; unfortunately, 
after some juggling around with git operations I can’t reliably handle 
yet I had to open a new issue for review: 
. I’m closing this one.


Best, Simon

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: stencil.scm: make args optional in stencil-whiteout (issue 284980043 by paulwmor...@gmail.com)

[paulwmorris]

Addressing Harm's suggestions in patch set 2.


https://codereview.appspot.com/284980043/diff/1/scm/stencil.scm
File scm/stencil.scm (right):

https://codereview.appspot.com/284980043/diff/1/scm/stencil.scm#newcode804
scm/stencil.scm:804: (define*-public (stencil-whiteout stil #:optional
(style 'box)
On 2016/01/03 23:14:22, thomasmorley651 wrote:

I like it optional.
But why do you give default-values for style and thickness? If you'd

do:

  #:optional style thickness (line-thickness 0.1)
then style and thickness default to #f, would be sufficient.


Good point!  I'll make that change.


Though the doc-string needs to be changed then, maybe something at the

lines of:

[...]


Please check spelling, grammar and wording, though. I'm not a native

speaker

Will do, and thanks for the text suggestions.  See how you like the
version in patch set 2.

https://codereview.appspot.com/284980043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: lilypond version manager

[Ricardo Wurmus]

Philip Olson  writes:

> I just finished a beta version of my lilypond version manager "lilyvm" found 
> on 
> github
>
> https://github.com/olsonpm/lilyvm
>
> I'm emailing because I would like to know whether it's a tool that would help 
> anyone besides myself, and if so, what kind of OS's are most widely used from 
> people using lilypond's CLI.  Lilyvm is currently restricted to linux on x86 
> and amd64 processors - which is why I ask.  The work involved in adding 
> support 
> for more kernels and processors is mostly testing.  The entire program is 
> written in POSIX sh so portability is built in.

I’d like to add that GNU Guix has a package for Lilypond.  Guix supports
installing multiple versions of any package into different profiles, so
I can have the stable version of Lilylpond installed at
~/.lily-stable/bin and the development version at ~/.lily-dev/bin,
provided I have package expressions for both versions.

Currently, Guix contains a package expression for 2.19.33 (that’s the
one I’m using).  It is almost trivial to create package variants with
Guix by inheriting from existing packages:

  (define my-lilypond
(package (inherit lilypond)
  (version "2.18.whatever")
  (source (origin
  (method url-fetch)
  (uri (string-append
"http://download.linuxaudio.org/lilypond/sources/v;
(version-major+minor version) "/"
"lilypond-" version ".tar.gz"))
  (sha256
   (base32
"0s4vbbfy4xwq4da4kmlnndalmcyx2jaz7y8praah2146qbnr90xh"))

This also only works on GNU systems, and currently the build fails for
mips64el and armhf (though it seems that the reason is a mere timeout in
building documentation, which could be due to the slow build slaves for
these architectures), so like Lilyvm this method is limited to x86 and
i686 for the moment.

~~ Ricardo


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

lilypond version manager

[Philip Olson]

I just finished a beta version of my lilypond version manager "lilyvm" found on 
github

https://github.com/olsonpm/lilyvm

I'm emailing because I would like to know whether it's a tool that would help 
anyone besides myself, and if so, what kind of OS's are most widely used from 
people using lilypond's CLI.  Lilyvm is currently restricted to linux on x86 
and amd64 processors - which is why I ask.  The work involved in adding support 
for more kernels and processors is mostly testing.  The entire program is 
written in POSIX sh so portability is built in.

I am not composing nor creating sheet music personally, but I recently decided 
to improve lilybin as a side-project of mine.  Its lack of version support 
seemed inhibiting.

Phil


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: [testlilyissues:issues] #4668 README: replace lilypond-cvs list info with lilypond-auto

[David Kastrup]

"Simon Albrecht"  writes:

> - **status**: Fixed --> Verified
> - **assigned_to**: David Kastrup -->  nobody 

We don't remove the owner when verifying.  That would make it impossible
to figure out from the tracker (at least without digging through the
issues individually0 who fixed what or at least was responsible for
fixing it.

I think it's fair to credit people for the work they have done.

-- 
David Kastrup

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

PATCHES: Countdown for January 6th

[James Lowe]

Hello,

Here is the current patch countdown list. The next countdown will be on
January 6th.

A quick synopsis of all patches currently in the review process can be
found here:

http://philholmes.net/lilypond/allura/

__


Push:


4716 Improve note-by-number to deal better with flag-styles - Thomas Morley
https://sourceforge.net/p/testlilyissues/issues/4716
http://codereview.appspot.com/28443


4715 Update texinfo.tex from upstream - David Kastrup
https://sourceforge.net/p/testlilyissues/issues/4715
http://codereview.appspot.com/279580043


4714 Web: fix dead links and redirects on Productions page - Greg Swinford
https://sourceforge.net/p/testlilyissues/issues/4714
http://codereview.appspot.com/283990043


4713 texi2html generated Japanese html navigation bars are broken -
Masamichi Hosada
https://sourceforge.net/p/testlilyissues/issues/4713
http://codereview.appspot.com/281970043


4703 Patch: Store accidental styles in an alist - Simon Albrecht
https://sourceforge.net/p/testlilyissues/issues/4703
http://codereview.appspot.com/280510043


Countdown:


4719 Document all outside-staff-priority values; neaten table - Phil Holmes
https://sourceforge.net/p/testlilyissues/issues/4719
http://codereview.appspot.com/280580043


Review: No patches in Review at this time.


New: No New Patches at this time.


Waiting:


4600 Let notes/rests suppress multi-measure rest grobs - Dan Eble
https://sourceforge.net/p/testlilyissues/issues/4600
http://codereview.appspot.com/265160043


2643 Attach lilypond source in pdf
https://sourceforge.net/p/testlilyissues/issues/2643
http://codereview.appspot.com/225040043
__


James

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

New Dutch PO file for 'lilypond' (version 2.19.26)

[Translation Project Robot]

Hello, gentle maintainer.

This is a message from the Translation Project robot.

A revised PO file for textual domain 'lilypond' has been submitted
by the Dutch team of translators.  The file is available at:

http://translationproject.org/latest/lilypond/nl.po

(We can arrange things so that in the future such files are automatically
e-mailed to you when they arrive.  Ask at the address below if you want this.)

All other PO files for your package are available in:

http://translationproject.org/latest/lilypond/

Please consider including all of these in your next release, whether
official or a pretest.

Whenever you have a new distribution with a new version number ready,
containing a newer POT file, please send the URL of that distribution
tarball to the address below.  The tarball may be just a pretest or a
snapshot, it does not even have to compile.  It is just used by the
translators when they need some extra translation context.

The following HTML page has been updated:

http://translationproject.org/domain/lilypond.html

If any question arises, please contact the translation coordinator.

Thank you for all your work,

The Translation Project robot, in the
name of your translation coordinator.



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

New Japanese PO file for 'lilypond' (version 2.19.26)

[Translation Project Robot]

Hello, gentle maintainer.

This is a message from the Translation Project robot.

A revised PO file for textual domain 'lilypond' has been submitted
by the Japanese team of translators.  The file is available at:

http://translationproject.org/latest/lilypond/ja.po

(We can arrange things so that in the future such files are automatically
e-mailed to you when they arrive.  Ask at the address below if you want this.)

All other PO files for your package are available in:

http://translationproject.org/latest/lilypond/

Please consider including all of these in your next release, whether
official or a pretest.

Whenever you have a new distribution with a new version number ready,
containing a newer POT file, please send the URL of that distribution
tarball to the address below.  The tarball may be just a pretest or a
snapshot, it does not even have to compile.  It is just used by the
translators when they need some extra translation context.

The following HTML page has been updated:

http://translationproject.org/domain/lilypond.html

If any question arises, please contact the translation coordinator.

Thank you for all your work,

The Translation Project robot, in the
name of your translation coordinator.



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel