Re: Lilypond issue tracker account request

2016-03-22 Thread Trevor Daniels 

Karl O. Pinc wrote Tuesday, March 22, 2016 2:32 PM

> On Tue, 22 Mar 2016 12:14:37 -
>
> "Trevor Daniels"  wrote:
> 
>> Karl O. Pinc wrote Tuesday, March 22, 2016 3:47 AM
> 
>> > I'd like an account in the lilypond issue tracker.  
>> 
>> Happy to add you to the Issue Tracker as a Member.
>> That allows you to comment on Issues without moderation.
>> That's the way to start.
>> 
>> You'll need to post or send me your SourceForge Username
>> so I can set that up.
> 
> I am "kpinc" at sourceforge.

Thanks.  You're added to the Issue Tracker as a Member.
That means you can freely comment on Issues.

https://sourceforge.net/p/testlilyissues/issues/

Trevor
 
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Lilypond issue tracker account request

2016-03-22 Thread Urs Liska 


Am 22.03.2016 um 15:32 schrieb Karl O. Pinc:
>>> I'm thinking about someday contributing to lilypond
>> Great!  The first step is to post specific issues that
>> you have identified to the bug list:
>> http://lists.gnu.org/archive/html/bug-lilypond/
>> for discussion and to have an Issue created.
> Ok.  Thanks.
>
> I take it that this is not required for a doc patch?
> I'm thinking I'll send in something simple like that (through
> the development pipeline) to get started.

It seems there's a little bit of confusion over what you intend to do
actually. I understand you are not interested in only reporting bugs but
in providing patches, but mainly (only) to the documentation.

If you want to prepare a patch it is not required to create an issue
*before*, but during the process you'll implicitly create one. But
depending on what you intend to do it may be very useful to discuss your
idea on the bug-lilypond or rather the lilypond-devel mailing list,
otherwise you may risk that your patch is not welcomed as nicely as you
thought.

OTOH, if you think there's something wrong that should be reported it's
perfectly possible to create an issue without actually working on it
(well, that's true for the vast majority of open issues). However, even
when you have got your account you shouldn't simply create an issue on
your own but rather report it on the bug-lilypond list to have someone
from the bug squad create the tracker item. The main reason for this is
to have at least two pairs of eyes look over it before the tracker item
is created. Pretty often it turns out that it is *not* a bug or (more
often) an already registered one.

>> The first few patches are usually sheparded through the
>> system by one of the Devs before you are elevated to
>> Developer status.
> I am at present way too ignorant of music to be comfortable
> with Developer status.

Well, in this context "Developer" means anyone with push access to the
repository, which includes people who are only touching the docs as
well. For now you would be able to upload a patch for review, and when
the patch has reached "Push" status you'd have to ask for someone to
push it on your behalf. At some point, when the devs and you have the
impression that the collaboration will become more continuous (or if
they simply are tired of pushing patches for you ;-) ) you may get that
push access.

Best
Urs


>
> Regards,
>
>
> Karl 
> Free Software:  "You don't pay back, you pay forward."
>  -- Robert A. Heinlein
>
> ___
> lilypond-devel mailing list
> lilypond-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/lilypond-devel


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Lilypond issue tracker account request

2016-03-22 Thread Karl O. Pinc 
On Tue, 22 Mar 2016 08:25:05 -
"Phil Holmes"  wrote:

> - Original Message - 
> From: "Karl O. Pinc" 
> To: 
> Sent: Tuesday, March 22, 2016 3:47 AM
> Subject: Lilypond issue tracker account request

> > I'd like an account in the lilypond issue tracker.
> >
> > I'm thinking about someday contributing to lilypond
> > in the area of harp related notation.  

> I believe you can contribute to the tracker without an account: it's
> just that the contributions require moderation.  Could I suggest you
> start like that and see how you progress?

Sure.  Sounds good.  Thanks.

FYI.  I wrote because it was suggested here:
http://lilypond.org/doc/v2.19/Documentation/contributor/git_002dcl#configuring-git_002dcl


Karl 
Free Software:  "You don't pay back, you pay forward."
 -- Robert A. Heinlein

P.S.  Is the nettiqute here to reply-all or just reply to the
list?  (Or, I suppose, just reply to the sender?)


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Lilypond issue tracker account request

2016-03-22 Thread Karl O. Pinc 
On Tue, 22 Mar 2016 12:14:37 -
"Trevor Daniels"  wrote:

Hi Trevor,

> Karl O. Pinc wrote Tuesday, March 22, 2016 3:47 AM

> > I'd like an account in the lilypond issue tracker.  
> 
> Happy to add you to the Issue Tracker as a Member.
> That allows you to comment on Issues without moderation.
> That's the way to start.
> 
> You'll need to post or send me your SourceForge Username
> so I can set that up.

I am "kpinc" at sourceforge.

>  
> > I'm thinking about someday contributing to lilypond

> Great!  The first step is to post specific issues that
> you have identified to the bug list:
> http://lists.gnu.org/archive/html/bug-lilypond/
> for discussion and to have an Issue created.

Ok.  Thanks.

I take it that this is not required for a doc patch?
I'm thinking I'll send in something simple like that (through
the development pipeline) to get started.


> When you are ready to contribute to a specific Issue,
> post a patch to the bug list.

Ok.

> The first few patches are usually sheparded through the
> system by one of the Devs before you are elevated to
> Developer status.

I am at present way too ignorant of music to be comfortable
with Developer status.

Regards,


Karl 
Free Software:  "You don't pay back, you pay forward."
 -- Robert A. Heinlein

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Lilypond issue tracker account request

2016-03-22 Thread Phil Holmes 
- Original Message - 
From: "Karl O. Pinc" 



P.S.  Is the nettiqute here to reply-all or just reply to the
list?  (Or, I suppose, just reply to the sender?)



Reply-all.

--
Phil Holmes

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Lilypond issue tracker account request

2016-03-22 Thread Trevor Daniels 

Karl O. Pinc wrote Tuesday, March 22, 2016 3:47 AM

Hi Karl

> I'd like an account in the lilypond issue tracker.

Happy to add you to the Issue Tracker as a Member.
That allows you to comment on Issues without moderation.
That's the way to start.

You'll need to post or send me your SourceForge Username
so I can set that up.
 
> I'm thinking about someday contributing to lilypond
> in the area of harp related notation.  I'd probably
> start with the fingering notation.

Great!  The first step is to post specific issues that
you have identified to the bug list:
http://lists.gnu.org/archive/html/bug-lilypond/
for discussion and to have an Issue created.

Or to comment on existing issues.

> [snip]
>
> I've no idea if I'll every get around to contributing
> but am reading through the developer docs and it
> can't hurt to get setup for it.  FWIW I've done
> FOSS development work with FOSS tools.

When you are ready to contribute to a specific Issue,
post a patch to the bug list.

The first few patches are usually sheparded through the
system by one of the Devs before you are elevated to
Developer status.

Trevor
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

PATCHES: Countdown for March 25th

2016-03-22 Thread James 

Hello,

Here is the current patch countdown list. The next countdown will be on
March 25th.

A quick synopsis of all patches currently in the review process can be
found here:

http://philholmes.net/lilypond/allura/

__


Push:


4805 Doc: NR A.2: Fix typos in chord modifiers table - Paul Morris
https://sourceforge.net/p/testlilyissues/issues/4805
http://codereview.appspot.com/293900043


4803 Amend convert-ly 2.17.6 rules for \tweak - David Kastrup
https://sourceforge.net/p/testlilyissues/issues/4803
http://codereview.appspot.com/290580043


4801 Let Stockhausen example use current override syntax - David Kastrup
https://sourceforge.net/p/testlilyissues/issues/4801
http://codereview.appspot.com/293860043


4800 Require path separators in assignments/overrides - David Kastrup
https://sourceforge.net/p/testlilyissues/issues/4800
http://codereview.appspot.com/286680043


4794 Doc: CG - Re-organize information about 'Patches' - James Lowe
https://sourceforge.net/p/testlilyissues/issues/4794
http://codereview.appspot.com/291160043


Countdown: No patches in Countdown at this time.


Review:


4804 Doc: HTML table cells are misleadingly associated: should be 
top-aligned - fedelibre

https://sourceforge.net/p/testlilyissues/issues/4804
http://codereview.appspot.com/291230043


New:


4809 Keep "\""-signs for graphviz - Thomas Morley
https://sourceforge.net/p/testlilyissues/issues/4809
http://codereview.appspot.com/292110043


4808 Make chord-naming robust against unsetting majorSevenSymbol - 
Thomas Morley

https://sourceforge.net/p/testlilyissues/issues/4808
http://codereview.appspot.com/288700043


Waiting:


4600 Let notes/rests suppress multi-measure rest grobs - Dan Eble
https://sourceforge.net/p/testlilyissues/issues/4600
http://codereview.appspot.com/265160043



James

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Keep "\""-signs for graphviz (issue 292110043 by thomasmorle...@gmail.com)

2016-03-22 Thread thomasmorley65 

Reviewers: ,

Message:
Please review

Not sure, whether it's the best way to do it.

Description:
Keep "\""-signs for graphviz

Transform them to "\\\""

Please review this at https://codereview.appspot.com/292110043/

Affected files (+8, -2 lines):
  M ly/graphviz-init.ly


Index: ly/graphviz-init.ly
diff --git a/ly/graphviz-init.ly b/ly/graphviz-init.ly
index  
470faffa6ac36228222bb077a250e1fdb2e240cb..96f45ded93ccc3f784eeaea6e1ebe8a61764f2b1  
100644

--- a/ly/graphviz-init.ly
+++ b/ly/graphviz-init.ly
@@ -2,6 +2,8 @@

 #(use-modules (scm graphviz))

+#(use-modules (ice-9 regex))
+
 #(define last-grob-action '())

 #(define sym-blacklist '())
@@ -55,9 +57,13 @@

 #(define (grob-mod grob file line func prop val)
   (let* ((val-str (truncate-value val))
- (label (format #f "~a\\n~a:~a\\n~a <- ~a" (grob::name grob) file  
line prop val-str)))
+ (label (format #f "~a\\n~a:~a\\n~a <- ~a" (grob::name grob) file  
line prop val-str))

+ ;; to keep escaped "\"" we need to transform it to "\\\""
+ ;; otherwise the final pdf-creation will break
+ (escaped-label
+   (regexp-substitute/global #f "\"" label 'pre "\\\"" 'post)))
(if (relevant? grob file line prop)
-   (grob-event-node grob label file
+   (grob-event-node grob escaped-label file

 #(define (grob-cache grob prop callback value)
   (let* ((val-str (truncate-value value))



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Make chord-naming robust against unsetting majorSevenSymbol (issue 288700043 by thomasmorle...@gmail.com)

2016-03-22 Thread thomasmorley65 

Reviewers: ,

Message:
please review

Description:
Make chord-naming robust against unsetting majorSevenSymbol

This will likely be changed anyway as soon as rewriting
chord-names is seriously tackled.
At least it might be a reminder to take care of the possibility
a user wants to unset majorSevenSymbol.

Please review this at https://codereview.appspot.com/288700043/

Affected files (+6, -4 lines):
  M scm/chord-ignatzek-names.scm


Index: scm/chord-ignatzek-names.scm
diff --git a/scm/chord-ignatzek-names.scm b/scm/chord-ignatzek-names.scm
index  
f798c0fdf6aa7fc82aba8dceb62691cfeab4f9b5..483b8cac8f18fc6bb20598ae7ef7ccfb120c48ff  
100644

--- a/scm/chord-ignatzek-names.scm
+++ b/scm/chord-ignatzek-names.scm
@@ -161,10 +161,12 @@ work than classifying the pitches."
   (let* ((num-markup (make-simple-markup
   (number->string (pitch-step pitch
  (args (list num-markup))
- (total (if (= (ly:pitch-alteration pitch) 0)
-(if (= (pitch-step pitch) 7)
-(list (ly:context-property  
context 'majorSevenSymbol))

-args)
+ (major-seven-symbol (ly:context-property  
context 'majorSevenSymbol))

+ (total
+(if (and (= (ly:pitch-alteration pitch) 0)
+ (= (pitch-step pitch) 7)
+ (markup? major-seven-symbol))
+(list major-seven-symbol)
 (cons (accidental->markup (step-alteration pitch))  
args


 (make-line-markup total)))



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Lilypond issue tracker account request

2016-03-22 Thread Urs Liska 
Hi Karl (and Phil),

Am 22.03.2016 um 09:25 schrieb Phil Holmes:
> I believe you can contribute to the tracker without an account: it's
> just that the contributions require moderation.  Could I suggest you
> start like that and see how you progress?

I think Karl talks about uploading patches with git-cl, which (AFAIK) is
not possible without a sourceforge account.
But I would also suggest that you start with creating *something* first
and propose that on the lilypond-devel list. You say that you don't know
if you will ever manage to contribute anything so there's no need yet to
add an account for you. Once you start delivering anything I'm sure
you'll be welcomed sufficiently.

Urs

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Lilypond issue tracker account request

2016-03-22 Thread Phil Holmes 
- Original Message - 
From: "Karl O. Pinc" 

To: 
Sent: Tuesday, March 22, 2016 3:47 AM
Subject: Lilypond issue tracker account request



Hi,

I'd like an account in the lilypond issue tracker.

I'm thinking about someday contributing to lilypond
in the area of harp related notation.  I'd probably
start with the fingering notation.

FYI.  I don't know much music or much harp.  Or much
lilypond.  Harp fingering notation seems to be like
\startGroup ... \stopGroup, or, after
\set Staff.pedalSustainStyle = #'bracket
\sustainOn ... \sustainOff.  Except that the line can be
slanted.  And in some styles the finger numbers are
written so their midpoint falls on the line and the
line is broken.

There seems to be 2 more variations, one where the
line segments on the ends remain at right angles to the
overall line, and are therefore slanted.  And another
style where the line segments at the end are vertical,
independent of the slope of the overall line.

Fingering runs from 1 to 4 with 1 being the thumb.

See also:
http://www.harpspectrum.org/harpworks/composing_for_harp/images/sacred_harp_notation.gif
from
http://www.harpspectrum.org/harpworks/composing_for_harp/composing_for_harp.shtml
for "lots 'o harp notation", most of which seems to
be missing from lilypond.  In the latter link
you can find an example of finger placement notation
in "Writing for the Harp", section 1, "Notation".

I've no idea if I'll every get around to contributing
but am reading through the developer docs and it
can't hurt to get setup for it.  FWIW I've done
FOSS development work with FOSS tools.

Regards,

Karl 



I believe you can contribute to the tracker without an account: it's just 
that the contributions require moderation.  Could I suggest you start like 
that and see how you progress?


--
Phil Holmes 



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Lilypond issue tracker account request

2016-03-22 Thread Karl O. Pinc 
Hi,

I'd like an account in the lilypond issue tracker.

I'm thinking about someday contributing to lilypond
in the area of harp related notation.  I'd probably
start with the fingering notation.

FYI.  I don't know much music or much harp.  Or much
lilypond.  Harp fingering notation seems to be like
\startGroup ... \stopGroup, or, after
\set Staff.pedalSustainStyle = #'bracket
\sustainOn ... \sustainOff.  Except that the line can be
slanted.  And in some styles the finger numbers are
written so their midpoint falls on the line and the
line is broken.

There seems to be 2 more variations, one where the
line segments on the ends remain at right angles to the
overall line, and are therefore slanted.  And another
style where the line segments at the end are vertical,
independent of the slope of the overall line.

Fingering runs from 1 to 4 with 1 being the thumb.

See also:
http://www.harpspectrum.org/harpworks/composing_for_harp/images/sacred_harp_notation.gif
from
http://www.harpspectrum.org/harpworks/composing_for_harp/composing_for_harp.shtml
for "lots 'o harp notation", most of which seems to
be missing from lilypond.  In the latter link
you can find an example of finger placement notation
in "Writing for the Harp", section 1, "Notation".

I've no idea if I'll every get around to contributing
but am reading through the developer docs and it
can't hurt to get setup for it.  FWIW I've done
FOSS development work with FOSS tools.

Regards,

Karl 
Free Software:  "You don't pay back, you pay forward."
 -- Robert A. Heinlein

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel