Re: Issue 4936: look up "mf" for default initial volume (issue 308890043 by nine.fierce.ball...@gmail.com)

[Carl Sorensen]

On 8/12/16 3:21 PM, "nine.fierce.ball...@gmail.com"
 wrote:

>James put this issue back in "review" thinking that there might be more
>than needs to be discussed, but my understanding is that none of the
>reviewers has any significant concern about pushing this as it is.
>
>Is that correct?

It is for me.

Carl


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Downcase of a symbol

[Urs Liska]

Hi,

I have written a function to return the lowercase version of a symbol
for use in my library as

% Return the lowercase version of a symbol
#(define (symbol->lowercase sym)
   (string->symbol
(string-downcase
 (symbol->string sym

Just a small question: this seems so general that I can't imagine it
isn't already available somewhere in Scheme, Guile or LilyPond. Of
course I'd prefer using an official function instead of my own.

Thanks for any pointers
Urs


___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Keep a staff alive with multiple layers (issue 308910043 by mark.opu...@googlemail.com)

[dak]

On 2016/08/12 14:55:06, mark_opus11.net wrote:

On 2016/08/12 14:52:42, http://mark_opus11.net wrote:
> Use key? (integer or symbol)



I looked at doing this, as David suggested, by introducing two new
properties (removal-friends and removal-foes) but found the
resultant logical permutations too confusing to either document
clearly or be useful to a user.


I'm somewhat surprised since I would have thought the _semantics_
reasonably straightforward.  If the _use_ turns out to be awkward, it
could probably amended with a few scheme functions delivering
appropriate context modifications or possibly some music function.

I haven't actually bothered doing so so I might be overlooking something
here.  Can you illustrate some of the occuring problems/awkwardnesses?
I would have thought the proposal comparatively straightforward to
describe and use and so I'd be interested to know where I was being too
optimistic.

https://codereview.appspot.com/308910043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 4936: look up "mf" for default initial volume (issue 308890043 by nine.fierce.ball...@gmail.com)

[dak]

On 2016/08/12 21:21:33, Dan Eble wrote:

James put this issue back in "review" thinking that there might be

more than

needs to be discussed, but my understanding is that none of the

reviewers has

any significant concern about pushing this as it is.



Is that correct?


I repeat:

Can we get to some version of the code where the code paths supposed to
be
equivalent (is there agreement about that?) actually looks the same?

If so, this would be a good starter for Heikki to eventually propose a
cleanup
that would result in a removal of the dead code or keeping it but adding
a
programming error.  Something like that.

This sounds like work either party has not bargained on doing.  But it
would
likely be easier to get it done now that people have taken a bit of a
look than
at a time when the person puzzling over it has no indication about why
stuff
looks different.

https://codereview.appspot.com/308890043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 4936: look up "mf" for default initial volume (issue 308890043 by nine.fierce.ball...@gmail.com)

[nine . fierce . ballads]

James put this issue back in "review" thinking that there might be more
than needs to be discussed, but my understanding is that none of the
reviewers has any significant concern about pushing this as it is.

Is that correct?


https://codereview.appspot.com/308890043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

PATCHES: Countdown for August 12th

[James]

Hello,

Here is the current patch countdown list. The next countdown will be on
August 15th

A quick synopsis of all patches currently in the review process can be
found here:

http://philholmes.net/lilypond/allura/

__


Push:


4954 Change spanner-id to be a key instead of a string - David Kastrup
https://sourceforge.net/p/testlilyissues/issues/4954
http://codereview.appspot.com/306950043


4953 Fix SchemeTextSpanEvent in scheme-text-spanner.ly - Thomas Morley
https://sourceforge.net/p/testlilyissues/issues/4953
http://codereview.appspot.com/301560043


4952 Clearify ending of hairpins at bar line in NR - Thomas Morley
https://sourceforge.net/p/testlilyissues/issues/4952
http://codereview.appspot.com/301550043


Countdown: No patches on Countdown at this time.


Review:


4936 MIDI: Look up "mf" instead of hard-coding a numeric default volume 
- Dan Eble

https://sourceforge.net/p/testlilyissues/issues/4936
http://codereview.appspot.com/302930043


New:


4950 Doc: CG update Indenting with vim section - Mark Knoop
https://sourceforge.net/p/testlilyissues/issues/4950
http://codereview.appspot.com/302340043

4949 Keep a staff alive with multiple layers - Mark Knoop
https://sourceforge.net/p/testlilyissues/issues/4949
http://codereview.appspot.com/308910043


Waiting:


4600 Let notes/rests suppress multi-measure rest grobs - Dan Eble
https://sourceforge.net/p/testlilyissues/issues/4600
http://codereview.appspot.com/265160043


Regards

James

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel



___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Branch management

[Ralph Little]

Hi,
> If, as you say, you only have one commit on your branch you can also
> just copy that commit to a new branch and later delete the old branch: git 
> checkout master
> git checkout -b my/new/branch
> git cherry-pick commit-id-from-old-branch ... later ...
> git branch -D dev/rlittle
> git push origin :refs/heads/dev/rlittle This *may* "feel" somewhat safer 
> without the rebasing.

> Urs

Actually, I have a new set of files to replace the old which compile and run 
cleanly against master.

The simplest thing is probably to just delete the branch and start over.
I don't really want to keep that commit.

I had forgotten that git branches are ephemeral. We use mercurial where I work 
and deleting branches is not part of the normal workflow.


Cheers,
Ralph

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Keep a staff alive with multiple layers (issue 308910043 by mark.opu...@googlemail.com)

[mark . opus11]

On 2016/08/12 14:52:42, mark_opus11.net wrote:

Use key? (integer or symbol)


I looked at doing this, as David suggested, by introducing two new
properties (removal-friends and removal-foes) but found the
resultant logical permutations too confusing to either document
clearly or be useful to a user.

So I have returned to a cleaner implementation of Patch Set 1, in
which remove-layer will accept a key with the following
behaviours:

- integer: layer removed when larger than smallest retained
- 'any: layer kept alive by any other layer
- #f: layer independent of the Keep_alive_together_engraver
- '(): layer does not participate in the layering decisions

Using a single polymorphic property avoids any possibility of
setting contradictory values for any single layer. The use of the
key type allows the potential for other behaviours to be added in
the future.

https://codereview.appspot.com/308910043/

___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel