Change \retrograde to deal with ties and repeat chords/notes (issue 302470043 by d...@gnu.org)
Didn't dive into the code in depth. From my (limited) testings, I'd say it's very nice, thus: LGTM A nitpick: https://codereview.appspot.com/302470043/diff/1/scm/modal-transforms.scm File scm/modal-transforms.scm (right): https://codereview.appspot.com/302470043/diff/1/scm/modal-transforms.scm#newcode188 scm/modal-transforms.scm:188: ;; See also LSR #105. There is no LSR-snippet 105. Must have been deleted somewhen in the past. Actually the entire LSR doesn't mention retrograde at all nowadays. https://codereview.appspot.com/302470043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
parser.yy: loc_on_music -> loc_on_copy (issue 302480043 by d...@gnu.org)
LGTM https://codereview.appspot.com/302480043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: Issue 4936: look up "mf" for default initial volume (issue 308890043 by nine.fierce.ball...@gmail.com)
I've marked the ticket as "needs work". Motivation has been lacking lately. I expect to return to this after some time (a week? a month?) but if someone else would like to take over this issue before then, I won't be offended. https://codereview.appspot.com/308890043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: GUB problem
- Original Message - From: "Masamichi Hosoda" To: Cc: ; Sent: Monday, August 15, 2016 4:51 PM Subject: Re: GUB problem In my environment (Ubuntu 14.04 LTS 64 bit), the error does not occur. Would you tell me the environment which the error occurs? Ubuntu 14.04 LTS 32 bit. FYI I had to make a small change to the GMP spec to accommodate 32 bit - my patch shows what I had to do. If you don't use the patch, do any errors occur? Yes: the terminal output has this: Tail of target/tools/log/gmp.log in this configuration expects 64 bits. You appear to have set $CFLAGS, perhaps you also need to tell GMP the intended ABI, see "ABI and ISA" in the manual. Anyway, this error means that cross-compiler gcc (for freebsd-64) tries to open "librestrict.so". "librestrict.so" is for host OS (perhaps Linux) instead of for target OS (freebsd-64). If I understand correctly, cross-compiler gcc does not need to open "librestrict.so". I don't know why cross-compiler gcc tries to open "librestrict.so". Moreover, at least a few weeks ago, the error did not occur. My recent pull request does not change gcc. I wonder why cross-compiler gcc began to open "librestrict.so". Perhaps your fix to librestrict made something work that was not previously, and so an error is now detected? I've noticed that this librestrict-error is secondary-effect. If I understand correctly, the first error is x86_64-freebsd6-gcc: internal compiler error: Illegal instruction (program cc1) Then, gcc tried to open "librestrict.so" for showing debugging information. So secondary-effect librestrict-error was occured. To confirm this hypothesis, would you try the following command and show me the result (config.log etc.)? $ LIBRESTRICT_ALLOW=/ bin/gub --fresh freebsd-64::fontconfig Do I issue that command and then restart the GUB compile? -- Phil Holmes ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
PATCHES: Countdown for August 15th
Hello, Here is the current patch countdown list. The next countdown will be on August 18th A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ __ Push: 4954 Change spanner-id to be a key instead of a string - David Kastrup https://sourceforge.net/p/testlilyissues/issues/4954 http://codereview.appspot.com/306950043 Countdown: 4950 Doc: CG update Indenting with vim section - Mark Knoop https://sourceforge.net/p/testlilyissues/issues/4950 http://codereview.appspot.com/302340043 4949 Keep a staff alive with multiple layers - Mark Knoop https://sourceforge.net/p/testlilyissues/issues/4949 http://codereview.appspot.com/308910043 4936 MIDI: Look up "mf" instead of hard-coding a numeric default volume - Dan Eble https://sourceforge.net/p/testlilyissues/issues/4936 http://codereview.appspot.com/302930043 Review: No patches in Review at this time. New: 4956 Change \retrograde to deal with ties and repeat chords/notes - David Kastrup https://sourceforge.net/p/testlilyissues/issues/4956 http://codereview.appspot.com/302470043 4600 Let notes/rests suppress multi-measure rest grobs - Dan Eble https://sourceforge.net/p/testlilyissues/issues/4600 http://codereview.appspot.com/265160043 Regards James ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Abwesenheitsnotiz
Sehr geehrte Dame, sehr geehrter Herr, ich bin bis zum 23.08.2016 im Urlaub und kann Ihre Anfrage leider nicht beantworten. Gerne kümmere ich mich nach meiner Rückkehr um Ihre Wünsche. Ihre eMail wird nicht weitergeleitet. In dringenden Fällen wenden Sie sich bitte an meine Kollegen (edit...@lilienteich.de). Mit freundlichen Grüßen Dennis Ried ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: GUB problem
>> In my environment (Ubuntu 14.04 LTS 64 bit), the error does not occur. >> Would you tell me the environment which the error occurs? > > Ubuntu 14.04 LTS 32 bit. > > FYI I had to make a small change to the GMP spec to accommodate 32 bit > - my patch shows what I had to do. If you don't use the patch, do any errors occur? >> Anyway, this error means that >> cross-compiler gcc (for freebsd-64) tries to open "librestrict.so". >> >> "librestrict.so" is for host OS (perhaps Linux) >> instead of for target OS (freebsd-64). >> >> If I understand correctly, >> cross-compiler gcc does not need to open "librestrict.so". >> I don't know why cross-compiler gcc tries to open "librestrict.so". >> >> Moreover, at least a few weeks ago, the error did not occur. >> My recent pull request does not change gcc. >> I wonder why cross-compiler gcc began to open "librestrict.so". > > Perhaps your fix to librestrict made something work that was not > previously, and so an error is now detected? I've noticed that this librestrict-error is secondary-effect. If I understand correctly, the first error is > x86_64-freebsd6-gcc: internal compiler error: Illegal instruction (program > cc1) Then, gcc tried to open "librestrict.so" for showing debugging information. So secondary-effect librestrict-error was occured. To confirm this hypothesis, would you try the following command and show me the result (config.log etc.)? $ LIBRESTRICT_ALLOW=/ bin/gub --fresh freebsd-64::fontconfig ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: GUB problem
- Original Message - From: "Masamichi Hosoda" To: ; Cc: Sent: Monday, August 15, 2016 1:57 PM Subject: Re: GUB problem configure:3706: checking whether the C compiler works configure:3728: x86_64-freebsd6-gcc conftest.c >&5 x86_64-freebsd6-gcc: internal compiler error: Illegal instruction (program cc1) librestrict:error:/home/gub/NewGub/gub/target/freebsd-64/root/usr/cross/bin/x86_64-freebsd6-gcc: tried to open () file /home/gub/NewGub/gub/target/tools/root/usr/lib/librestrict.so librestrict:allowed: /home/gub/NewGub/gub/target/freebsd-64 /tmp /dev/null /dev/urandom /proc/self In my environment (Ubuntu 14.04 LTS 64 bit), the error does not occur. Would you tell me the environment which the error occurs? Ubuntu 14.04 LTS 32 bit. FYI I had to make a small change to the GMP spec to accommodate 32 bit - my patch shows what I had to do. Anyway, this error means that cross-compiler gcc (for freebsd-64) tries to open "librestrict.so". "librestrict.so" is for host OS (perhaps Linux) instead of for target OS (freebsd-64). If I understand correctly, cross-compiler gcc does not need to open "librestrict.so". I don't know why cross-compiler gcc tries to open "librestrict.so". Moreover, at least a few weeks ago, the error did not occur. My recent pull request does not change gcc. I wonder why cross-compiler gcc began to open "librestrict.so". Perhaps your fix to librestrict made something work that was not previously, and so an error is now detected? -- Phil Holmes 0001-Fix-GMP-for-32-bit.patch Description: Binary data ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
Re: GUB problem
> configure:3706: checking whether the C compiler works > configure:3728: x86_64-freebsd6-gcc conftest.c >&5 > x86_64-freebsd6-gcc: internal compiler error: Illegal instruction (program > cc1) > librestrict:error:/home/gub/NewGub/gub/target/freebsd-64/root/usr/cross/bin/x86_64-freebsd6-gcc: > tried to open () file > /home/gub/NewGub/gub/target/tools/root/usr/lib/librestrict.so > librestrict:allowed: > /home/gub/NewGub/gub/target/freebsd-64 > /tmp > /dev/null > /dev/urandom > /proc/self In my environment (Ubuntu 14.04 LTS 64 bit), the error does not occur. Would you tell me the environment which the error occurs? Anyway, this error means that cross-compiler gcc (for freebsd-64) tries to open "librestrict.so". "librestrict.so" is for host OS (perhaps Linux) instead of for target OS (freebsd-64). If I understand correctly, cross-compiler gcc does not need to open "librestrict.so". I don't know why cross-compiler gcc tries to open "librestrict.so". Moreover, at least a few weeks ago, the error did not occur. My recent pull request does not change gcc. I wonder why cross-compiler gcc began to open "librestrict.so". ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel
